April 2007 - Wine-devel - list.winehq.org

Which component should I use to create this bug ?
by Laurent Vromman 16 Apr '07

16 Apr '07

Hi, I am trying to create a bug in Bugzilla concerning Navigation. When Navigation is installed, the file DAO350.dll is copied to the Common Files directory and is regsrved. When running Navigation after that, it displays an error message about not finding DAO350.dll. Copying the file to windows/system32 allows Navigation to find the file and use it, but it should be able to find it in Common Files too. Which component should I choose ? I am not sure where the problem is. Navigation is a Visual Basic program, using VB methods to load dlls. Thank you for your help. Laurent Vromman

1 0

Re: quartz: Partially implement the MPEG 1 Stream Splitter filter
by Dmitry Timoshkov 16 Apr '07

16 Apr '07

Chris Robinson <chris.kcat(a)gmail.com> wrote: > +static inline void flip_dword(DWORD *pVal) > +{ > + DWORD val = *pVal; > + val = (val>>24) | ((val>>8)&0xFF00) | > + ((val&0xFF00)<<8) | (val<<24); > + *pVal = val; > +} > + > +static inline void flip_word(WORD *pVal) > +{ > + WORD val = *pVal; > + val = (val>>8) | (val<<8); > + *pVal = val; > +} You need to take WORDS_BIGENDIAN macro into account, not blindly assume that we are running on a LE machine. Something like (as done in other DLLs): #ifdef WORDS_BIGENDIAN #define GET_BE_WORD(x) (x) #define GET_BE_DWORD(x) (x) #else #define GET_BE_WORD(x) RtlUshortByteSwap(x) #define GET_BE_DWORD(x) RtlUlongByteSwap(x) #endif Besides it looks like flip_word() is not used. > +static int head_check(DWORD head) > +{ > + /* If this is a possible start code, check for a system or video header */ > + if ((head & 0xFFFFFF00) == 0x100) { > + /* Check if we got a system or elementary stream start code */ > + if (head == PACK_START_CODE || head == VIDEO_ELEMENTARY_STREAM || > + head == AUDIO_ELEMENTARY_STREAM) > + return MPEG_SYSTEM_HEADER; > + > + /* Check for a MPEG video sequence start code */ > + if (head == SEQUENCE_HEADER_CODE) > + return MPEG_VIDEO_HEADER; > + } > + > + /* This should give a good guess if we have an MPEG audio header */ > + if((head & 0xffe00000) == 0xffe00000 && ((head>>17)&3) != 0x0 && > + ((head>>12)&0xf) != 0xf && ((head>>10)&0x3) != 0x3) > + return MPEG_AUDIO_HEADER; Why not use a struct with bit fields to simplify the above check? > + if (headercode & (1<<20)) > + { > + lsf = ((headercode & (1<<19)) ? 0x0 : 0x1); > + mpg25 = 0; > + } > + else > + { > + lsf = 1; > + mpg25 = 1; > + } > + > + layer = 4-((headercode>>17)&0x3); > + bitrate_index = ((headercode>>12)&0xf); > + freq_index = ((headercode>>10)&0x3) + (mpg25?6:(lsf*3)); > + padding = ((headercode>> 9)&0x1); > + mode = ((headercode>> 6)&0x3); > + mode_ext = ((headercode>> 4)&0x3); > + emphasis = ((headercode )&0x3); Same here. -- Dmitry.

2 1

Re: locales, unicode and ansi with msvcrt (bug 8022)
by Ann & Jason Edmeades 16 Apr '07

16 Apr '07

> > >What your test app is doing? It probably needs a test under Windows > > >to see in which encoding (ANSI/OEM) a not unicode app should > > >receive input via a pipe. > > > I meant things like 'dir >lst.txt', 'dir | sort > lst.txt'. 'dir' and > 'sort' could be replaced by some external .exes that get input and > produce outpup. > Hiya, I wrote an app which did ReadConsoleW and then traced out the hex of the first character read in, and used ALT+157 as a mechanism to supply a character which differs between the codepages I was playing with: (All the following was under windows XP) Code: ReadConsoleW(GetStdHandle(STD_INPUT_HANDLE), buf, sizeof(buf)/sizeof(WCHAR), &nChars, NULL); printf("Character at position 0 is %x\n", buf[0]); Results: Active code page: 437 - Character at position 0 is a5 Active code page: 850 - Character at position 0 is d8 Active code page: 1252 - Character at position 0 is 9d So I think its converting between the console codepage and Unicode, if I interpret that correctly. I then modified it to write out (**) unicode character 0xa5 to see if the conversion is back to oem or ansi, and although its hard to prove beyond doubt(*), it appears to me I am getting the reverse of that, it its converted to the console codepage before being output.. (*) in cmd.exe if its not full screen, the font does not change when chcp is executed, so for 437 and 850 I get an 0 type char and a yen. If I do it full screen, both give me a yen, so I would concur from that the character codepoint is changing and comes out depending on the font (**) Because I want to test this with WriteConsoleW, this does not get redirected to a file so I cant see the raw codepoints... Anything else I can test, or am I ok to put file tests into msvcrt test buckets and allow the msvcrt unicode printf and friends to convert to non-unicode using the console codepage before being output to the file handle? Suggested tests welcome, but I was planning on using the unicode wide file i/o functions, the opening in and confirming the bytes were as expected (If I stick to a-z, 0-9 we will know if its come out with extra 0's) Regards and thanks for your time, Jason

2 4

Re: secur32: invert error handling conditions in order to decrease indentation in secur32/wrapper.c.
by Kai Blin 15 Apr '07

15 Apr '07

On Saturday 14 April 2007 00:56, Yuval Fledel wrote: > - the patch is a no-op. While I like to do the same to functions I work on, is there any reason you need to change this for wrapper.c? It hasn't been changed for quite a while and seems feature complete. Kai -- Kai Blin, <kai Dot blin At gmail Dot com> WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin/ -- Will code for cotton.

1 0

Re: secur32: invert error handling conditions in order to decrease indentation in secur32/wrapper.c.
by Detlef Riekenberg 15 Apr '07

15 Apr '07

On Sa, 2007-04-14 at 01:56 +0300, Yuval Fledel wrote: > wrapper.c | 1252 > ++++++++++++++++++++++++++------------------------------------ > 1 file changed, 545 insertions(+), 707 deletions(-) I have no Idea about the code in secur32.dll, but your Patch is much to large. I suggest to modify only one Function per Patch (max. two Functions, when they work together and the total Patch-size is small). As an Example: secur32: Reorder code (SECUR32_makeSecHandle) -- By by ... Detlef

1 0

Re: Implementation of mathematical functions for D3DRM
by James Hawkins 15 Apr '07

15 Apr '07

On 4/15/07, David.Adam(a)math.cnrs.fr <David.Adam(a)math.cnrs.fr> wrote: > Here is the complete implementation of the mathematical functions of > D3DRM with tests. > Tests work under Windows XP and wine. > One patch per email please. -- James Hawkins

1 0

Recommendation for configure.ac fix
by sol11x86＠comcast.net 15 Apr '07

15 Apr '07

I've just started hacking on wine. I've found a case of Solaris supporting the getaddrinfo function call that is tested in configure (via configure.ac) but I need to add specific libraries to the test. However, I don't think it's a good idea to overload the LIBS variable for all the functions that are being tested in that sequence. (though that fixed the issue for me) Can someone recommend the right way I should modify configure.ac? Thanks, Ben

2 1

Towards getting the top ten requested apps running...
by Dan Kegel 15 Apr '07

15 Apr '07

Novell did a survey last year to find out what ten apps people most wanted ported to Linux. I've put a copy of the results into our wiki here: http://wiki.winehq.org/LinuxApplicatonRequestSurvey Wine seems far enough along that it's not unreasonable to consider getting all ten of these apps working over the next year. (One of them already works great: Lotus Notes. So that's one down, nine to go...)

4 3

Re: GetDIBits(): Handle Bitfields properly
by Dmitry Timoshkov 15 Apr '07

15 Apr '07

"Michael Kaufmann" <hallo(a)michael-kaufmann.ch> wrote: > + if (bpp > 0 && compr == BI_BITFIELDS) > + { > + /* Windows ignores the input bitfields and overwrites them */ > + > + if (bpp == 16) > + { > + /* With these bitfields, the color data is the same as for BI_RGB */ > + ((PDWORD)info->bmiColors)[0] = 0x7c00; > + ((PDWORD)info->bmiColors)[1] = 0x03e0; > + ((PDWORD)info->bmiColors)[2] = 0x001f; > + } > + else if (bpp == 32) > + { > + /* With these bitfields, the color data is the same as for BI_RGB */ > + ((PDWORD)info->bmiColors)[0] = 0xff0000; > + ((PDWORD)info->bmiColors)[1] = 0x00ff00; > + ((PDWORD)info->bmiColors)[2] = 0x0000ff; > + } What happens in 15 and 24 bpp cases? -- Dmitry.

2 2

Re: RegDeleteTree
by Detlef Riekenberg 15 Apr '07

15 Apr '07

On So, 2007-04-15 at 10:02 +0200, Stefan Leichter wrote: I did not test the code, but ... > +LONG WINAPI RegDeleteTreeW(HKEY hKey, LPCWSTR lpszSubKey) > +{ > + if (!ret) > + ret = RegSetValueA(hSubKey, NULL, REG_SZ, "", 0); Please do not call an ANSI-Function in an UNICODE-Implementation. http://wiki.winehq.org/CrossCallsWtoA static const WCHAR emptyW[] = {0}; ret = RegSetValueW(hSubKey, NULL, REG_SZ, emptyW, 0); Thanks -- By by ... Detlef

1 0