May 2007 - Wine-devel - list.winehq.org

Re: Patch [1/4]:Implement D3DRMColorGetRed
by Stefan Dösinger 20 May '07

20 May '07

Am Samstag 19 Mai 2007 22:01 schrieb David.Adam(a)math.cnrs.fr: + color=2949120; + expected=45.0/255.0; Maybe it would be easier to read if you write the color as a hex value(the D3DCOLOR one). Also try to set blue and green to something different than 0.

1 0

Error compiling wine during git regression test
by Austin English 20 May '07

20 May '07

Howdy, I was attempting to run a regression test, and kept running into errors when trying to compile a bisect between wine 0.9.34 and 0.9.35. After trying all sorts of things to fix it, I tried compiling between wine 0.9.34 and the current git, which worked fine, eventually leading me to the troubled patch. However, building between 0.9.34 and 0.9.35 still does not work. Below is the output from terminal of where it fails, seemingly on the cmd program, and more specifically, in the directory function. make[2]: Entering directory `/home/austin/wine-git/programs/cmd' gcc -c -I. -I. -I../../include -I../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o batch.o batch.c gcc -c -I. -I. -I../../include -I../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o builtins.o builtins.c gcc -c -I. -I. -I../../include -I../../include -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wpointer-arith -g -O2 -o directory.o directory.c directory.c:36: error: expected ) before * token directory.c: In function WCMD_directory: directory.c:409: warning: implicit declaration of function WCMD_list_directory directory.c: At top level: directory.c:443: warning: conflicting types for WCMD_list_directory directory.c:443: error: static declaration of WCMD_list_directory follows non-static declaration directory.c:409: error: previous implicit declaration of WCMD_list_directory was here make[2]: *** [directory.o] Error 1 make[2]: Leaving directory `/home/austin/wine-git/programs/cmd' make[1]: *** [cmd] Error 2 make[1]: Leaving directory `/home/austin/wine-git/programs' make: *** [programs] Error 2 Please CC me in any replies, as I am not subscribed to this mailing list. Austin

1 0

configure error on OpenBSD
by Vortechz Anderson 19 May '07

19 May '07

I am trying to port wine to OpenBSD, or at least trying to make it build and not segfault upon execution... (This bug is a minor issue compared to some ld.so trouble I have run into. I'd be happy to know about differences between Net/Free/OpenBSD ld.so) configure output: configure: WARNING: sys/sysctl.h: present but cannot be compiled configure: WARNING: sys/sysctl.h: check for missing prerequisite headers? configure: WARNING: sys/sysctl.h: see the Autoconf documentation configure: WARNING: sys/sysctl.h: section "Present But Cannot Be Compiled" configure: WARNING: sys/sysctl.h: proceeding with the preprocessor's result configure: WARNING: sys/sysctl.h: in the future, the compiler will take precedence configure: WARNING: ## ------------------------------------ ## configure: WARNING: ## Report this to wine-devel(a)winehq.org ## configure: WARNING: ## ------------------------------------ ## Some rows from config.log: In file included from /usr/include/sys/sysctl.h:46, from conftest.c:106: /usr/include/sys/ucred.h:49: error: `NGROUPS' undeclared here (not in a function ) In file included from /usr/include/sys/sysctl.h:47, from conftest.c:106: /usr/include/sys/proc.h:65: error: `MAXLOGNAME' undeclared here (not in a functi on) /usr/include/sys/proc.h:91: error: syntax error before "int" /usr/include/sys/proc.h:215: error: syntax error before "sigset_t" /usr/include/sys/proc.h:230: error: `MAXCOMLEN' undeclared here (not in a function) In file included from conftest.c:106: /usr/include/sys/sysctl.h:327: error: `MAXLOGNAME' undeclared here (not in a function) I managed to get around this by including sys/param.h in the sys/proc.h and sys/ucred.h headers but I'm not sure that's the right approach. Wine developers wouldn't benefit from such patches anyway. I have tried to change configure.ac properly but it seems that I can't get it right... // V.A. P.S. Adding sys/proc and sys/ucred to header list and checking for param.h dependency is not sufficient: AC_CHECK_HEADERS([sys/proc.h],,, [#if HAVE_SYS_PARAM_H # include <sys/param.h> #endif]) AC_CHECK_HEADERS([sys/ucred.h],,, [#if HAVE_SYS_PARAM_H # include <sys/param.h> #endif]) With these addons, both proc and ucred fails. D.S. _________________________________________________________ Flyger tiden iväg? Fånga dagen med Yahoo! Mails inbyggda kalender. Dessutom 250 MB gratis, virusscanning och antispam. Få den på: http://se.mail.yahoo.com _________________________________________________________ Ont om plats? Skaffa gratis Yahoo! Mail med obegränsat, lagringsutrymme, kalender, virusscan och antispamfunktion. http://se.mail.yahoo.com

1 0

Re: Direct3D thread safety review
by H. Verbeet 19 May '07

19 May '07

On 18/05/07, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > * When a method needs locking, the lock is aquired after printing the trace, > but before checking error conditions(like windows). > * If a method doesn't need locking(e.g. unimplemented, or just a getter for > static info(GetCaps), or QI / AddRef / Release), then the lock is not held > > Since ddraw, d3d8 and d3d9 need their own locking anyway, my plan is to > implement locking in them and assume synchronised calls in wined3d - ie no > wined3d locking. No 2 threads may call wined3d at the same time, and > ddraw/d3d8/d3d9 have to take care of that. That keeps the code simpler. > Makes sense to me.

1 0

Re: [PATCH] wined3d: IWineD3DDeviceImpl_Clear: list Color parameter in the trace.
by H. Verbeet 19 May '07

19 May '07

On 12/05/07, Erik Inge Bolsø <knan-wine(a)anduin.net> wrote: > - TRACE("(%p) Count (%d), pRects (%p), Flags (%x), Z (%f), Stencil (%d)\n", This, > - Count, pRects, Flags, Z, Stencil); > + TRACE("(%p) Count (%d), pRects (%p), Flags (%x), Color (%f %f %f %f), Z (%f), Stencil (%d)\n", This, > + Count, pRects, Flags, D3DCOLOR_R(Color), D3DCOLOR_G(Color), D3DCOLOR_B(Color), D3DCOLOR_A(Color), Z, Stencil); > Tracing the color is fine, but there's no reason to convert it do individual float components. Printing it as 0x%08x should be fine.

1 0

Re: [PATCH] wined3d: debug_d3dusage: prettyprint a flag combination
by H. Verbeet 19 May '07

19 May '07

On 12/05/07, Erik Inge Bolsø <knan-wine(a)anduin.net> wrote: > --- > dlls/wined3d/utils.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c > index c444232..4db0622 100644 > --- a/dlls/wined3d/utils.c > +++ b/dlls/wined3d/utils.c > @@ -238,6 +238,7 @@ const char* debug_d3dusage(DWORD usage) { > WINED3DUSAGE_TO_STR(WINED3DUSAGE_SOFTWAREPROCESSING); > WINED3DUSAGE_TO_STR(WINED3DUSAGE_DONOTCLIP); > WINED3DUSAGE_TO_STR(WINED3DUSAGE_POINTS); > + WINED3DUSAGE_TO_STR(WINED3DUSAGE_WRITEONLY|WINED3DUSAGE_POINTS); > WINED3DUSAGE_TO_STR(WINED3DUSAGE_RTPATCHES); > WINED3DUSAGE_TO_STR(WINED3DUSAGE_NPATCHES); > WINED3DUSAGE_TO_STR(WINED3DUSAGE_DYNAMIC); > -- > 1.4.4.2 > That's not a proper fix, debug_d3dusage() should be changed to print all the flags in "usage", not just exact matches.

1 0

Re: [PATCH] dlls/wined3d: Implemented converting X1R5G5B5 format to R5G5B5A1 to emulate color-keying.
by Stefan Dösinger 19 May '07

19 May '07

Am Samstag 19 Mai 2007 15:33 schrieb hightower(a)tregt.net: Looks good to me, although I wonder if the maskin in "*Dest = (color & 0x7FFF) << 1" is really needed or if we can just shift out the highest bit.

1 0

Re: shlwapi: stub implementation for SHSetTimerQueueTimer
by Dmitry Timoshkov 19 May '07

19 May '07

"Nigel Liang" <ncliang(a)gmail.com> wrote: > + CreateTimerQueueTimer(phNewTimer, hQueue, pfnCallback, pContext, > + dwDueTime, dwPeriod, dwFlags); > + > + return *phNewTimer; You have to check the return value of CreateTimerQueueTimer before returning a possible garbage. -- Dmitry.

1 0

Re: RegDeleteTree [6]
by Juan Lang 19 May '07

19 May '07

Hi Stefan, + if (!lpszName) { + ret = ERROR_NOT_ENOUGH_MEMORY; + goto cleanup; + } Now you're mixing tabs and spaces (here and elsewhere.) Please honor the existing formatting. --Juan ____________________________________________________________________________________Yahoo! oneSearch: Finally, mobile search that gives answers, not web links. http://mobile.yahoo.com/mobileweb/onesearch?refer=1ONXIC

1 0

Re: [PATCH 3/4] msi: automation: Generalize list implementation.
by Alexandre Julliard 18 May '07

18 May '07

Misha Koshelev <mk144210(a)bcm.edu> writes: > if (wFlags & DISPATCH_PROPERTYGET) { > V_VT(pVarResult) = VT_I4; > - V_I4(pVarResult) = data->iCount; > + V_I4(pVarResult) = data->ulCount; I committed this patch, but I can't resist pointing out that if you had simply named the field "count" instead of using the (idiotic) Hungarian notation, the code would be just as clear, and you wouldn't need to rename it everywhere when making it unsigned... -- Alexandre Julliard julliard(a)winehq.org

4 3