May 2007 - Wine-devel - list.winehq.org

Re: shell32: handle invalid cbSize in Shell_NotifyIcon[AW] (fixed, with testcase)
by Alexandre Julliard 09 May '07

09 May '07

Mikołaj Zalewski <mikolaj(a)zalewski.pl> writes: > As I've understood from wine-devel to catch exceptions in tests I > need to write my own handler. My handler is more compilcated than in > ntdll/tests/exception.c as I can't assume the next instruction after > the invalid one will be a 'ret' but is simplier than wine > __TRY/__EXCEPT as I don't try to filter exception but catch all of > them (I hope this is not a problem with stack guard pages or something > like that). I'm also not using siglongjump but longjmp to be able to > compile it with msvcrt. It won't work when not using msvcrt, and it's really too ugly. That sort of thing might be acceptable in an exception test in ntdll, but not in shell32 tests. Please find another way to write the test that doesn't rely on deliberately triggering a crash. -- Alexandre Julliard julliard(a)winehq.org

1 0

RE: Resend of Adds NET START to net.exe
by Rolf Kalbermatter 09 May '07

09 May '07

Tim Schwartz wrote: + if(!strcasecmp(operation, "start")) + { + printf("The %s service is starting.\n", service_display_name); + result = StartService(serviceHandle,0,NULL); + CloseServiceHandle(serviceHandle); + if(!result) printf("The %s service failed to start.\n", service_display_name); + else printf("The %s service was started successfully.\n", service_display_name); + + HeapFree(GetProcessHeap(), 0, service_display_name); + CloseServiceHandle(SCManager); + return result; + } + + CloseServiceHandle(serviceHandle); + CloseServiceHandle(SCManager); + HeapFree(GetProcessHeap(), 0, service_display_name); + return 0; +} I think with a little rearrangment of the code and returning result at the end you could avoid duplicating those CloseServiceHandle() and HeapFree() calls. int main(int argc, char *argv[]) { - int ret = 0; if (argc < 2) { printf("The syntax of this command is:\n\n"); - printf("NET [ HELP ]\n"); + printf("NET [ HELP | START ]\n"); return 1; } @@ -35,7 +88,24 @@ int main(int argc, char *argv[]) printf("The syntax of this command is:\n\n"); printf("NET HELP command\n -or-\nNET command /HELP\n\n"); printf(" Commands available are:\n"); - printf(" NET HELP\n"); + printf(" NET HELP NET START\n"); } - return ret; + + if(!strcasecmp(argv[1], "start")) + { + if(argc < 3) + { + printf("Specify service name to start.\n"); + return 1; + } + + if(!net_service(argv[1], argv[2])) + { + return 1; + } + return 0; + } + + + return 0; } Me thinks it would be cleaner to only string test for the command in the main() and pass in a constant you define somewhere to net_service() that specifies the operation to perform. That will allow you to use a switch statement in net_service() and make the code a lot easier to read. Also adding new commands won't make the whole such a big mess as it would now. Also consider to use TRUE and FALSE as return value. This being a Windows tool and not a Unix one it seems clearer to me. Rolf Kalbermatter

1 0

Drop-in replacement of windows dll's?
by Tom Spear 09 May '07

09 May '07

I just remembered reading somewhere (wiki, perhaps?) that the ultimate goal of wine (aside from documenting the windows api, etc) was to provide open-source drop-in replacements for windows' core dll's. If that is the case, do we have a framework setup for building the wine dlls as windows .dll files, so that we could test the actual status of this? I think it would be interesting to see how much of windows will run with wine's dlls in their current state. Obviously it would be bad to test this with something like user32.dll, etc, but something like riched32 and maybe some of the common controls dlls should be ok to test with? -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

4 4

Re: Resend of Adds NET START to net.exe
by Dmitry Timoshkov 08 May '07

08 May '07

"Tim Schwartz" <tim(a)sanityinternet.com> wrote: > + GetServiceDisplayName(SCManager, service_name, NULL, &buffer_size); You need to check GetServiceDisplayName return value here and later. > + /* until GetServiceDisplayName() is implemented, buffer_size will always be zero so the service short name will > be used instead */ GetServiceDisplayName *is* implemented. > + if(!buffer_size) > + { The check above is wrong. -- Dmitry.

1 1

rsaenh: fix bug in RSAENH_CPGetProvParam (corrected)
by Juan Lang 08 May '07

08 May '07

Hi Mounir, + case PP_KEYSTORAGE: + dwTemp = CRYPT_SEC_DESCR; This looks fine.. + result = CryptGetProvParam(prov, PP_KEYSTORAGE, (LPBYTE)&dwParam, &dataLen, 0); + ok(result && dataLen == sizeof(dwParam) && (dwParam == CRYPT_SEC_DESCR), + "Expected CRYPT_SEC_DESCR to be set, got 0x%08X\n",dwParam); but this test will now fail on Win9x, yes? A simple fix would be to check (dwParam & CRYPT_SEC_DESCR) rather than (dwParam == CRYPT_SEC_DESCR). --Juan ____________________________________________________________________________________ Don't pick lemons. See all the new 2007 cars at Yahoo! Autos. http://autos.yahoo.com/new_cars.html

2 3

Re: RSAENH_CPGetProvParam
by Alexandre Julliard 08 May '07

08 May '07

Mounir IDRASSI <mounir.idrassi(a)idrix.fr> writes: > + case PP_KEYSTORAGE: > + dwTemp = GetVersion(); > + /* for Windows NT, 95,98, Me, return CRYPT_PSTORE | CRYPT_UI_PROMPT | CRYPT_SEC_DESCR > + * for the others, return CRYPT_SEC_DESCR > + */ > + if(dwTemp < 0x80000000 && ((dwTemp & 0x000000FF) != 0x00000004)) > + dwTemp = CRYPT_SEC_DESCR; > + else > + dwTemp = CRYPT_PSTORE | CRYPT_UI_PROMPT | CRYPT_SEC_DESCR; You shouldn't add such version checks, unless you have a real life app that depends on the difference. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: Drop-in replacement of windows dll's?
by Tom Spear 08 May '07

08 May '07

On 5/8/07, Thorsten Kani <beebix(a)gmx.net> wrote: > Hi Tom > > Please read through wwn244 and 245. > > If i remenber correctly, at that time common controls from wine wont > work out of the box. > I had to apply reactos patches to them and had to binary patch sfc.dll > on windows. Thanks for the info. I have sfc completely removed from my windows system (as in sfc.dll doesnt even exist) via a nifty little windows component remover. I didnt expect for the common controls to work out of the box, but it would be interesting to see how close we come. I'll try the various things mentioned here when I get time (dont know when that will be), and post results on the wiki, unless someone beats me to the punch. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

1 0

(no subject) (WAS: Re: Drop-in replacement of windows dll's?)
by Tom Spear 08 May '07

08 May '07

On 5/8/07, Brian Vincent <brian.vincent(a)gmail.com> wrote: > On 5/8/07, Tom Spear <speeddymon(a)gmail.com> wrote: > > That would be the framework. I appreciate the response. Is this > > something that either now or in the future will be officially > > supported by wine, or even a true goal of wine, or is it more of a > > side project for you and some others? > > It's not an explicit goal, but it does work, and it is a configuration > that we want to keep working. It's just not a configuration that gets > tested every day, so there might be some little issues. Previously > ReactOS was the big consumer of Wine DLL's as PE. Ok, thanks for the input. Thanks to all of the developers for their hard work, and dedication. Unfortunately I am going to have to mute myself on the list (I can hear the sighs of relief now), as I dont think I am getting anywhere trying to get even trivial patches committed. I sent a patch over a week ago to correct a trace message (not the one for winecfg, but one for uninstaller), and it never got committed. Then I get told to send all of my patches to a developer privately for review before I send them to the patches list, and when I send them to that developer, I _basically_ get told that I should bother submitting them. I know I'm not good enough to even write conformance tests right now, which is why I dont work on the major API's or even on the conformance tests, but sheesh, what do I have to do to get one problematic trace fixed? I'll send that patch one more time, just to make sure it got to the list, and I would appreciate someone offering some comment if there is a reason that it should not be committed. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

1 0

Re: [setupapi/tests] SetupQueryInfOriginalFileInformationA is not available on win98
by Robert Shearman 08 May '07

08 May '07

Paul Vriens wrote: > Hi, > > This makes the setupapi tests run again on win98. > > Changelog > SetupQueryInfOriginalFileInformationA is not available on win98 Weird. From http://msdn2.microsoft.com/en-us/library/aa377417.aspx: "Requires Windows Vista, Windows XP, Windows 2000 Professional, Windows NT Workstation 4.0, Windows Me, Windows 98, or Windows 95" Looks like MSDN is wrong about which versions of Windows support this function and possibly others. -- Rob Shearman

2 1

winegcc: gcc failed
by Zalmay A-khaliq 08 May '07

08 May '07

Respected Developers of the wine My name is Zalmay And I am a BCS student. I have been assigned to port windows(VC++) application into linux. After a thorough searching and researching I found that "wine:" is the resource I can use to port a windows 32 bit application to Linux. I downloaded and installed wine as according to the winehq developers instruction and every thing went well. Then I started to test the winelib samples (notepad) to compile on Redhat Linux 9 according to winelib user guide but in the process I got the following error message -------------------------------------------------------------------------------------------------------------------------- wrc -I. -forsrc.res rsrc.rc winegcc -mwindows -mno-cygwin -o notepad2.exe.so dialog.o main.o rsrc.res -lodbc32 -lole32 -loleaut32 -lwinspool -luuid dialog.o(.text+0x1a5): In function `DIALOG_StringMsgBox': : undefined reference to `wnsprintfW' collect2: ld returned 1 exit status winegcc: gcc failed. make: *** [notepad2.exe.so] Error 2 -------------------------------------------------------------------------------------------------------------- I will be greatefull to you sir for your help in this. That how can I overcome these errors and run my application successfully. thanking you in anticipation Zalmay Gul --------------------------------- Ahhh...imagining that irresistible "new car" smell? Check outnew cars at Yahoo! Autos.

2 1