May 2007 - Wine-devel - list.winehq.org

re: Implement MsiBreak Feature - Bug 8243
by Dan Kegel 04 May '07

04 May '07

> Do we really need to write out unix pid? > AFAIK Winedbg can attach to windows process IDs just fine. Hrmph. The author did say in http://bugs.winehq.org/show_bug.cgi?id=8243 that he needed Windows PIDs, didn't say he needed Unix pids. so maybe you're right. Let's ask him. Hey, Anastasius, do you really need the unix pid? - Dan

1 1

OLE2A
by Bill Medland 04 May '07

04 May '07

Does anyone know where a call to OLE2A is going to enter wine? Presumably OLE2A returning null means that the thread ran out of stack space? Bill Medland

3 5

kernel32: MultiByteToWideChar: MB_USEGLYPHCHARS & incorrect GetLastError() codes fix
by Kirill K. Smirnov 04 May '07

04 May '07

+/* 0x00..0x1f chars glyph map */ +static const WCHAR glyph_xlat[32] = { + 0x0000, 0x263A, 0x263B, 0x2665, 0x2666, 0x2663, 0x2662, 0x2219, + 0x25D8, 0x25CB, 0x25D9, 0x2642, 0x2640, 0x266A, 0x266B, 0x263C, + 0x25BA, 0x25C4, 0x2195, 0x203C, 0x00B6, 0x00A7, 0x25AC, 0x21A8, + 0x2191, 0x2193, 0x2192, 0x2190, 0x221F, 0x2194, 0x25B2, 0x25BC +}; + +/* adds glyphs to the string */ +static inline void add_glyphs( WCHAR *str, unsigned int length ) +{ + unsigned int i; + for (i=0; i!=length; i++) { + if (str[i]<0x20) str[i]=glyph_xlat[str[i]]; + } +} I propose to make this routine extern, because it is the simpliest way to make console renderer (I mean user backend of wineconsole) display the characters below 0x20 correct. The test: #include <windows.h> int main(void) { DWORD d; char str[32]; int i; GetConsoleMode(GetStdHandle(STD_OUTPUT_HANDLE), &d); d &= ~ENABLE_PROCESSED_OUTPUT; SetConsoleMode(GetStdHandle(STD_OUTPUT_HANDLE), d); for (i = 0; i < 32; i++) str[i] = i; WriteConsoleA(GetStdHandle(STD_OUTPUT_HANDLE), str, 32, &d, 0); d |= ENABLE_PROCESSED_OUTPUT; SetConsoleMode(GetStdHandle(STD_OUTPUT_HANDLE), d); return 0; } Under wine we get strange symbols, under windows we get correct glyphs. If we perform the same character conversion in wineconsole/user.c just before actual text output, we get almost the same result that Windows does. The only difference is handling \0 symbol. -- Kirill

1 1

Re: [05/10] d3d: Fix the surface locking rectangle validation
by Stefan Dösinger 04 May '07

04 May '07

Am Donnerstag 03 Mai 2007 20:58 schrieb H. Verbeet: > Validation on the rectangle passed to LockRect/Lock is inconsistent > across ddraw/d3d8/d3d9. D3d9 doesn't do any validation at all, d3d8 > doesn't allow empty, flipped, mirrored, or out of bounds rectangles, > while ddraw does allow empty rectangles, but not flipped, mirrored or > out of bounds ones. Tests for this are in the next few patches in this > set. You have to take care for IDirectDrawSurface::Blt and BltFast too, because parts of the Blt rectangle checks were done by Lock()

1 0

Re: [4/5] WineD3D: Implement vertex blending using GL_ARB_vertex_blend
by H. Verbeet 04 May '07

04 May '07

Actually, I only thought about this just now, but you should also call glDisableClientState(GL_WEIGHT_ARRAY); in unloadVertexData().

2 1

Re: Unsecured API functions
by Tom Spear 04 May '07

04 May '07

On 5/3/07, Robert Shearman <rob(a)codeweavers.com> wrote: > Tom Spear wrote: > > I was writing up a Hello World with input program for a demonstration > > for a non-developer coworker last week, and used the unsecured getch() > > and got the standard warning about how it was unsecured and dangerous > > to use that. That prompted me to look up the basic secured functions > > on the MS website, and compare to wine code. According to MSDN, > > things like gets have been replaced with gets_s. However, as far as I > > can tell, wine still only implements gets for Windows programs to > > use.. Do we implement secured versions of other functions, and if > > not, how come? > > Q: Why doesn't Wine implement X? > A: Because not many programs use it and no-one has felt interested in > implementing it for fun. So in other words, most programs use insecure functions (like gets) instead of using secure functions (like gets_s), leaving themselves vulnerable to all sorts of buffer overflows? I wonder if microsoft doesn't silently convert gets calls to gets_s calls, then, and maybe didn't document that? Otherwise I assume there would be thousands of buffer overflows that (malicious) people would exploit. I understand that most programs dont use either of those functions, but there are others that are used by nearly every program that ms deprecated in favor of secure versions. -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

5 6

Re: kernel32: MultiByteToWideChar: MB_USEGLYPHCHARS & incorrectGetLastError() codes fix
by Dmitry Timoshkov 04 May '07

04 May '07

"Andrew O. Shadoura" <bugzilla(a)tut.by> wrote: > This patch implements MB_USEGLYPHCHARS flag in MultiByteToWideChar function > and fixes incorrect error codes (in case of CP_SYMBOL charset non-zero dwFlags > should give ERROR_INVALID_FLAGS, not ERROR_INVALID_PARAMETER, almost the same > with CP_UTF8, but "dwFlags must be set to either 0 or MB_ERR_INVALID_CHARS" > according to MSDN: http://msdn2.microsoft.com/en-us/library/ms776413.aspx > Also, test case is added. Please follow the existing code style of the files you're changing (indentation, braces, spaces), don't mix tabs and spaces. > + for (i=0; i!=length; i++) { > + if (str[i]<0x20) str[i]=glyph_xlat[str[i]]; > + } This is rather an unusual style of breaking out of the loop, 'i < length' is less confusing IMO. -- Dmitry.

1 0

dinput : crash of Pro Evolution Soccer 3 with a joystick
by Sébastien GRIPON 04 May '07

04 May '07

Hi, I try to play to Pro Evolution Soccer 3 on my Ubuntu Fesity Fawn and it's not far to be possible. Every wine release brings a lots of wined3d improvements and pes3 is almost playable. Many textures are missing, but it's on a good way. Congratulations ! However, I have a problem with my joystick. I have a Microsoft Sidewinder and a Thrustmaster and when any of them is plugged on an USB port, the exe pes3.exe or the PES configuration tool setting.exe crash. This crash doesn't occur when joysticks are not pluggued. I tried to debug this crash, but it is a very hard work. I think dinput is involved but I can't be sure. If you're interesting in this game, this is the crash dump. Thank you, Seb. $ wine setting.exe fixme:win:WIN_CreateWindowEx Parent is HWND_MESSAGE wine: Unhandled page fault on read access to 0x00000000 at address (nil) (thread 0009), starting debugger... Unhandled exception: page fault on read access to 0x00000000 in 32-bit code (0x00000000). Register dump: CS:0073 SS:007b DS:007b ES:007b FS:0033 GS:003b EIP:00000000 ESP:0033f518 EBP:0058b2a8 EFLAGS:00210246( - 00 -RIZP1) EAX:00182c18 EBX:00000000 ECX:7da5bc00 EDX:00181bfc ESI:0058ad38 EDI:00000000 Stack dump: 0x0033f518: 00407eab 00182c18 004363fc 00000000 0x0033f528: 0043e4c0 0043fac4 00000000 0040814e 0x0033f538: 00181bf8 00000003 7da58b08 0033fa20 0x0033f548: 7da5af6c 0058ad38 00007734 90234a8d 0x0033f558: f7bdb63f 00003020 0033f658 7da4bc9f 0x0033f568: 7e4fa15f 7e4c2cd0 0033fa78 0042f0bb Backtrace: =>1 0x00000000 (0x0058b2a8) 2 0x00000000 (0x00182c18) 3 0x00000001 (0x7da5bc00) 4 0x00000000 (0x00000000) 0x00000000: addb %al,0x0(%eax) Modules: Module Address Debug info Name (96 modules) PE 400000- 464000 Deferred setting ELF 7b800000-7b927000 Deferred kernel32<elf> \-PE 7b820000-7b927000 \ kernel32 ELF 7bc00000-7bc96000 Deferred ntdll<elf> \-PE 7bc10000-7bc96000 \ ntdll ELF 7bf00000-7bf03000 Deferred <wine-loader> ELF 7ccdb000-7ccf0000 Deferred midimap<elf> \-PE 7cce0000-7ccf0000 \ midimap ELF 7ccf0000-7cd16000 Deferred msacm32<elf> \-PE 7cd00000-7cd16000 \ msacm32 ELF 7cd16000-7cd2e000 Deferred msacm32<elf> \-PE 7cd20000-7cd2e000 \ msacm32 ELF 7cd2e000-7cd6a000 Deferred wineoss<elf> \-PE 7cd40000-7cd6a000 \ wineoss ELF 7cd6a000-7cdbb000 Deferred libgcrypt.so.11 ELF 7cdbb000-7cdd0000 Deferred libtasn1.so.3 ELF 7cdd0000-7cdfe000 Deferred libcrypt.so.1 ELF 7ce11000-7ce81000 Deferred libgnutls.so.13 ELF 7ce81000-7ceb2000 Deferred libcups.so.2 ELF 7d1e7000-7d1eb000 Deferred libgpg-error.so.0 ELF 7d1eb000-7d21d000 Deferred uxtheme<elf> \-PE 7d1f0000-7d21d000 \ uxtheme ELF 7d21f000-7d224000 Deferred libxfixes.so.3 ELF 7d224000-7d22d000 Deferred libxcursor.so.1 ELF 7d22d000-7d233000 Deferred libxrandr.so.2 ELF 7d233000-7d23b000 Deferred libxrender.so.1 ELF 7d23b000-7d23e000 Deferred libxinerama.so ELF 7d764000-7d7f3000 Deferred winex11<elf> \-PE 7d770000-7d7f3000 \ winex11 ELF 7d89c000-7d8bc000 Deferred libexpat.so.1 ELF 7d8bc000-7d8e7000 Deferred libfontconfig.so.1 ELF 7d8e7000-7d8fb000 Deferred libz.so.1 ELF 7d8fb000-7d966000 Deferred libfreetype.so.6 ELF 7d966000-7d97a000 Deferred oleacc<elf> \-PE 7d970000-7d97a000 \ oleacc ELF 7d97a000-7d997000 Deferred imm32<elf> \-PE 7d980000-7d997000 \ imm32 ELF 7d997000-7da26000 Deferred winmm<elf> \-PE 7d9a0000-7da26000 \ winmm ELF 7da26000-7da5c000 Deferred dinput<elf> \-PE 7da30000-7da5c000 \ dinput ELF 7da5c000-7da75000 Deferred dinput8<elf> \-PE 7da60000-7da75000 \ dinput8 ELF 7dad8000-7e35e000 Deferred libglcore.so.1 ELF 7e35e000-7e3de000 Deferred libglu.so.1 ELF 7e3de000-7e46a000 Deferred libgl.so.1 ELF 7e46a000-7e55b000 Deferred libx11.so.6 ELF 7e55b000-7e569000 Deferred libxext.so.6 ELF 7e569000-7e581000 Deferred libice.so.6 ELF 7e581000-7e642000 Deferred wined3d<elf> \-PE 7e590000-7e642000 \ wined3d ELF 7e642000-7e66a000 Deferred d3d8<elf> \-PE 7e650000-7e66a000 \ d3d8 ELF 7e66a000-7e705000 Deferred oleaut32<elf> \-PE 7e680000-7e705000 \ oleaut32 ELF 7e705000-7e718000 Deferred libresolv.so.2 ELF 7e718000-7e736000 Deferred iphlpapi<elf> \-PE 7e720000-7e736000 \ iphlpapi ELF 7e736000-7e78b000 Deferred rpcrt4<elf> \-PE 7e740000-7e78b000 \ rpcrt4 ELF 7e78b000-7e828000 Deferred ole32<elf> \-PE 7e7a0000-7e828000 \ ole32 ELF 7e828000-7e84a000 Deferred oledlg<elf> \-PE 7e830000-7e84a000 \ oledlg ELF 7e84a000-7e87d000 Deferred winspool<elf> \-PE 7e850000-7e87d000 \ winspool ELF 7e87d000-7e939000 Deferred comctl32<elf> \-PE 7e890000-7e939000 \ comctl32 ELF 7e939000-7e991000 Deferred shlwapi<elf> \-PE 7e950000-7e991000 \ shlwapi ELF 7e991000-7ea8c000 Deferred shell32<elf> \-PE 7e9a0000-7ea8c000 \ shell32 ELF 7ea8c000-7eb2c000 Deferred comdlg32<elf> \-PE 7ea90000-7eb2c000 \ comdlg32 ELF 7eb2c000-7eb73000 Deferred advapi32<elf> \-PE 7eb40000-7eb73000 \ advapi32 ELF 7eb73000-7eb7f000 Deferred libgcc_s.so.1 ELF 7eb81000-7eb86000 Deferred libxdmcp.so.6 ELF 7eb86000-7eb89000 Deferred libxau.so.6 ELF 7eb89000-7eb92000 Deferred libsm.so.6 ELF 7ec7c000-7ed3a000 Deferred gdi32<elf> \-PE 7ec90000-7ed3a000 \ gdi32 ELF 7ed3a000-7ee76000 Deferred user32<elf> \-PE 7ed60000-7ee76000 \ user32 ELF 7efa4000-7efaf000 Deferred libnss_files.so.2 ELF 7efaf000-7efc6000 Deferred libnsl.so.1 ELF 7efc6000-7efed000 Deferred libm.so.6 ELF 7efed000-7eff7000 Deferred libnss_nis.so.2 ELF 7eff7000-7f000000 Deferred libnss_compat.so.2 ELF b7d51000-b7d56000 Deferred libxxf86vm.so.1 ELF b7d57000-b7d5b000 Deferred libdl.so.2 ELF b7d5b000-b7e9c000 Deferred libc.so.6 ELF b7e9d000-b7eb4000 Deferred libpthread.so.0 ELF b7eb4000-b7eb6000 Deferred libnvidia-tls.so.1 ELF b7ec7000-b7fd8000 Deferred libwine.so.1 ELF b7fda000-b7ff5000 Deferred ld-linux.so.2 Threads: process tid prio (all id:s are in hex) 0000000a 0000000c 0 0000000b 0 00000008 (D) C:\Program Files\KONAMI\Pro Evolution Soccer 3\setting.exe 0000000d 0 00000009 0 <==

2 1

Unsecured API functions
by Tom Spear 04 May '07

04 May '07

I was writing up a Hello World with input program for a demonstration for a non-developer coworker last week, and used the unsecured getch() and got the standard warning about how it was unsecured and dangerous to use that. That prompted me to look up the basic secured functions on the MS website, and compare to wine code. According to MSDN, things like gets have been replaced with gets_s. However, as far as I can tell, wine still only implements gets for Windows programs to use.. Do we implement secured versions of other functions, and if not, how come? -- Thanks Tom Check out this new 3D Instant Messenger called IMVU. It's the best I have seen yet! http://imvu.com/catalog/web_invitation.php?userId=1547373&from=power-email

3 2

Re: Boundary test cases for SystemTimeToFileTime and GetDateFormat
by James Hawkins 03 May '07

03 May '07

On 5/3/07, Bill Medland <billmedland(a)shaw.ca> wrote: > Bill Medland (billmedland(a)shaw.ca) > Lower boundary test cases for SystemTimeToFileTime and GetDateFormat > > Index: wine/dlls/kernel32/tests/locale.c > =================================================================== > RCS file: /home/wine/wine/dlls/kernel32/tests/locale.c,v > retrieving revision 1.11 > diff -u -r1.11 locale.c > --- wine/dlls/kernel32/tests/locale.c 2 Apr 2007 11:24:36 -0000 1.11 > +++ wine/dlls/kernel32/tests/locale.c 3 May 2007 22:21:55 -0000 > @@ -424,6 +424,34 @@ > STRINGSW("dddd d MMMM yyyy","Wednesday 23 October 2002"); /* Incorrect DOW and time */ > ret = GetDateFormatW (lcid, 0, &curtime, input, buffer, COUNTOF(buffer)); > EXPECT_VALID; EXPECT_LENW; EXPECT_EQW; > + > + /* Limit tests */ > + > + curtime.wYear = 1601; > + curtime.wMonth = 1; > + curtime.wDay = 1; > + curtime.wDayOfWeek = 0; /* Irrelevant */ > + curtime.wHour = 0; > + curtime.wMinute = 0; > + curtime.wSecond = 0; > + curtime.wMilliseconds = 0; > + STRINGSW("dddd d MMMM yyyy","Monday 1 January 1601"); > + SetLastError(0xdeadbeef); > + ret = GetDateFormatW (lcid, 0, &curtime, input, buffer, COUNTOF(buffer)); > + EXPECT_VALID; EXPECT_LENW; EXPECT_EQW; > + > + curtime.wYear = 1600; > + curtime.wMonth = 12; > + curtime.wDay = 31; > + curtime.wDayOfWeek = 0; /* Irrelevant */ > + curtime.wHour = 23; > + curtime.wMinute = 59; > + curtime.wSecond = 59; > + curtime.wMilliseconds = 999; > + STRINGSW("dddd d MMMM yyyy","Friday 31 December 1600"); > + SetLastError(0xdeadbeef); > + ret = GetDateFormatW (lcid, 0, &curtime, input, buffer, COUNTOF(buffer)); > + EXPECT_INVALID; > } > > > Index: wine/dlls/kernel32/tests/time.c > =================================================================== > RCS file: /home/wine/wine/dlls/kernel32/tests/time.c,v > retrieving revision 1.3 > diff -u -r1.3 time.c > --- wine/dlls/kernel32/tests/time.c 4 Jan 2007 10:46:26 -0000 1.3 > +++ wine/dlls/kernel32/tests/time.c 3 May 2007 22:22:04 -0000 > @@ -73,6 +73,23 @@ > (st).wSecond = 32; \ > (st).wMilliseconds = 123; > > +#define SETUP_ZEROTIME(st) \ > + (st).wYear = 1601; \ > + (st).wMonth = 1; \ > + (st).wDay = 1; \ > + (st).wHour = 0; \ > + (st).wMinute = 0; \ > + (st).wSecond = 0; \ > + (st).wMilliseconds = 0; > + > +#define SETUP_EARLY(st) \ > + (st).wYear = 1600; \ > + (st).wMonth = 12; \ > + (st).wDay = 31; \ > + (st).wHour = 23; \ > + (st).wMinute = 59; \ > + (st).wSecond = 59; \ > + (st).wMilliseconds = 999; > > > static void test_conversions(void) > @@ -82,6 +99,12 @@ > > memset(&ft,0,sizeof ft); > > + SETUP_EARLY(st) > + ok ((!SystemTimeToFileTime(&st, &ft) && GetLastError() == ERROR_INVALID_PARAMETER), "Conversion failed EARLY\n"); > + > + SETUP_ZEROTIME(st) > + ok (SystemTimeToFileTime(&st, &ft) && ft.dwHighDateTime == 0 && ft.dwLowDateTime == 0, "Conversion failed ZERO_TIME\n"); > + You need to check each part of those conditions separately in their own ok()'s. -- James Hawkins

1 0