June 2007 - Wine-devel - list.winehq.org

Re: [crypt32/tests 2/2] Vista uses a different error code
by Kai Blin 13 Jun '07

13 Jun '07

On Wednesday 13 June 2007 16:13:21 Paul Vriens wrote: > ok ( GetLastError() == ERROR_FILE_INVALID || > + GetLastError() == ERROR_INVALID_PARAMETER /* Vista */ || > GetLastError() == S_OK /* Win98 */, > "Expected ERROR_FILE_INVALID or S_OK, got 0x%08x\n", > GetLastError()); ok ( !memcmp(&subject, &nullSubject, sizeof(GUID)), In that case I think it would make sense to also fix the message. Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://us1.samba.org/samba/team/ -- Will code for cotton.

1 0

Re: gdi32: Add some tests for BITMAPINFOHEADER biSize checks.
by Dmitry Timoshkov 13 Jun '07

13 Jun '07

"Hans Leidekker" <hans(a)it.vu.nl> wrote: > These tests pass on XP and on Wine with Dimitry's patch applied. > I can also confirm that the patch fixes bug 8674. > > -Hans > > Changelog > Add some tests for BITMAPINFOHEADER biSize checks. Please add DeleteObject calls to delete a DIB section after each succeeding test. -- Dmitry.

1 0

CJK XCreateFontSet performance problem (bug 5309)
by dank＠kegel.com 13 Jun '07

13 Jun '07

It turns out bug 5309 affects Picasa; a Chinese user complained that menus were terribly slow. The patch Aric committed here: http://www.winehq.org/pipermail/wine-cvs/2006-October/027272.html seems to have helped. I'm wondering, though, whether this points up a problem in how linux distros configure their asian fonts. I'm sending this via direct telnet to winehq's tsmtp server, since there's no other way to avoid setnding passwords in the clear from where I am at the momment (dang unencrypted wireless in hotel forooms.). Sorry for all the ^H's :-)

1 0

Seeking advice for rewrite of dlls/quartz/videorenderer.c using DirectDraw
by Alex Villacís Lasso 13 Jun '07

13 Jun '07

From a time till now, I am using a test application in Visual Basic in order to test progress in quartz. The code for the application (along with a precompiled EXE) can be found at the following address: http://www.palosanto.com/~a_villacis/WMediaTest.tar.bz2 One of the things I dislike about the current quartz implementation is that when a large AVI video file (say, 640x480) is played with the test application, the sound stutters (in both ALSA and OSS) while the frames are being updated. This occurs with the builtin quartz.dll, but not with native (WinXP) quartz. From what I can deduce from WINEDEBUG=+tid,+quartz , it seems that builtin feeds video and audio in the same thread. In addition, dlls/quartz/videorenderer.c uses StretchDIBits() in order to write one frame of video into the output window. Apparently StretchDIBits() is slow enough in my machine that it cannot complete by the next sound sample. Therefore the stuttering. I made a little patch to move the video rendering in videorender.c into a separate thread, in order to allow it to drop frames. However this does not completely eliminate the stuttering audio. I am now thinking about rewriting the video rendering with DirectDraw. It seems that native quartz.dll uses DirectDraw, not GDI, to display video frames into the output window. One thing I am worried about is the pixel format of the surfaces. The video data is 32bpp, but the output window uses my X config at 16bpp. However, nowhere in the ddraw trace of native quartz I can find any reference to a CreateSurface with 32bpp. It seems that native quartz does the depth conversion itself. The question is this: if I create a 32 bpp surface (in order to lock it and write the 32 bpp frame data into it), can I then blit it into a 16 bpp output window and somehow let DirectDraw take care of the depth conversion? If so, can this be any faster than writing the depth conversion myself? Alex Villacís Lasso -- perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

4 5

Re: [GDI+ implementation: 1/8] GdipDrawLineI
by Evan Stade 13 Jun '07

13 Jun '07

On 6/12/07, Evan Stade <estade(a)gmail.com> wrote: > Hi, > > Changelog: > *implemented GdipDrawLineI > > dlls/gdiplus/gdiplus.spec | 2 +- > dlls/gdiplus/graphics.c | 16 ++++++++++++++++ > 2 files changed, 17 insertions(+), 1 deletions(-) > > -Evan Stade > > Sorry, to clarify: this series of patches is a resend of the last without the tests, and with some new patches.

2 1

Re: [GDI+: 2/10] first pen test
by Detlef Riekenberg 13 Jun '07

13 Jun '07

On Mo, 2007-06-11 at 11:52 -0700, Evan Stade wrote: > + > + status = GdipCreatePen1((ARGB)0xffff00ff, 10.0f, UnitPixel, > &pen); > + > + todo_wine > + expect(GdiplusNotInitialized, status); > + > + GdipDeletePen(pen); > +} Is pen set to NULL, when GdipCreatePen1 failed? This ist not checked in your test and not done in your implementation, but you pass uninitialized garbage (pen) to GdipDeletePen. You might want to use: - GpPen *pen; + GpPen *pen = NULL; and - GdipDeletePen(pen); + if (status == Ok) then GdipDeletePen(pen); Thanks -- By by ... Detlef

3 2

Re: advapi32: Allow setting CRYPT_VERIFYCONTEXT and CRYPT_NEWKEYSET in CryptAcquireContext
by Mounir IDRASSI 12 Jun '07

12 Jun '07

Hi Maarten, You should not modify advapi32 to accommodate this behavior but rsaenh instead. The acceptance of this flags combination is specific to the Microsoft RSA CSP implementation and other vendors don't support it (I tested it with four third party CSPs). Moreover, your patch will clearly introduce unexpected CSP behavior when this combination of flags is specified as you start by acquiring a context using CRYPT_NEWKEYSET only: the returned context will not behave as intended by the CRYPT_VERIFYCONTEXT flag which normally limits many things. The modification to rsaenh is straightforward: in the code of RSAENH_CPAcquireContext, juste add the line "case CRYPT_VERIFYCONTEXT | CRYPT_NEWKEYSET:" above the existing line "case CRYPT_VERIFYCONTEXT:". Mounir IDRASSI IDRIX - Cryptography and IT Security Experts http://www.idrix.fr Maarten Lankhorst wrote: > With tests. I think this is the correct way to do this: First try to > Acquire with CRYPT_NEWKEYSET, then CRYPT_VERIFYCONTEXT if it already exists. >

1 0

Re: [7/7] Add ID3D10Device interface and implement it's IUnknown methods
by H. Verbeet 12 Jun '07

12 Jun '07

On 13/06/07, Kovács András <andras(a)csevego.net> wrote: > + TRACE("Adapter %p, Driver Type %d, Software Module handle %p, Flags %08x, SDKVersion %d, Device %p\n", > + Adapter, DriverType, Software, Flags, SDKVersion, Device); I think the DriverType should be traces as string there (ie, using something like the debug_d3d*() functions in dlls/wined3d/utils.c). Also, please prefix hexadecimal numbers with 0x. d3d8 and d3d9 are pretty bad wrt producing readable traces, but we might as well do it right when writing a new dll. > + FIXME("ID3D10Device interface is not binary compatible to windows yet\n"); Actually, a void * is binary compatible with IDGXIAdapter * I suppose it's a matter of taste, but personally I think more C like naming (ie, lower case, _ separated) for the parameter names would be easier on the eyes :-) (and you do use those for the ID3D10DeviceImpl functions). Chris already mentioned the initial refcount on IRC.

2 2

Re: Allow GL_ONE on WINED3DRS_EDGEANTIALIAS dstBlend value (try 2)
by H. Verbeet 12 Jun '07

12 Jun '07

On 13/06/07, Kovács András <andras(a)csevego.net> wrote: > Hi, > > Allow GL_ONE on WINED3DRS_EDGEANTIALIAS' dstBlend value. This fixes Pirates Of > Caribbean At The Worlds End blending problem. ( black square behind linght > sources) > > -- I think I wasn't very clear wrt what I said on IRC / wrote in my earlier mail. The original patch was fine with me for what it did. What I meant to say was that an additional patch should probably follow that one to remove the code that modifies srcBlend and dstBlend. Personally I think the changes are small enough to go in a single patch, but that would be up to Alexandre. You should remove the line modifying srcBlend a few lines above as well though.

1 0

Re: [7/7] Add ID3D10Device interface and implement it's IUnknown methods
by Stefan Dösinger 12 Jun '07

12 Jun '07

Am Mittwoch, 13. Juni 2007 00:17 schrieb Kovács András: > [7/7] Add ID3D10Device interface and implement it's IUnknown methods >+ object->lpVtbl = &D3D10Device_Vtbl; >+ object->ref = 0; Spotted by KittyCat on irc. The ref should be 1. Either set it to 1, or call ID3D10Device_AddRef(*Device) after setting *Device(ms seems to do it the Addref way).

1 0