June 2007 - Wine-devel - list.winehq.org

Re: cabinent: add a comment about parm passing
by James Hawkins 28 Jun '07

28 Jun '07

On 6/27/07, Jeff Latimer <lats(a)yless4u.com.au> wrote: > Coverity CID 43 Forward_Null is false. This adds a comment explaining > the NULL pass is ok. > Why do we need a comment for that? -- James Hawkins

3 2

Re: [1/2] gdi32: Added PolyDraw tests to tests/path.c [try2]
by Misha Koshelev 28 Jun '07

28 Jun '07

> +static const path_test_t polydraw_path[] = { > + {300, 300, 6, 0, 0}, /*0*/ > + {150, 200, 2, 0, 0}, /*1*/ > + {200, 150, 3, 0, 0}, /*2*/ > + {300, 300, 6, 0, 1}, /*3*/ > + {300, 300, 2, 0, 0}, /*4*/ > + {400, 300, 2, 0, 0}, /*5*/ > + {400, 350, 2, 0, 0}, /*6*/ > + {50, 100, 6, 0, 0}, /*7*/ > + {100, 50, 2, 0, 0}, /*8*/ > + {400, 250, 2, 0, 0}, /*9*/ > + {500, 300, 2, 0, 0}, /*10*/ > + {500, 350, 2, 0, 0}, /*11*/ > + {350, 400, 6, 0, 1}, /*12*/ > + {600, 200, 2, 0, 1}, /*13*/ > + {500, 150, 2, 0, 1}, /*14*/ > + {500, 350, 6, 0, 0}, /*15*/ > + {500, 150, 2, 0, 0}, /*16*/ > + {100, 200, 2, 0, 0}, /*17*/ > + {400, 150, 2, 0, 0}, /*18*/ > + {400, 350, 2, 0, 0} /*19*/ > + }; This is not major, but just thought I'd point out that if you do a set WINETEST_DEBUG=3 on Windows and then call ok_path in your test (you can just do a 0 size when you first make the test for this), you'll get the following output, which seems like it would be both faster to produce and nicer-looking (get the actual PT_'s rather than a number): static const path_test_t polydraw_path[] = { {300, 300, PT_MOVETO, 0, 0}, /* 0 */ {150, 200, PT_LINETO, 0, 0}, /* 1 */ {200, 150, PT_LINETO | PT_CLOSEFIGURE, 0, 0}, /* 2 */ {300, 300, PT_MOVETO, 0, 0}, /* 3 */ {300, 300, PT_LINETO, 0, 0}, /* 4 */ {400, 300, PT_LINETO, 0, 0}, /* 5 */ {400, 350, PT_LINETO, 0, 0}, /* 6 */ {50, 100, PT_MOVETO, 0, 0}, /* 7 */ {100, 50, PT_LINETO, 0, 0}, /* 8 */ {400, 250, PT_LINETO, 0, 0}, /* 9 */ {500, 300, PT_LINETO, 0, 0}, /* 10 */ {500, 350, PT_LINETO, 0, 0}, /* 11 */ {350, 400, PT_MOVETO, 0, 0}, /* 12 */ {600, 200, PT_LINETO, 0, 0}, /* 13 */ {500, 150, PT_LINETO, 0, 0}, /* 14 */ {500, 350, PT_MOVETO, 0, 0}, /* 15 */ {500, 150, PT_LINETO, 0, 0}, /* 16 */ {100, 200, PT_LINETO, 0, 0}, /* 17 */ {400, 150, PT_LINETO, 0, 0}, /* 18 */ {400, 350, PT_LINETO, 0, 0}}; /* 19 */ Hope this helps. Misha

1 0

mozilla control download problems?
by Dan Kegel 28 Jun '07

28 Jun '07

Say, I just saw a repeatable mozilla download failure. Here's a summary of the tcpdump log. Is this a known problem? - Dan

2 1

Re: Problem with patch "dsound: Simplify mixing by removing remixing support, and fix its waveout breakage"
by Maarten Lankhorst 27 Jun '07

27 Jun '07

Chris Rankin schreef: > Hi, > > This patch has killed the sound on World of Warcraft. Instead, I now get silence and a stream of > errors like this: > Don't #if 0 out the code there Change it to something like this: if (pmix > This->buflen) WARN("Mixing further ahead then buffer is long\n");

2 1

Re: Worms world party install - 0x80040706 object reference not set
by James Hawkins 27 Jun '07

27 Jun '07

On 6/27/07, Peter <swjawa(a)gmail.com> wrote: > 2007/6/27, James Hawkins <truiken(a)gmail.com>: > > On 6/27/07, Peter <swjawa(a)gmail.com> wrote: > > > When I try to install worms world party I get a message when 6%: > > > Unhandled Exception [_] [X] > > > Error Number: 0x80040706 > > > Description: Object reference not set > > > > > > Setup will now terminate > > > [OK] > > > > > > http://consumer.installshield.com/kb.asp?id=q110641 > > > This site says to update InstallShield engine, but that's the solution > > > for windows. > > > > > > > Why would it not be the solution for Wine? > > > > -- > > James Hawkins > > > Yes it works now. > Thanks. > Please reply-all so everyone can know the results. -- James Hawkins

1 0

RE: [advapi32/service #2] Don't rely blindly on type
by Rolf Kalbermatter 27 Jun '07

27 Jun '07

Hi Paul, >On Wine, type is unchanged in a failure case for RegQueryValueExW. This means the >previous code relied on the returned type of the previous last succeeded call, huh? You are right that there is a problem with the existing code at some places. But changing - if( ( r == ERROR_SUCCESS ) || ( type == REG_DWORD ) ) + if( ( r == ERROR_SUCCESS ) && ( type == REG_DWORD ) ) should be enough. Since the funtion returned with success the type must be valid now. Rolf Kalbermatter

1 0

Worms world party install - 0x80040706 object reference not set
by Peter 27 Jun '07

27 Jun '07

When I try to install worms world party I get a message when 6%: Unhandled Exception [_] [X] Error Number: 0x80040706 Description: Object reference not set Setup will now terminate [OK] http://consumer.installshield.com/kb.asp?id=q110641 This site says to update InstallShield engine, but that's the solution for windows.

4 3

Move of the Bugzilla CVS to Git
by Jan Zerebecki 27 Jun '07

27 Jun '07

I hereby announce that with the upgrade of Bugzilla we will use Git for what the "bugzilla" cvs module is currently used (if nothing unforeseen prevents this). This can be seen as a test for also moving our other remaining CVS modules. Anyone who has a problem with this should speak up now. Btw. the idea is to upgrade the server to "Sarge" shortly before the Bugzilla upgrade. Jan

5 5

Re: user32,wined3d: move refresh rate fallback to catch all cases
by Erik Inge Bolsø 27 Jun '07

27 Jun '07

On 25/06/07, H. Verbeet wrote: >On 24/06/07, Erik Inge Bolsø <knan-wine at anduin.net> wrote: >> --- >> dlls/user32/sysparams.c | 13 ++++++++++++- >> dlls/wined3d/device.c | 10 +--------- >> 2 files changed, 13 insertions(+), 10 deletions(-) >> >What was the reason for writing this? See the comments on http://appdb.winehq.org/appview.php?iVersionId=5618 ... essentially, I have a game that's hardcoded to request 1024x768x50hz, which is not available on my monitor, and the existing fallback to any available refresh rate in wined3d didn't catch it. Haven't traced the exact sequence of calls - but figured that since there was an existing refresh rate fallback coded, I'd move that a step instead of duplicating. I can try to trace it down and duplicate the fallback, if that would be a preferable solution. -- Erik

3 2

Re: user32:painting.c Add comment to function.[try2]
by Robert Shearman 27 Jun '07

27 Jun '07

Anatoly Lyutin wrote: > /*********************************************************************** > * LockWindowUpdate (USER32.@) > + * > + * Enables or disables choosen window. > This isn't quite correct. LockWindowUpdate prevents or allows painting to the window. It doesn't prevent user input, which is what "disable" suggests (c.f. EnableWindow). -- Rob Shearman

1 0