July 2007 - Wine-devel - list.winehq.org

crosstest target missing dependency on idl headers
by John Klehm 06 Jul '07

06 Jul '07

Hello, Just thought I'd mention that the crosstest target is missing dependencies on headers generated from .idl files. The ones that come up for me are tmarshal.h(oleaut32) and server.h (rpcrt4). Thanks to Hans Leidekker for helping me find my way on this. So as of right now here is how the process works: >From a clean source dir: ./configure make crosstest => error: missing tmarshal.h make -C dlls/oleaut32/tests => errors out as well but it builds tmarshal.h make crosstest => error: missing server.h make -C dlls/rpcrt4/tests => errors out as well but builds server.h make crosstest => suceeds Maybe this will be helpful to someone else who found it slightly confusing. John

1 0

appdb not working
by Stefan Leichter 05 Jul '07

05 Jul '07

Hello, is anyone else getting the error message "Fatal error: type of variable cw is not recognized." when browsing http://appdb.winehq.org/ with konquerror? My system is debian etch (kde 3.5.5). The main page of the appdb is working well with iceweasel (mozilla). The problem started after the downtime on last weekend for me. Bye Stefan

5 4

re: Direct3D Game test framework
by Dan Kegel 05 Jul '07

05 Jul '07

Martin wrote: > on YAWT homepage, I read: > "YAWT can be used either standalone, or as part of the > cxtest.org automated regression test suite for Wine" > > You mean, it can generate result emails which can be parsed by CxTest server? I mean that it should be trivial to wrap a Yawt test into a cxtest script... Lei's got this on his todo list, part of the work will be making sure the yawt test results feed smoothly into cxtest (which we haven't looked at yet, really).

1 0

access restrictions / sandbox
by Ioannis Nousias 05 Jul '07

05 Jul '07

Hello wine developers, I'm running Wine on Linux. Is there a way to restrict wine from accessing some folders and/or resources? Ideally have Wine restraint in its WINEPREFIX directory and configure what resources it could access (like network for instance). I've seen few talks on having a 'sandbox' that date back to 2002 and most conclusions suggest that access restrictions should be made on the host OS. If that's the case, any tips on how one could do that in Linux would be appreciated. Thanks. -Ioannis

4 4

Re: [kernel32/tests 1/2] Don't crash on win98
by Vitaliy Margolen 05 Jul '07

05 Jul '07

Paul Vriens wrote: > Hi, > > Test crashes on win98. > > Changelog > Don't crash on win98 > > Cheers, > > Paul. > As I recall some programs do this and it works. And those programs strictly require w2k+ to work. Should we use a version check here instead? Vitaliy.

2 2

Re: gdi32: Using a bitmap font as the sans serif fallback is a very bad idea.
by Vitaliy Margolen 05 Jul '07

05 Jul '07

Huw Davies wrote: > --- > dlls/gdi32/freetype.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > ------------------------------------------------------------------------ > > You reverting this patch: commit 69a23a608eea59624b2f37ab424e0f42b3da5baf Author: Dmitry Timoshkov <dmitry(a)codeweavers.com> Date: Thu Feb 23 20:33:06 2006 +0800 gdi: Use "MS Sans Serif" as default sans serif font, not Arial. Any reasons why? Also AFAIK native does not use Arial for any part of the interface. Vitaliy.

2 2

Re: programs:extrac32 Add new program (Extrac32.exe) (Pre alpha version :))
by Vitaliy Margolen 05 Jul '07

05 Jul '07

Anatoly Lyutin wrote: > This program (EXTRAC32.exe) needed for extract *.cab files. Some Win > programs use EXTARC32.exe for inner functions and often impossible to > change unpacker. I test this EXTRAC32.exe for one program (Russian > office program) and it works! > > I shall be glad for all comments which will help to make this program > better. > +static BOOL ExtCmp( const WCHAR str1[], const WCHAR str2[] ) Any reason you are not using strcmpW? > +LRESULT WINAPI ExtCabCallback ( IN PVOID pMyInstallData, > + IN UINT Notification, > + IN UINT Param1, > + IN UINT Param2 ) > +{ What do you need the "IN" here for? It's the useless domain of some parts of PSDK. Please use one format of indentation, if (), function( p1, p2, p3 ), etc. It's hard to impossible to read your code with at least 5-10 different variations of both some times IN ONE LINE! > + case SPFILENOTIFY_NEEDNEWCABINET: // Unexpected. > + lRetVal = NO_ERROR; > + break; > + } Do not use c++ comment stile. This part is completely useless - you set lRetVal = NO_ERROR; above already. Same type of mistake all over the place. > +++ programs/extrac32/parsecmd.c 2007-07-04 16:12:38 +0400 What do you need a whole separate file for? It has only one function! > + for(i=0;i<strlenW(cmdline);i++) > + { > + if( ((cmdline[i] == ' ')||(cmdline[i] == '\t') )&&(!bCav)&&((i!=0)&&(cmdline[i-1]!=' ')&&(cmdline[i-1]!='\t')) ) > + { This will never be true with i == 0, so you might as well start from i = 1. > + if( (cmdline[strlenW(cmdline)-1] != ' ')&&(cmdline[strlenW(cmdline)-1] != '\t') ) > + (*argc)++; What if cmdline is ""? What will be be checking here? Also you really should combine this with the previous for() loop. > + if(cmdline[i] == '\"') You don't need to escape double-quote here. Vitaliy.

2 1

Re: msi [2/13]: Handle remote calls to MsiDoAction
by Robert Shearman 05 Jul '07

05 Jul '07

James Hawkins wrote: > > package = msihandle2msiinfo( hInstall, MSIHANDLETYPE_PACKAGE ); > if (!package) > - return ERROR_INVALID_HANDLE; > + { > + HRESULT hr; > + IWineMsiRemotePackage *remote_package; > + > + remote_package = (IWineMsiRemotePackage *)msi_get_remote( hInstall ); > + if (!remote_package) > + return ERROR_INVALID_HANDLE; > + > + hr = IWineMsiRemotePackage_DoAction( remote_package, (BSTR *)szAction ); > BSTR * is the same level of indirection as LPWSTR *, which is not what you want. Also note that in general you can convert from BSTR to LPWSTR, but not LPWSTR to BSTR (as LPWSTR don't have the string length secretly stashed away before the string starts). The same applies to some of your other patches too. > + > + IWineMsiRemotePackage_Release( remote_package ); > + > + if (FAILED(hr)) > + { > + if (HRESULT_FACILITY(hr) == FACILITY_WIN32) > + return HRESULT_CODE(hr); > + > + return ERROR_FUNCTION_FAILED; > + } > + > + return ERROR_SUCCESS; > + } > > ret = ACTION_PerformUIAction( package, szAction, -1 ); > msiobj_release( &package->hdr ); > -- Rob Shearman

1 0

About stdlib.h system()
by Zhongli Xu 05 Jul '07

05 Jul '07

Hi all, I tried to call another .exe file in my own exe file by using the system() API. But the return value of system() is -1 and errno is set to ENOENT. It indicates that the another exe file is not found. So I copy the another exe to the fake directory: C:\windoes\system32, since wine always find the exe file there. And I also set the environment variable "System" and "Path" in the key HOST_CURRENT_USER/Environment thru regedit. But still, wine couldn't find the another exe. Any help is welcomed. Milo Xu

4 4

[PATCH] winspool.drv: Fallback to the first found printer as default printer [try 2]
by Pedro Araujo Chaves Jr. 04 Jul '07

04 Jul '07

--- dlls/winspool.drv/info.c | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-) Detlef Riekenberg wrote: > > Sorry, I misinterpreted the Patch because of the subject. > > I'm fine with your Patch, when you fix your typo: > > > + if (hadprinter & !haddefault) > > + WINSPOOL_SetDefaultPrinter(dests[0].name, dests[i].name, TRUE); > > With greetings from Copy and Paste: [i] => [0] > > > For the subject, I suggest to include "Fallback": > winspool.drv: Fallback to the first found printer as default printer Thank you for your comments, and sorry for the typo and the ambiguous subject… - Pedro.

1 0