August 2007 - Wine-devel - list.winehq.org

Direct3D 10 design considerations
by Stefan Dösinger 20 Aug '07

20 Aug '07

Hi, In the past days there was a bit of discussion about the implementation design of our future d3d10 implementation. The major question was wether we should make a clean start over with opengl 3.0, or extend wined3d for d3d10. A few facts: *) D3D10 is a clean restart without any backwards compatiblity, so is gl3. The fixed function pipeline was removed in both. *) The D3D10 interface is a present. Many of the nasty things in d3d9 have gone. SRGB textures are a pixel format property now. Sampler states are a texture property, not a device setting. Offscreen-rendering is more fbo like. *) WineD3D contains a huge set of functionality of d3d10 already. D3D10 is an evolutionary step, not a revolution. I estimate that 80% of the functionality that is of our interest already existed in d3d9. Code reuse, especially of the shader code and texture management, is desireable. *) GL3 isn't out yet. When will we have a gl3 implementation on all platforms and drivers? *) If we split, we do not have to take care for old opengl implementations and missing extensions. For d3d10 we could just require gl3, period. Of course that will only work satisfiably for the user if there are gl3 implementations everywhere. So we have two ways: 1) Do the same Microsoft did, and do a fresh start. Some code, like the shader code, could be copied over and forked. This is propably the fastest way, but it leaves us with 2 different d3d implementation. The d3d10 implementation on the other hand would be free of old junk. It would make it hard to run d3d10 on gl2+extensions, and even more harder to implement d3d9- on gl3. 2) Extend wined3d. We could use the inheritance scheme like in old ddraw, where the non-rendering functionality was implemented in a base object, and the renderer specific things(DGA / User / 3D) was implemented in objects derived from the base objects. This was a nice thing, but it made the code next to unreadable IMHO because of a huge number of objects and unintuitive interactions(DGA code calling User stuff, common code calling callbacks that are set in 5 places in the code, 5 different surface types). WineD3D already has the attachment points for such an abstraction. We have COM vtables and state management callbacks. Implementing d3d10 properly in wined3d is most likely more work than a restart is, but it would allow us to reuse some code. What we would have to do is this: *) Make sampler states work like in opengl. D3D7-9 takes care for updating the per texture states based on the device states. This will require some code to be moved from wined3d to d3d7-9 and duplicated in the 3 libs, most notable sampler state tracking in stateblocks. *) Move the srgb flag -> format matching from wined3d to d3d9. Before this can be done, wined3d has to be changed from D3DFORMAT to DXGI_FORMAT style. *) Clearly separate gl-specific code from non-gl-specific code in surface, texture, cubetexture, volumetexture, indexbuffer and vertexbuffer. Then split them in a base object and a derived gl2 object. Add a gl3 object implementing the gl-specific stuff in gl3. Make sure there is no gl specific buffer/texture stuff in the device(like CreateVBO & *) Add a 2nd state table and callback functions for gl3. GL3 will have different state linkings. Most of the states can stay unimplemented unless we want to run d3d9 with gl3. D3D10 is much simpler here because the fixed function pipeline was removed. *) Do something about the context manager. Multithreading has changed in d3d10, and it may change in gl3. Offscreen rendering in d3d10 can require fbos(no point in d3d10 offscreen rendering without them), this has much less hassles than the back buffer or pbuffer orm. Context management will most likely be much simpler in d3d10+gl3. Andras tells me that he has the d3d10 stubs(no rendering yet) done now, and he is writing some tests currently, then he will send stubs and tests in. Which way do you think should we go?

5 9

Re: dsound: Handle failing of IDsDriver_CreateSoundBuffer better
by Vitaliy Margolen 20 Aug '07

20 Aug '07

Maarten Lankhorst wrote: > There, now hush. :p > > Does 'Hardware Acceleration to Emulation' silently, without requiring of > the user to do something. > > > - ERR("Could not map sound device for direct access (%s)\n", strerror(errno)); > - ERR("Please run winecfg, open \"Audio\" page and set\n" > - "\"Hardware Acceleration\" to \"Emulation\".\n"); > + WARN("Could not map sound device for direct access (%s)\n", strerror(errno)); > return DSERR_GENERIC; And this really fixes the bug, doesn't just hide the error message? If it fixed, then there should be no messages at all. I really do not want to have people opening bugs because something crashes/sound doesn't work, etc. Vitaliy

2 1

Re: Greek resource file for comctl final
by Paul Vriens 19 Aug '07

19 Aug '07

Dj Apal [GR] wrote: > OK changed the copyright and added the diff file for the rsrc.rc file so as > to be included. > > Thnx for noticing that! > > I think that we are OK now. Sorry for all this mess but it was my first time > posting a patch! > > > > ------------------------------------------------------------------------ > > Your 'greek_comctl' patch is in 'diff -up' format. The 'rsrc.diff' patch should also be in that format (and done from the root of your Wine source directory). Cheers, Paul.

1 0

choppy anim
by Skrzynka 18 Aug '07

18 Aug '07

Hi, I'm trying to get some game (Settlers 3) to work on Wine (updated sources recently from git). If possible, I'd like to ask for some clues for a start: 1) the issue is choppy animation - the frame rate is abt 1/sec while the cpu load is low. However there are random periods when there seem to be about few frames per second (and cpu is laoded 100%). I tried measuring the time between call and return of DLL functions in relay.c. The only thing that looked suspiciously was WaitForSingle|MultipleObjects having times like 200-500ms. I also tried adding some delay to WaitForVerticalBlank in ddraw.c but also to no effect. Where should I start looking for the problem - some events or callbacks code? which? 2) when I run it from within winedbg i get lots of exceptions (no matter if app was started from winedbg or it was attached later) and no matter what combination of pass/continue I do, the app crashed with some msg box about exception or structured exception. Any pointers to docs on this? Any suggestions will help greatly. Thanks & regards Piotr -- ----- AlphaNet - najtaniej w sieci! -------- Odnowienia domen w rewelacyjnych cenach! .pl - 65 zl, .com.pl - 50 zl, reg - 20 zl http://www.domeny.alpha.pl --------------------------------------------

1 0

Re: #winehq admin abuse
by Abel Chiaro 18 Aug '07

18 Aug '07

Tom Wickline <twickline(a)gmail.com> wrote: > I gladly take the side of vitamin on this issue. I believe he is a > valuable member of the FOSS community, he has contributed many patches > to this and other OSS projects. And in HIS free time he volunteers on > the #winehq IRC channel to help people who want to accept his help... > He tried to help YOU and YOU refused to try what he ask YOU to do!! > YOU kept asking the same stupid *shit* over and over and over until > you got on his last nerve. He cant help someone who doesn't want to > help them self. > > Also, it doesn't look to me like he cussed anyone out! but I guess I > just cussed YOU as I used the poo word in this reply. :D I beg your pardon if I got this wrong, but I seems to me that Jonathan is *Pie-rate* rather than carretto. While carretto did ask the same thing over and over until vitamin gave him the download link, Pie-rate only asked once (timestamp: 09:43:50 PM), to which vitamin replied with his "oh well". I don't want to take any sides here — especially because I refrain from going to support channels exactly to avoid such situations —, but I have to say that vitamin's behavior in that discussion is definitely less than polite. However, I do think that Jonathan made the issue a bit bigger than it actually is. Ah, yes, regarding cussing around, I recall reading vitamin saying "F***" to Pie-rate twice, all the while not cussing *carretto* out. Anyway, being civil does no harm. My 2¢. - Pedro.

5 5

Re: Greek resource file for comctl final
by Maarten Lankhorst 18 Aug '07

18 Aug '07

Dj Apal [GR] schreef: > > OK changed the copyright and added the diff file for the rsrc.rc file > so as to be included. > > Thnx for noticing that! > > I think that we are OK now. Sorry for all this mess but it was my > first time posting a patch! Just curious, are files supposed to have dos line terminators? It seems to me like your file has it. Cheers, Maarten

1 0

re: [patch] Garbage code in text string display
by Dan Kegel 18 Aug '07

18 Aug '07

Xin Guan wrote: > This patch solves the problem that many MBCS programs display garbage code > for text strings. Because most windows programmers do not handle charsets > properly, we have to force DEFAULT_CHARSET in here. Can you give a simple example of such a program (preferably downloadable)? Can you add a conformance test showing that your patch is correct? - Dan

1 0

Re: Greek resource patch for comctl [third attempt, last I hope!!]
by Paul Vriens 18 Aug '07

18 Aug '07

Dj Apal [GR] wrote: > Hope this is what u want us to send! ;) used --> diff -up /dev/null ... etc etc > > > > ------------------------------------------------------------------------ > > Hi, Just a few remarks. The copyright says 'Eric Kohl' is that correct? You also need to add this resource file to 'rsrc.rc' in that same directory otherwise it will never be picked up. Cheers, Paul.

1 0

Re: bugs 9062,9325
by Stefan Dösinger 17 Aug '07

17 Aug '07

Am Freitag, 17. August 2007 15:39 schrieb Martin Vanek: > I have posted some minor bugs in combobox a week ago (ID=9062, with a > source text example and pictures documenting what's wrong). I am not an expert on user32 stuff, but generally you should send one patch per mail. If you have 2 patches, just send 2 mails. If you have written a test application, you may want to include it in dlls/user32/tests/ to proove the correctness of your patches and prevent the issue from coming back.

1 0

Re: [PATCH 3/6] winealsa: Implement IDsCaptureDriverImpl_Open
by Tomas Carnecky 17 Aug '07

17 Aug '07

Maarten Lankhorst wrote: > Sanity check to see if device can be opened or not Is alloca() not allowed in wine? (asking because you allocate hw_params on the stack, but it's freed if the function exits, so it's only used inside this one function). tom

2 2