August 2007 - Wine-devel - list.winehq.org

Can we please have at least a minimal coding style ?
by Tomas Carnecky 06 Aug '07

06 Aug '07

This type of construct seems popular in the wine source: while (isspace(*GL_Extensions)) GL_Extensions++; Start = GL_Extensions; Or even worse (I've seen this in winex11.drv, and it took me quite a long time until I understood it - it was part of a larger block with a lot these constructs): if (cond) do_sth(); do_sth_else(); This indentation is so utterly stupid, it makes my brain hurt (I'm sure I'm not the only one)!! I don't know what AJs stance is on code readability and I know that there are no official coding style guidelines, but can we please avoid this? Can we agree on a set of fundamental style rules? To make peer-reviewing patches easier? And for people not familiar with the code easier to understand it? Please? tom

5 4

Some details about SHDoDragDrop
by Timo Kunze 06 Aug '07

06 Aug '07

Hi, currently Wine's SHDoDragDrop is a stub and the comment states that it probably is equivalent to DoDragDrop. That's not quite true. In one of my programs I passed a NULL drop source accidentally and to my surprise it worked. So SHDoDragDrop creates an IDropSource object for you if you don't pass one. I've also found out, that on Vista SHDoDragDrop does the drag-image generation for you if you pass a NULL hWnd to SHDoDragDrop. While the hWnd thing works only if the dragged data object describes shell items, the IDropSource thing works for any dragged data. HTH Timo -- www.TimoSoft-Software.de - Unicode controls for VB6 "Those who sacrifice freedom for safety deserve neither."

1 0

Re: winecfg: values list should be NULL-terminated.
by Paul Chitescu 06 Aug '07

06 Aug '07

Great, thanks! Paul On Mon, 6 Aug 2007, Kirill K. Smirnov wrote: > This fixes winecfg crash caused by recent winecfg changes.

1 0

Re: wine.inf: Remove RelayFromExclude. It hides the real call traces which makes nearly useless relay logs. [resend]
by Alexandre Julliard 06 Aug '07

06 Aug '07

Vitaliy Margolen <wine-patches(a)kievinfo.com> writes: > Resend. Anything wrong with this patch? > > After this change went in, it became impossible to see what functions was > being called where and how inside Wine to understand what is happening. If > any one looks at the bugzilla and all of the reported +relay logs they are > 100% useless in determining the real cause of the problem. It wasn't the > case before without RelayFromExclude. In most cases it makes the trace much more readable and manageable. If you want to know what's going on inside Wine code there are better debug channels to use than relay. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: user32 - set_active_window uses SendMessage instead of PostMessage for WM_ACTIVATEAPP messages.
by Vitaliy Margolen 06 Aug '07

06 Aug '07

Peter Dons Tychsen wrote: > Hello Wine. > > On original Windows, the messages WM_ACTIVATEAPP are sent using > PostMessage() and not SendMessage() like in the current Wine > implementation. > > I have thoroughly verified that this is the case on Windows-XP (that it > uses PostMessage()). > > This error can lead to fatal focusing problems, as some programs call > more focus related functions when they receive this message. This leads > to recursive calls into set_active_calls. It does not crash, but leads > to unexpected results such as lost focus for mouse and keyboard. > > This fixes the focus for the game "Wild Metal" if you switch focus from > the game to the desktop, and then back again. > > http://www.rockstargames.com/classics/ > > Cheers, > > /Pedro > > This patch makes 45 msg.c tests in user32 fail for me. Could you double check your findings? Also when you say "thoroughly verified" have you used Wine tests or your own program? Vitaliy

4 9

Re: wined3d: Use a safer, more compliant method to parse extension strings
by Vitaliy Margolen 06 Aug '07

06 Aug '07

Chris Robinson wrote: > > + > + /* End */ > + {NULL, 0} > }; [..] > - for (i = 0; i < (sizeof(EXTENSION_MAP) / sizeof(*EXTENSION_MAP)); ++i) { > + for (i = 0; EXTENSION_MAP[i].extension_string; ++i) { What was the reason for this change? It's a static const array why do you want to treat it as a dynamically sized one? Vitaliy.

2 1

Re: [1/5] D3D9: Deal with failing surface creation
by H. Verbeet 05 Aug '07

05 Aug '07

On 03/08/07, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + ok(SUCCEEDED(hr) || hr == D3DERR_INVALIDCALL, "IDirect3DDevice9_CreateTexture: %s\n", DXGetErrorString9(hr)); Same comment as for yesterday's test (even though that one apparently made it in), I don't think that's a useful test. As the patch comment says, the point of the test isn't to test CreateTexture behaviour.

2 1

Re: dinput - Allow the use of the standard Joystick GUID when calling CreateDevice
by Vitaliy Margolen 05 Aug '07

05 Aug '07

Peter Dons Tychsen wrote: > OK. Please review this diff: > > I will re-submit it if you like it. > > /Pedro Alright looks good now (you might want to remove the extra white space your patch adds - git complains about those). Just left to make the same change to the other joystick interface :) BTW don't forget to cc: the wine-devel list when you replying. Vitaliy.

3 11

[winetest] Show missing tests in single/group results
by Paul Vriens 05 Aug '07

05 Aug '07

Hi, Before sending this to wine-patches I would like people to have a look first. I've added as many screenshots as I thought where needed to show the changes (so sorry in advance for the flood of pictures). This patch makes sure that missing tests are shown in the test results, both when there is only one system in a group (f.e. Win98) or multiple systems in a group. 'single_test_before' shows that currently we have a single '.' where a test is missing (without a link obviously or explanation). 'main_summary_before' shows the same '.' but now we have 2 systems in the group. This means there is a link to the group overview. 'group_overview_before' shows nothing for these particular tests (gdiplus). Now with the new output: 'single_test_after' still show the '.' but now it's marked todo (and a skip border as these tests are skipped). 'failing_test_single_onmouseover' shows at least some explanation. 'main_summary_after' is still the same with this new version (there is a link to the group overview). 'group_overview_after' shows that now the group overview correctly shows the missing tests and 'failing_test_onmouseover' shows some explanation. Remember that this is still without winetest producing output about missing dll's. Next patches will: - add a missing dll as one of the reasons for missing tests - add some better clue's on the main summary for multiple systems in a group (not a single '.' but maybe the same 'failed and skipped'). One of the thoughts I had was to replace the '.' with a '?' in case of missing tests for an unknown reason but I'm not sure about that yet. Comments/remarks etc.. are welcome. I'd also like to hear about other idea's for this page to make it useful for everybody. Apart from the fact that we probably should have more exposure to the fact that we have such a page/tool. We saw an immediate rise (slowed down again) in test results as soon as winetest was mentioned on 'http://tweakers.net/meuktracker/15817/Wine-0.9.42.html' (in Dutch). There it was also mentioned that some machines crashed because of the tests etc.. (maybe a wine-winetest component on bugzilla could help with that which we could reference on the main test.winehq.org/data/*/index.html page). Cheers, Paul.

1 0

Re: [PATCH] winecfg: Fix crash caused by calling set_reg_key with NULL value
by Evan Stade 04 Aug '07

04 Aug '07

On 8/3/07, Nigel Liang <ncliang(a)gmail.com> wrote: > diff --git a/programs/winecfg/winecfg.c b/programs/winecfg/winecfg.c > index 84dd4c8..05f322c 100644 > --- a/programs/winecfg/winecfg.c > +++ b/programs/winecfg/winecfg.c > @@ -468,11 +468,15 @@ void set_reg_key(HKEY root, const char * > > wpath = HeapAlloc(GetProcessHeap(), 0, (strlen(path)+1)*sizeof(WCHAR)); > wname = HeapAlloc(GetProcessHeap(), 0, (strlen(name)+1)*sizeof(WCHAR)); > - wvalue = HeapAlloc(GetProcessHeap(), 0, (strlen(value)+1)*sizeof(WCHAR)); > > MultiByteToWideChar(CP_ACP, 0, path, -1, wpath, strlen(path)+1); > MultiByteToWideChar(CP_ACP, 0, name, -1, wname, strlen(name)+1); > - MultiByteToWideChar(CP_ACP, 0, value, -1, wvalue, strlen(value)+1); > + > + if (value) > + { > + wvalue = HeapAlloc(GetProcessHeap(), 0, (strlen(value)+1)*sizeof(WCHAR)); > + MultiByteToWideChar(CP_ACP, 0, value, -1, wvalue, strlen(value)+1); > + } > > set_reg_key_ex(root, wpath, wname, wvalue, REG_SZ); > > -- > 1.4.1 > > > > You need to initialize wvalue to NULL -- Evan Stade

2 2