August 2007 - Wine-devel - list.winehq.org

[test.winehq.org] Addition of todo on the results page
by Paul Vriens 24 Aug '07

24 Aug '07

Hi, While I'm also busy with getting dll information on the page, I'm still adding stuff. This next iteration will add todo information on the pages. Current situation: http://test.winehq.org/data/200708221000/ There are several todo's for the Wine test but this is not shown on the page. New situation: http://www.xs4all.nl/~pvriens/200708221000_new/ The main difference is the yellow border on the left for some of the Wine tests (for the group shown in the Main Summary and individually at the Group 'Wine differences'). I deliberately didn't add all the todo tests on the Group level (as is done for the skips) as todo have more to do with tests/implementations than the actual system running the test. If there are no objections, I'll sent the necessary patches in a few days. Bit off topic: One thing that struck me was the difference in test results for the Wine runs. This has most likely to do with old Wine installations running new tests. I will add the Wine version to the infrastructure soon so that these outcomes make more sense. -- Cheers, Paul.

3 5

Re: user32: static controls should have a clipping region set while sending the WM_CTLCOLORSTATIC (patch)
by Alexandre Julliard 24 Aug '07

24 Aug '07

"Mikolaj Zalewski" <mikolajz(a)google.com> writes: > +static void setup_clipping(HWND hwnd, HDC hdc) > +{ > + RECT rc; > + HRGN hrgn; > + > + /* Native control has always a clipping region set when sending > + * the WM_CTLCOLORSTATIC and an application depends on it > + */ > + GetClientRect(hwnd, &rc); > + hrgn = CreateRectRgn(rc.left, rc.top, rc.right, rc.bottom); > + if (GetClipRgn(hdc, hrgn) == 0) > + SelectClipRgn(hdc, hrgn); > + DeleteObject(hrgn); > +} You need to set the region in all cases, intersecting with the existing one if any. Also you need to restore the previous region after painting. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: cabinet 4: Don't extract a file if DoExtract is FALSE
by Alexandre Julliard 24 Aug '07

24 Aug '07

"James Hawkins" <truiken(a)gmail.com> writes: > Changelog: > * Don't extract a file if DoExtract is FALSE. This one fails make test: ../../../tools/runtest -q -P wine -M advpack.dll -T ../../.. -p advpack_test.exe.so files.c && touch files.ok files.c:465: Test failed: Expected dest\testdir to exist files.c:466: Test failed: Expected dest\b.txt to not exist files.c:467: Test failed: Expected dest\testdir\d.txt to not exist files.c:474: Test failed: Expected dest\testdir to exist files.c:475: Test failed: Expected dest\b.txt to not exist files.c:476: Test failed: Expected dest\testdir\d.txt to not exist files.c:483: Test failed: Expected dest\testdir to not exist make[2]: *** [files.ok] Error 7 -- Alexandre Julliard julliard(a)winehq.org

1 0

What the web test reports need.
by Jakob Eriksson 24 Aug '07

24 Aug '07

We need a http://test.winehq.org/data/latest/ Which always points to the latest results. Instead of: http://test.winehq.org/data/200708221000/ etc... Who can fix this? regards, Jakob

2 1

Photoshop CS2 surprise
by Dan Kegel 23 Aug '07

23 Aug '07

I fired up Photoshop CS2 today on a hunch, and sure enough, it starts and runs just barely well enough to test! When it starts, you have to dismiss a dialog box, press ^C in the console, and then dismiss another dialog box, but after that you can open an image, edit it, and save it successfully. Quite a few menu items misbehave, so there's lots left to do, but this is a lovely improvement. It seems likely that Mikolaj's recent changes had something to do with this. He's been doing quite a bit on Photoshop lately. Go Mikolaj! - Dan

1 0

re: mscoree: Return S_OK if mono runtime is found
by Dan Kegel 23 Aug '07

23 Aug '07

Hi Bryan, I believe your patch lets me install WinBITS successfully. Thanks! - Dan p.s. To be precise, it let winetricks mono12 wine msiexec /i WinBITS.msi work. I then had to do winetricks gdiplus corefonts else the startup would complain about a missing font. Now mono's only complaining about GetThreadContext failed in gc, but that's another kettle of fish.

1 0

Re: user32: static controls should have a clipping region set while sending the WM_CTLCOLORSTATIC (2nd version, with testcase, fixes bug #9195)
by James Hawkins 23 Aug '07

23 Aug '07

On 8/23/07, Mikolaj Zalewski <mikolajz(a)google.com> wrote: > Tests have shown that every control style should set the clipping > region so I've changed the patch. > You forgot the patch. -- James Hawkins

1 0

Application minimizing resizes it to icon size.
by Meelis Mägi 23 Aug '07

23 Aug '07

Hello, i have a silly question. Why does application resized to icon size when it gets minimized ? (also when switching desktops, but thats acts as minimizing i think) Reason i ask is that, there is MMO Ryzom (ryzom.com) that gets a bit confused when minimized and ingame UI gets messed up (only game i know that has this problem) If i comment out SetWindowPos() line in X11DRV_UnmapNotify() function (file dlls/winex11.drv/winpos.c), then ingame ui stays ok. thanks

2 3

Re: shlwapi: Fix UrlCombineW for absolute URLs without slashes.
by Dmitry Timoshkov 23 Aug '07

23 Aug '07

"Robert Shearman" <rob(a)codeweavers.com> wrote: > + process_case = (*base.pszSuffix == L'/') ? 5 : 1; Although using the L prefix is harmless in this case, it's better to avoid it in Wine code IMO. -- Dmitry.

1 0

[winetest] Use of HeapAlloc and friends
by Paul Vriens 23 Aug '07

23 Aug '07

Hi, Is there any particular reason we don't use HeapAlloc/HeapReAlloc in winetest? The rest of our programs do, but winetest uses malloc and realloc. Cheers, Paul.

3 4