September 2007 - Wine-devel

Re: olethk32.dll
by Juan Lang 06 Sep '07

06 Sep '07

Hi Stefan, + if (fdwReason == DLL_PROCESS_ATTACH) + DisableThreadLibraryCalls(hinstDLL); + + return TRUE; You should probably add a DLL_WINE_PREATTACH case that returns FALSE. --Juan

1 0

IDirect3DImpl_EnumDevices only enumerating IID_IDirect3DTnLHalDevice
by David Hedberg 06 Sep '07

06 Sep '07

Hi, I've been tracking down the reason for bug 7993 ( http://bugs.winehq.org/show_bug.cgi?id=7993 , "Delta Force Land Warrior 1.31 -> Can't find 3D Video Card" ), and I think I've found it. It appears as if the EnumDevices callback in Delta Force for some reason discards all devices with a GUID of IID_IDirect3DTnLHalDevice, thus discarding the only device enumerated by wine. This is "easily" checked (and bypassed) by searching for and altering the IID_IDirect3DTnLHalDevice value used in the check (78 9E 04 F5 (..) ) in the delta force executable. While this works as a "fix", it's obviously not a good one. In my (somewhat limited and at the moment not doublechecked) understanding, windows "always" returns (at least) two devices, one reporting T&L capable and one not. So I am wondering how one would implement a proper fix for this in wine. Fixing this together with applying (or otherwise fixing the issue highlighted in) the patch at http://flodaby.ath.cx/~david/0001-ddraw-fix-cases-where-desc2.u2.dwMipMapCo… (also sent to wine-patches), would enable both Delta Force Land Warrior and Delta Force Task Force Dagger to run great with wine. David

2 4

Re: winhelp, Vector NTI, molecular biologists
by Misha Koshelev 05 Sep '07

05 Sep '07

On 9/4/07, Alexander Sornes wrote: > Tirsdag 04 september 2007 03:17, skrev Misha Koshelev: > > On 9/3/07, Stefan Dosinger wrote: > > > Am Montag, 3. September 2007 13:30:57 schrieb Damjan Jovanovic: > > > > Somebody needs to make a do-nothing-useful app, intended for Windows, > > > > that also installs on wine and supplies each and every DLL that > > > > Windows applications need but we don't have in wine (like MFC42.DLL, > > > > the D3DX9_xx.DLL's, new MSVCRT's, etc.). That way we can legally use > > > > those DLLs without a Windows licence. > > > > > > This is not necessarily true. I don't know about MFC42.dll or the > > > msvcrts, but the directx eula does not allow that; It requires the > > > application to run only on the Microsoft Windows operating system, > > > targetting both Windows and Linux+Wine violates the contract. These are > > > the conditions for distributing the directx dlls. I've not found anything > > > against installing them on Wine, you just must not distribute the DLLs > > > with an app that targets both Windows and Wine. Thus I think it's legal > > > to write a script that downloads them from the original location > > > @microsoft.com and installs them, as long as that script isn't bundled > > > with the dlls. However, IANAL. > > > > > > What remains unanswered though is how this affects game vendors whose > > > games run on Wine without intention from the game vendor and ship the > > > dlls, e.g. Eve Online. > > > > Actually you all bring up rather interesting points with regards to Vector > > NTI as: > > > > (a) It pretty much ships with almost every Microsoft redistributable needed > > (e.g., MDAC, Windows Script, MFC71, etc.) and installs them on its > > installation _except_ MFC42 (not sure why this oversight and if this would > > break it on some native system, although I _believe_ it installed correctly > > on my plain vanilla Win98 VMWare installation, but I would have to double > > check for sure). > > > > I believe mfc42 is bundled with Windows XP. Actually, I just reinstalled Windows 98 in VMWare _without_ installing VMWare tools and even my version of Windows 98 is bundled with mfc42.dll, so wine really should provide it too... > > > (b) If the licenses for those DLLs/redistributables are the same as you > > suggest for DirectX, this would mean they couldn't ever say they support > > Wine (but I'm not sure whether or not the licenses are). Anyway, seeing it > > work "gold" on Wine still wouldn't be a bad thing in either case and > > certainly Vector NTI is not the only program that needs good winhelp > > support. > > > > Misha > Misha

1 1

Would also like to contribute to Wine
by Reece Dunn 05 Sep '07

05 Sep '07

I am interested in the Wine project, and my manager at work has accepted my request to work on it. I work for a company that develops Windows software, so as I have access to Visual Studio, and thus the sources for ATL, MFC and the msvc runtime (provided with the full version of Visual Studio), I state that I will not participate in the development of these components. I have not seen, and do not intend on seeing, any of the Windows source code. I am interested in the following. 1. Writing tests for various parts of Wine, initially the RECT API. I know that this is a simple API, but even the simplest API needs tests. I will expand on this set as time permits. Is it possible for me to write tests for ATL and/or the msvc runtime, as this is not implementing those API? 2. Investigating the failing tests (e.g. the new, unknown message in the monthcal tests on Vista) and how to fix them properly. 3. Improve the user32/comctl32 controls. I would like to address the outstanding issues with these if I can. 4. Microsoft Active Accessibility (MSAA)/User Interface Automation (UIA). I would like to get this working with the various Linux accessibility API, so that more people will have access to Windows applications running on Linux+Wine. 5. Microsoft Text-To-Speech API (part of the sapi DLL). This is on my wishlist and is likely beyond my capabilities to get working. It is used by applications like Dragon Naturally Speaking and Cepstral SwiftTalker. Here, there is supporting voices installed on Windows that use the SAPI interface directly, and voices installed on Linux that implement different APIs. 6. Get theming working with the user32 controls and Window frames. Get the theming support working with GNOME themes as well. 7. Anything else I can think of. I would be interested in improving Wine to help get more applications running on Wine. Does anyone know if there are some common things that are holding Wine up, or is it more a per-application problem as each application is hitting different problems in Wine? - Reece

5 6

The Sims - some hacks
by Trent Waddington 05 Sep '07

05 Sep '07

Attached is a patch for some hacks that will get The Sims to run and not crash (for a while). First, there's the easy problem of the cursors not working. This is because Sims.exe calls LoadCursorFromFile on a bunch of files that contain icons, not cursors. As the only difference between the two is that the cursor has a hotspot in front of it, I added some code to treat the icon as a cursor with no hotspot. Other programs may benefit from this patch, as it seems it is something you can get away with on Windows. Then there's the problem of the actual crash. This is caused by CreateSurface in ddraw returning an error and Sims.exe doesn't check for the error. It is returning an error because Sims.exe is trying to create a depth buffer without specifying a valid pixelformat. Note that it actually does pass a pixelformat, it's just all zeros, except for the dwSize member. Again, this appears to be something you can get away with on Windows.. the pixelformat defaults to the current screen format. Once these patches are applied there are significant problems with the game. Minor: the company logo flashes and won't go away without a mouse click. Minor: the scrolling text of pointless terms sometimes overlaps itself Annoyance: there seems to be some blitting error on the "neighborhood" screen that results in parts of the splash screen not being overwritten. Major: the characters in the game are not redrawn correctly, and eventually, it will crash. Overall result: not playable. If someone with a better understanding of wined3d code could have a look, I'd love to receive some hints on what could be causing these issues. Thanks, Trent

3 2

Fwd: Phoronix Forums: AMD Linux Announcement
by Dan Kegel 05 Sep '07

05 Sep '07

Say, maybe these new drivers won't crash with Wine a la http://wiki.winehq.org/fglrx Wouldn't that be sweet? ---------- Forwarded message ---------- From: phoronix-forums(a)phoronix.com <phoronix-forums(a)phoronix.com> Date: Sep 4, 2007 9:15 PM Subject: Phoronix Forums: AMD Linux Announcement ... We also wanted to let you know that Advanced Micro Devices has officially announced their new Linux driver this morning, which is a overhaul of their existing Linux graphics driver. The AMD fglrx 8.41 (Catalyst 7.9) driver introduces Radeon HD 2000 "R600" support as well as massive performance improvements for all supported generations of ATI graphics processors. This new driver is not available today, but it will be made available within the next week. Though at Phoronix we have been using and testing this new driver now for a number of weeks. Below are the articles we have just published today about this new ATI/AMD Linux driver. AMD 8.41 Display Driver Preview -- Our first article on this new driver are simply the technical details such as noting this driver has been actually in development for over a year, the AIGLX support that is coming next month, and other relevant information. Read More: http://www.phoronix.com/vr.php?view=10955 ATI R300/400 Linux Performance -- We re-tested the Radeon X300 and X800XL with this new driver and it offers some HUGE performance improvements! The Mobility Radeon X300 was as much as 54 times faster compared to the previous ATI Linux driver. The improvements in these older ATI GPUs are simply astonishing. Read More: http://www.phoronix.com/vr.php?view=10964 ATI R500 Linux Performance -- With an X1300PRO, X1800XL, X1800XT, and X1950PRO in hand we compared the ATI 8.40 and 8.41 display drivers. The performance improvements for the Radeon X1000 series range from 50% to 90% faster. Read More: http://www.phoronix.com/vr.php?view=10970 ATI Radeon HD 2900XT Linux Performance -- Four months after the Radeon HD 2900XT was introduced there is finally proper Linux support! Not only is there support, but it offers a pretty darn good level of performance. In fact, the ATI Radeon HD 2900XT offers the best bang for the buck when it comes to high-end graphics cards. There is also more on the R600 support in general inside this article. Read More: http://www.phoronix.com/vr.php?view=10973 AMD: Accelerating Open-Source Drivers? -- Not today, but in the near future AMD will be making an announcement about accelerating efforts within the open-source community. What does this mean? Open-Source ATI Drivers? We will tell you in due time. Read More: http://www.phoronix.com/vr.php?view=10977 At Phoronix we also have a number of other articles we will be publishing in the near future pertaining to this new driver and the Radeon HD 2000 series support. Be sure to check out the latest articles and join in on the discussions in the Phoronix Forums! Best, The Phoronix Staff

2 1

osalt.com top-requested commercial app stats
by Dan Kegel 05 Sep '07

05 Sep '07

http://www.osalt.com/ has a list of most-requested commercial windows apps, currently: 1. Visio 2. Norton Ghost 3. Photoshop 4. Nero Burning Rom 5. Dreamweaver 6. AutoCAD 7. Illustrator 8. Access 9. Premiere Pro 10. ACDSee No idea how they generated that list, but it seems somewhat reasonable. cc'ing them in case they feel like commenting on where that list comes from and what it means. (And no, I don't think Ghost will ever run on Wine :-) - Dan

7 7

Re: comctl32: TCM_SETCURSEL also updates the focus item
by Reece Dunn 05 Sep '07

05 Sep '07

On 04/09/07, Aric Stewart <aric(a)codeweavers.com> wrote: > --- > dlls/comctl32/tab.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) Do you have a test for this? - Reece

2 1

Re: RFC: winealsa.drv: fix memory leak (found by Smatch)
by Michael Stefaniuc 04 Sep '07

04 Sep '07

Hello Lionel, the patch has different problems: - lpNewData is used only in "case MOD_MIDIPORT" so moving the HeapAlloc call there makes more sense. - Please keep the indentation level of the surrounding code; here it is 4. - Tabs are 8 spaces. Lionel_Debroux wrote: > modLongData leaks some heap memory in three error paths. Found in > Michael Stefaniuc's list of Wine potential bugs detected by Smatch. > > While looking at the function, I noticed > if (lpNewData) > HeapFree(GetProcessHeap(), 0, lpData); > at lines 1015-1016. > I think "lpData" should be "lpNewData", because this function allocates > "lpNewData", not "lpData" which is passed to the function through a > LPMIDIHDR structure. > So I added a FIXME, and I am asking for comments/corrections :-) lpNewData is allocated only if lpData has a wrong start/end byte in the header. It is passed on in that case instead of lpData. If the functions to which it is passed on process the data asynchronous then the current code is correct: the caller cannot free the data (lpNewData) as the callee might still need to process it whereas lpData is unused and can be freed. The "event" name suggests an asynchronous processing of the data but that's only a guess as i don't know the code. bye michael > > 2007-08-31 Lionel Debroux <lionel_debroux(a)yahoo.fr> > * dlls/winealsa.drv/midi.c: > winealsa.drv: fix memory leak (found by Smatch) > > > ------------------------------------------------------------------------ > >>From e148279419c180bd3db1b8b1a61f737bd92c73be Mon Sep 17 00:00:00 2001 > From: Lionel Debroux <lionel_debroux(a)yahoo.fr> > Date: Fri, 31 Aug 2007 14:33:40 +0200 > Subject: winealsa.drv: fix memory leak (found by Smatch). > > --- > dlls/winealsa.drv/midi.c | 12 +++++++++--- > 1 files changed, 9 insertions(+), 3 deletions(-) > > diff --git a/dlls/winealsa.drv/midi.c b/dlls/winealsa.drv/midi.c > index f5e98ed..2cf9287 100644 > --- a/dlls/winealsa.drv/midi.c > +++ b/dlls/winealsa.drv/midi.c > @@ -1013,20 +1013,26 @@ static DWORD modLongData(WORD wDevID, LPMIDIHDR lpMidiHdr, DWORD dwSize) > snd_seq_ev_set_sysex(&event, lpMidiHdr->dwBufferLength + len_add, lpNewData ? lpNewData : lpData); > snd_seq_event_output_direct(midiSeq, &event); > if (lpNewData) > - HeapFree(GetProcessHeap(), 0, lpData); > + HeapFree(GetProcessHeap(), 0, lpData); /* FIXME: lpNewData instead of lpData ? */ > break; > default: > WARN("Technology not supported (yet) %d !\n", > MidiOutDev[wDevID].caps.wTechnology); > - return MMSYSERR_NOTENABLED; > + if (lpNewData) > + HeapFree(GetProcessHeap(), 0, lpNewData); > + return MMSYSERR_NOTENABLED; > } > > lpMidiHdr->dwFlags &= ~MHDR_INQUEUE; > lpMidiHdr->dwFlags |= MHDR_DONE; > if (MIDI_NotifyClient(wDevID, MOM_DONE, (DWORD)lpMidiHdr, 0L) != MMSYSERR_NOERROR) { > WARN("can't notify client !\n"); > - return MMSYSERR_INVALPARAM; > + if (lpNewData) > + HeapFree(GetProcessHeap(), 0, lpNewData); > + return MMSYSERR_INVALPARAM; > } > + if (lpNewData) > + HeapFree(GetProcessHeap(), 0, lpNewData); > return MMSYSERR_NOERROR; > } > > > > ------------------------------------------------------------------------ > > -- Michael Stefaniuc Tel.: +49-711-96437-199 Sr. Network Engineer Fax.: +49-711-96437-111 -------------------------------------------------------------------- Reg. Adresse: Red Hat GmbH, Hauptstätter Strasse 58, 70178 Stuttgart Handelsregister: Amtsgericht Stuttgart HRB 153243 Geschäftsführer: Brendan Lane, Charlie Peters, Michael Cunningham, Werner Knoblich

1 0

Re: dinput: Add evdev mouse driver.
by Stefan Dösinger 04 Sep '07

04 Sep '07

Hi, > This is the first fully working implementation of dinput mouse using evdev > generic input driver. I have enabled this driver by default. If people do > not have functioning HAL or that for some reasons it can't find the mouse > device, it will fall-back to current mouse driver. > > Use explorer to enumerate all mice devices. Unfortunately msdn says there > can only be one system pointer device. I was curious if that patch fixes Empire Earth, so I tried it, but it fails to create a new evdev mouse and falls back to the x11 based mouse. It seems that HKEY_LOCAL_MACHINE\HARDWARE\DeviceMap\PointerClass does not exist. I've run wineprefixcreate and made sure I have full access to /dev/input/*, do I need anything else?

2 2