January 2008 - Wine-devel - list.winehq.org

re: shell32: Check if token references the current user
by Dan Kegel 09 Jan '08

09 Jan '08

Ge is looking for feedback on this patch, could somebody familiar with the innards of SHGetFolderPath() comment? http://bugs.winehq.org/show_bug.cgi?id=10905#c6 / http://www.winehq.org/pipermail/wine-patches/2007-December/048437.html Thanks, Dan

2 1

re: Spelling fixes - round 6
by Dan Kegel 09 Jan '08

09 Jan '08

A few issues: 1. * DPMI_xalloc - * special virtualalloc, allocates lineary monoton growing memory. + * special virtualalloc, allocates linear monoton growing memory. Um... Probably should be 'linearly'. But if you're opening the can of worms, might as well really improve it. I suspect this would be better: * DPMI_xalloc - * special virtualalloc, allocates lineary monoton growing memory. + * Try to VirtualAlloc the len bytes just past the last block we allocated + * If that's not available, try 64K beyond; if still not available, fail. 2. -/* Volume functions derived from Alsaplayer source */ +/* Volume functions derivated from Alsaplayer source */ What? What's wrong with "derived"? "Derivated" isn't even a word?! 3. -# include <unistd.h> +#include <unistd.h> That's not a spelling fix, and you would have to fix a whole lot of those. Best leave alone. - Dan -- Wine for Windows ISVs: http://kegel.com/wine/isv

2 1

Re: Spelling fixes round 6 - resend - don't apply first patch
by Francois Gouget 09 Jan '08

09 Jan '08

#ifdef HAVE_UNISTD_H -# include <unistd.h> +#include <unistd.h> #endif #include <stdarg.h> #include <stdio.h> I think this chunk should not be applied because: * as pointed out before, it's not a spelling fix * it's perfectly valid to have a space there * the indentation makes the scope of the #ifdef clearer. So removing it makes the code less readable -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ You can have my guns when you pry them from my kids cold, dead hands.

3 2

Re: [PATCH] wineboot: fix installation of SFP protected files
by Dmitry Timoshkov 09 Jan '08

09 Jan '08

"Andrey Turkin" <andrey.turkin(a)gmail.com> wrote: > + dllcache_wildcard = HeapAlloc(GetProcessHeap(), 0, strlenW( dllcache )*sizeof(WCHAR) * sizeof(wildcardW)); Aren't there too much of multiplications? -- Dmitry.

2 1

Re: gdi32: Fix the regression caused by the scaling font metrics patch
by Alexandre Julliard 09 Jan '08

09 Jan '08

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > Changelog: > gdi32: Fix the regression caused by the scaling font metrics patch. This breaks the tests: ../../../tools/runtest -q -P wine -M riched20.dll -T ../../.. -p riched20_test.exe.so editor.c && touch editor.ok editor.c:309: Test failed: 0 == 0 editor.c:317: Test failed: 0 == 0 editor.c:865: Test failed: EM_SCROLL page down didn't scroll by a small positive number of lines (r == 0x00010000) editor.c:869: Test failed: EM_SCROLL page down not functioning (line 0 scrolled to line 0 editor.c:876: Test failed: EM_SCROLL page up didn't scroll by a small negative number of lines (r == 0x00010000) editor.c:879: Test failed: EM_SCROLL page up not functioning (line 0 scrolled to line 0 editor.c:888: Test failed: EM_SCROLL line down didn't scroll by one line (r == 0x00010000) editor.c:890: Test failed: EM_SCROLL line down didn't go down by 1 line (0 scrolled to 0) editor.c:899: Test failed: EM_SCROLL line up didn't scroll by one line (r == 0x00010000) editor.c:901: Test failed: EM_SCROLL line up didn't go up by 1 line (0 scrolled to 0) editor.c:865: Test failed: EM_SCROLL page down didn't scroll by a small positive number of lines (r == 0x00010000) editor.c:869: Test failed: EM_SCROLL page down not functioning (line 0 scrolled to line 0 editor.c:876: Test failed: EM_SCROLL page up didn't scroll by a small negative number of lines (r == 0x00010000) editor.c:879: Test failed: EM_SCROLL page up not functioning (line 0 scrolled to line 0 editor.c:888: Test failed: EM_SCROLL line down didn't scroll by one line (r == 0x00010000) editor.c:890: Test failed: EM_SCROLL line down didn't go down by 1 line (0 scrolled to 0) editor.c:899: Test failed: EM_SCROLL line up didn't scroll by one line (r == 0x00010000) editor.c:901: Test failed: EM_SCROLL line up didn't go up by 1 line (0 scrolled to 0) make[2]: *** [editor.ok] Error 18 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: server/token.c -- -Wtype-limits changes
by Alexandre Julliard 09 Jan '08

09 Jan '08

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > diff -u -3 -p -r1.60 token.c > --- server/token.c 6 Dec 2007 14:27:53 -0000 1.60 > +++ server/token.c 7 Jan 2008 13:57:28 -0000 > @@ -515,8 +515,7 @@ struct token *token_duplicate( struct to > struct privilege *privilege; > struct group *group; > > - if ((impersonation_level < SecurityAnonymous) || > - (impersonation_level > SecurityDelegation)) > + if (impersonation_level > SecurityDelegation) There's no guarantee that the enum is an unsigned type. -- Alexandre Julliard julliard(a)winehq.org

1 0

Dynace OO Extension to C and Windows Development System
by Blake McBride 09 Jan '08

09 Jan '08

This is an announcement for a new release of the Dynace Object Oriented Extension to C and the Windows Development System. Real briefly, Dynace is an OO extension to C which includes multiple inheritance, meta object protocol (MOP), class library, native thread support, garbage collection, and is well documented. The system has been in production use for over 10 years. The Windows Development System is a Dynace class library which makes programming GUI applications under Windows and Linux (WINE) very easy. It also includes a library for SQL Databases, an interface to Java and MzScheme, a custom resource editor, etc. Besides 600+ pages of professional documentation, the system also includes a language tutorial and a GUI and Database tutorial. Dynace will run on almost anything with a C compiler. It has been tested on many different systems over the years. The Windows Development System runs on Windows an Linux (with WINE). This is open source software. I can be downloaded at: http://blake.mcbride.name Blake McBride blake(a)mcbride.name

1 0

Re: Spelling fixes - round 6
by Francois Gouget 09 Jan '08

09 Jan '08

- * 3 - controller supports hardware stereoscopic signalling + * 3 - controller supports hardware stereoscopic signaling * 4 - =0 stereo signalling via external VESA stereo connector * =1 stereo signalling via VESA EVC connector Why are you changing 'signalling' to 'signaling' in one place, but leaving it as is twice two lines down. Note that I'm not sure which form is right, but ispell is happy with both so it's possible both are ok. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ We are Pentium of Borg. You will be approximated. Division is futile.

4 4

Spelling fixes - abbreviation question
by Austin English 09 Jan '08

09 Jan '08

I'm seeing quite a few abbreviations. While they don't hurt anything, they do give the code a slang tone. I personally think that wine is a very professional project, and it's code should reflect that. While this is obviously a very generic question, I wanted to clarify before submitting some changes for these. A few examples. These are all in comments, not in actual code, and I'm checking to make sure compilation/tests still pass before submitting. mem -> memory init -> initialize concat -> concatenate nr/num -> number infos -> information manuf -> manufacturer Etc. Anyone have any objections to these being changed? Call me a grammar nazi, but it's easier to read when not shortened like that. -Austin

3 3

re: Spelling fixes - abbreviation question
by Dan Kegel 08 Jan '08

08 Jan '08

I also object to removing abbreviations or Britishisms. The key to being a successful spelling policeman is to stick to noncontroversial spelling fixes, and avoiding anything controversial or non-spelling-related.

1 0