January 2008 - Wine-devel - list.winehq.org

Re: [5/5] wined3d: change colorkey fixup for stage 0 alphaop / alphaarg
by Stefan Dösinger 03 Jan '08

03 Jan '08

Am Mittwoch, 2. Januar 2008 13:38:57 schrieb Alexander Dorofeyev: > In case of colorkey emulation for a texture, if the application wants to > select alpha from diffuse color at stage 0, a fixup to modulate with > texture alpha more closely matches what the application wants than fixup to > just select alpha from texture. I am not sure about this. From my understanding of color keying, the color keying should only depend on the texture, not the diffuse color. Unfortunately, this is mutually exclusive with always honoring the app's blending settings. I have two games which use color keying, Moto Racer 2 and Prince of Persia 3D. I'll test the patches with those two games. The problem is that our color keying is emulated, so we'll always have to fiddle to get it working properly everywhere. The correct, but complex and incomplete fix would be a replacement shader for the fixed function pipeline which can implement color keying properly using 'KIL' or 'discard'. Unfortunately that won't fix the problem for cards without fragment shader support. The other patches look good to me

3 3

Re: mshtml #1: Includes clean up. (resend)
by Alexandre Julliard 03 Jan '08

03 Jan '08

Jacek Caban <jacek(a)codeweavers.com> writes: > diff --git a/dlls/mshtml/mshtml_private.h b/dlls/mshtml/mshtml_private.h > index c981348..e0c94c3 100644 > --- a/dlls/mshtml/mshtml_private.h > +++ b/dlls/mshtml/mshtml_private.h > @@ -16,6 +16,19 @@ > * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA > */ > > +#include "config.h" > + > +#include <stdarg.h> > +#include <stdio.h> You can't use config.h from a header file. -- Alexandre Julliard julliard(a)winehq.org

1 0

So, you want to fix typos?
by Dan Kegel 03 Jan '08

03 Jan '08

I see somebody's posting a few fix-typo-in-comments patches, e.g. http://www.winehq.org/pipermail/wine-patches/2007-December/048099.html http://www.winehq.org/pipermail/wine-patches/2007-December/048101.html That reminds me that I worked out some time ago how to find such typos efficiently. At the risk of encouraging lots of silly typo-fixing patches, I've documented the process here: http://kegel.com/wine/spellingpolice/ For instance, to find typos in comments in shell32, you can do: sudo apt-get install ispell wget http://kegel.com/wine/spellingpolice/stop.txt wget http://kegel.com/wine/spellingpolice/lspell-pl.txt -O lspell.pl perl lspell.pl stop.txt ~/wine-git/dlls/shell32/*.[ch] This outputs: /home/dank/wine-git/dlls/shell32/autocomplete.c: 1 dispays /home/dank/wine-git/dlls/shell32/brsfolder.c: 1 relativ /home/dank/wine-git/dlls/shell32/dataobject.c: 1 droping /home/dank/wine-git/dlls/shell32/iconcache.c: 1 resoure /home/dank/wine-git/dlls/shell32/pidl.c: 1 relativ /home/dank/wine-git/dlls/shell32/pidl.h: 1 desribes /home/dank/wine-git/dlls/shell32/shell.c: 1 incidently /home/dank/wine-git/dlls/shell32/shfldr_fs.c: 1 spezified /home/dank/wine-git/dlls/shell32/shfldr_unixfs.c: 4 appart relativ savely should'nt /home/dank/wine-git/dlls/shell32/shlexec.c: 1 foward /home/dank/wine-git/dlls/shell32/shlfileop.c: 2 ERRROR INVLID /home/dank/wine-git/dlls/shell32/shlfolder.c: 1 whitch /home/dank/wine-git/dlls/shell32/shlview.c: 2 buily provied /home/dank/wine-git/dlls/shell32/trash.c: 1 DESCRITION

4 4

I am at the Ubuntu Developer Summit, do we need anything from other projects?
by scott＠tuzakey.com 03 Jan '08

03 Jan '08

The other day an X.org developer asked me if Wine needed anything from X. Off the top of my head, all I could think to tell him was relative mouse movements. There are people from many free software projects here, including the kernel and Samba. Should I voice anything else? Thanks, Scott Ritchie

5 5

Re: [1/7] msxml3: Implement setNamedItem
by Alexandre Julliard 03 Jan '08

03 Jan '08

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > + /* Must be an Attribute */ > + IUnknown_QueryInterface(newItem, &IID_IXMLDOMNode, (LPVOID*)&pAttr); > + if(pAttr) > + { > + ThisNew = impl_from_IXMLDOMNode( pAttr ); > + > + IUnknown_Release(pAttr); > + > + if(ThisNew->node->type != XML_ATTRIBUTE_NODE) > + return E_FAIL; You shouldn't access the object after having released it. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: wine gdiplus <-> mono gdiplus wrapper
by Dan Kegel 03 Jan '08

03 Jan '08

Jerome wrote: > I wrote a little script in order to wrap gdiplus with the mono one; > Here are the source file and the spec file (this one made with winedump), but > I have no idea how to compile it and/or include it in the wine source tree. > Could you tell me what you think about it ? And if it has some utility ? IIRC, the Mono gdiplus isn't so useful for us because it doesn't deal with GDI handles the way we need. That's one reason we have our own gdiplus now. It might be more useful if you would look at fixing bugs in our gdiplus rather than trying to wrap Mono's. - Dan

5 5

Can't figure out how tolink a program
by Blake McBride 03 Jan '08

03 Jan '08

I have a library built under Linux with Wine (mylib.a) that uses various Windows API (mainly GUI) that built fine. I compiled the main program from .c to .o and from .rc to .res just fine. My problem is I can't figure our what command line to use to link: myprogram.o myprogram.res mylib.a In other words, when I try to link it all together I get a bunch of unresolved externals on things like: ReleaseDC GetDC SendMessageA MulDiv GlobalAlloc etc....... I don't know what gcc command line argument to load the normal API's. I checked all the online docs. There are no examples and the docs that do exist state that hey are out-of-date. I would really appreciate a few simple example command lines to link a program with the normal API's AND my .res file. Thank you. Blake McBride blake(a)mcbride.name

1 0

TrackPopupMenu() and TPM_RECURSE
by olympia＠skydreams.org 02 Jan '08

02 Jan '08

Hi, According to the MSDN documentation (see below), TrackPopupMenu() should only display multiple popupmenus if TPM_RECURSE is used. At the moment, Wine always seems to allow this and in some applications this results in very confusing menu overlaps. Moreover, the old popup menus will never be closed. This seems to particularly be the case in applications that use TrackPopupMenuEx() for their application menus. I was looking at the code and was unsure of how existing popup menus in a window should be safely closed when the application calls TrackPopupMenu() a second or third time. Does anyone have a suggestion? Best regards, Nicholai Windows 98/Me, Windows 2000/XP: Use the TPM_RECURSE flag to display a menu when another menu is already displayed. This is intended to support context menus within a menu.

1 0

Re: comdlg32: Remove unneeded casts (Resend)
by Robert Shearman 02 Jan '08

02 Jan '08

Andrew Talbot wrote: > if (fodInfos->ofnInfos->Flags & OFN_ALLOWMULTISELECT) > size += 1; > /* return needed size in first two bytes of lpstrFile */ > - *(WORD *)fodInfos->ofnInfos->lpstrFile = size; > + *fodInfos->ofnInfos->lpstrFile = size; > FILEDLG95_Clean(hwnd); > ret = EndDialog(hwnd, FALSE); > COMDLG32_SetCommDlgExtendedError(FNERR_BUFFERTOOSMALL); > @@ -763,7 +763,7 @@ static BOOL PRINTDLG_SetUpPaperComboBoxW(HWND hDlg, > NrOfEntries = DeviceCapabilitiesW(PrinterName, PortName, > fwCapability_Names, Names, dm); > NrOfEntries = DeviceCapabilitiesW(PrinterName, PortName, > - fwCapability_Words, (LPWSTR)Words, dm); > + fwCapability_Words, Words, dm); > > /* reset any current content in the combobox */ > SendDlgItemMessageW(hDlg, nIDComboBox, CB_RESETCONTENT, 0, 0); > I think these two casts should stay as LPWSTR is compatible with WORD * only by coincidence - one is intended to hold characters and the other numbers. -- Rob Shearman

1 0

wine gdiplus <-> mono gdiplus wrapper
by Jérôme Gardou 02 Jan '08

02 Jan '08

I wrote a little script in order to wrap gdiplus with the mono one; Here are the source file and the spec file (this one made with winedump), but I have no idea how to compile it and/or include it in the wine source tree. Could you tell me what you think about it ? And if it has some utility ?

1 0