November 2008 - Wine-devel - list.winehq.org

Wine integration with native (Gtk, Qt, Cocoa/Carbon) themes
by Reece Dunn 21 Dec '08

21 Dec '08

Hi, There is a discussion going on over at https://bugs.launchpad.net/ubuntu/+source/wine/+bug/111061 about improving Wine's look and feel to better match the system that it is running on. The situation is as follows: == Colour Schemes Wine supports these by reading the settings from the registry. Winecfg can load a .theme file containing a colour profile and adapt accordingly (saving those settings to the registry). At the moment, if you need to script this (e.g. when installing Wine) you need to manipulate the registry. It would be helpful if winecfg (or some other helper utility) supported setting the theme file on the command line. In addition to this, if the user changes the theme used on their system it would not be reflected by Wine. == Windows Theme Support Windows theming support is in place to some extent, w.r.t. the XP theming APIs. There are some user32 controls and the window/dialog handlers that don't support theming yet and there are some performance issues that need resolving. This would be set via the command line used to set the colour scheme since they can be set via the same .theme file. This is limited in that you need an XP theme for each native theme available. == Native Theme Support The main thing here is that Wine would monitor the native system for theme changes. The colours of the native theme would be mapped to the Windows system colours, saved to the registry and then a WM_SYSCOLORCHANGED message would be sent to all open top-level windows so they could update to the new look. Any metric data would be mapped in a similar way. As for the theme, an implementation of uxtheme would map the API calls to the native calls. Here, it may be possible to just send a request to redraw everything on each active window. If not, a WM_THEMECHANGED message would need to be sent to all active windows. The challenge with native theme support is two-fold: (1) it should work on any system - some have Gtk, some Qt and some Cocoa/Carbon, while others (like the *BSDs and OpenSolaris) are likely not to have those engines available; (2) it should not break any Windows application. Note that as Vista has a different msstyles theming engine (it is a DLL), we could have the msstyles DLL expose the uxtheme API and have uxtheme call msstyles to do the rendering. That way, we could have a gtk.msstyles, qt3.msstyles, qt4.msstyles and an carbon.msstyles that would bind to the corresponding theming engine. If the msstyles DLL does not expose those methods, the uxtheme engine could then fallback to the current XP theme processing. For Mac theme support that would possibly require Objective-C code to be done properly, that theme could be an external package (possibly in darwine) that would be installed in addition to Wine. The same thing for the Qt engines, allowing them to directly interface with the C++ Qt APIs. Thoughts? Ideas? - Reece

7 19

No response to updated patch for gdi32/StretchDIBits
by Mathias Kosch 13 Dec '08

13 Dec '08

Hallo! About two weeks ago I tried to hand in a (corrected version of my) patch for "StretchDIBits" [1]. However it isn't accepted until now and I didn't yet notice any response. Would someone please tell me what's wrong or if it was just missed out accidentally? [1] http://www.winehq.org/pipermail/wine-patches/2008-September/062221.html -- Mathias Kosch <info(a)mkosch.de> | http://www.mkosch.de/ RSA Public Key: http://www.mkosch.de/pubkey Roboter zum selber bauen: http://www.heise.de/ct/projekte/ct-bot/

2 2

winetest.exe now available on test.winehq.org
by Paul Vriens 01 Dec '08

01 Dec '08

Hi, Test.winehq.org is the new home of the cross compiled winetest.exe. Alexandre put in some magic to create the new winetest.exe on winehq. The new link: http://test.winehq.org/builds/winetest-latest.exe The link can also be found at the bottom of the test.winehq.org index page. I already changed the wiki to reflect these changes. This also means that Paul Millars winetest is no longer available. I'd like to thank Paul for all the hard work he did with keeping up that site and providing us for years with a cross compiled version of winetest. I also like to thank the people that provided the necessary MinGW patches in the past to get that winetest compiled again. -- Cheers, Paul.

2 1

Bugzilla's down again
by Austin English 01 Dec '08

01 Dec '08

Different error than usual though: <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML 2.0//EN"> <html><head> <title>500 Internal Server Error</title> </head><body> <h1>Internal Server Error</h1> <p>The server encountered an internal error or misconfiguration and was unable to complete your request.</p> <p>Please contact the server administrator, bugs-admin(a)winehq.org and inform them of the time the error occurred, and anything you might have done that may have caused the error.</p> <p>More information about this error may be available in the server error log.</p> </body></html> Is there anything we can do to prevent it from going down so much? -- -Austin

3 3

Re: wined3d: Sign-compare warnings fix
by Austin English 01 Dec '08

01 Dec '08

On Sat, Nov 29, 2008 at 11:42 AM, Andrew Talbot <andrew.talbot(a)talbotville.com> wrote: > Changelog: > wined3d: Sign-compare warnings fix. > > @@ -504,7 +504,7 @@ static void shader_generate_glsl_declarations(IWineD3DBaseShader *iface, const s > IWineD3DBaseShaderImpl* This = (IWineD3DBaseShaderImpl*) iface; > IWineD3DDeviceImpl *device = (IWineD3DDeviceImpl *) This->baseShader.device; > int i; > - unsigned int extra_constants_needed = 0; > + unsigned int i, extra_constants_needed = 0; > const local_constant *lconst; > > /* There are some minor differences between pixel and vertex shaders */ > > > You forgot to remove 'int i' here. -- -Austin

2 1

Error Message and Office 2000
by SWEETSKY＠ROCKETMAIL.COM 01 Dec '08

01 Dec '08

Hi, I'm in Southern California. I did a search for the event when my Office 2000 Professional gave me an error message. It won't setup. The event was 1000 and the fault address is the same as a read out of your computer that you posted online. http://www.winehq.org/pipermail/wine-devel/2003-July/018313.html Did you ever figure out how to get it to work? Thanks! Ciao! Connie

2 1

Sound regression (in Warcraft III)
by Adam Petaccia 30 Nov '08

30 Nov '08

Maarten, could you look at http://bugs.winehq.org/show_bug.cgi?id=16297 as you're the author of 717df5b2972b3cb998ca5a43279ae2283b117eaa? I tried adding you as CC but bugzilla complained.

2 1

Re: Fw: selinux in fedora 10 regarding text relocation in wine and mono.
by Hin-Tak Leung 30 Nov '08

30 Nov '08

Hi all, I had managed to fix my selinux/wine/mono problem in fedora 10... it is actually two issues, in fact: 1) fedora 10 ships some much stricter selinux policies (but make some exception for wine). 2) I have kernel support for miscellaneous binary formats enabled and have win32 PE registration in the kernel, and run win32 mono.exe (or other PE executables) direct from time to time. so "wine [path]/mono.exe [.NET.exe]" works within the restriction of f10 selinux policies, but "[path]/mono.exe [.NET.exe]" does not. I could either relax the "execmod" policy in selinux, if I want to run any PE .exe's wholesale; or I just need to remember always putting "wine" in front of PE .exe's I want to run... Sorry for the noise.

1 0

Did anyone have any trouble compiling wine today? Or was it just me ....
by Susan Cragin 30 Nov '08

30 Nov '08

and my jaunty jackalope with 2.6.27-7 generic kernel MAKE gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith -g -O2 -o serial.o serial.c In file included from serial.c:77: /usr/include/linux/serial.h:164: error: expected specifier-qualifier-list before ‘__u32’ make[2]: *** [serial.o] Error 1 make[2]: Leaving directory `/home/susan/wine/dlls/ntdll' make[1]: *** [ntdll] Error 2 make[1]: Leaving directory `/home/susan/wine/dlls' make: *** [dlls] Error 2 INSTALL make[2]: Leaving directory `/home/susan/wine/dlls/newdev' make[2]: Entering directory `/home/susan/wine/dlls/ntdll' gcc -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_NTSYSTEM_ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wwrite-strings -Wtype-limits -Wpointer-arith -g -O2 -o serial.o serial.c In file included from serial.c:77: /usr/include/linux/serial.h:164: error: expected specifier-qualifier-list before ‘__u32’ make[2]: *** [serial.o] Error 1 make[2]: Leaving directory `/home/susan/wine/dlls/ntdll' make[1]: *** [ntdll/__install__] Error 2 make[1]: Leaving directory `/home/susan/wine/dlls' make: *** [dlls/__install__] Error 2

3 2

Re: includes: Fix macros for ITextServices
by Dylan Smith 30 Nov '08

30 Nov '08

The problems with having the macros in the public headers are that they won't work on x86 machines, and are not included in the public headers. Therefore someone developing for another platform will have their code break when using the native public headers or when porting the code to an x86 where the thiscall calling convention is used. On Sun, Nov 30, 2008 at 5:42 AM, Maarten Lankhorst <m.b.lankhorst(a)gmail.com>wrote: > Commit e4ef9c5c removed the ITextServices macros from > wine/include/textserv.h. With this they are added again, and COBJMACROS > before including that header, so that they won't conflict. > --- > > From c04fcab5168309395602f4c4fd07a319a9a532ab Mon Sep 17 00:00:00 2001 > From: Maarten Lankhorst <maarten(a)codeweavers.com> > Date: Sun, 30 Nov 2008 11:37:54 +0100 > Subject: [PATCH] includes: Fix macros for ITextServices > > --- > dlls/riched20/tests/txtsrv.c | 8 +++++++- > include/textserv.h | 19 +++++++++++++++++++ > 2 files changed, 26 insertions(+), 1 deletions(-) > > diff --git a/dlls/riched20/tests/txtsrv.c b/dlls/riched20/tests/txtsrv.c > index 3d47490..c28f5a7 100644 > --- a/dlls/riched20/tests/txtsrv.c > +++ b/dlls/riched20/tests/txtsrv.c > @@ -29,6 +29,9 @@ > #include <objbase.h> > #include <richedit.h> > #include <initguid.h> > + > +#undef COBJMACROS > +/* Don't define ITextServices, we override it here */ > #include <textserv.h> > #include <wine/test.h> > > @@ -44,6 +47,9 @@ static HMODULE hmoduleRichEdit; > #define TXTSERV_VTABLE(This) (This)->lpVtbl > #endif /* __i386__ */ > > +#define ITextServices_QueryInterface(p,a,b) > (p)->lpVtbl->QueryInterface(p,a,b) > +#define ITextServices_AddRef(p) (p)->lpVtbl->AddRef(p) > +#define ITextServices_Release(p) (p)->lpVtbl->Release(p) > #define ITextServices_TxSendMessage(This,a,b,c,d) > TXTSERV_VTABLE(This)->TxSendMessage(This,a,b,c,d) > #define ITextServices_TxDraw(This,a,b,c,d,e,f,g,h,i,j,k,l) > TXTSERV_VTABLE(This)->TxDraw(This,a,b,c,d,e,f,g,h,i,j,k,l) > #define ITextServices_TxGetHScroll(This,a,b,c,d,e) > TXTSERV_VTABLE(This)->TxGetHScroll(This,a,b,c,d,e) > @@ -84,7 +90,7 @@ static HRESULT WINAPI > ITextHostImpl_QueryInterface(ITextHost *iface, > > if (IsEqualIID(riid, &IID_IUnknown) || IsEqualIID(riid, > &IID_ITextHost)) { > *ppvObject = This; > - ITextHost_AddRef((ITextHost *)*ppvObject); > + IUnknown_AddRef((IUnknown *)*ppvObject); > return S_OK; > } > > diff --git a/include/textserv.h b/include/textserv.h > index 977b742..820fc0a 100644 > --- a/include/textserv.h > +++ b/include/textserv.h > @@ -147,6 +147,25 @@ DECLARE_INTERFACE_(ITextServices,IUnknown) > #define ITextServices_QueryInterface(p,a,b) > (p)->lpVtbl->QueryInterface(p,a,b) > #define ITextServices_AddRef(p) (p)->lpVtbl->AddRef(p) > #define ITextServices_Release(p) (p)->lpVtbl->Release(p) > +/*** ITextServices methods ***/ > +#define ITextServices_TxSendMessage(p,a,b,c,d) > (p)->lpVtbl->TxSendMessage(p,a,b > +#define ITextServices_TxDraw(p,a,b,c,d,e,f,g,h,i,j,k,l) > (p)->lpVtbl->TxDraw(p,a > +#define ITextServices_TxGetHScroll(p,a,b,c,d,e) > (p)->lpVtbl->TxGetHScroll(p,a,b > +#define ITextServices_TxGetVScroll(p,a,b,c,d,e) > (p)->lpVtbl->TxGetVScroll(p,a,b > +#define ITextServices_OnTxSetCursor(p,a,b,c,d,e,f,g,h,i) > (p)->lpVtbl->OnTxSetCu > +#define ITextServices_TxQueryHitPoint(p,a,b,c,d,e,f,g,h,i,j) > (p)->lpVtbl->TxQue > +#define ITextServices_OnTxInplaceActivate(p,a) > (p)->lpVtbl->OnTxInplaceActivate > +#define ITextServices_OnTxInplaceDeactivate(p) > (p)->lpVtbl->OnTxInplaceDeactiva > +#define ITextServices_OnTxUIActivate(p) (p)->lpVtbl->OnTxUIActivate(p) > +#define ITextServices_OnTxUIDeactivate(p) (p)->lpVtbl->OnTxUIDeactivate(p) > +#define ITextServices_TxGetText(p,a) (p)->lpVtbl->TxGetText(p,a) > +#define ITextServices_TxSetText(p,a) (p)->lpVtbl->TxSetText(p,a) > +#define ITextServices_TxGetCurrentTargetX(p,a) > (p)->lpVtbl->TxGetCurrentTargetX > +#define ITextServices_TxGetBaseLinePos(p,a) > (p)->lpVtbl->TxGetBaseLinePos(p,a) > +#define ITextServices_TxGetNaturalSize(p,a,b,c,d,e,f,g,h) > (p)->lpVtbl->TxGetNat > +#define ITextServices_TxGetDropTarget(p,a) > (p)->lpVtbl->TxGetDropTarget(p,a) > +#define ITextServices_OnTxPropertyBitsChange(p,a,b) > (p)->lpVtbl->OnTxPropertyBi > +#define ITextServices_TxGetCachedSize(p,a,b) > (p)->lpVtbl->TxGetCachedSize(p,a,b > #endif > > #undef INTERFACE > -- > 1.5.6.5 > > > > >

1 0