March 2008 - Wine-devel - list.winehq.org

Re: [PATCH] (RESUBMIT) wininet: restructure for better return checking
by Alexandre Julliard 14 Mar '08

14 Mar '08

Marcus Meissner <marcus(a)jet.franken.de> writes: > Coverity spotted some potential lpwhh NULL usage > after NULL checking. > > I restructured the code a bit to check lpwhh > earlier and return at that time. Also removed a > unnecessary cast. This doesn't work: ../../../tools/runtest -q -P wine -M wininet.dll -T ../../.. -p wininet_test.exe.so internet.c && touch internet.ok internet.c:118: Test failed: InternetSetOptionA failed 6, expected ERROR_INTERNET_INVALID_OPTION make[2]: *** [internet.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [3/6] kernel32: Add the MOVEFILE_WRITE_THROUGH flag (stub) for MoveFileEx.
by Dan Hipschman 13 Mar '08

13 Mar '08

Yup, ignore. On Thu, Mar 13, 2008 at 04:00:32PM -0700, Dan Hipschman wrote: > > NOTE: I thought I sent this with the other five patches, but I don't see > it. Sorry if it ends up being a resend. > > This feature of MoveFileEx is technically needed by IBackgroundCopyJob_Complete > to return the correct status if it has to move temp files across volumes, but > since it's a very small point, I'm just adding the flag so we can compile with > it. > > --- > dlls/kernel32/path.c | 3 +++ > include/winbase.h | 1 + > 2 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/dlls/kernel32/path.c b/dlls/kernel32/path.c > index f0f713f..aad260f 100644 > --- a/dlls/kernel32/path.c > +++ b/dlls/kernel32/path.c > @@ -1010,6 +1010,9 @@ BOOL WINAPI MoveFileWithProgressW( LPCWSTR source, LPCWSTR dest, > if (!dest) > return DeleteFileW( source ); > > + if (flag & MOVEFILE_WRITE_THROUGH) > + FIXME("MOVEFILE_WRITE_THROUGH unimplemented\n"); > + > /* check if we are allowed to rename the source */ > > if (!RtlDosPathNameToNtPathName_U( source, &nt_name, NULL, NULL )) > diff --git a/include/winbase.h b/include/winbase.h > index e2ee515..f3130a0 100644 > --- a/include/winbase.h > +++ b/include/winbase.h > @@ -845,6 +845,7 @@ typedef DWORD (CALLBACK *LPPROGRESS_ROUTINE)(LARGE_INTEGER, LARGE_INTEGER, LARGE > #define MOVEFILE_REPLACE_EXISTING 0x00000001 > #define MOVEFILE_COPY_ALLOWED 0x00000002 > #define MOVEFILE_DELAY_UNTIL_REBOOT 0x00000004 > +#define MOVEFILE_WRITE_THROUGH 0x00000008 > > #define REPLACEFILE_WRITE_THROUGH 0x00000001 > #define REPLACEFILE_IGNORE_MERGE_ERRORS 0x00000002 > >

1 0

Please vote for your favorite Wine-1.0 bugs...
by Dan Kegel 13 Mar '08

13 Mar '08

The 1.0 release of Wine is tenatively scheduled for the 15th anniversary of the project (roughly 1 June 2008, if you take Dan Dulitz' message as the start of the project, http://groups.google.com/group/comp.os.linux/msg/7f92abdf494ab8b3 ) Over the last six or so months, the wine developers have identified 180 or so bugs as possibly being worth fixing before the 1.0 release. 63 of the Wine 1.0 bugs have already been fixed: http://bugs.winehq.org/buglist.cgi?target_milestone=1.0.0&resolution=FIXED 101 are left to fix: http://bugs.winehq.org/buglist.cgi?target_milestone=1.0.0&resolution=--- We can't fix all of these before the 1.0 release; we'll have to leave some for later. If you want a say in which of these bugs get fixed sooner, please vote for your favorite bugs. To do this, sign into Bugzilla (you need to register, but that's easy), pull up your favorite bug from the above list, and click on the 'Vote for this bug' link on the bug. We can't promise we'll fix the bugs with the most votes, but knowing which ones are most popular can't hurt. Thanks, Dan

2 1

Re: fonts: Start of the Symbol font.
by Alexandre Julliard 13 Mar '08

13 Mar '08

Huw Davies <huw(a)codeweavers.com> writes: > --- > fonts/Makefile.in | 1 + > fonts/symbol.sfd | 83 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 84 insertions(+), 0 deletions(-) > create mode 100644 fonts/symbol.sfd It fails make test for me: ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so font.c && touch font.ok font.c:1357: Test failed: no fonts should be enumerated: Symbol ANSI_CHARSET font.c:1405: Test failed: SYMBOL_CHARSET should NOT enumerate ANSI_CHARSET for Symbol font.c:1407: Test failed: SYMBOL_CHARSET should enumerate SYMBOL_CHARSET for Symbol font.c:1447: Test failed: no fonts enumerated: Symbol SYMBOL_CHARSET font.c:1458: Test failed: SYMBOL_CHARSET should enumerate SYMBOL_CHARSET for Symbol font.c:1639: Test failed: A: tmLastChar for Symbol 20 != ff font.c:1671: Test failed: W: tmFirstChar for Symbol 00 != 30 make: *** [font.ok] Error 7 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: mshtml: Return full patch in res protocol's secure URL.
by Alexandre Julliard 13 Mar '08

13 Mar '08

Jacek Caban <jacek(a)codeweavers.com> writes: > --- > dlls/mshtml/protocol.c | 31 +++++++++++++++++++++---------- > dlls/mshtml/tests/protocol.c | 41 > ++++++++++++++++++++++++++++++++++++++++- > 2 files changed, 61 insertions(+), 11 deletions(-) This breaks the tests: ../../../tools/runtest -q -P wine -M urlmon.dll -T ../../.. -p urlmon_test.exe.so misc.c && touch misc.ok misc.c:775: Test failed: [0] size=39, expected 9 misc.c:777: Test failed: [0] wrong secid make: *** [misc.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

1 0

Configure not throwing error for missing asoundlib.h
by Sebastian Goth 13 Mar '08

13 Mar '08

Hi, even with "--with-alsa" there is no report on a missing asoundlib.h. This is a bit inconvenient since other missing libs are reported. Valid for wine-0.9.57 Sebastian

1 0

1 program is separating me from complete windows independence. please help!
by Eric Appleman 13 Mar '08

13 Mar '08

Can someone please take a look at this bug for me? http://bugs.winehq.org/show_bug.cgi?id=11953

1 0

Re: RESEND D3D add device uuid solves bug 11897
by Stefan Dösinger 13 Mar '08

13 Mar '08

Am Donnerstag, 13. März 2008 14:40:07 schrieb Artur Szymiec: > Stefan Dösinger pisze: > > Am Donnerstag, 13. März 2008 10:19:36 schrieb Artur Szymiec: > >> This is a corrected patch. > >> The uuid is common to dx8 and dx9 since the UUID is generated > >> inside wined3d. > > > > Yes, that looks reasonable. Only two small issues: > >> +/* Fixes BUG 11897 */ > > > > That's not really needed, specifying a GUID is correct even if it > > wouldn't fix a bug report. > > > > Also, please attach the patch as an extra file to the mail, if you inline > > it like you did in your last mails it most likely suffers from line > > wrapping and can't be applied > > That's final version with suggested correction > by Stefan Dösinger Sorry that I didn't think of that earlier, but do you have to use memcpy? Doesn't a simple *pIdentifier->DeviceIdentifier = IID_D3DDEVICE_D3DUID; work as well?

2 1

Re: Prototype patch that solves bug 11897
by Stefan Dösinger 13 Mar '08

13 Mar '08

Hi, Note that we do not accept workaround patches into Wine, because otherwise the whole software would become a huge workaround collection. A potential proper fix for this is to generate an UUID, store it in a constant global variable and memcpy it into the deviceidentifier

3 7

Re: [2/4] qmgr: Add infrastructure for background file transferring. [take 4]
by Alexandre Julliard 13 Mar '08

13 Mar '08

Dan Hipschman <dsh(a)linux.ucla.edu> writes: > @@ -129,6 +131,21 @@ ServiceMain(DWORD dwArgc, LPWSTR *lpszArgv) > return; > } > > + globalMgr.jobEvent = CreateEventW(NULL, TRUE, FALSE, NULL); > + if (!globalMgr.jobEvent) { > + ERR("Couldn't create event: error %d\n", GetLastError()); > + UpdateStatus(SERVICE_STOPPED, NO_ERROR, 0); > + return; > + } > + > + fileTxThread = CreateThread(NULL, 0, fileTransfer, NULL, 0, &threadId); > + if (!fileTxThread) > + { > + ERR("Failed starting file transfer thread\n"); > + UpdateStatus(SERVICE_STOPPED, NO_ERROR, 0); > + return; > + } > + > UpdateStatus(SERVICE_RUNNING, NO_ERROR, 0); You also need to shutdown the thread properly when the service terminates. -- Alexandre Julliard julliard(a)winehq.org

1 0