March 2008 - Wine-devel - list.winehq.org

Re: wininet: Make the reference count of WININETHANDLEHEADER thread-safe by using InterlockedIncrement/InterlockedDecrement.
by Alexandre Julliard 10 Mar '08

10 Mar '08

Robert Shearman <rob(a)codeweavers.com> writes: > @@ -1296,7 +1296,7 @@ HINTERNET FTP_FtpOpenFileW(LPWININETFTPSESSIONW lpwfs, > lpwh->hdr.vtbl = &FTPFILEVtbl; > lpwh->hdr.dwFlags = dwFlags; > lpwh->hdr.dwContext = dwContext; > - lpwh->hdr.dwRefCount = 1; > + lpwh->hdr.lRefCount = 1; If you are going to rename the variable then please take the opportunity to get rid of the silly Hungarian prefix, so that we don't need to rename it again next time. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: a patch to fix the font in bottons and so on.
by Robert Shearman 10 Mar '08

10 Mar '08

彭思 wrote: > Hi everyone, > I have a patch in ubuntu China forum, which fix the font in bottons > and so on to display correctly using the right font. This patch > changes only one source file: dlls/gdi32/freetype.c. The main function > is: Default and ansi charset is translated to > getenv("WINE_DEFAULT_CODEPAGE"). This patch was written by *windowssux > <javascript:pn('windowssux');> in ubunt china forum: > http://forum.ubuntu.org.cn/* > > > The patched freetype.c is attached. It's the first time for me to send > you guys a patch to wine. Please let know if something is wrong. Thanks. You need to send the patch, not the whole file. It's nearly impossible to review the changes if you add an attachment with several thousand lines of code. -- Rob Shearman

1 0

Re: [comctl32/tests #3] Use GetModuleHandleA instead of LoadLibraryA
by Mikołaj Zalewski 10 Mar '08

10 Mar '08

I've changed GetModuleHandle to LoadLibrary because when I compiled only tests/rebar.c as standalone, the comctl32 wasn't loaded and GetModuleHandle returned NULL. Are there advantages from using GetModuleHandle? Mikołaj Zalewski

3 4

Re: [PATCH 3/3] shell32: use well known directories from xdg-user-dirs (try 2)
by Lei Zhang 10 Mar '08

10 Mar '08

On Wed, Mar 5, 2008 at 8:41 PM, Lei Zhang <thestig(a)google.com> wrote: > Hi, > > This sets the shell folders using values from xdg-user-dirs. The > existing shell folder code checks the shell folder registry keys, and > will not overwrite the values we set here. > > This version converts the Unix paths to Unicode when needed. > It just occurred to me that I need to convert the Unix path to a dos path. Should I just send the updated version of this patch, or resend the first two patches in the series as well?

2 1

Re: [PATCH] qedit: use skip in MediaDet test
by Lei Zhang 10 Mar '08

10 Mar '08

On Thu, Feb 21, 2008 at 5:15 PM, Lei Zhang <thestig(a)google.com> wrote: > Hi, > > Dank pointed out the qedit test crashes with an old .wine directory. > Adding a skip(). > Any reason why this wasn't committed?

2 1

New winetricks 20080309: new verb 'icodecs'
by Dan Kegel 10 Mar '08

10 Mar '08

Intel codecs are needed to run Tonka Search & Rescue 2 (which my son likes), so I added them to winetricks as 'icodecs'. I also renamed allvcodecs to be allcodecs (since it's hard to separate audio from video codecs sometimes) and removed a spurious warning from wsh56. As always, winetricks is at http://kegel.com/wine/winetricks and http://winezeug.googlecode.com

1 0

Please remove/block DARKGuy user from the forum and user mailing list!
by Vitaliy Margolen 10 Mar '08

10 Mar '08

What the subject say.

1 0

Processes and ioctl's
by Maarten Lankhorst 10 Mar '08

10 Mar '08

Hi all, I am hitting a snag with moving ioctl handling into mount manager. I got the ioctl's working and itunes fairly satisfied, but now I'm hitting another problem: The mount manager is not in the same process any more as the application. This is an issue because one of the ioctl's is passing a pointer in the struct itself, which gives a messy situation if it doesn't run in the current application any more. A workaround would be to use ReadProcessMemory and WriteProcessMemory, then fudge the wineserver ioctl request to somehow pass a handle of the calling process around so I can use that. This looks like it is not a clean solution. Does anyone know how to do it cleanly? Cheers, Maarten.

1 0

Re: [PATCH 6/6] wined3d: Dirtify p8 textures when device palettes change.
by Stefan Dösinger 09 Mar '08

09 Mar '08

Am Sonntag, 9. März 2008 15:10:54 schrieb Alexander Dorofeyev: > Fixes problems with properly updating wine's P8 textures, when it is > required because of device palette change. Instead of iterating over all resources and finding P8 textures I think it would be nicer to store the palette the texture/surface was loaded with in each P8 / A8P8 surface and compare this stored palette to the current device palette in IWineD3DSurface::PreLoad(non-texture path) and IWineD3D*Texture::PreLoad. With this, patch 4 could maybe be made nicer as well. If we have to verify the palettes anyway, we can remove the DDraw-Style IWineD3DPalette interface from WineD3D altogether, and just give each ddraw palette in ddraw.dll a WineD3D palette number and use the d3d8/9 palette management exclusively in WineD3D and avoid the confusion of having two palette interfaces.

3 2

Re: oleacc: add GetOleaccVersionInfo
by Reece Dunn 09 Mar '08

09 Mar '08

On 09/03/2008, Louis. Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > > Hi, this fixes crash in DietPower: > http://bugs.winehq.org/show_bug.cgi?id=10102 > +@ stdcall GetOleaccVersionInfo(long long) Since both these arguments are DWORD*, they need to be ptr, not long. - Reece

1 1