March 2008 - Wine-devel - list.winehq.org

Re: [PATCH] gdiplus: Fix errors in image dimensions.
by Dmitry Timoshkov 06 Mar '08

06 Mar '08

"Nathan Beckmann" <nathan.beckmann(a)gmail.com> wrote: > - y = (UINT)(((REAL)y) * ((REAL)GetDeviceCaps(hdcref, LOGPIXELSY)) / > - ((REAL)INCH_HIMETRIC)); > + /* this calculation can lead to truncation error */ > + y = (UINT)((((REAL)y) * ((REAL)GetDeviceCaps(hdcref, LOGPIXELSY)) / > + ((REAL)INCH_HIMETRIC)) + 0.5); Using MulDiv instead should be a more appropriate fix here. -- Dmitry.

1 0

Re: (resend) msi: Fix bug in handling of multivolume CAB files.
by James Hawkins 06 Mar '08

06 Mar '08

On Tue, Mar 4, 2008 at 11:51 AM, Ove Kaaven <ovek(a)transgaming.com> wrote: > The email address in the patch was wrong, sending it again. > > > >From b88a43dbc2234c8b35ee4fa7bb4f275475b8d821 Mon Sep 17 00:00:00 2001 > From: Ove Kaaven <ovek(a)transgaming.com> > Date: Tue, 4 Mar 2008 18:16:27 +0100 > Subject: [PATCH] Fix bug in handling of multivolume CAB files. > After extracting a single file from a multivolume CAB file, sometimes > information about the next CAB file to extract from would not be loaded, > because the is_continuous state was previously only properly reset if a > file happened to be partially extracted from the last volume of a > multivolume series. > A lot of time has been spent fixing cab/media related bugs in installers, as the behavior is very fickle (and easily breakable), so can you please add a test case first? See the multicab tests that are already in install.c. They will fail in wine because our cabinet.dll cannot create compressed cabinets, but assuming you test in Windows or use native cabinet.dll, it'll still verify that the patch is correct. -- James Hawkins

2 5

Re: user32: Fix enumeration for EnumWindowStations and EnumDesktops, try2
by Dmitry Timoshkov 06 Mar '08

06 Mar '08

"Maarten Lankhorst" <m.b.lankhorst(a)gmail.com> wrote: > Oops, the other call has to be null terminated as well. Do you have test cases for those changes? They look like a noop to me. -- Dmitry.

2 1

Re: Winecfg: Raise max screen resolution to 160 DPI
by L. Rahyen 05 Mar '08

05 Mar '08

Your patch isn't correct. Just try this: rm -rf ~/.wine wineprefixcreate winecfg Go to Graphics tab and set any resolution more than 127 DPI (for example, 150). Close winecfg. Run it again. Now you have 63 DPI (instead of 150; in fact anything bigger than 127 DPI will not be displayed correctly in winecfg). This problem was already solved in this patch [1] by Nigel Liang. Unfortunately, it wasn't accepted and Nigel didn't tried to ask why it was rejected or to resend it. I think I will go ahead and resend his patch. [1] http://www.winehq.org/pipermail/wine-patches/2007-October/044977.html

3 3

[feature requist] Glide API support
by Vincent Weber 05 Mar '08

05 Mar '08

Dear Wine devs, There are some games out there that were built with the Glide API. The Glide API is the graphics API of the 3dfx Voodoo cards and is basically a stripped down version of OpenGL. Could please consider adding support for the Glide API because I, and other have games that requires this API to be able to run under Wine. Now I know that there are Glide wrappers but they don't seem to work for a lot of people, including me, and Glide has been a very popular game API in the mid- to late 90's. Thanks in advance, Vincent Weber, weber dot vincent at gmail dot com

7 6

Re: Maarten Lankhorst : oleaut32: Handle TKIND_ALIAS properly when passed as pointer.
by Marcus Meissner 05 Mar '08

05 Mar '08

On Wed, Mar 05, 2008 at 06:24:14AM -0600, Alexandre Julliard wrote: > Module: wine > Branch: master > Commit: c978bbee87dd6e09e4ad836df5ad7d63506face2 > URL: http://source.winehq.org/git/wine.git/?a=commit;h=c978bbee87dd6e09e4ad836df… > > Author: Maarten Lankhorst <m.b.lankhorst(a)gmail.com> > Date: Mon Mar 3 14:27:03 2008 -0800 > > oleaut32: Handle TKIND_ALIAS properly when passed as pointer. > > --- > > + break; > case TKIND_ENUM: /* confirmed */ > case TKIND_RECORD: /* FIXME: mostly untested */ > - derefhere=TRUE; > break; ... Why the removal of this line? Any indication that it helps? Ciao, Marcus

2 1

Re: hal: Add a stub for HalGetBusData() to make 3DMark2001SE happy in WinNT mode.
by Alexandre Julliard 05 Mar '08

05 Mar '08

Francois Gouget <fgouget(a)codeweavers.com> writes: > +typedef enum _BUS_DATA_TYPE > +{ > + ConfigurationSpaceUndefined = -1, > + Cmos, > + EisaConfiguration, > + Pos, > + CbusConfiguration, > + PCIConfiguration, > + VMEConfiguration, > + NuBusConfiguration, > + PCMCIAConfiguration, > + MPIConfiguration, > + MPSAConfiguration, > + PNPISAConfiguration, > + MaximumBusDataType > +} BUS_DATA_TYPE, *PBUS_DATA_TYPE; Shouldn't that stuff go into a public header? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: ntdll/tests: Don't use 0x55/0xaa to avoid any confusion when running with +heap.
by Paul Vriens 05 Mar '08

05 Mar '08

Francois Gouget wrote: > --- > dlls/ntdll/tests/atom.c | 12 ++++++------ > 1 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/dlls/ntdll/tests/atom.c b/dlls/ntdll/tests/atom.c > index 2de94a0..68f5aba 100644 > --- a/dlls/ntdll/tests/atom.c > +++ b/dlls/ntdll/tests/atom.c > @@ -198,13 +198,13 @@ static void test_NtAtom(void) > ok((lstrlenW(testAtom2) * sizeof(WCHAR)) == Len, "Returned wrong length %d\n", Len); > > Len = 8; > c- Name[0] = Name[1] = Name[2] = Name[3] = Name[4] = 0x55AA; > + Name[0] = Name[1] = Name[2] = Name[3] = Name[4] = 0x1337; What happened there? -- Cheers, Paul.

2 1

Re: WineHQ should discourage the use of cracks
by Remco 05 Mar '08

05 Mar '08

Or how about this: ::Wine Compatibility:: ( ) Doesn't work at all [Garbage] ( ) Starts, but not very usable [Bronze] ( ) Basically works, a few bugs [Silver] (*) Works flawlessly [Gold] ::Extra Info:: [x] Needs Wine configuration (Windows version, sound options, regedit entries, etc.) [x] Needs a Windows DLL (has legal issues) [x] Needs a third party hack (has legal issues) If Gold and no tick boxes are selected: Works out of the box! [Platinum] The Extra Info tick boxes could be represented as icons accompanying the color-based Status wherever it goes. The icons should probably give a negative impression. A red color for example, although that might not get across very well, considering the color palette of WineHQ... ;) The "has legal issues" should link to a Wine Wiki page which explains exactly what those issues are and that specific discussion on how to get those things working is not allowed at winehq.org, the mailing lists, the newsgroup or the IRC channel. Remco ____________________________________________________________________________________ Never miss a thing. Make Yahoo your home page. http://www.yahoo.com/r/hs

3 2

Re: #1 gdi32: Move GetICMProfile to the driver.
by Alexandre Julliard 05 Mar '08

05 Mar '08

Hans Leidekker <hans(a)it.vu.nl> writes: > Changelog > Move GetICMProfile to the driver. Looks good, but the code doesn't belong in x11drv_main.c. Something like graphics.c would be more appropriate. -- Alexandre Julliard julliard(a)winehq.org

1 0