April 2008 - Wine-devel - list.winehq.org

Any particular reason we are using printf in the shlwapi/istream tests?
by Paul Vriens 02 Apr '08

02 Apr '08

Hi, Should these printf's be turned into trace/skip? -- Cheers, Paul.

2 2

Re: [2/5] setupapi: Changing pointers on SP_DEVINFO_DATA
by Alexandre Julliard 02 Apr '08

02 Apr '08

Alexander Morozov <amorozov(a)etersoft.ru> writes: > SETUPDI_AddDeviceToSet: changing pointers on SP_DEVINFO_DATA after > allocating new memory block for their array We shouldn't have to do that sort of thing. The data structure should be fixed to store pointers that don't have to be moved around. -- Alexandre Julliard julliard(a)winehq.org

3 2

Re: WINEX11.DRV: workaround for unstable window state while handling MapNotify (fixes bug 12196)
by Alex Villacís Lasso 02 Apr '08

02 Apr '08

Alex Villacís Lasso escribió: > > The attached patch seems to fix this issue for me. It issues > X11DRV_MapNotify > when it detects that the window is still marked as iconic on a > transition from > IconicState to NormalState. Please comment on this. > > See bug #12196 for full discussion. > > Changelog: > * Workaround for unstable window state when handling MapNotify at > window restore after minimize. Issue extra X11DRV_MapNotify call when > PropertyNotify detects still-iconic window on > IconicState->NormalState transition. > Is this patch incorrect? Nobody has commented on it, and it has not been applied either. -- perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

2 1

Re: winex11.drv: Connect to XIM server dynamically. [take 2]
by Alexandre Julliard 02 Apr '08

02 Apr '08

Kusanagi Kouichi <slash(a)ma.neweb.ne.jp> writes: > + > + if (data->xic) > + return data->xic; > + > + xim = x11drv_thread_data()->xim; > + if (!xim) > + return NULL; > + > + return X11DRV_CreateIC(xim, data->whole_window, &data->xic); You shouldn't store a pointer to an internal field of the win_data structure, that makes things hard to follow. You should store win_data or hwnd in the pointer field and dereference it in the callback. > @@ -651,7 +651,10 @@ struct x11drv_thread_data *x11drv_init_thread_data(void) > if (TRACE_ON(synchronous)) XSynchronize( data->display, True ); > wine_tsx11_unlock(); > > - if (use_xim && !(data->xim = X11DRV_SetupXIM( data->display, input_style ))) > + data->xim = NULL; > + if (use_xim && > + !XRegisterIMInstantiateCallback(data->display, NULL, NULL, NULL, > + X11DRV_SetupXIM, (XPointer)&data->xim)) The XRegisterIMInstantiateCallback should go in xim.c, the initialization code in x11drv_main.c shouldn't need to know about such implementation details. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: imm: Keep track of context associations between HWND and HIMC
by Alexandre Julliard 02 Apr '08

02 Apr '08

Aric Stewart <aric(a)codeweavers.com> writes: > @@ -93,12 +93,21 @@ typedef struct _tagTRANSMSG { > LPARAM lParam; > } TRANSMSG, *LPTRANSMSG; > > +typedef struct _tagContextAssociation { > + struct list entry; > + > + HWND *hwnds; > + UINT wndCount; > + HIMC context; > +} ContextAssociation; Wouldn't it be a lot easier to store the HIMC in a window property? -- Alexandre Julliard julliard(a)winehq.org

2 2

Minor regression introduced in user32
by Kolbjørn Fredheim 02 Apr '08

02 Apr '08

There is a regression introduced into the git tree that is causing some minor issues with Anarchy Online atleast(should be other applications affected aswell). On login, if you press enter instead of pushing "Login" a box will come up stating "You must select a charactername before playing! [OK]", this is before checking if the password is correct, or actually logging in to the account. I have never seen this box in the 2.5 years I've been playing Anarchy, so I can only speculate it's trying to select a character without actually having one selected in the drop-down box(ie. Sending the enter twice to the application). I bisected down to the following commit: # ~/tmp/wine-git $ git bisect good 41ea8f0e8a6fab93fa08da16ecc24260dbad327c is first bad commit commit 41ea8f0e8a6fab93fa08da16ecc24260dbad327c Author: Lei Zhang <thestig(a)google.com> Date: Tue Mar 25 19:09:38 2008 -0700 user32: Tweak how the edit control handles WM_GETDLGCODE. :040000 040000 5583dc91d4f658340fcab6169c5be12b18c5d862 114715be44f79ddf45a9c61a01b90ee624504c1a M dlls I didn't want to file a bug-report on it, due to it beeing in the current git, and 0.9.58 is ok, and my knowledge on this part of wine is rather limited. - Kolbjørn Fredheim ____________________________________________________________________________________ You rock. That's why Blockbuster's offering you one month of Blockbuster Total Access, No Cost. http://tc.deals.yahoo.com/tc/blockbuster/text5.com

2 1

Re: shell32: Handle a few cases in FO_COPY that arise from not double-NULL terminating the input
by Paul Vriens 02 Apr '08

02 Apr '08

James Hawkins wrote: > Hi, > > Fix for bug 9809. > > Changelog: > * Handle a few cases in FO_COPY that arise from not double-NULL > terminating the input. > > dlls/shell32/shlfileop.c | 11 +++- > dlls/shell32/tests/shlfileop.c | 122 ++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 130 insertions(+), 3 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi James, + /* no double-NULL terminator for pTo */ + memset(to, 'a', MAX_PATH); + lstrcpyA(to, "two.txt"); + shfo.pFrom = "one.txt\0"; + shfo.pTo = to; + shfo.fFlags = FOF_NOCONFIRMATION | FOF_SILENT | FOF_NOERRORUI; + retval = SHFileOperation(&shfo); + ok(retval == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", retval); + ok(DeleteFileA("one.txt"), "Expected file to exist\n"); + ok(DeleteFileA("two.txt"), "Expected file to exist\n"); + + createTestFile("one.txt"); + + /* no FOF_MULTIDESTFILES, two files in pTo */ + shfo.pFrom = "one.txt\0"; + shfo.pTo = "two.txt\0three.txt\0"; + shfo.fFlags = FOF_NOCONFIRMATION | FOF_SILENT | FOF_NOERRORUI; + retval = SHFileOperation(&shfo); + ok(retval == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", retval); + ok(DeleteFileA("one.txt"), "Expected file to exist\n"); + ok(DeleteFileA("two.txt"), "Expected file to exist\n"); + + createTestFile("one.txt"); + + /* no double-NULL terminator for pTo */ + memset(to, 'a', MAX_PATH); + lstrcpyA(to, "two.txt"); + shfo.pFrom = "one.txt\0"; + shfo.pTo = to; + shfo.fFlags = FOF_NOCONFIRMATION | FOF_SILENT | FOF_NOERRORUI; + retval = SHFileOperation(&shfo); + ok(retval == ERROR_SUCCESS, "Expected ERROR_SUCCESS, got %d\n", retval); + ok(DeleteFileA("one.txt"), "Expected file to exist\n"); + ok(DeleteFileA("two.txt"), "Expected file to exist\n"); Isn't the last test the same as the first (in the above piece of code) ? -- Cheers, Paul.

1 0

user32: Implement BroadcastSystemMessage, try 6
by Maarten Lankhorst 02 Apr '08

02 Apr '08

Hello Paul, 2008/4/1, Paul Vriens <paul.vriens.wine(a)gmail.com>: > Hi Maarten, > > + if (!recipients) > + recipients = &recips; > + > > Will that work? Yes. recipients is a pointer. Cheers, Maarten.

2 1

Wine 1.0 status: T minus 73 days (!), 69 bugs left
by Dan Kegel 02 Apr '08

02 Apr '08

Grumble. I was off by a week when I wrote http://wiki.winehq.org/WineReleasePlan I've adjusted the release dates to match our two-week cycle correctly this time (I hope). That pushed our release out one week... which means we finally have fewer bugs than days-to-release. Bugs fixed since last summary: 3711 wininet 1 Musicmatch fails to install (missing registry key, HTTP_HttpOpenRequest() problem) 8246 urlmon 3 invoking htmlhelp:HtmlHelpW crashes wine Bugs new since last summary (!): 4372 comctl32 0 listview: cannot drag several items 5535 directx- 16 Planescape:Torment doesn't work 11509 crypt32 0 Wordviewer 2003 is unable to open documents encrypted with AES (The first is arguable, but listview is pretty central, so ok. The second was closed by mistake earlier. The third is in one of our release criterion apps. Even though we only promise to fix *regressions* in those apps, we might as well try to fix newly discovered bugs, too.) Bugs deferred since last summary: 638 document 9 Document Wine debugging channels 4733 kernel32 5 Get optimized/compressed/packed executables (non-upx) working 4770 ole 3 BlackBerry Device Manager fails to install under wine 4971 -unknown 3 Corel Draw 12 demo install fails 9926 gdi32 5 gdi32.dll should not have exported function pointers 10905 shell32 0 thinstall firefox demo requires native msvcrt Current list of open bugs: ID Comp Votes Summary 5948 -unknown 1 Star Trek: Armada does not install 7404 -unknown 2 ShowWindow(SW_MINIMIZE) should not generate a WM_PAINT message 12246 -unknown 1 "make test" gives different results with and without warn+heap 5055 -unknown 5 Deleting files from a window in wine doesn't send them to the Trash 8125 -unknown 0 Marratech 6.1 crashes on start 5402 -unknown 0 Trying to run PhotoStitch 3.1 11281 -unknown 2 CJK input many issues 9916 -unknown 6 "make test" usually fails 7477 -unknown 1 Uplink demo crashes 12097 -unknown 3 Wine 1.0 should not ship out-of-sync resource translations 9178 -unknown 7 "hello world" dos program hangs 5024 -unknown 4 Thief: Deadly Shadows crashes:page fault on read access to 0x0000040c 5061 -unknown 6 Copying from Windows Firefox in Wine and pasting to Linux OpenOffice pastes metadata as data 10815 -unknown 2 Cannot drag images into Adobe Photoshop 7 from the web / desktop 5844 -unknown 11 tray minimize 10147 -unknown 1 Word Viewer 2003 - Tab behavior differs from Windows 9959 -unknown 8 Make wine updates work even if the registry changed 556 build-en 1 Reconcile the Windows and Wine spec files 2493 comctl32 2 Multi-select listview: Shift-arrow up only selects top two items 1114 comctl32 2 Winrar2.90/3.00: Comboex doesn't trigger a event when you mouse-click in some value of it 4372 comctl32 0 listview: cannot drag several items 11509 crypt32 0 Wordviewer 2003 is unable to open documents encrypted with AES 11681 directx- 14 Add support for video overlay 5535 directx- 16 Planescape:Torment doesn't work 5955 directx- 8 DirectDrawCreate crash on non-OpenGL desktop 9030 directx- 0 army men hangs on black screen 82 document 2 Stabilize Winelib User Guide Table of Contents 6519 gdi32 7 Wine blacks out rotated font bitmap 3270 gdi32 15 Problem with minimized top-level windows 9771 gdi32 38 Steam Friends doesn't work (fails to render correctly or refresh) 7571 gdi32 1 Accented character glyphs are mixed up with TrueType fonts (affects e.g. Lotus Notes R5) 9484 kernel32 18 Program refuses to run because of ProtectCD/ProtectDISC copy-protection 9039 kernel32 0 GS-Auftrag Professional SQL aborts on startup 5541 kernel32 0 WriteConsole can't write to stdout; affects e.g. wsh's cscript's usage message 5351 kernel32 9 Windows Installer 3.1 cannot install because of non-standard drive labeling 7098 mscoree 1 RufzXP crashes on startup, needs mscoree.dll.CorBindToRuntimeEx 5163 msi 12 Office XP 2002 crashes on installation 8783 ntdll 12 USB serial ports do not work 9356 ntdll 6 Serial communication not working since wine-0.9.33 6607 ole 9 Drag and Drop not working 9942 ole 2 Powerpoint Viewer 2007 crashes opening .pptx files 8095 ole 0 PQ Teaching toy crashes 2539 ole 3 XDND (Drag and drop for X Windows) doesn't copy text 5926 programs 0 Wine does not provide an implementation of winhlp32.exe 6254 richedit 4 Installer infinite loop from rich text error 6095 shdocvw 12 MOTD in counter-strike 1.6 and counter-strike source does not render 9304 shdocvw 3 Temple of Elemental Evil demo doesn't start - gui irresponsive 8898 shdocvw 0 Run Time Error "445": Object doesn't support this action in Europa Knowledgebase 3546 shdocvw 2 CLSID_InternetShortcut not available... 9809 shell32 4 Autodesk Revit Architecture 2008 install fails 8439 shell32 8 Visual Studio .NET (7) install fails 11742 shlwapi 8 Small .net 1.1 app (FastMD5 1.3) fails to start up 12074 testcase 2 The conformance tests fail on Windows 6604 tools 2 Ship icons for the wine-tools that can be used in .desktop files 664 user32 6 The help menu functionality inside programs is broken (messaging problem) 4523 user32 5 Can't copy from Firefox 1.5 and paste into OpenOffice 2 under Wine 3023 user32 5 Orcad - "Place Part" never tries to put down a part 124 wineserv 2 Review of Wine Server Protocol 1990 winex11. 1 modifier keys not released when switching desktop 5623 winex11. 3 GetAsyncKeyState wrong if querying process doesn't have focus 5828 winex11. 24 Command and Conquer Generals (Zero Hour) doesn't change the mouse cursor from the default X mouse 10984 winex11. 5 sun jre 5 update 10 installer hangs in 0.9.52 3297 winex11. 12 UpdateWindow() doesn't call XFlush() 7372 winex11. 12 can't copy and paste between gnome apps eg openoffice or gimp and wine apps such as dreamweaver or adobe photoshop 2368 winex11. 7 Wine loses its X-Window when switching to another virt. desktop in Fvwm 11019 winex11. 3 matlab r14 and r16 (7.0.4 and 7.3.0) and WriteItNow3.1.0s hang if X in 24bpp mode 5625 wininet 4 Wine does not handle internet proxy settings conveniently 9787 winsock 47 Warcraft3 Battle.net Doesn't work (Needs AcceptEx) 12005 wintab32 0 Regression in pressure sensitivity with wizardpen tablet driver and Photoshop 7

1 0

Bitrotting Translations
by Michael Stefaniuc 01 Apr '08

01 Apr '08

Hello guys, there are a couple resource file translations that are so way out of sync that they are commented out of the main rc file of the relevant module. programs/progman/rsrc.rc: ------------------------- - Da.rc - Danish - Fi.rc - Finnish - Sk.rc - Slovak - Sw.rc - Swedish (correct filename: Sv.rc) - Va.rc - Rumansh (Vallader) (correct filename: Rm.rc) - Wa.rc - Wallon This are so bitrotted that they don't even stink anymore but are nice fertile compost. Means they aren't even .rc files but .c/.h files. I have sent a patch to remove them. If somebody still wants to look at them they can with git show e.g.: git show wine-0.9.58:programs/progman/Va.rc programs/winecfg/winecfg.rc: ---------------------------- - Pt.rc - Portuguese (Brazil/Portugal) - It.rc - Italian - Si.rc - Slovenian This are only a little bit more broken but should be able to be fixed. If a native speaker could take care of them that would be really nice. Else I'll try to fix them myself or remove them if I fail after 1.0.0-rc1 comes out. programs/start/rsrc.rc: ----------------------- - Si.rc - Slovenian Looks like only a few characters (the non-7bit clean ones) are broken. Should be fairly easy to fix for a native speaker. Else I'll try to fix it myself after 1.0.0-rc1 comes out. bye michael

2 1