June 2008 - Wine-devel - list.winehq.org

Re: winex11.drv: Add support for AlphaBlend with non-opaque SourceConstantAlpha values.
by Peter Urbanec 02 Jun '08

02 Jun '08

Ángel Guzmán Maeso wrote: > A small change: > > +int x,y; > +for (x = 0; x < widthSrc; x++, tmpBits += 4) > + for(y=0;y<4;y++) > + tmpBits[y] = tmpBits[y] * blendfn.SourceConstantAlpha / 255; I'm not fussed one way or the other, but I can see at least two advantages in keeping the original code: 1) It's slightly more obvious that the data we are dealing with is four bytes of R, G, B and A - although a comment to that effect would be a better solution. 2) Compiler optimisers may do a slightly better job on the already unrolled loop. I'll leave it to Alexandre and co. to pick and choose which version makes it in.

1 0

Re: snmpapi: Stop tests from crashing on win98
by Paul Vriens 02 Jun '08

02 Jun '08

Alistair Leslie-Hughes wrote: > Hi, > > Changelog: > snmpapi: Stop tests from crashing on win98 > > Best Regards > Alistair Leslie-Hughes > > > > > ------------------------------------------------------------------------ > > I still don't think they should be removed but that's my opinion. If not running is preferable shouldn't we just if(0) them and add some comments? -- Cheers, Paul.

2 1

Re: user32: Fix input tests failing on WinXP+ (resend)
by Vitaliy 02 Jun '08

02 Jun '08

Vitaliy Margolen wrote: > --- > dlls/user32/tests/input.c | 29 +++++++++++++++++------------ > 1 files changed, 17 insertions(+), 12 deletions(-) >

1 0

Re: [PATCH] winealsa: Raise ALSA minimum period size to sane value
by John Klehm 02 Jun '08

02 Jun '08

On Sun, Jun 1, 2008 at 6:58 PM, Zephiris <zephiris(a)gmail.com> wrote: > The ALSA period size can be set to rather odd values, and querying the > minimum period size isn't always guaranteed to be sane. Use a safety net > value. This fixes bug 13458. > > --- > > dlls/winealsa.drv/dsoutput.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > Please use your real name, Wine doesn't accept anonymous patches. --John

1 0

iexplore/gecko problems with recent builds
by Steven Edwards 02 Jun '08

02 Jun '08

Hi, I did not find anything about this in bugzilla. Is anyone else having problems using builtin IE with gecko? I keep getting this error with the tip err:mshtml:before_async_open GetWineURL returned NULL -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 1

Re: Revert "wined3d: Put implicit surfaces into drawable on unload."
by H. Verbeet 02 Jun '08

02 Jun '08

2008/6/2 Vitaliy Margolen <wine-patches(a)kievinfo.com>: > This reverts commit 0de167db9e2ef6c62ba48b050bc3d0ba2638467f. > Fixes bug 12794 and probably others related to the black screen with enabled > FBO. > --- > dlls/wined3d/surface.c | 11 ++--------- > 1 files changed, 2 insertions(+), 9 deletions(-) > I've actually got a more correct fix for this, which I'll send in later today.

1 0

Re: [try 4] user32: Use correct buffer header for cursor inCURSORICON_LoadFromFile
by Dmitry Timoshkov 02 Jun '08

02 Jun '08

"Sergey Khodych" <khodych(a)gmail.com> wrote: > CreateIconFromResourceEx expects POINT16 at beginning of input buffer( > for cursors ). > Fixes bug #5031. Please follow the indentation/braces style of the file you are changing. -- Dmitry.

1 0

Re: [1/3] ddraw/tests: Detach surface if attaching worked by surprise (or refrast)
by James Hawkins 02 Jun '08

02 Jun '08

On Sun, Jun 1, 2008 at 5:47 PM, Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de> wrote: > --- > dlls/ddraw/tests/dsurface.c | 3 +++ > 1 files changed, 3 insertions(+), 0 deletions(-) > Patch already sent: http://winehq.org/pipermail/wine-patches/2008-May/055424.html -- James Hawkins

2 1

Re: [2/3] ddraw/tests: Add another refrast exception
by James Hawkins 02 Jun '08

02 Jun '08

On Sun, Jun 1, 2008 at 5:48 PM, Michael Karcher <wine(a)mkarcher.dialup.fu-berlin.de> wrote: > --- > dlls/ddraw/tests/dsurface.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > I've gone through all the latest test results, and this failure isn't happening anywhere that I've seen. Please link to where you're seeing this. -- James Hawkins

2 1

Re: advapi32: RegEnumKeyEx() should return "ERROR_INVALID_PARAMETER" if name_len is NULL
by James Hawkins 01 Jun '08

01 Jun '08

On Sun, Jun 1, 2008 at 11:28 AM, Andrew Talbot <andrew.talbot(a)talbotville.com> wrote: > Like native. > > -- Andy. > --- > Changelog: > advapi32: RegEnumKeyEx() should return "ERROR_INVALID_PARAMETER" if name_len is NULL. > > diff --git a/dlls/advapi32/registry.c b/dlls/advapi32/registry.c > index 9ce3da0..41ef3bf 100644 > --- a/dlls/advapi32/registry.c > +++ b/dlls/advapi32/registry.c > @@ -473,7 +473,7 @@ LSTATUS WINAPI RegEnumKeyExW( HKEY hkey, DWORD index, LPWSTR name, LPDWORD name_ > TRACE( "(%p,%d,%p,%p(%d),%p,%p,%p,%p)\n", hkey, index, name, name_len, > name_len ? *name_len : -1, reserved, class, class_len, ft ); > > - if (reserved) return ERROR_INVALID_PARAMETER; > + if (!name_len || reserved) return ERROR_INVALID_PARAMETER; > if (!(hkey = get_special_root_hkey( hkey ))) return ERROR_INVALID_HANDLE; > > status = NtEnumerateKey( hkey, index, KeyNodeInformation, > @@ -537,7 +537,7 @@ LSTATUS WINAPI RegEnumKeyExA( HKEY hkey, DWORD index, LPSTR name, LPDWORD name_l > TRACE( "(%p,%d,%p,%p(%d),%p,%p,%p,%p)\n", hkey, index, name, name_len, > name_len ? *name_len : -1, reserved, class, class_len, ft ); > > - if (reserved) return ERROR_INVALID_PARAMETER; > + if (!name_len || reserved) return ERROR_INVALID_PARAMETER; > if (!(hkey = get_special_root_hkey( hkey ))) return ERROR_INVALID_HANDLE; > > status = NtEnumerateKey( hkey, index, KeyNodeInformation, > Please add a test. -- James Hawkins

1 0