July 2008 - Wine-devel - list.winehq.org

RE: wined3d: universal surface convertor function for unsigned integer color formats(3rd attempt)
by Stefan Dösinger 23 Jul '08

23 Jul '08

The patch looks reasonably, just one small thing: There is a count_bits function implemented in utils.c, which as far as I can see does the same as getMaskSize. Can you check if you can reuse it? > -----Original Message----- > From: wine-patches-bounces(a)winehq.org [mailto:wine-patches- > bounces(a)winehq.org] On Behalf Of Victor Eremin > Sent: Wednesday, July 23, 2008 10:25 AM > To: wine-patches(a)winehq.org > Subject: wined3d: universal surface convertor function for unsigned > integer color formats(3rd attempt) > > > Supports conversion between most of "unsigned color" argb/xrgb surface > formats (D3DFMT_A8R8G8B8, D3DFMT_A8R3G3B2, etc), and "luminosity" color > formats (D3DFMT_L8, etc), excluding D3DFMT_A16R16G16B16, D3DFMT_A8P8, > D3DFMT_P8 and D3DFMT_A1. > luminosity to argb/xrgb (and vice versa) conversions are not supported > > Removes "Cannot find coverter" FIXMEs from "Ancient Evil" and "Stranded > 2" games. > > Fixes water glitches in "Stranded 2" game. > --- > dlls/wined3d/surface_base.c | 202 > ++++++++++++++++++++++++++++++++++++++- > dlls/wined3d/utils.c | 126 +++++++++++++------------- > dlls/wined3d/wined3d_private.h | 2 +- > 3 files changed, 260 insertions(+), 70 deletions(-)

3 4

Re: crypt32/tests: check Vista error codes for the protectdata tests.
by Juan Lang 23 Jul '08

23 Jul '08

Hi Reece, > (Vista does not set the last error on success for the functions used > in protectdata). In that case, it seems to me we should just remove those tests, as it's unlikely an app can depend on the last error being set on success. --Juan

1 0

Re: crypt32/tests: check Vista error codes for the msg tests.
by Markus Hitter 23 Jul '08

23 Jul '08

Am 23.07.2008 um 02:25 schrieb Reece Dunn: > > + /* last error -- NT: E_INVALIDARG, 9x/Vista: unchanged */ > + /* ret is FALSE on XP and earlier but TRUE on Vista, therefore > it cannot be tested for */ > + ok((GetLastError() == E_INVALIDARG || GetLastError() == > 0xdeadbeef), > + "Expected E_INVALIDARG or 0xdeadbeef, 0x%x\n", GetLastError > ()); A more general question: Is it Wine's policy to just ignore differences in behaviour between different Windows versions? From my own (naive) standpoint I'd say something like this would be better (pseudo-code): if (WinVer <= XP) { ok((!ret && [...]), "Expected [...]); } else { ok((ret && [...]), "Expected [...]); } Likely a often asked question, but I couldn't find hints about the answer yet. MarKus - - - - - - - - - - - - - - - - - - - Dipl. Ing. Markus Hitter http://www.jump-ing.de/

3 2

RE: wined3d: universal surface convertor function for unsigned integer color formats(3rd attempt)
by Stefan Dösinger 23 Jul '08

23 Jul '08

Actually, one more idea: It will be extra-slow, but we could implement a general all-to-all format by converting the source format to A32R32G32B32F(float values), and then write code to convert this format to all possible destination formats. The from->to table lookup could be replaced by code that can combine multiple conversions to find a conversion strategy(e.g. R5G6B5->ARGB32F->R8G8B8). I am not sure if it is a good idea, but it is worth a consideration

2 1

valgrind warning in wineconsole
by Dan Kegel 23 Jul '08

23 Jul '08

Here's a warning that seems to pop up if you type or mouse or something during the kernel32/console test. I first saw it last year, but it popped up again once last month and again today: http://kegel.com/wine/valgrind/logs/2008-07-23-07.18/vg-kernel32_console.txt Syscall param writev(vector[...]) points to uninitialised byte(s) at (within /lib/ld-2.7.so) by send_request (server.c:246) by wine_server_call (server.c:327) by wine_server_call_err (server.h:61) by WriteConsoleInputW (console.c:429) by WCUSER_GenerateKeyInputRecord (user.c:1059) by WCUSER_Proc (user.c:1118) by ??? (library.h:163) by call_window_proc (winproc.c:457) by WINPROC_call_window (winproc.c:2198) by DispatchMessageW (message.c:3125) by WCUSER_MainLoop (user.c:1381) by WinMain (wineconsole.c:869) by main (exe_main.c:48) Address 0x7f22f8a6 is on thread 1's stack Uninitialised value was created by a stack allocation at WCUSER_GenerateKeyInputRecord (user.c:1019) That user.c is in programs/wineconsole. This might just be a matter of INPUT_RECORD being holey, I haven't checked.

1 0

Valgrind warnings in new msxml3 saxreader code?
by Dan Kegel 23 Jul '08

23 Jul '08

Hi Piotr, I see a lot of new valgrind warnings today that seem to be triggered by your new msxml3 code. I don't know offhand if they're bugs in libxml2 or in your code, could you have a look? Thanks! See http://kegel.com/wine/valgrind/logs/2008-07-21-07.56/vg-msxml3_saxreader-di… Here are the first two: Conditional jump or move depends on uninitialised value(s) at xmlStrlen (in /usr/lib/libxml2.so.2.6.31) by xmlSetupParserForBuffer (in /usr/lib/libxml2.so.2.6.31) by isaxxmlreader_parse (saxreader.c:1077) by test_saxreader (saxreader.c:502) by func_saxreader (saxreader.c:518) by run_test (test.h:488) by main (test.h:537) Uninitialised value was created by a client request at mark_block_uninitialized (heap.c:164) by RtlAllocateHeap (heap.c:1236) by SAFEARRAY_Malloc (safearray.c:94) by SafeArrayAllocData (safearray.c:536) by SAFEARRAY_Create (safearray.c:231) by SafeArrayCreate (safearray.c:576) by test_saxreader (saxreader.c:494) by func_saxreader (saxreader.c:518) by run_test (test.h:488) by main (test.h:537) Conditional jump or move depends on uninitialised value(s) at get_length_mbs_utf8 (utf8.c:286) by wine_utf8_mbstowcs (utf8.c:312) by MultiByteToWideChar (locale.c:1838) by bstr_from_xmlChar (node.c:284) by libxmlCharacters (saxreader.c:249) by xmlParseCharData (in /usr/lib/libxml2.so.2.6.31) by xmlParseContent (in /usr/lib/libxml2.so.2.6.31) by xmlParseElement (in /usr/lib/libxml2.so.2.6.31) by xmlParseDocument (in /usr/lib/libxml2.so.2.6.31) by isaxxmlreader_parse (saxreader.c:1083) by test_saxreader (saxreader.c:502) by func_saxreader (saxreader.c:518) by run_test (test.h:488) by main (test.h:537) Uninitialised value was created by a client request at mark_block_uninitialized (heap.c:164) by RtlAllocateHeap (heap.c:1236) by SAFEARRAY_Malloc (safearray.c:94) by SafeArrayAllocData (safearray.c:536) by SAFEARRAY_Create (safearray.c:231) by SafeArrayCreate (safearray.c:576) by test_saxreader (saxreader.c:494) by func_saxreader (saxreader.c:518) by run_test (test.h:488) by main (test.h:537) ...

2 1

Re: [3/4] ntdll: Implement the timer queue thread.
by Rob Shearman 23 Jul '08

23 Jul '08

Hi Dan, 2008/7/23 Dan Hipschman <dsh(a)linux.ucla.edu>: > This isn't the most efficient implementation, but it works, and it should > not be difficult to tweak. Hence, I'd rather get this version in and add > the optimizations one at a time, in little patches. "Get it working first..." Yes, I think you're right. I don't think it will be too hard to change the architecture of this to that of my suggestions. However, I have one minor nit. > +static void WINAPI timer_queue_thread_proc(LPVOID p) > +{ > + struct timer_queue *q = p; > + ULONG timeout_ms; > + BOOL done; > + > + timeout_ms = INFINITE; > + while (!q->quit) > + { > + LARGE_INTEGER timeout; > + DWORD ret = NtWaitForSingleObject(q->event, FALSE, > + get_nt_timeout(&timeout, timeout_ms)); This should be NTSTATUS. > + > + if (ret == STATUS_TIMEOUT) > + queue_timer_expire_next(q); > + > + RtlEnterCriticalSection(&q->cs); > + timeout_ms = timer_queue_update(q); > + RtlLeaveCriticalSection(&q->cs); > + } -- Rob Shearman

2 1

Re: d3dx8: implement D3DXSphereBoundProbe
by H. Verbeet 23 Jul '08

23 Jul '08

2008/7/22 David Adam <david.adam.cnrs(a)gmail.com>: > + b = pow(D3DXVec3Dot(&difference, praydirection), 2); Maybe I'm just bad at math, but shouldn't that just be b = D3DXVec3Dot(&difference, praydirection); (The test case doesn't really help there) > + ok(result == TRUE, "expected FALSE, received TRUE\n"); That's misleading.

1 0

Re: libs/wpp/ppy.y signedness fixes
by Alexandre Julliard 23 Jul '08

23 Jul '08

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > In ISO C, operations involving both signed and unsigned types are > using signed. If the case of ui = ui OP si is really ment to make > use of this (despite the result being stored in an unsigned type), > we'd need to handle this via two casts, but I doubt this is really > the intent here. It's supposed to follow the C rules, so yes the result most likely needs to be signed in this case. That doesn't mean using two casts, it means using the correct output type. -- Alexandre Julliard julliard(a)winehq.org

1 0

Add "Wine FAQ" entry to Wine menu?
by Dan Kegel 23 Jul '08

23 Jul '08

Recently, several newbies had trouble finding the FAQ and were surprised to hear that it could be helpful. Perhaps if our packages added a "Wine FAQ" menu item, they'd have less trouble finding it. Here's a patch to add that to the Debian / Ubuntu packages. What do people think? --- /dev/null 2008-05-31 06:33:17.000000000 -0700 +++ debian/wine-faq.desktop 2008-07-22 00:06:29.000000000 -0700 @@ -0,0 +1,8 @@ +[Desktop Entry] +Name=Wine FAQ +Comment=Frequently Asked Questions about Wine (and their answers) +Exec=xdg-open http://wiki.winehq.org/FAQ +Terminal=false +Type=Application +Icon=gnome-help +Categories=Wine; --- debian/rules.orig 2008-07-22 00:11:37.000000000 -0700 +++ debian/rules 2008-07-22 00:12:32.000000000 -0700 @@ -160,6 +160,7 @@ cp -f $(CURDIR)/debian/wine-notepad.desktop $(CURDIR)/debian/tmp/usr/share/applications/ cp -f $(CURDIR)/debian/wine-browsedrive.desktop $(CURDIR)/debian/tmp/usr/share/applications/ cp -f $(CURDIR)/debian/wine-winecfg.desktop $(CURDIR)/debian/tmp/usr/share/applications/ + cp -f $(CURDIR)/debian/wine-faq.desktop $(CURDIR)/debian/tmp/usr/share/applications/ mkdir -p $(CURDIR)/debian/tmp/usr/share/desktop-directories/ cp -f $(CURDIR)/debian/wine-wine.directory $(CURDIR)/debian/tmp/usr/share/desktop-directories/

2 3