July 2008 - Wine-devel - list.winehq.org

re: xinput implementation
by Dan Kegel 03 Aug '08

03 Aug '08

chourmovs wrote: > I'd like to participate to wine improvement instead of > always requesting for new features > > ... xinput support lack for new games and its > implementation is maybe not the hardest thing to do Please start by writing conformance tests. See http://www.winehq.org/site/docs/winedev-guide/testing - Dan

3 2

DLL loading prolem when injecting into another process
by Hongbo Ni 02 Aug '08

02 Aug '08

Hi, I have observed a DLL loading prolem when injecting into another process. For example, In folder C:\DirA\, I have A.exe which is linked to B.dll, and B.dll is linked to C.dll. B.dll and C.dll are in same folder as A.exe. If I run A.exe, B.dll and C.dll will be loaded without problem since they are in same folder. Support there is a process running C:\DirX\X.exe, and C:\DirX\ is not the current folder and it's not on PATH. Now I inject B.dll from A.exe into process X.exe, the System will map C:\DirA\B.dll into process X.exe. Since B.dll is linked to C.dll, the system will try to load C.dll for process X.exe. But because C.dll is not in same folder of process X.exe, wine failed to load C.dll for X.exe. This cause DLL injection to fail. Windows does not have this problem. So I am trying to find a solution. I think when processing the imports for C:\DirA\B.dll to load C.dll, it should try C:\DirA\C.dll first, then form the standard load locations. I think it should call load_library( "C:\DirA\C.dll ", LOAD_WITH_ALTERED_SEARCH_PATH) so C.dll can be loaded into C:\DirX\X.exe process. Alexandre, can you please comment ? Regards Hongbo Ni _________________________________________________________________ Want to help Windows Live Messenger plant more Aussie trees? http://livelife.ninemsn.com.au/article.aspx?id=443698

5 10

mono progress on mixed-mode assemblies...
by Dan Kegel 02 Aug '08

02 Aug '08

http://lists.ximian.com/pipermail/mono-devel-list/2008-May/027767.html shows that Pál Kornél is now working on supporting apps that use msvcrt. Go Pal go!

7 15

Re: one liner patch to stop crash, everquest2.exe
by H. Verbeet 02 Aug '08

02 Aug '08

2008/7/17 Andrew Fenn <andrewfenn(a)gmail.com>: > I added a check to make sure This->shader_priv wasn't null. Before > Everquest2.exe would crash when I tried to alt+enter from windowed mode. > This stops it crashing wine. > This->shader_priv shouldn't be NULL. It probably means the backend was already destroyed when shader_glsl_free() was called.

4 22

New valgrind warnings in wined3d/arb_program_shader.c
by Dan Kegel 01 Aug '08

01 Aug '08

Hi Stefan, your recent round of changes (circa http://www.winehq.org/pipermail/wine-cvs/2008-July/045946.html) seems to have triggered a whole bunch of valgrind warnings, e.g. http://kegel.com/wine/valgrind/logs/2008-07-31-07.46/vg-d3d9_visual-diff.txt + Use of uninitialised value of size 4 + at hash_table_get_by_idx (utils.c:1600) + by hash_table_get (utils.c:1750) + by find_ffp_shader (utils.c:1961) + by fragment_prog_arbfp (arb_program_shader.c:2761) + by ActivateContext (context.c:1169) + by drawPrimitive (drawprim.c:950) + by IWineD3DDeviceImpl_DrawIndexedPrimitiveUP (device.c:5350) + by IDirect3DDevice9Impl_DrawIndexedPrimitiveUP (device.c:1227) + by lighting_test (visual.c:300) + by func_visual (visual.c:9234) + by run_test (test.h:488) + by main (test.h:537) + Uninitialised value was created by a stack allocation + at fragment_prog_arbfp (arb_program_shader.c:2745) http://kegel.com/wine/valgrind/logs/2008-07-31-07.46/vg-ddraw_visual-diff.t… + Use of uninitialised value of size 4 + at hash_table_get_by_idx (utils.c:1600) + by hash_table_get (utils.c:1750) + by find_ffp_shader (utils.c:1961) + by fragment_prog_arbfp (arb_program_shader.c:2761) + by ActivateContext (context.c:1169) + by drawPrimitive (drawprim.c:950) + by IWineD3DDeviceImpl_DrawIndexedPrimitiveUP (device.c:5350) + by IDirect3DDeviceImpl_7_DrawIndexedPrimitive (device.c:3731) + by IDirect3DDeviceImpl_7_DrawIndexedPrimitive_FPUSetup (device.c:3754) + by lighting_test (visual.c:276) + by func_visual (visual.c:2649) + by run_test (test.h:488) + by main (test.h:537) + Uninitialised value was created by a stack allocation + at fragment_prog_arbfp (arb_program_shader.c:2745) Could you have a look? Thanks, Dan

3 5

Re: [PATCH] wine.inf: Change Msi.Package actions to have the full msiexec path. (try 2)
by Alexandre Julliard 31 Jul '08

31 Jul '08

"Lei Zhang" <thestig(a)google.com> writes: > @@ -143,9 +143,9 @@ HKCR,lnkfile\CLSID,,2,"{00021401-0000-0000-C000-000000000046}" > HKCR,lnkfile\shellex\IconHandler,,2,"{00021401-0000-0000-C000-000000000046}" > HKCR,lnkfile\shellex\ContextMenuHandlers\{00021401-0000-0000-C000-000000000046},,0x10, > HKCR,Msi.Package\DefaultIcon,,2,"msiexec.exe" > -HKCR,Msi.Package\shell\Open\command,,2,"msiexec /i ""%1""" > -HKCR,Msi.Package\shell\Repair\command,,2,"msiexec /f ""%1""" > -HKCR,Msi.Package\shell\Uninstall\command,,2,"msiexec /x ""%1""" > +HKCR,Msi.Package\shell\Open\command,,0x20000,"""%SystemRoot%\System32\msiexec.exe"" /i ""%1"" %*" > +HKCR,Msi.Package\shell\Repair\command,,0x20000,"""%SystemRoot%\System32\msiexec.exe"" /f ""%1"" %*" > +HKCR,Msi.Package\shell\Uninstall\command,,0x20000,"""%SystemRoot%\System32\msiexec.exe"" /x ""%1"" %*" You should be using %11% instead of hardcoding system32, but it shouldn't make any difference either way. Why do you need to change this? -- Alexandre Julliard julliard(a)winehq.org

2 3

Hang in mshtml/tests/dom.c
by Dan Kegel 31 Jul '08

31 Jul '08

While running mshtml/tests/dom.c on a slow dual processor under valgrind, I got the following hang: ... 7 0x04b22c1c GetMessageA+0x60(msg=0x7f21fdc8, hwnd=0x0, first=0x0, last=0x0) [dlls/user32/message.c:2976] in user32 (0x7f21fda8) 8 0x04946eb1 run_domtest+0x91(str=0x495fab0, test=0x493daa4) [dlls/mshtml/tests/dom.c:2597] in mshtml_test (0x7f21fdf8) 9 0x0494711c func_dom+0x45() [dlls/mshtml/tests/dom.c:2652] in mshtml_test (0x7f21fe18) ... The offending GetMessage call is in the following loop in tests/dom.c: while(!doc_complete && GetMessage(&msg, NULL, 0, 0)) { TranslateMessage(&msg); DispatchMessage(&msg); } The doc_complete test has been in that file since the test was added; git blame says it was added by this commit: commit 1534267ba500156e7965fdc399247ca69eb7c014 Author: Jacek Caban <jacek(a)codeweavers.com> Date: Sun Jun 24 21:09:03 2007 +0200 mshtml: Added beginning DOM tests. Jacek, could you have a look and see if there's some obvious race you could fix? Thanks, Dan

2 2

Re: shdocvw(2/2): rudimentary implementation of CLSID_InternetShortcut (try 3)
by Jacek Caban 31 Jul '08

31 Jul '08

Hi Damjan, Damjan Jovanovic wrote: > Changelog: > * Added a rudimentary implementation of CLSID_InternetShorcut, with > tests (#3546). > > Damjan Jovanovic > + +static HRESULT strdupAtoW(LPCSTR in, LPWSTR *out) +{ + INT len; + if (in == NULL) + { + *out = NULL; + return S_OK; + } + len = MultiByteToWideChar(CP_ACP, 0, in, -1, NULL, 0); + *out = HeapAlloc(GetProcessHeap(), 0, len*sizeof(WCHAR)); + if (!*out) + return E_OUTOFMEMORY; + MultiByteToWideChar(CP_ACP, 0, in, -1, *out, len); + return S_OK; +} + +static HRESULT strdupWtoA(LPCWSTR in, LPSTR *out) +{ + INT len; + if (in == NULL) + { + *out = NULL; + return S_OK; + } + len = WideCharToMultiByte(CP_ACP, 0, in, -1, NULL, 0, 0, 0); + *out = HeapAlloc(GetProcessHeap(), 0, len); + if (!*out) + return E_OUTOFMEMORY; + WideCharToMultiByte(CP_ACP, 0, in, -1, *out, len, 0, 0); + return S_OK; +} These function should go to shdocvw.h and be named heap_strdup*. You may copy them from dlls/mshtml/mshtml_private.h. + else if (IsEqualGUID(&IID_IShellLinkA, riid)) + { + FIXME("The IShellLinkA interface is not yet supported by InternetShortcut\n"); + return E_NOTIMPL; E_NOINTERFACE is better choice. + } + else if (IsEqualGUID(&IID_IShellLinkW, riid)) + { + FIXME("The IShellLinkW interface is not yet supported by InternetShortcut\n"); + return E_NOTIMPL; Same here. + } + else + { + FIXME("Interface with GUID %s not yet implemented by InternetShortcut\n", debugstr_guid(riid)); + return E_NOINTERFACE; + } You should set ppvObject to NULL here. Also, the order of function is strange. The convention is to order function as they are ordered in the interface declaration and not mix interfaces. Also there are heap_alloc, heap_alloc_zero and heap_free functions in shdocvw.h that you should use instead of HeapAlloc/HeapFree. Jacek

1 0

Re: [5/7] WineD3D: Only set D3D caps when GL was loaded successfully
by H. Verbeet 31 Jul '08

31 Jul '08

2008/7/31 Stefan Dösinger <stefan(a)codeweavers.com>: > + if(Adapters[0].opengl) { Shouldn't you be checking the adapter for which the caps are requested instead?

2 1

Re: [resent] Fix some hackish usages of WideCharToMultiByte
by Alexandre Julliard 31 Jul '08

31 Jul '08

"Colin Finck" <mail(a)colinfinck.de> writes: > @@ -947,7 +947,8 @@ static void convert_PCREDENTIALW_to_PCREDENTIALA(const CREDENTIALW *CredentialW, > if (CredentialW->TargetName) > { > CredentialA->TargetName = buffer; > - string_len = WideCharToMultiByte(CP_ACP, 0, CredentialW->TargetName, -1, CredentialA->TargetName, -1, NULL, NULL); > + /* Buffer is guaranteed to be large enough */ > + string_len = WideCharToMultiByte(CP_ACP, 0, CredentialW->TargetName, -1, CredentialA->TargetName, 0x7FFFFFFF, NULL, NULL); It would be cleaner to pass the actual buffer size to the function, it's complex enough that it would be easy to inadvertently break the guarantee that the allocated space is large enough. -- Alexandre Julliard julliard(a)winehq.org

2 1