July 2008 - Wine-devel - list.winehq.org

Re: [2/10] [try 4] appwiz.cpl: Display Add/Remove Programs dialog
by Juan Lang 17 Jul '08

17 Jul '08

Hi Owen, -#define ICO_FLOPPY 4 -#define ICO_CDROM 5 - It seems a little unusual that you remove icon IDs you just introduced in patch 1. (Probably you shouldn't have included them in the first place?) --Juan

1 0

Starting point to debug an application error
by Brad Campbell 17 Jul '08

17 Jul '08

G'day all, I'm playing with a windows program used to develop code for a uC. The application is free to download and installs cleanly with no dependence on external hardware. It's pretty much working except for two details. A) The file tree on the left of the application throws an application exception when clicking on any items. B) It won't recognise there is a serial port configured. I'm working on (B) myself and making progress. It's all to do with registry keys windows 2k+ creates when a serial port is detected/created. This is not an issue for me and I think I can make it work relatively cleanly. I'm having trouble with (A). I've done full traces, relay traces and played with the debugger, but I don't seem to be able to get a starting point to track down the error. The application handles it internally and does not seem to throw an exception at wine. No crash, just not working. If someone has the time to look at it, I'd love a pointer on where / how to start investigating this.. The application is available here. I'd direct link it but their web server won't allow a download without the correct references. http://www.parallax.com/tabid/442/Default.aspx I've tried it on the latest CVS as of this morning. I've also built and tested against crossover-7 sources today. Both fail in precisely the same way. Regards, Brad

2 2

Re: [1/3] [try 3] appwiz.cpl: Add GUI for Add/Remove Programs controlpanel
by Owen Rudge 17 Jul '08

17 Jul '08

> OK, seems there was a small bug in the last patch that could cause > crashes, plus I'd forgotten to include wine.inf.in. I'm pretty sure this > one should be fine now, at least. Sorry for all the messages. ;-) Just wondering if anybody has any feedback on these, as I notice they've not been accepted into the last couple of rounds of commits. If there's anything glaringly wrong with it that I haven't spotted, or another reason why they've not made it into the codebase yet, please do let me know. :-) Thanks, -- Owen Rudge http://www.owenrudge.net/

3 4

Re: taskmgr: Add full translation [1/2]
by Alexandre Julliard 17 Jul '08

17 Jul '08

Vladimir Pankratov <scriptkid(a)mail.ru> writes: > @@ -50,10 +51,17 @@ > int nOldWidth; /* Holds the previous client area width */ > int nOldHeight; /* Holds the previous client area height */ > > +TCHAR szLoadedString[250]; /* Variable where load string from resource*/ > + > BOOL bInMenuLoop = FALSE; /* Tells us if we are in the menu loop */ > > TASKMANAGER_SETTINGS TaskManagerSettings; > > +BOOL GetStringFromRes(UINT uID) > +{ > + LoadStringA(hInst, uID, szLoadedString, sizeof(szLoadedString)); > + return TRUE; > +} That's ugly, you should return string somehow, not use a global variable. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] [WineX11.Drv]: correctly pad 1 bpp DDB's lines with 0 values
by Alexandre Julliard 17 Jul '08

17 Jul '08

Eric Pouech <eric.pouech(a)orange.fr> writes: > A+ > --- > > dlls/gdi32/tests/bitmap.c | 1 - > dlls/winex11.drv/dib.c | 5 ++++- > 2 files changed, 4 insertions(+), 2 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M gdi32.dll -T ../../.. -p gdi32_test.exe.so bitmap.c && touch bitmap.ok bitmap.c:1514: Test failed: DIB bits don't match make[2]: *** [bitmap.ok] Error 1 -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: comctl32: statusbar[3/5]: change the height expression to one that seems to be the same as in Windows
by Alexandre Julliard 17 Jul '08

17 Jul '08

Mikołaj Zalewski <mikolaj(a)zalewski.pl> writes: > @@ -116,7 +116,7 @@ STATUSBAR_ComputeHeight(STATUS_INFO *infoPtr) > TEXTMETRICW tm; > > COMCTL32_GetFontMetrics(infoPtr->hFont ? infoPtr->hFont : infoPtr->hDefaultFont, &tm); > - height = tm.tmHeight + 4 + infoPtr->verticalBorder; > + height = tm.tmHeight + tm.tmInternalLeading + 2 + infoPtr->verticalBorder; This doesn't make sense, the height already includes tmInternalLeading. -- Alexandre Julliard julliard(a)winehq.org

1 0

That tiny OpenGL app
by Markus Hitter 17 Jul '08

17 Jul '08

Hello all, maybe I'm just missing the obvious, but I can't get my small one-file app to link. As I've just built Wine from scratch on this box, everything should be installed, including libGL... in /usr/lib32: mah(a)piccard:~/Wine Apps/GPWiki Framework$ make i586-mingw32msvc-g++ -pipe -mwindows \ -L/usr/local/lib/wine -L/lib32 -L/usr/lib32 \ -Wl,-rpath,/usr/local/lib/wine -Wl,-rpath,/lib32 -Wl,-rpath,/usr/ lib32 \ -lopengl32 -lglu32 -o OpenGLBase.exe OpenGLBase.cpp /tmp/cclajgrA.o:OpenGLBase.cpp:(.text+0x10e): undefined reference to `_wglCreateContext(a)4' /tmp/cclajgrA.o:OpenGLBase.cpp:(.text+0x134): undefined reference to `_wglMakeCurrent(a)8' /tmp/cclajgrA.o:OpenGLBase.cpp:(.text+0x15d): undefined reference to `_glClearColor(a)16' /tmp/cclajgrA.o:OpenGLBase.cpp:(.text+0x16a): undefined reference to `_glClear(a)4' collect2: ld returned 1 exit status make: *** [OpenGLBase.exe] Fehler 1 mah(a)piccard:~/Wine Apps/GPWiki Framework$ for F in /lib32/* /usr/ lib32/* /usr/local/lib/wine/*; do if nm "$F" 2>/dev/null | grep glClearColor; then echo "$F"; fi; done U glClearColor 000621c0 T wine_glClearColor 000522f0 t wine_glClearColorIiEXT 00052240 t wine_glClearColorIuiEXT /usr/local/lib/wine/opengl32.dll.so 00102574 B glClearColor /usr/local/lib/wine/wined3d.dll.so mah(a)piccard:~/Wine Apps/GPWiki Framework$ Short of solid knowledge I tried about anything I could imagine, but no joy. Any ideas, somebody? Thanks, MarKus - - - - - - - - - - - - - - - - - - - Dipl. Ing. Markus Hitter http://www.jump-ing.de/

3 6

Re: ws2_32: Partial implementation of TransmitFile/TransmitPackets (try 2)
by Alexandre Julliard 17 Jul '08

17 Jul '08

Jon Griffiths <jon_p_griffiths(a)yahoo.com> writes: > + while (send_len) > + { > + wsabuf.len = send_len; > + if (wsabuf.len > chunk_len) > + wsabuf.len = chunk_len; > + if (!ReadFile(packet->u.s.hFile, wsabuf.buf, wsabuf.len, &n, NULL)) > + goto TransmitPackets_fail; > + wsabuf.len = n; > + if (WSASendTo(s, &wsabuf, 1, &n, 0, NULL, 0, NULL, NULL) == SOCKET_ERROR) > + goto TransmitPackets_fail; > + send_len -= n; > + } This is still wrong, WSASendTo doesn't necessarily send the whole buffer. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 03/12] quartz: Make Filtermapper aggregatable.
by Alexandre Julliard 17 Jul '08

17 Jul '08

Alexander Dorofeyev <alexd4(a)inbox.lv> writes: > @@ -1148,7 +1201,7 @@ static const IFilterMapper2Vtbl fm2vtbl = > > static HRESULT WINAPI FilterMapper_QueryInterface(IFilterMapper * iface, REFIID riid, LPVOID *ppv) > { > - FilterMapper2Impl *This = impl_from_IFilterMapper(iface); > + ICOM_THIS_MULTI(FilterMapper2Impl, lpVtblFilterMapper, iface); Please don't do that. Using inline functions is much better than the ugly and non-typesafe ICOM_THIS_MULTI macro. -- Alexandre Julliard julliard(a)winehq.org

1 0

re: msxml3: Added ISAXContentHandler_startDocument evenet (3/12)
by Alistair Leslie-Hughes 17 Jul '08

17 Jul '08

"Piotr Caban" <piotr.caban(a)gmail.com> wrote in message news:200807170041.01333.piotr.caban(a)gmail.com... +/*** LibXML callbacks ***/ +static void libxmlStartDocument(void *ctx) +{ + saxlocator *This = ctx; + HRESULT hr; + + if(This->saxreader->contentHandler) + { + hr = ISAXContentHandler_startDocument(This->saxreader->contentHandler); + if(FAILED(hr)) + { + xmlStopParser(This->pParserCtxt); + This->ret = hr; + } Hi Piotr, Should This->ret be set on a non-error? Best Regards Alistair Leslie-Hughes _________________________________________________________________ Are you paid what you're worth? Find out: SEEK Salary Centre http://a.ninemsn.com.au/b.aspx?URL=http%3A%2F%2Fninemsn%2Eseek%2Ecom%2Eau%2…

2 1