July 2008 - Wine-devel - list.winehq.org

start/stop logs by code... is it possible ?
by Massimo Del Fedele 03 Jul '08

03 Jul '08

I'd like to start some trace log entering a function and stopping it at exit, to isolate just the part I need. Is it possible to add some code inside the function body that do it ? I mean... void aWineFunction(...) { ....... STARTLOG ....... ....... STOPLOG ....... } The purpose is to isolate traces from code called by a single function. Max

4 5

Re: [Gdiplus 03/16] test_getgenerics: Don't use a pointer-to-pointer construct.
by Alexandre Julliard 03 Jul '08

03 Jul '08

Adam Petaccia <adam(a)tpetaccia.com> writes: > diff --git a/dlls/gdiplus/tests/font.c b/dlls/gdiplus/tests/font.c > index 59a6cb7..e710c30 100644 > --- a/dlls/gdiplus/tests/font.c > +++ b/dlls/gdiplus/tests/font.c > @@ -189,42 +189,38 @@ static void test_fontfamily (void) > static void test_getgenerics (void) > { > GpStatus stat; > - GpFontFamily** family; > + GpFontFamily* FontFamily; It's a matter of taste, but I think 'family' was a much better name that 'FontFamily' for a local variable. The latter looks like an API call. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [Gdiplus 01/16] Valgrind: fix warnings about using uninitialized memory, and leaking memory
by Alexandre Julliard 03 Jul '08

03 Jul '08

Adam Petaccia <adam(a)tpetaccia.com> writes: > @@ -152,6 +154,8 @@ static void test_fontfamily (void) > WCHAR itsName[LF_FACESIZE]; > GpStatus stat; > > + ZeroMemory(itsName, sizeof(itsName)); > + Clearing buffers is almost always a sign that you are hiding a bug. Please fix it properly instead. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [try 2] user32: GetMenuStringA now returns correct buffer length for multibyte menu text. (with test)
by Alexandre Julliard 03 Jul '08

03 Jul '08

"Huang, Zhangrong" <hzhrong(a)gmail.com> writes: > @@ -665,6 +678,26 @@ static void test_menu_add_string( void ) > else > ok (!ret, "GetMenuStringW on ownerdraw entry succeeded.\n"); > > + /* test multibyte menu text */ > + strcpy(string, "\xce\xc4\xbc\xfe(&F)"); /* CP936 */ You shouldn't hardcode codepage 936. Look at test_dbcs_wm_char() in msg.c to see how to test DBCS chars in a generic way. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [Bug 13838] AutoCAD 2005 setup : Missing backslash in registry entry and profile path
by Massimo Del Fedele 03 Jul '08

03 Jul '08

wine-bugs(a)winehq.org ha scritto: > http://bugs.winehq.org/show_bug.cgi?id=13838 > > > > > > --- Comment #29 from Dan Kegel <dank(a)kegel.com> 2008-07-02 18:52:54 --- > If you could write a conformance test to expose and verify the > problem first, that would be cool. > > Well, I'm not so good with installer stuffs... in particular, I don't know how to get the PACKAGE stuff needed for the call. BTW, I'll try it this night.... Max

1 0

New winetricks 20080402: new verbs dotnet20, win2k, flash, msls31; updated mono, liberation
by Dan Kegel 03 Jul '08

03 Jul '08

Big news: as of today or so, wine doesn't need any patches to install the .net 2.0 runtime or run trivial .net 2.0 apps, so I've added a dotnet20 verb. No more futzing with recipes to try out simple .net 2 apps, huzzah! There are lots of other little changes, too: 20080402 r21 Added dotnet20, removed one kludge from dotnet11, added win2k verb, plus shorthand for winver=foo r20 Updated liberation fonts. 20080328 r19 Added flash. 20080326 r18 Fix i18n problem reported by Ricardo Cabral 20080321 r17 Added msls31 (seems to be needed by e-Sword) 20080317 r16 update mono12 to 1.2.9 ... As always, winetricks is downloadable from http://kegel.com/wine/winetricks and change history is at http://code.google.com/p/winezeug Thanks to the folks who keep feeding me improvements and suggestions! - Dan

4 3

Registering mstask without DllRegisterServer
by Roy Shea 03 Jul '08

03 Jul '08

Howdy, I'm looking for advice on how to add registry entries for an implementation of the mstask Task Scheduler Service. The mstask DLL does not provide DllRegisterServer or DllUnregisterServer. To mirror this within my version I'm assuming that DllRegisterServer / DllUnregisterServer are off limits. For registration I'm currently planning to to extend wine.inf.in directly with the required registry entries. The barebones version of mstask this would add to the classes section: ---- HKCR,CLSID\{148BD52A-A2AB-11CE-B11F-00AA00530503},,,"CTaskScheduler" HKCR,CLSID\{148BD52A-A2AB-11CE-B11F-00AA00530503}\InProcServer32,,,"mstask.dll" HKCR,CLSID\{148BD52A-A2AB-11CE-B11F-00AA00530503}\InProcServer32,"ThreadingModel",,"Both" ---- See the attached patch for details. I'm not completely happy with this approach. Any insight into a cleaner way to add the mstask registry data into wine? Thanks! -Roy

1 0

richedit: do not read actual scrollbar state for scrollbar update, use internal state instead
by Alex Villacís Lasso 02 Jul '08

02 Jul '08

This is supposed to be a fix for bug #12311 . This bug involves a recursive message loop where the application forces visibility of scrollbars for the richedit control, which causes a WM_SIZE that triggers an update of the window size and re-hiding of the scrollbar. However, just after exiting the richedit winproc, the app forces visibility again, which again triggers a WM_SIZE, and so on. Native is oblivious to the fact that an external agent is messing with the scrollbar visibility, and is therefore unaffected by recursion. This patch attempts to fix this behavior in builtin and test for it. I have tried to test it on WinXP-SP2 and Win98, but testing on other platforms is helpful too. Changelog: * Use internal copy of scrollbar state instead of directly reading state from scrollbars, just as native does. * Tests for ability to externally modify scrollbars. * Test for behavior that caused recursion until builtin richedit was fixed. -- perl -e '$x=2.4;print sprintf("%.0f + %.0f = %.0f\n",$x,$x,$x+$x);'

2 2

re: Tests and Valgrinding
by Dan Kegel 02 Jul '08

02 Jul '08

Zachary Goldberg wrote: > test.winehq.org ... is fantastic, but it doesn't give a very good feel for progress > that all of these recent patches have been making. I would love to see a feature added to test.winehq.org which showed one tests's results across time (and platform). That would let you see regressions (and progress) at a glance. > Also, Dan Kegel has been extraordinarily diligent in valgrinding of > late (/applause) and I just wanted to ask if we're doing anything to > support him? A few people are starting to run Valgrind themselves. How about this: if you ever post a patch that causes a valgrind warning, you send yourself to valgrind jail for a month, and valgrind every patch you write before you send it in... > perhaps making Valgrind-passing a requirement (along > with not breaking tests) for being committed. I think perhaps > we should take a look at this and seriously consider implementing it. As a first step, James and I could (along with posting the errors to wine-devel) also post patches to revert the guilty changes. (And if we do it quickly enough, perhaps Alexandre can do the revert on the same day...) Then the author could fix and resubmit. How's that sound? - Dan

3 2

Re: winhttp: include/winhttp.h: Add more #define's for options
by Zac Brown 02 Jul '08

02 Jul '08

Zac Brown wrote: > Add more #define's for options used in WinHttpOpenRequest, > WinHttpSendRequest, and WinHttp{Set/Query}Options. > > > ------------------------------------------------------------------------ > > --- > include/winhttp.h | 66 +++++++++++++++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 66 insertions(+), 0 deletions(-) > > diff --git a/include/winhttp.h b/include/winhttp.h > index ef2caff..e816c82 100644 > --- a/include/winhttp.h > +++ b/include/winhttp.h > @@ -62,6 +62,72 @@ typedef int INTERNET_SCHEME, *LPINTERNET_SCHEME; > > #define ERROR_WINHTTP_AUTODETECTION_FAILED (WINHTTP_ERROR_BASE + 180) > > +/* Flags for WinHttp{Set/Query}Options */ > +#define WINHTTP_FIRST_OPTION WINHTTP_OPTION_CALLBACK > +#define WINHTTP_OPTION_CALLBACK 1 > +#define WINHTTP_OPTION_RESOLVE_TIMEOUT 2 > +#define WINHTTP_OPTION_CONNECT_TIMEOUT 3 > +#define WINHTTP_OPTION_CONNECT_RETRIES 4 > +#define WINHTTP_OPTION_SEND_TIMEOUT 5 > +#define WINHTTP_OPTION_RECEIVE_TIMEOUT 6 > +#define WINHTTP_OPTION_RECEIVE_RESPONSE_TIMEOUT 7 > +#define WINHTTP_OPTION_HANDLE_TYPE 9 > +#define WINHTTP_OPTION_READ_BUFFER_SIZE 12 > +#define WINHTTP_OPTION_WRITE_BUFFER_SIZE 13 > +#define WINHTTP_OPTION_PARENT_HANDLE 21 > +#define WINHTTP_OPTION_EXTENDED_ERROR 24 > +#define WINHTTP_OPTION_SECURITY_FLAGS 31 > +#define WINHTTP_OPTION_SECURITY_CERTIFICATE_STRUCT 32 > +#define WINHTTP_OPTION_URL 34 > +#define WINHTTP_OPTION_SECURITY_KEY_BITNESS 36 > +#define WINHTTP_OPTION_PROXY 38 > +#define WINHTTP_OPTION_USER_AGENT 41 > +#define WINHTTP_OPTION_CONTEXT_VALUE 45 > +#define WINHTTP_OPTION_CLIENT_CERT_CONTEXT 47 > +#define WINHTTP_OPTION_REQUEST_PRIORITY 58 > +#define WINHTTP_OPTION_HTTP_VERSION 59 > +#define WINHTTP_OPTION_DISABLE_FEATURE 63 > +#define WINHTTP_OPTION_CODEPAGE 68 > +#define WINHTTP_OPTION_MAX_CONNS_PER_SERVER 73 > +#define WINHTTP_OPTION_MAX_CONNS_PER_1_0_SERVER 74 > +#define WINHTTP_OPTION_AUTOLOGON_POLICY 77 > +#define WINHTTP_OPTION_SERVER_CERT_CONTEXT 78 > +#define WINHTTP_OPTION_ENABLE_FEATURE 79 > +#define WINHTTP_OPTION_WORKER_THREAD_COUNT 80 > +#define WINHTTP_OPTION_PASSPORT_COBRANDING_TEXT 81 > +#define WINHTTP_OPTION_PASSPORT_COBRANDING_URL 82 > +#define WINHTTP_OPTION_CONFIGURE_PASSPORT_AUTH 83 > +#define WINHTTP_OPTION_SECURE_PROTOCOLS 84 > +#define WINHTTP_OPTION_ENABLETRACING 85 > +#define WINHTTP_OPTION_PASSPORT_SIGN_OUT 86 > +#define WINHTTP_OPTION_PASSPORT_RETURN_URL 87 > +#define WINHTTP_OPTION_REDIRECT_POLICY 88 > +#define WINHTTP_OPTION_MAX_HTTP_AUTOMATIC_REDIRECTS 89 > +#define WINHTTP_OPTION_MAX_HTTP_STATUS_CONTINUE 90 > +#define WINHTTP_OPTION_MAX_RESPONSE_HEADER_SIZE 91 > +#define WINHTTP_OPTION_MAX_RESPONSE_DRAIN_SIZE 92 > +#define WINHTTP_OPTION_CONNECTION_INFO 93 > +#define WINHTTP_OPTION_CLIENT_CERT_ISSUER_LIST 94 > +#define WINHTTP_OPTION_SPN 96 > +#define WINHTTP_OPTION_GLOBAL_PROXY_CREDS 97 > +#define WINHTTP_OPTION_GLOBAL_SERVER_CREDS 98 > +#define WINHTTP_OPTION_UNLOAD_NOTIFY_EVENT 99 > +#define WINHTTP_OPTION_REJECT_USERPWD_IN_URL 100 > +#define WINHTTP_OPTION_USE_GLOBAL_SERVER_CREDENTIALS 101 > +#define WINHTTP_LAST_OPTION WINHTTP_OPTION_USE_GLOBAL_SERVER_CREDENTIALS > +#define WINHTTP_OPTION_USERNAME 0x1000 > +#define WINHTTP_OPTION_PASSWORD 0x1001 > +#define WINHTTP_OPTION_PROXY_USERNAME 0x1002 > +#define WINHTTP_OPTION_PROXY_PASSWORD 0x1003 > + > +/* Option "prettifiers" for WinHttpOpenRequest */ > +#define WINHTTP_NO_REFERER NULL > +#define WINHTTP_DEFAULT_ACCEPT_TYPES NULL > + > +/* Option "prettifiers" for WinHttpSendRequest */ > +#define WINHTTP_NO_ADDITIONAL_HEADERS NULL > +#define WINHTTP_NO_REQUEST_DATA NULL > + > typedef struct > { > DWORD dwStructSize; > > > ------------------------------------------------------------------------ > > Ignore this, bad comments.

1 0