October 2009 - Wine-devel - list.winehq.org

Re: [3/5] ddraw: Implement and test DirectDrawEnumerateW.
by Stefan Dösinger 08 Oct '09

08 Oct '09

Am 08.10.2009 um 09:46 schrieb Andrew Nguyen: > --- > dlls/ddraw/ddraw.spec | 2 +- > dlls/ddraw/main.c | 17 +++++++++++++---- > dlls/ddraw/tests/ddrawenum.c | 37 +++++++++++++++++++++++++++++++++ > ++++ > 3 files changed, 51 insertions(+), 5 deletions(-) > <0003-ddraw-Implement-and-test-DirectDrawEnumerateW.txt> The patch looks ok to me(as do the others). I am just curious, how did you run into this function if its unimplemented on Windows? Just curiosity because it exists, or do you have an app that actually calls it?

2 1

Re: comctl32: Move inline to the beginning of the declaration.
by Michael Stefaniuc 08 Oct '09

08 Oct '09

Alexandre, please apply Francois version of this patch. bye michael Michael Stefaniuc wrote: > Signed-off-by: Michael Stefaniuc <mstefani(a)redhat.de> > --- > dlls/comctl32/monthcal.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/dlls/comctl32/monthcal.c b/dlls/comctl32/monthcal.c > index 893a505..fd0d398 100644 > --- a/dlls/comctl32/monthcal.c > +++ b/dlls/comctl32/monthcal.c > @@ -383,7 +383,7 @@ int MONTHCAL_CalculateDayOfWeek(DWORD day, DWORD month, DWORD year) > } > > /* properly updates date to point on next month */ > -void inline MONTHCAL_GetNextMonth(SYSTEMTIME *date) > +inline void MONTHCAL_GetNextMonth(SYSTEMTIME *date) > { > if(++date->wMonth > 12) > { > @@ -395,7 +395,7 @@ void inline MONTHCAL_GetNextMonth(SYSTEMTIME *date) > } > > /* properly updates date to point on prev month */ > -void inline MONTHCAL_GetPrevMonth(SYSTEMTIME *date) > +inline void MONTHCAL_GetPrevMonth(SYSTEMTIME *date) > { > if(--date->wMonth < 1) > {

2 1

Re: comctl32/monthcal: Make MONTHCAL_Get{Prev,Next}Month() static.
by Nikolay Sivov 08 Oct '09

08 Oct '09

Francois Gouget wrote: > --- > > Changed the inline placement as 'static inline' in one chunk seems more > standard. > > dlls/comctl32/monthcal.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > I've changed this to static here: http://www.winehq.org/pipermail/wine-patches/2009-October/079626.html Could you please wait for it?

1 0

Request for review: [PATCH] Resize fullscreen window when DirectDraw changes the display mode [resubmit 4]
by Johan Gill 08 Oct '09

08 Oct '09

On Wed, Jul 29, 2009 at 11:55 PM, Johan Gill <johan.gill(a)gmail.com> wrote: > This patch fixes bug 17215. Since the patch was seemingly dropped, I made > some test improvements and resubmit it. > > The tests pass on Windows XP, and of course Wine. > > Suggested changelog: > In DirectDraw fullscreen mode, make sure the fullscreen window is resized > when the display mode changes > > Johan Gill > > Since I heard nothing on this, I make a request here /Johan Gill

2 5

New winetricks 20091007: new verbs vcexpress2005sp1, nodialogcrash, sandbox, atmlib, psdkwin7
by Dan Kegel 08 Oct '09

08 Oct '09

Another month, another winetricks. A half-dozen new verbs and lots of updates, too. And oddly, winetricks is starting to become useful on Windows. (What can I say? I develop on Windows, too, and I missed winetricks there.) Updates since 20090913: * added mozillabuild, vcexpress2005sp1 * added nodialogcrash (Erik Inge Bolsø) * added sandbox (Erik Inge Bolsø) * support firefox, psdkwin7, vc2005trial verbs under Windows, more or less * support quiet mode on psdkwin7 * updated AutoHotKey, divx, firefox, gdiplus Updates since 20090902 (short changelog from ryandesign): * add atmlib, psdkwin7 * update directx to aug2009 * update msxml4 to MS07-042 * update msxml6 to sp1 * update vcrun2005 and vcrun2005sp1 to MS09-035 * update vcrun2008 and vcrun2008sp1 to MS09-035 Online as always at http://kegel.com/wine/winetricks or http://winezeug.googlecode.com (Bug reports to the issue tracker at the above URL, please.) Thanks to Austin English, Andrew Nguyen, and especially Erik Inge Bolsø.

1 0

Re: tools/winebuild: add FreeBSD support (1/2) (RESEND) (fwd)
by Alexandre Julliard 07 Oct '09

07 Oct '09

Gerald Pfeifer <gerald(a)pfeifer.com> writes: > If you prefer, I'll be happy to convert the code into a switch statement. > Just let me know! That would certainly be more elegant. -- Alexandre Julliard julliard(a)winehq.org

2 1

Multiple wineservers?
by Nicholas LaRoche 07 Oct '09

07 Oct '09

Is it possible to run more than 1 version of wineserver concurrently? -Nick

4 3

Re: [2/2] ntdll: Implement FILE_ATTRIBUTE_HIDDEN and FILE_ATTRIBUTE_SYSTEM support (take 6)
by Detlef Riekenberg 07 Oct '09

07 Oct '09

On Do, 2009-10-01 at 16:59 -0700, Dan Kegel wrote: > +/*********************************************************************** > + * wrap_getxattr > + * Retrieve extended attribute of posix file into given buffer. > + * Use fd if given, else use fname; caller only sets one or the > other. > + */ > +static int wrap_getxattr(int fd, const char *fname, const char > *attrname, char *attrbuf, int attrbuflen) Code, which is called very often, should produce as less overhead as possible. I suggest to use "static inline". Seperate implementations for fd and fname should also make a difference. Your code handle different parameter for the attr functions. Is it possible, that code, which is compiled for one ABI version can call the implementation of the other ABI version? When Wine depends on libattr and libattr-dev after you Patch, all packagers should get this information. -- By by ... Detlef

5 7

Re: kernel32/tests: Save last error before calling lstrcmpA() since it may reset GLE (try 2)
by Alexandre Julliard 07 Oct '09

07 Oct '09

"Ge van Geldorp" <ggeldorp(a)vmware.com> writes: > Changelog: > kernel32/tests: Save last error before calling lstrcmpA() since it may > reset GLE It would be better to split the tests, first check length and last error, then check string contents. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: system.drv16: Merge CreateSystemTimer() into WIN16_CreateSystemTimer().
by Alexandre Julliard 07 Oct '09

07 Oct '09

Francois Gouget <fgouget(a)free.fr> writes: > I did not take the extra step of renaming WIN16_CreateSystemTimer() to > CreateSystemTimer(), CreateSystemTimer16() or something else as the > naming convention was not clear to me. Also, it's possible the > CreateSystemTimer() prototype in include/wine/winuser16.h should be > removed but I assumed it somehow applied to the function exported by > system.drv16.spec but I'm not so sure now. So let me know if further > changes are desired. It should be CreateSystemTimer16, and the whole 32-bit callback support could be removed, since it's no longer called from 32-bit code. -- Alexandre Julliard julliard(a)winehq.org

1 0