December 2009 - Wine-devel - list.winehq.org

Re: mshtml: Added PersistStreamInit_InitNew implementation
by Jacek Caban 04 Dec '09

04 Dec '09

Hi Piotr, Piotr Caban wrote: > --- > dlls/mshtml/mshtml_private.h | 1 + > dlls/mshtml/nsevents.c | 25 ++++++----- > dlls/mshtml/persist.c | 84 +++++++++++++++++++++++++++++------- > dlls/mshtml/tests/htmldoc.c | 95 > ++++++++++++++++++++++++++++++++++++++++-- > 4 files changed, 173 insertions(+), 32 deletions(-) hres = IOleClientSite_QueryInterface(doc->client, &IID_IOleCommandTarget, (void**)&olecmd); if(SUCCEEDED(hres)) { - VARIANT state, progress; - - V_VT(&progress) = VT_I4; - V_I4(&progress) = 0; - IOleCommandTarget_Exec(olecmd, NULL, OLECMDID_SETPROGRESSPOS, OLECMDEXECOPT_DONTPROMPTUSER, - &progress, NULL); - - V_VT(&state) = VT_I4; - V_I4(&state) = 0; - IOleCommandTarget_Exec(olecmd, NULL, OLECMDID_SETDOWNLOADSTATE, OLECMDEXECOPT_DONTPROMPTUSER, - &state, NULL); + if(doc->download_state) { + VARIANT state, progress; + + V_VT(&progress) = VT_I4; + V_I4(&progress) = 0; + IOleCommandTarget_Exec(olecmd, NULL, OLECMDID_SETPROGRESSPOS, + OLECMDEXECOPT_DONTPROMPTUSER, &progress, NULL); + + V_VT(&state) = VT_I4; + V_I4(&state) = 0; + IOleCommandTarget_Exec(olecmd, NULL, OLECMDID_SETDOWNLOADSTATE, + OLECMDEXECOPT_DONTPROMPTUSER, &state, NULL); + } + doc->download_state = 0; You should clear download_state if client doesn't implement IOleCommandTarget interface too. Thanks, Jacek

1 0

Re: [4/6] WineD3D: Infrastructure to render swapchains to a FBO
by Henri Verbeet 04 Dec '09

04 Dec '09

2009/12/4 Stefan Dösinger <stefan(a)codeweavers.com>: > hr = create_primary_opengl_context(iface, (IWineD3DSwapChain *) swapchain); > + if(SUCCEEDED(hr)) > + { > + swapchain->context[0]->render_offscreen = swapchain->render_to_fbo; > + } This should probably be part of create_primary_opengl_context(). > +static inline void swapchain_blit(IWineD3DSwapChainImpl *This, struct wined3d_context *context) It's kind of obvious because of the "context" parameter, but for consistency please document the requirement for the caller to provide an active context.

1 0

Re: [2/6] WineD3D: A function for checking if a surface is offscreen
by Henri Verbeet 04 Dec '09

04 Dec '09

2009/12/4 Stefan Dösinger <stefan(a)codeweavers.com>: > GLenum buffer = surface_get_gl_buffer((IWineD3DSurface *) This, (IWineD3DSwapChain *)swapchain); > + > + IWineD3DSurface_GetContainer((IWineD3DSurface *) This, &IID_IWineD3DSwapChain, (void **)&swapchain); That doesn't look quite right. Also, you should check the return value for GetContainer().

1 0

Locale data update request
by Nikolay Sivov 04 Dec '09

04 Dec '09

Hi, guys. I've finally got some time today to complete genitive name support in GetDateFormat(). Now to make it useful for users I'd like to ask translators to update NLS files for languages that use this month form. I'm sure it's present in some Slavonic languages like Ukrainian and Belorussian, maybe some others (Asian?) too. Thanks.

1 0

Anti aliased fonts in wine - minimum font size
by Avery Pennarun 04 Dec '09

04 Dec '09

Hi all, I'm using Microsoft Office 2002 under wine. According to the instructions here: http://www.wine-reviews.net/wine-reviews/tips-n-tricks/how-to-enable-font-a… ...I've enabled font anti-aliasing, and it does work for fonts above a particular point size. However, it seems to turn itself off below a certain size. How can I configure the minimum font size at which to allow anti-aliasing? I've looked through the wine source and didn't see any obvious references to font size in the anti-aliasing-related code. Thanks, Avery

4 7

Re: ntdll: add partial support for HEAP_FREE_CHECKING_ENABLED heap overrun detection (take 3)
by Alexandre Julliard 04 Dec '09

04 Dec '09

Dan Kegel <dank(a)kegel.com> writes: > @@ -1261,6 +1297,8 @@ HANDLE WINAPI RtlCreateHeap( ULONG flags, PVOID addr, SIZE_T totalSize, SIZE_T c > totalSize = HEAP_DEF_SIZE; > flags |= HEAP_GROWABLE; > } > + if (NtCurrentTeb() && NtCurrentTeb()->Peb && (NtCurrentTeb()->Peb->NtGlobalFlag & FLG_HEAP_ENABLE_FREE_CHECK)) > + flags |= HEAP_FREE_CHECKING_ENABLED; This can't work, you can't use NtCurrentTeb before the TEB is properly initialized. -- Alexandre Julliard julliard(a)winehq.org

1 0

WineConf 2009 videos
by Julius Schwartzenberg 04 Dec '09

04 Dec '09

Hi, All the videos from WineConf 2009 are online now. The links can be found on the wiki page: http://wiki.winehq.org/WineConf2009 Because my camera isn't the greatest, Audacity was used to remove the noise from the audio track and using Kdenlive with melt the keynote video was filtered to make things somewhat visible again (the lights were off during that presentation). Thanks a lot to Roderick Colenbrander and grub_booter from #kdenlive, who helped me a lot with all of this :) Let me know if you have any comments on the videos! Thanks, Julius

1 0

d3d8 test failure, more details.
by David Anderson 04 Dec '09

04 Dec '09

Thanks to James Mckenzie and Austin English for earlier hints. I've installed more stuff (ubuntu packages) and spent a bit more time with d3d8. I assume most people get these tests to work, so I'm a bit distressed I cannot seem to get them to work properly, 100%. The large amount of test code that 'just works' is impressive. I'd be reassured I was not breaking things in any patch I submit if I could figure out why I'm not getting 100% (that is, what the heck might I be doing wrong?). Any hints/suggestions would be welcome. In dlls/d3d8/tests/visual.c one has the call that gets errors: 1357 if (caps.VertexShaderVersion >= D3DVS_VERSION(1, 1)) 1358 { 1359 test_rcp_rsq(device_ptr); 1360 } and test_rcp_rsq() does some *VertexShade calls not made elsewhere. The last few lines of 'make test' output in d3d8/tests are: fixme:d3d:WineD3D_ChoosePixelFormat Add OpenGL context recreation support to SetDepthStencilSurface fixme:d3d_draw:drawPrimitive Using software emulation because manual fog coordinates are provided visual.c:598: Test failed: Color components differ: c1 = 80, c2 = 00, c3 = 80 visual.c:632: Test failed: Color components differ: c1 = 80, c2 = 00, c3 = 80 visual.c:634: Test failed: Color component value is 80 make: *** [visual.ok] Error 3 These failures are in test_rcp_rsq(), the function called at line 1359. Note that other calls to to getPixelColor() (a function in the test code, tests/visual.c) work fine. Only when a couple of special Shaders are invoked does getPixelColor() get something the test does not expect. Possibly IDirect3DDevice8_CreateVertexShader() is not setting things up right or somehow the 'DRI' code in package libgl1-mesa-dri is not being effective? I stuck a couple sleep(5) calls in the test source (to slow things down at the error points) and I can see the shader code has an effect visually (the test code generates small-ish windows with color blocks). Compiling d3d8 and its test code -g (that is, no -O2) gets exactly the same results. Ubuntu9.10. Intel(R) Core(TM)2 Duo CPU E8500 cpu. ATI 4350 PCI graphics. q2 616: dpkg-query -l '*mesa*' Desired=Unknown/Install/Remove/Purge/Hold | Status=Not/Inst/Cfg-files/Unpacked/Failed-cfg/Half-inst/trig-aWait/Trig-pend |/ Err?=(none)/Reinst-required (Status,Err: uppercase=bad) ||/ Name Version Description +++-==============-==============-============================================ un libgl1-mesa <none> (no description available) ii libgl1-mesa-de 7.6.0-1ubuntu4 A free implementation of the OpenGL API -- G ii libgl1-mesa-dr 7.6.0-1ubuntu4 A free implementation of the OpenGL API -- D ii libgl1-mesa-dr 7.6.0-1ubuntu4 Debugging symbols for the Mesa DRI modules un libgl1-mesa-dr <none> (no description available) ii libgl1-mesa-gl 7.6.0-1ubuntu4 A free implementation of the OpenGL API -- G ii libgl1-mesa-gl 7.6.0-1ubuntu4 Debugging symbols for the Mesa GLX runtime un libgl1-mesa-sw <none> (no description available) ii libglu1-mesa 7.6.0-1ubuntu4 The OpenGL utility library (GLU) ii libglu1-mesa-d 7.6.0-1ubuntu4 The OpenGL utility library -- development fi ii mesa-common-de 7.6.0-1ubuntu4 Developer documentation for Mesa un mesa-glide2-de <none> (no description available) ii mesa-utils 7.6.0-1ubuntu4 Miscellaneous Mesa GL utilities un mesag-dev <none> (no description available) un mesag3 <none> (no description available) un mesag3+ggi-dev <none> (no description available) un xlibmesa-dev <none> (no description available) un xlibmesa-dri <none> (no description available) ii xlibmesa-gl-de 1:7.4+3ubuntu1 transitional package for Debian etch un xlibmesa-glu-d <none> (no description available) un xlibmesa3 <none> (no description available) un xlibosmesa-dev <none> (no description available) The 'libgl1-mesa-swx11*' packages are not installed, swx11 seems to be incompatible with some of the mesa stuff above (according to synaptic package manager). Any hints/suggestions would be welcome.

2 1

Please Review - Revised OS X Application Bundle patch
by Steven Edwards 04 Dec '09

04 Dec '09

Hi, If any of the OS X hackers have time, could you guys take a look at the following patch? I'd like to get it in to move on to more interesting stuff like the icon generation cleanup in winemenubuilder using windowscodecs.dll, OS X association support and perhaps even proper dock integration. I've been testing this with the PowerPoint 2003 viewer and it works for me. I'd be interested in hearing if anyone has trouble with other applications. You need to have Wine installed somewhere in your path or you will need to manually hardcode the path to your wine executable in the script generator just like with the menu builder on the linux side. I don't like the amount of #ifdef'ing I had to do but didn't really see a better way. I know before Alexandre will accept he most likely will want me to - Cleanup comments a bit. - Maybe shorten some of the variable and function names So I am looking for any other feedback you have. Documentation on bundles can be found at the following location http://developer.apple.com/mac/library/documentation/CoreFoundation/Concept… Changelog: Implement Application Bundle support for OS X using the CoreFoundation to generate Information Property Lists Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: shell32: Implement IPersistFile_fnSaveCompleted
by Nikolay Sivov 03 Dec '09

03 Dec '09

Vladimir Pankratov wrote: > Hello all. > > Implemented IPersistFile_fnSaveCompleted. > > changed files: > dlls/shell32/shelllink.c > > Thanks. --- + TRACE("(%p)->(%s)\n",This,debugstr_w(pszFileName)); + return S_OK; /* MSDN says: return value S_OK, returned in all cases */ --- You shouldn't care much of what MSDN says, please provide some tests.

1 0