February 2009 - Wine-devel - list.winehq.org

Need help for D3DXComputeSphereBounding
by paulo lesgaz 04 Feb '09

04 Feb '09

Hello, I am trying to implement D3DXComputerSphereBounding. The attached test cases success with a native d3dx9 but fail with a native d3dx8. Can anyone could explain why? Thanks in advance

1 0

Happy user says: "You’ve done the impossible, and it is good."
by Dan Kegel 04 Feb '09

04 Feb '09

A user is declaring that Wine has succeeded: http://loobin.wordpress.com/2009/01/13/wine-ascendant/ http://loobin.wordpress.com/2009/02/03/wine-going-production/

1 0

Re: MSVCRT: Still problems in ASCII Mode
by Dan Kegel 04 Feb '09

04 Feb '09

Thanks. Please don't use rand() in testcases, though. Would a constant 'a' suffice in this case? Which app did you find this in, btw? On Tue, Feb 3, 2009 at 1:55 PM, Uwe Bonnes <bon(a)elektron.ikp.physik.tu-darmstadt.de> wrote: > Hello, > > it seems that in ASCII mode, fseek() may disturb reading. Appended patch > adds a todo_wine. > > Bye > -- > Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de > > Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt > --------- Tel. 06151 162516 -------- Fax. 06151 164321 ---------- > diff --git a/dlls/msvcrt/tests/file.c b/dlls/msvcrt/tests/file.c > index 9032e51..2a72212 100644 > --- a/dlls/msvcrt/tests/file.c > +++ b/dlls/msvcrt/tests/file.c > @@ -306,7 +306,8 @@ static void test_asciimode(void) > { > FILE *fp; > char buf[64]; > - int c, i, j; > + int c, i, j, done, count1, count2; > + > > /* Simple test of CR CR LF handling. Test both fgets and fread code paths, they're different! */ > fp = fopen("ascii.tst", "wb"); > @@ -372,6 +373,46 @@ static void test_asciimode(void) > ok((c = fgetc(fp)) == '1', "fgetc fails to read next char when positioned on \\r\n"); > fclose(fp); > > + fp= fopen("ascii.tst","wb"); > + for (i=0; i<1000; i++) > + { > + unsigned char c = (rand()+ ' ') & 0x7f; > + if (isgraph(c) || (c == ' ')) > + fputc(c, fp); > + else if ((c == '\r') || (c == '\n')) > + fputs("\r\n", fp); > + } > + fclose(fp); > + > + done = 0; > + count1 = 0; > + > + fp = fopen("ascii.tst", "r"); > + while (!done) > + { > + c= fgetc(fp); > + if (c == EOF) > + done = 1; > + else if (isalnum(c)) > + count1 ++; > + } > + fclose(fp); > + > + done = 0; > + count2 = 0; > + > + fp = fopen("ascii.tst", "r"); > + while (!done) > + { > + c= fgetc(fp); > + fseek(fp, 0, SEEK_CUR); > + if (c == EOF) > + done = 1; > + else if (isalnum(c)) > + count2 ++; > + } > + fclose(fp); > + todo_wine ok((count1 == count2), "fseek caused short read %d vs %d\n", count2, count1); > unlink("ascii.tst"); > } > >

2 2

Re: shdocvw: Correct OnAmbientPropertyChange regession
by Jacek Caban 03 Feb '09

03 Feb '09

Alistair Leslie-Hughes wrote: > Hi, > After testing on XP, it appears that OnAmbientPropertyChange when > passwed DISP_UNKNOWN doesnt check all properties. > > Changelog: > shdocvw: Correct OnAmbientPropertyChange regession + CHECK_NOT_CALLED(Invoke_AMBIENT_OFFLINEIFNOTCONNECTED); + CHECK_NOT_CALLED(Invoke_AMBIENT_SILENT); + CHECK_NOT_CALLED(Invoke_AMBIENT_USERMODE); + CHECK_NOT_CALLED(Invoke_AMBIENT_DLCONTROL); + CHECK_NOT_CALLED(Invoke_AMBIENT_USERAGENT); + CHECK_NOT_CALLED(Invoke_AMBIENT_PALETTE); These checks don't make sense here. If you don't set these calls as expected, CHECK_EXPECT will fail when they are called. Jacek

2 1

Fixing AppDB once and for all
by Zachary Goldberg 03 Feb '09

03 Feb '09

All, So it seems to be almost every other day now when somebody mentions how broken the appdb rating system is. This "broken-ness" has had several high level discussions on Wine-Devel. There have also been many, many proposed solutions to this problem. I do not wish to discuss these problems or these solutions in this thread. It is time something was done about this. By done I mean agreed upon (probably the harder part) then implemented in code and published to the winehq server(s). I'de like to arrange an IRC discussion for all those interested in finalizing an attack plan, and then assigning the responsibility of doing it to somebody who is capable and has the time (perhaps myself). Lets (arbitrarily) set a time for the chat at: When: 11PM UTC (6PM EST) 2/6/09 (Friday) Where: #winehackers If this arbitrary time seems to be poorly chosen for a large number of people then please propose an alternative well in advance so all are aware of it. --Zach

6 6

Re: Fixing AppDB once and for all
by James Mckenzie 03 Feb '09

03 Feb '09

Zachary Goldberg <zgold(a)bluesata.com> >Sent: Feb 3, 2009 12:27 PM >To: James Mckenzie <jjmckenzie51(a)earthlink.net> >Cc: Wine Devel <wine-devel(a)winehq.org>, Jeremy Newman <jnewman(a)codeweavers.com> >Subject: Re: Fixing AppDB once and for all > >2009/2/3 James Mckenzie <jjmckenzie51(a)earthlink.net>: >> This would be too early for people on the West Coast of the United States by about three hours. >> >> No time will be satisfactory for all people who work on this project. >> >> What I feel is necessary at this point is to collect who lives in what time zone so that we incovience as few people as possible. >> >> Since this would be Saturday in Asia, this time may work for the majority of the people on this list. >> >> Also, will there be a transcript of the discussion and where will it be placed since this has a major impact on the functionality of the Applications Database. >> >> James McKenzie >> >> > >I have made a wiki on winehq with an agenda which will be updated with >the results (and maybe transcript?) of the conversation. > >http://wiki.winehq.org/AppDBUpgrades Thank you for your forward thinking and thoughtfulness. I look forward to reading the Wiki and reviewing what is determined during the IRC conversation as I will not be able to attend. James McKenzie

1 0

Re: wine honor roll slashdotted
by James Mckenzie 03 Feb '09

03 Feb '09

Dan Kegel <dank(a)kegel.com> wrote: >Sent: Feb 3, 2009 6:48 AM >To: Wine Devel <wine-devel(a)winehq.org> >Subject: wine honor roll slashdotted > >http://tech.slashdot.org/article.pl?sid=09/02/03/0112249 > >One comment mentions the grade inflation on the appdb, >i.e. platinum apps that have not been thoroughly tested >or don't really qualify as platinum... > Dan: Sadly, I agree with the grade inflation. We need a grading interface that will generate whether or not an application is Plat/Gold/Silver/Bronze/Garbage based upon user input. This usually stops the inflation. James McKenzie

4 3

Re: advapi32: add Security Label sids used by IE7
by Paul Vriens 03 Feb '09

03 Feb '09

Aric Stewart wrote: > --- > dlls/advapi32/security.c | 4 ++++ > include/winnt.h | 16 +++++++++++++++- > 2 files changed, 19 insertions(+), 1 deletions(-) > > > > ------------------------------------------------------------------------ > > You added WinUntrustedLabelSid to winnt.h but not to security.c. Is that correct? -- Cheers, Paul.

2 1

Re: kernel32/tests: Add a CreateMutex test. (Win9X todo)
by Dmitry Timoshkov 03 Feb '09

03 Feb '09

"Florian Tobias Schandinat" <FlorianSchandinat(a)gmx.de> wrote: > this test shows a difference between Win9X and NT. (tested on Win98SE > and WinXP) Some apps expect the Win9X behaviour to work. I don't know > what's the right way to fix it. Any advice or patch is welcome. How do that apps work under NT based Windows versions like XP or Vista? -- Dmitry.

2 1

Re: winedos: Improve PIT emulation.
by Alexandre Julliard 03 Feb '09

03 Feb '09

Florian Tobias Schandinat <FlorianSchandinat(a)gmx.de> writes: > + /* Convert: time counter -> PIT counter > + * GetSystemTimeAsFileTime: 10000000 Hz > + * PIT frequency: 1193182 Hz */ > + val = (DWORD)(val - delta*1193182./10000000.) % (maxval + 1); You should probably use QueryPerformanceCounter as it already uses the correct frequency. -- Alexandre Julliard julliard(a)winehq.org

2 1