March 2009 - Wine-devel - list.winehq.org

qmgr test failures
by Austin English 11 Mar '09

11 Mar '09

Howdy Rob, Looks like one of your recent qmgr patches added failure to qmgr: http://test.winehq.org/data/1b9a6fb4e9f5a76f1ca352bef121689df02d9289/#group… file.c:121: Test failed: GetRemoteName failed: 800706c6 file.c:124: Tests skipped: Unable to get remote name of test_file. file.c:138: Test failed: GetLocalName failed: 800706c6 file.c:141: Tests skipped: Unable to get local name of test_file. file: 6 tests executed (0 marked as todo, 2 failures), 2 skipped. qmgr: 1 tests executed (0 marked as todo, 0 failures), 0 skipped. qmgr.c:217: Test failed: Adding a job in another process failed qmgr: 11 tests executed (0 marked as todo, 1 failure), 0 skipped. Could you take a look? -- -Austin

2 2

Fwd: Disabling File attachments on Wiki
by David Gerard 11 Mar '09

11 Mar '09

to list as well ---------- Forwarded message ---------- From: David Gerard <dgerard(a)gmail.com> Date: 2009/3/11 Subject: Re: Disabling File attachments on Wiki To: Dimi Paun <dimi(a)lattica.com> 2009/3/11 Dimi Paun <dimi(a)lattica.com>: > On Wed, 2009-03-11 at 08:02 -0600, Vitaliy Margolen wrote: >> Anyone? Also how about blocking this IP: 213.155.0.32 ? > Not sure how we can block that IP easily. If it has to do > with iptables, forget it. You add a line to moin_config.py : http://moinmo.in/AntiSpamFeatures#Black_Lists_--_detecting_spam_by_source MoinMoin doesn't have the sophisticated anti-vandal capabilities of MediaWiki, but it's far from helpless. - d.

1 0

Re: [3/6] wined3d: The adapters array should be owned by IWineD3DImpl.
by Allan Tong 11 Mar '09

11 Mar '09

On Wed, Mar 11, 2009 at 5:18 AM, Henri Verbeet <hverbeet(a)codeweavers.com> wrote: > @@ -4051,10 +4097,11 @@ static void WINE_GLAPI diffuse_d3dcolor(const void *data) > static void WINE_GLAPI specular_d3dcolor(const void *data) > { > DWORD specularColor = *((const DWORD *)data); > + GLbyte d[] = {D3DCOLOR_B_R(specularColor), > + D3DCOLOR_B_G(specularColor), > + D3DCOLOR_B_B(specularColor)}; > > - GL_EXTCALL(glSecondaryColor3ubEXT)(D3DCOLOR_B_R(specularColor), > - D3DCOLOR_B_G(specularColor), > - D3DCOLOR_B_B(specularColor)); > + specular_func_3ubv(d); > } > > static void WINE_GLAPI warn_no_specular_func(const void *data) > @@ -4110,6 +4157,7 @@ static void fillGLAttribFuncs(const WineD3D_GL_Info *gl_info) > } > specular_funcs[WINED3DDECLTYPE_FLOAT4] = invalid_func; > if(GL_SUPPORT(EXT_SECONDARY_COLOR)) { > + specular_func_3ubv = (glAttribFunc)GL_EXTCALL(glSecondaryColor3ubvEXT); > specular_funcs[WINED3DDECLTYPE_D3DCOLOR] = specular_d3dcolor; > } else { > specular_funcs[WINED3DDECLTYPE_D3DCOLOR] = warn_no_specular_func; This looks like an unrelated change. > @@ -4182,7 +4231,7 @@ BOOL InitAdapters(void) { > /* No need to hold any lock. The calling library makes sure only one thread calls > * wined3d simultaneously > */ > - if(numAdapters > 0) return Adapters[0].opengl; > + if (This->adapter_count) return This->adapters[0].opengl; > > TRACE("Initializing adapters\n"); Is this check still necessary? InitAdapters should only be called once per IWineD3DImpl object. - Allan

2 1

Re: [ddraw/tests 1/2] Fix a few test failures on W2K (VMware?)
by Paul Vriens 11 Mar '09

11 Mar '09

Paul Vriens wrote: > Hi, > > As acknowledged by Stefan, there is no point in testing colors if something > isn't drawn. > > I'm not sure if this is W2K specific or W2K in combination with VMware. > > Changelog > Fix a few test failures on W2K (VMware?) > Please ignore this series of 2. I'm first going to check the remark the Henri made about a possible missing EndScene. -- Cheers, Paul.

1 0

Re: [ddraw/tests 2/2] Mark some more tests are broken() on W2K
by Stefan Dösinger 11 Mar '09

11 Mar '09

Am Mittwoch, 11. März 2009 12:07:27 schrieb Paul Vriens: > + ok(hr == D3D_OK || > + broken(hr == D3DERR_SCENE_IN_SCENE), /* W2K */ > + "IDirect3DDevice7_BeginScene failed with %08x\n", hr); I don't like that one. I think I wrote those tests on Win2K partially, so I'd blame it on Vmware. Its ok to skip checking the colors to reduce follow-up tests, but I dislike accepting random errors because Vmware returns them. If you find a real Windows hardware driver that returns this error its ok to accept D3DERR_SCENE_IN_SCENE as a return value

3 2

ddraw/visual tests
by Paul Vriens 11 Mar '09

11 Mar '09

Hi Stefan, As you wrote most of the tests: I'm looking into some of the ddraw:visual failures (windows 2000 and I guess only VMware). Several tests draw quads but only if _BeginScene succeeded. Is it useful at all to check the colors afterwards if the quads are not drawn in the first place? I don't want to mark all those failures as broken() if failing _BeginScene could just do with a win_skip() for the test of a particular test. -- Cheers, Paul.

2 1

Wiki challenge question on user account creation
by John Klehm 11 Mar '09

11 Mar '09

Hey, After months of browseing the wiki recent changes rss feed I've been irked enough to try and see what could be done about it. I'm sure everyone is having fun playing whack a mole with the wikispam but I was hoping that we could do something similar to the forum account creation "Who is the maintainer of Wine" question. I'm hoping that would cut down on a large portion of the wiki spam, which is now up to several bogus posts per day. (hats off to those that have been scrubbing it clean!) Luckily it seems MoinMoin has a feature that provides exactly this: http://moinmo.in/TextCha However on that page it only mentions a challenge question for commits which wasn't quite what I wanted so I took a look at the source for stable release 1.8.2 http://hg.moinmo.in/moin/1.8/file/1f0db10c207f/MoinMoin/action/newaccount.p… Seems they have the challenge question for user account creation in that version. What's involved in upgrading? How can I get the current winehq wiki code/data? I would be interested in helping test this or patching but I'm not sure how to import the data into my test server. Regards, --John Klehm

6 11

Re: Fwd: [Wine] Re: The pros and cons of a wiki AppDB
by James Mckenzie 11 Mar '09

11 Mar '09

David Gerard <dgerard(a)gmail.com> wrote on March 8th: > >2009/3/8 James Mckenzie <jjmckenzie51(a)earthlink.net>: > >> Would you be willing to clean out the ash and trash that will show up with an open Wiki? > > >I already said I would, yes - that the only reason for not just >starting one is to avoid massive duplication of effort. > If we move to an open Wiki, be prepared to be very busy. I've seen spambots get past most, if not all, of the verification systems and bomb away. I've read where several systems had to shut them down for fear of being sued. At the present time, we have verification for exactly that reason. To keep the spam out and to pre-edit those entries that do not provide all of the information needed. > >> I don't have the time to do this and it REALLY sounds like you are volunteering since you are pushing this issue so hard. See there are VALID reasons for doing things the way we do them. > > >I'm sure there are. > I would love to see a Wiki, with pre-editing of the entries. This is possible, but would not address the problem you raised. James McKenzie

4 4

Re: mshtml: Implement IHTMLStyle4 get/put textOverflow
by Alistair Leslie-Hughes 10 Mar '09

10 Mar '09

Ignore this patch, we'll have to wait until Firefox 3.1 before CSS3 is supported. I forgot there was wine_todo. "Alistair Leslie-Hughes" <leslie_alistair(a)hotmail.com> wrote in message news:49B726BB.4000009(a)hotmail.com... > Hi, > > Changelog: > mshtml: Implement IHTMLStyle4 get/put textOverflow > > Best Regards > Alistair Leslie-Hughes > > > >

1 0

Re: winemaker: add project-parse function
by Francois Gouget 10 Mar '09

10 Mar '09

Here are some quick comments: You cannot add functions that are not used. So this patch should include the following lines from patch 0004: + if (defined $opt_work_dir) { + # Now scan the directory tree looking for source files and, maybe, targets + print "Scanning the source directories...\n"; + source_scan_directory(\@main_project,"","",0); + @projects=sort { @$a[$P_PATH] cmp @$b[$P_PATH] } @projects; + } elsif (defined $opt_work_file) { + if ($opt_work_file =~ /.dsp$/i or $opt_work_file =~ /.vcproj$/i) { + source_scan_project_file(\@main_project,0,$opt_work_file); + } And the relevant $opt_work_file lines so that it's functional. The vcproj parser is still pushing compilation options only to CXXEXTRA. I believe dsp files can only have one target. Can vcproj files have multiple targets? If not it should be possible to avoid the loop on %targets. Also, I think the dsp parser at least does not need @std_imports because if I'm not mistaken all the libraries to link with are explicitely mentionned in the file. It also seems like we should not have to play guessing games to 'Match sources'. So I think it should be possible to simplify that part of the code. The patch does not use $has_headers anymore but it still declares and sets it. Still a few unneeded '."' and '".' (concatenation issues). Could you move source_scan_project_file() and source_scan_workspace_file() above source_scan_directory()? That way later on the latter will be able to call the former without having to reorder the functions. -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ "Utilisateur" (nom commun) : Mot utilisé par les informaticiens en lieu et place d'"idiot".

2 1