March 2009 - Wine-devel - list.winehq.org

dlls/userenv: fixed stubs GetUserProfileDirectoryW/A (resend)
by Andreas Rosenberg 30 Mar '09

30 Mar '09

2 2

Re: 16bit code generation
by Hin-Tak Leung 30 Mar '09

30 Mar '09

I wonder how bad is it to port some old version of djgpp forward? ( http://www.delorie.com/djgpp/history.html ) - it is a fork of gcc as far as I see and did support 16-bit code generation at one time?

2 1

Re: Patch for specifying video card name and driver
by Henri Verbeet 30 Mar '09

30 Mar '09

2009/3/30 John Whitlock <John-Whitlock(a)ieee.org>: > This patch adds the ability to specify the name and driver for the video > card using registry keys (Current_user/Software/Wine/Direct3D). This is > similar to existing code in wined3d, and has been used since 1.1.8 to get > Fallout 3 working. > Either you didn't write this, or you made the exact same errors as in the other patch doing the same thing I already commented on.

1 0

Re: GetTempFileName should return 0 when the path isn't valid
by Vitaliy Margolen 30 Mar '09

30 Mar '09

Oskar Eisemuth wrote: > GetTempFileName should check the path and should return zero if it isn't a directory. > See Bug 17875 > Tests verifying the behavior will be nice. Shouldn't be too hard to add. Vitaliy.

1 0

urlmon ftp protocol failures on Windows
by Ge van Geldorp 30 Mar '09

30 Mar '09

Hi Jacek, I've been investigating the failures in the urlmon ftp protocol tests that show up on quite a few WinXP and higher machines. It seems to me that there is an inherent race condition in the test. The main thread waits in line 1822 until IInternetProtocolSink_Switch has been called. It will then call CHECK_CALLED(Switch) and SET_EXPECT(Switch). However, nothing prevents a background thread from calling IInternetProtocolSink_Switch again before SET_EXPECT(Switch) in the main thread is complete. In fact, if I add a Sleep(100) between the WaitForSingleObject() in line 1822 and the CHECK_CALLED() on the next line, the failures that show up now and then on test.winehq.org become reproducible every time. I believe the attached patch fixes the problem, it breaks the current assumption that there's a 1:1 relationship between IInternetProtocolSinc_Switch() and IInternetProtocol_Read() calls. Before shipping it off to wine-patches, I'd like your opinion, do you think this is the correct solution? Thanks, Ge.

2 1

Re: mciqtz32: Add basic play capability
by Detlef Riekenberg 30 Mar '09

30 Mar '09

On Sa, 2009-03-28 at 16:36 +0100, Christian Costa wrote: > + hr = CoCreateInstance(&CLSID_FilterGraph, NULL, > CLSCTX_INPROC_SERVER, &IID_IGraphBuilder, (LPVOID*)&wma->pgraph); > + if (FAILED(hr)) { > + TRACE("Cannot create filtergraph (hr = %x)\n", hr); > + return MCIERR_INTERNAL; > + } Again TABs in the Code. > + > + hr = IGraphBuilder_QueryInterface(wma->pgraph, > &IID_IMediaControl, (LPVOID*)&wma->pmctrl); > + if (FAILED(hr)) { > + TRACE("Cannot get IMediaControl interface (hr = %x)\n", hr); > + return MCIERR_INTERNAL; TAB again. And while i read this quote: You leak wma->pmctrl here. -- By by ... Detlef

2 1

Re: wined3d [try 4]: SetDepthStencilSurface is always called when AutoDepthStencil is enabled
by Henri Verbeet 30 Mar '09

30 Mar '09

2009/3/29 David Adam <david.adam.cnrs(a)gmail.com>: > - return WINED3DERR_INVALIDCALL; > + HRESULT hrc; You're still using 9 space indentation.

1 0

Re: WineD3D: Check for the presence of wglGetExtensionsStringARB
by Robert Millan 30 Mar '09

30 Mar '09

On Sun, Mar 29, 2009 at 10:11:19PM +0200, Roderick Colenbrander wrote: > Hi, > > Don't call wglGetExtensionsStringARB when it isn't around. After this patch > WineD3D can work unpatched on VirtualBox. Hi, I can confirm this works fine on VirtualBox. Thanks Roderick -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."

1 0

Re: wined3d [try3]: SetDepthStencilSurface is always called when AutoDepthStencil is enabled
by Henri Verbeet 30 Mar '09

30 Mar '09

2009/3/29 David Adam <david.adam.cnrs(a)gmail.com>: > + hrc = IWineD3DDeviceParent_CreateDepthStencilSurface(This->device_parent, > + NULL, > + pPresentationParameters->BackBufferWidth, > + pPresentationParameters->BackBufferHeight, > + pPresentationParameters->AutoDepthStencilFormat, > + pPresentationParameters->MultiSampleType, > + pPresentationParameters->MultiSampleQuality, > + FALSE, > + &This->auto_depth_stencil_buffer); Even though I don't think any implementation of IWineD3DDeviceParent_CreateDepthStencilSurface actually uses the second parameter, you should pass "This->parent" rather than NULL there. > + if (SUCCEEDED(hrc)) > + IWineD3DDevice_SetDepthStencilSurface(iface, This->auto_depth_stencil_buffer); This is redundant, the code a couple of lines down will also set the depth stencil. > + else { > + ERR("Failed to create the auto depth stencil\n");· > + return WINED3DERR_INVALIDCALL; > + } You're leaking the swapchain here. Also, not trying to be picky, but could you please fix the indentation?

1 0

winetricks:
by Rico Schüller 29 Mar '09

29 Mar '09

Hi, this patch let winetricks only overwrite d3dx9_36.dll, because all other d3dx9_xx.dlls should be redirected by wine's implementation, so this shouldn't be needed for this dlls. Cheers Rico

2 1