March 2009 - Wine-devel - list.winehq.org

Re: gdi32: don't compile printdtv16 on 64-bit
by Alexandre Julliard 25 Mar '09

25 Mar '09

Austin English <austinenglish(a)gmail.com> writes: > diff --git a/dlls/gdi32/gdi32.spec b/dlls/gdi32/gdi32.spec > index 36a8fb1..da77ad5 100644 > --- a/dlls/gdi32/gdi32.spec > +++ b/dlls/gdi32/gdi32.spec > @@ -512,15 +512,15 @@ > ################################################################ > # Wine extensions: Win16 functions that are needed by other dlls > # > -@ stdcall CloseJob16(long) > -@ stdcall DrvGetPrinterData16(str str ptr ptr long ptr) > -@ stdcall DrvSetPrinterData16(str str long ptr long) > -@ stdcall GetDCHook(long ptr) > -@ stdcall OpenJob16(str str long) > -@ stdcall SelectVisRgn(long long) > -@ stdcall SetDCHook(long ptr long) > -@ stdcall SetHookFlags(long long) > -@ stdcall WriteSpool16(long ptr long) > +@ stdcall -i386 CloseJob16(long) > +@ stdcall -i386 DrvGetPrinterData16(str str ptr ptr long ptr) > +@ stdcall -i386 DrvSetPrinterData16(str str long ptr long) > +@ stdcall -i386 GetDCHook(long ptr) > +@ stdcall -i386 OpenJob16(str str long) > +@ stdcall -i386 SelectVisRgn(long long) > +@ stdcall -i386 SetDCHook(long ptr long) > +@ stdcall -i386 SetHookFlags(long long) > +@ stdcall -i386 WriteSpool16(long ptr long) You can't do that, 16-bit code can be disabled on i386 too. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH 5/6] kernel32: Fix an off-by-one error.
by Alexandre Julliard 24 Mar '09

24 Mar '09

James Hawkins <truiken(a)gmail.com> writes: > --- > dlls/kernel32/profile.c | 2 +- > dlls/kernel32/tests/profile.c | 30 ++++++------------------------ > 2 files changed, 7 insertions(+), 25 deletions(-) > > diff --git a/dlls/kernel32/profile.c b/dlls/kernel32/profile.c > index 5d563a5..b6ad6d0 100644 > --- a/dlls/kernel32/profile.c > +++ b/dlls/kernel32/profile.c > @@ -396,7 +396,7 @@ static PROFILESECTION *PROFILE_Load(HANDLE hFile, ENCODING * pEncoding) > first_section->name[0] = 0; > first_section->key = NULL; > first_section->next = NULL; > - next_section = &first_section->next; > + next_section = &first_section; This cannot be right. What happens to the original first_section then? -- Alexandre Julliard julliard(a)winehq.org

2 3

Serial port conformance tests
by Chris Teague 24 Mar '09

24 Mar '09

I'm new to wine, looking into serial communications. I have a failing scenario in a application, and I'd like to write a conformance test to demonstrate/document the issue. I looked in dlls/ntdll/tests but did not see any serial port related tests - did I miss them or do none exist yet? Assuming none exist, a very useful tool would be a serial port loopback device. Rather than require conformance testers to attach a hardware loopback device (NULL modem) to a physical port, could we create some virtual ports in wine and connect them together? Maybe com98 and com99 for example? Anything written to one of the ports would be sent to the other one. On Windows this can be done with a device driver, one example is com0com (http://com0com.sourceforge.net/) Is this a reasonable approach? Thanks, Chris

4 3

iphlpapi patch - what does it need?
by David Gerard 24 Mar '09

24 Mar '09

http://bugs.winehq.org/show_bug.cgi?id=14574 has a patch for iphlpapi that stubs GetAdaptersAddresses(). Just this stub is enough to get Safari 4 working. Patch is: http://bugs.winehq.org/attachment.cgi?id=19704 http://bugs.winehq.org/attachment.cgi?id=19705 Do these need anything done before they're fit to go in? (These are not my patches - I'd just like Safari 4 working.) - d.

1 0

Re: setupapi: Initialization fix
by Andrew Talbot 24 Mar '09

24 Mar '09

Andrew Talbot wrote: > The TRACE() potentially reporting the value of "newpath" must be placed > after where that variable is first set. > I suspect that this patch still doesn't fix the problem. Feedback or expert intervention is welcomed! Thanks. -- Andy.

1 0

Re: [PATCH 1/6] kernel32: Add tests for WritePrivateProfileString.
by Paul Vriens 24 Mar '09

24 Mar '09

James Hawkins wrote: > --- > dlls/kernel32/tests/profile.c | 227 +++++++++++++++++++++++++++++++++++++++++ > 1 files changed, 227 insertions(+), 0 deletions(-) > > > ------------------------------------------------------------------------ > > Two of these new tests crash on Windows (see attached patch for a "fix" on Windows). Applying the patch triggers a failure on Wine though, which is very weird. -- Cheers, Paul. diff --git a/dlls/kernel32/tests/profile.c b/dlls/kernel32/tests/profile.c index 7b57699..9dd551f 100644 --- a/dlls/kernel32/tests/profile.c +++ b/dlls/kernel32/tests/profile.c @@ -860,13 +860,16 @@ static void test_WritePrivateProfileString(void) ok(check_file_data(path, data), "File doesn't match\n"); DeleteFileA(path); - /* empty lpAppName */ + if (0) + { + /* empty lpAppName, crashes on Windows */ data = "[]\r\n" "key=string\r\n"; ret = WritePrivateProfileStringA("", "key", "string", path); ok(ret == TRUE, "Expected TRUE, got %d\n", ret); ok(check_file_data(path, data), "File doesn't match\n"); DeleteFileA(path); + } /* NULL lpKeyName */ data = ""; @@ -878,7 +881,9 @@ static void test_WritePrivateProfileString(void) } DeleteFileA(path); - /* empty lpKeyName */ + if (0) + { + /* empty lpKeyName, crashes on Windows */ data = "[App]\r\n" "=string\r\n"; ret = WritePrivateProfileStringA("App", "", "string", path); @@ -888,6 +893,7 @@ static void test_WritePrivateProfileString(void) ok(check_file_data(path, data), "File doesn't match\n"); } DeleteFileA(path); + } /* NULL lpString */ data = "";

1 0

SOC Project Idea: Winelib-aware scons
by Scott Ritchie 24 Mar '09

24 Mar '09

For a while now I've been hoping someone would tackle a pet project of mine. It occurred to me that it would be a great summer of code project. Basically, I want a magic script that can convert a visual studio project file into a winelib-aware, scons-powered, linux-compatible build system. This would make it very easy for a Windows-only Visual Studio project to be ported. Now, normally, someone writing portable code would probably want to use scons from the start instead of Visual Studio, but Winelib throws a monkey wrench into this process by making formerly non-portable code suddenly Linux compatible. As a good example application to test, the program eMule would be a good candidate - it's open source, works great in Wine, is built with Visual Studio, and has no good native equivalents. I've added a work in progress wiki page on the Wine wiki here: http://wiki.winehq.org/SconsWine I'm not sure whether this will function better as an scons summer of code project or a Wine one, nor am I sure where a student would be able to find a good mentor. Accordingly, I'm emailing both mailing lists, and hoping for some feedback, particularly if it doesn't sound feasible. Thanks, Scott Ritchie

8 11

Re: [PATCH 1/2] secur32: Change scan_free_handle to print an error, if the index (handle) is out of range.
by Francois Gouget 24 Mar '09

24 Mar '09

On Tue, 24 Mar 2009, Florian Köberle wrote: [...] > + if (handle_idx < 0 || handle_idx >= schan_handle_count) > + { > + ERR("Handle %ld is not in range [0,%ld]\n", handle_idx, schan_handle_count-1); > + return NULL; > + } A conformance test to show that Windows has this check would be nice. Otherwise this patch is just for hiding a bug and thus should not be committed. But really, finding out why this API gets called with an invalid handle would be much better... (likely harder too, I know) -- Francois Gouget <fgouget(a)free.fr> http://fgouget.free.fr/ Linux: Because rebooting is for adding new hardware

1 0

Re: [PATCH 1/2] secur32: Change scan_free_handle to print an error, if the index (handle) is out of range.
by Henri Verbeet 24 Mar '09

24 Mar '09

2009/3/24 Florian Köberle <florian(a)fkoeberle.de>: > + if (handle_idx < 0 || handle_idx >= schan_handle_count) > handle_idx can't be < 0 because it's unsigned. Printing an ERR if the handle is out of range is probably ok, but I think crashing is better than just returning NULL.

2 1

Re: gdi32/path.c -- Allow PATH_ExtTextOut() handle non printablecharacters
by Dmitry Timoshkov 24 Mar '09

24 Mar '09

"Massimo Del Fedele" <max(a)veneto.com> wrote: > PATH_ExtTextOut() uses GetGlyphOutlineW() which can return a NULL buffer > size not just on errors but also on non-printable glyphs. > Instead of aborting the function should check for such cases, get the > metrics and continue. This patch doesn't match the normal logic of ExtTextOut implemented in dlls/winex11.drv/xrender.c, also this requires a test case for both code paths. -- Dmitry.

3 7