April 2009 - Wine-devel - list.winehq.org

Windows 7
by Fred . 03 Apr '09

03 Apr '09

I can put Windows XP, Vista, 2003, 2008. But not Windows 7.

5 9

Re: OpenBSD configure fix for cups
by Alexandre Julliard 03 Apr '09

03 Apr '09

Toni Spets <toni.spets(a)gmail.com> writes: > @@ -1221,7 +1221,7 @@ if test "x$with_cups" != "xno" > then > ac_save_CPPFLAGS="$CPPFLAGS" > ac_cups_cflags=`cups-config --cflags 2>/dev/null` > - ac_cups_libs=`cups-config --ldflags 2>/dev/null` > + ac_cups_libs=`cups-config --ldflags --libs 2>/dev/null` > CPPFLAGS="$CPPFLAGS $ac_cups_cflags" I'm afraid we can't do that, cups-config --libs returns a lot of crap that will break the build on many platforms. You should fix the OpenBSD libcups build to import the needed libraries. -- Alexandre Julliard julliard(a)winehq.org

1 0

Registry keys for serial ports
by Stefan Leichter 03 Apr '09

03 Apr '09

Hello Alexandre, you said in http://www.winehq.org/pipermail/wine-devel/2008-November/070691.html that registry entries for the serial ports should be created from the information received from hal. i 'm planing to implement this code. But before i start coding i like to know where the code should be created. Should the code go into kernel32/oldconfig.c, should i start creating serenum.sys is there any other place? Bye Stefan

2 1

Wine registry question
by Damjan Jovanovic 03 Apr '09

03 Apr '09

Hi I've noticed that Wine doesn't merge HKCU\Classes\Root into HKCR (http://bugs.winehq.org/show_bug.cgi?id=17019) Is this for compatibility with older Windows versions, or is it a Wine bug? Damjan Jovanovic

2 2

Re: (resubmit) user32: In COMBO_WindowPosChanging() do not change the height of the the dropped rectangle, if the new height is too small
by Alexandre Julliard 03 Apr '09

03 Apr '09

Rein Klazes <wijn(a)online.nl> writes: > Fixes bug #17695 > --- > dlls/user32/combo.c | 6 ++-- > dlls/user32/tests/combo.c | 46 +++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 49 insertions(+), 3 deletions(-) It doesn't work here: ../../../tools/runtest -q -P wine -M user32.dll -T ../../.. -p user32_test.exe.so combo.c && touch combo.ok combo.c:143: Tests skipped: Invalid Marlett font heights combo.c:143: Tests skipped: Invalid Marlett font heights combo.c:377: Test succeeded inside todo block: clientrect height is 24 vs 24 combo.c:377: Test succeeded inside todo block: clientrect height is 24 vs 24 make[2]: *** [combo.ok] Error 2 -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: dlls/comctl32/tests/listview.c: fix ok statements to actually test something
by Joris Huizer 02 Apr '09

02 Apr '09

--- On Thu, 4/2/09, Nikolay Sivov <bunglehead(a)gmail.com> wrote: > From: Nikolay Sivov <bunglehead(a)gmail.com> > Subject: Re: dlls/comctl32/tests/listview.c: fix ok statements to actually test something > To: wine-devel(a)winehq.org, joris_huizer(a)yahoo.com > Date: Thursday, April 2, 2009, 2:04 PM > > Joris Huizer wrote: > Hi, Joris. Thanks for spotting this, but changes you've > made will fail on Windows. I've just sent a corrected > version with one test more. > Here it is if you're interested: > http://www.winehq.org/pipermail/wine-patches/2009-April/071433.html > > No problem :-) Sorry I didn't test with Windows just as I don't have it available; I wasn't sure what would be the proper action, to send a best-guess patch or personal email - any ideas on this in general? regards, Joris

2 1

Re: [1/4]winemaker: winresrc.h is the right name in actual wine(try10)
by Austin English 02 Apr '09

02 Apr '09

On Thu, Apr 2, 2009 at 2:58 PM, Dawncrow <webmaster(a)dawncrow.de> wrote: > --- > tools/winemaker | 10 +++++----- > 1 files changed, 5 insertions(+), 5 deletions(-) > > > > > > Your patch lacks your real name. -- -Austin

2 1

Re: include: Add declaration of sockaddr_storage to winsock2.h.
by Alexandre Julliard 02 Apr '09

02 Apr '09

Rob Shearman <robertshearman(a)gmail.com> writes: > @@ -437,6 +437,18 @@ typedef struct _CSADDR_INFO { > } CSADDR_INFO, *PCSADDR_INFO, *LPCSADDR_INFO; > #endif > > +#define _SS_MAXSIZE 128 > +#define _SS_ALIGNSIZE (sizeof(__int64)) > +#define _SS_PAD1SIZE (_SS_ALIGNSIZE - sizeof(short)) > +#define _SS_PAD2SIZE (_SS_MAXSIZE - 2 * _SS_ALIGNSIZE) > + > +typedef struct WS(sockaddr_storage) { > + short ss_family; > + char __ss_pad1[_SS_PAD1SIZE]; > + __int64 __ss_align; > + char __ss_pad2[_SS_PAD2SIZE]; > +} SOCKADDR_STORAGE, *PSOCKADDR_STORAGE, *LPSOCKADDR_STORAGE; This is apparently in ws2def.h in the Vista SDK. Also the #defines need a WS prefix too. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/5] resend include: bring in6_addr into line with the MS definition
by Alexandre Julliard 02 Apr '09

02 Apr '09

Jeff Latimer <lats(a)yless4u.com.au> writes: > diff --git a/include/ws2tcpip.h b/include/ws2tcpip.h > index a38ccda..9ddb3d1 100644 > --- a/include/ws2tcpip.h > +++ b/include/ws2tcpip.h > @@ -85,26 +85,41 @@ struct WS(ip_msfilter) { > struct WS(in_addr) imsf_slist[1]; > }; > > -typedef struct WS(in_addr6) > -{ > - WS(u_char) s6_addr[16]; /* IPv6 address */ > +struct WS(in6_addr) { > + union { > + WS(u_char) Byte[16]; > + WS(u_short) Word[8]; > + } u; > } IN6_ADDR, *PIN6_ADDR, *LPIN6_ADDR; > > +#define in_addr6 WS(in6_addr) > + > +#define _S6_un u > +#define _S6_u8 Byte > +#ifndef USE_WS_PREFIX > +#define s6_addr _S6_un._S6_u8 > +#else > +#define WS_s6_addr _S6_un._S6_u8 > +#endif > + > +#define s6_bytes u.Byte > +#define s6_words u.Word This doesn't seem to match the PSDK, I don't see anything like this in ws2tcpip.h. -- Alexandre Julliard julliard(a)winehq.org

3 4

Re: dlls/comctl32/tests/listview.c: fix ok statements to actually test something
by Nikolay Sivov 02 Apr '09

02 Apr '09

> Joris Huizer wrote: Hi, Joris. Thanks for spotting this, but changes you've made will fail on Windows. I've just sent a corrected version with one test more. Here it is if you're interested: http://www.winehq.org/pipermail/wine-patches/2009-April/071433.html

1 0