July 2009 - Wine-devel - list.winehq.org

image loading with windowscodecs
by Vincent Povirk 09 Jul '09

09 Jul '09

So I've been working on an implementation of windowscodecs.dll (Windows Imaging Component). This is a Vista/.NET 3.x API for manipulating image data. To the best of my knowledge, only 2 programs currently use it, and I'm not running either one. We're not likely to see it used by real programs in Wine much, since there's no redistributable. A program using it would have to require Vista or .NET 3.0, or require users to download it manually. It's documented here: http://msdn.microsoft.com/en-us/library/ms735422(VS.85).aspx Adding this dll will not increase compatibility, at least not directly. It will, however, provide Wine with a single component that can be used by any dll or program that needs to load or save a raster image. All of the code for png, gif, jpeg, etc should be migrated into this dll. If we need any image formats not supported by native, we can implement them as Wine-specific extensions. We need to do this because oleaut32 (the current home of image-loading code) sucks. I have been told that the libpng code should not be duplicated throughout the codebase. I need features in gdiplus that oleaut32 does not provide, such as access to the image dpi and metadata, and the ability to save images. In fact, much of the gdiplus image/bitmap api matches WIC 1:1. On Windows, gdiplus is known to be able to use WIC extensions to support new image types, so in theory it should use WIC (though this probably won't matter any time soon). I'm told that image loading is also useful for d3dx9 dll's. The WIC api is well-designed in my opinion and should be able to provide any operations needed by other components to load/save images. The next step is to implement the image types needed by oleaut32 and start using WIC to load them in olepicture, starting with BMP. To that end, I need a good test program. I need to see what kind of BMP files currently work (I suspect that many are broken) and what kinds will work if I replace the BMP-loading code. This will tell me at what point I can make the change without introducing a regression. After that, I'll need to do the same thing with the other file types. So I need a general-purpose image viewer that uses either gdiplus or oleaut32 to do its image loading. Does anyone know any? -- Vincent Povirk

1 0

Re: [1/2] winemine: Add ellipses for menu entries that open new dialog windows
by Yuri Khan 09 Jul '09

09 Jul '09

On Thu, Jul 9, 2009 at 15:53, Anders Jonsson<anders.jonsson(a)norsjonet.se> wrote: > POPUP "&Info" { > - MENUITEM "&Fastest Times", IDM_TIMES > + MENUITEM "&Fastest Times...", IDM_TIMES > MENUITEM "&About", IDM_ABOUT > } According to Microsoft's guidelines, an ellipsis is only necessary when the command asks for confirmation or additional parameters. "If simply viewing the window is a common action, don't use an ellipsis." http://msdn.microsoft.com/en-us/library/aa511502.aspx#ellipses

2 1

Re: transl and sublangs are not showing neutral
by Ricardo Filipe 09 Jul '09

09 Jul '09

2009/7/8 Paul Vriens <paul.vriens.wine(a)gmail.com> > Paul Vriens wrote: > >> Ricardo Filipe wrote: >> >>> hi mikolaj, >>> >>> in transl the Portuguese language (not Portugese :( ) is not showing most >>> of the neutral strings for it's sublangs (portugal and brazil). >>> i think this is not how it should be... in each sublang it should show >>> the Neutral derived strings and the warning that neutral is being used and >>> should not be used aside the language name in the main list, not put neutral >>> separate in another hidden page. >>> >>> as it is now it's hard for me to know what is translated and what's not. >>> what do you (and wine devel) think? could you please change this? >>> >>> regards, >>> Ricardo >>> >>> >>> ------------------------------------------------------------------------ >>> >>> >>> Hi Ricardo, >> >> So you would be happy/happier if we show "Portuguese (Neutral)" (with the >> warning) on the main page next to the "Portuguese (Portugal)" and >> "Portuguese (Brazilian)"? >> >> Just re-read your email. What you like is to have "Portuguese (Portugal)" > show the combination of "Portuguese (Portugal)" and "Portuguese (Neutral)", > correct? With a warning for the neutral resources. > > What does this mean for "English (Neutral)" should that be treated the same > or is Portuguese an exception? > > -- > Cheers, > > Paul. > yes that is what i would like and think is correct showing. portuguese strings should defer to neutral if none is found in the sublang, with a warning that they may be incorrect. i would say english is the exception by having all translated in SUBLANG_DEFAULT and not separating sublangs as is done with portuguese resources and others. as i stated in irc one of these days, i think the solution to english is to have a SUBLANG_BRITISH or whatever and not assume neutral is for british english, how it is right now contradicts the use of wrc which is sublang -> neutral -> default (english). i'd say english should have all resources in neutral and then the different ones in sublang_british or sublang_australian or other. at least that is what makes sense to me for the process to be consistent.

2 6

Re: [PATCH 1/7] jscript: Inherit Function_valueOf from Object
by Piotr Caban 09 Jul '09

09 Jul '09

Hi, Please drop this bunch of patches (it will not apply to newest git). Piotr

1 0

Re: WineD3D: Check if GL accepts 4 component specular colors
by Henri Verbeet 09 Jul '09

09 Jul '09

Actually, while I'm at it, you're also missing ENTER_GL()/LEAVE_GL() calls in match_allows_spec_alpha(), and you should document that it depends on the caller to do context activation.

1 0

Re: comctl32: Fix dialog ('Next' button was hidden)
by Aurimas Fišeras 09 Jul '09

09 Jul '09

On 07/08/2009 10:31 PM, Frédéric Delanoy wrote: > I think it should be under the button "Finish", so that the "Finish" button can be shown in the same place instead of "Next >" on the last wizard page.

3 3

Re: WineD3D: Check if GL accepts 4 component specular colors
by Henri Verbeet 09 Jul '09

09 Jul '09

2009/7/9 Stefan Dösinger <stefan(a)codeweavers.com>: > - GL_EXTCALL(glSecondaryColorPointerEXT)(e->format_desc->gl_vtx_format, e->format_desc->gl_vtx_type, > - e->stride, e->data + stateblock->loadBaseVertexIndex * e->stride + offset[e->stream_idx]); > + > + if(GLINFO_LOCATION.quirks & WINED3D_QUIRK_ALLOWS_SPECULAR_ALPHA) > + { > + /* The spec disallows 4 component specular colors, but most GL drivers accept it. Try to use it, > + * since the 4th value can be passed through to pixel shaders > + */ > + GL_EXTCALL(glSecondaryColorPointerEXT)(e->format_desc->gl_vtx_format, e->format_desc->gl_vtx_type, > + e->stride, e->data + stateblock->loadBaseVertexIndex * e->stride + offset[e->stream_idx]); > + } > + else > + { > + GLenum type = e->format_desc->gl_vtx_type; > + GLint format = e->format_desc->gl_vtx_format; > + if(format == 4 && type == GL_UNSIGNED_BYTE) > + { > + GL_EXTCALL(glSecondaryColorPointerEXT)(3, GL_UNSIGNED_BYTE, > + e->stride, e->data + stateblock->loadBaseVertexIndex * e->stride + offset[e->stream_idx]); > + } > + else > + { > + FIXME("Add specular color code for type %x, fmt %u\n", type, format); > + GL_EXTCALL(glSecondaryColorPointerEXT)(format, type, > + e->stride, e->data + stateblock->loadBaseVertexIndex * e->stride + offset[e->stream_idx]); > + } > + } I think you should test for the specific case the quirk addresses. For example, 3 component specular color will trigger the FIXME with this code. Also, EXT_vertex_array_bgra adds GL_BGRA as a valid type/size parameter for glSecondaryColorPointer(). Just test for "type == 4" and handle it according to the quirk being present or not. Combinations that are always invalid, like e.g. 1 or 2 component data should already have been filtered by declaration_element_valid_ffp().

1 0

Re: comctl32: Fix dialog ('Next' button was hidden) [ invalid patch ]
by Frédéric Delanoy 09 Jul '09

09 Jul '09

Please discard this patch Frédéric

1 0

Translations/locale
by Ken Sharp 09 Jul '09

09 Jul '09

Can someone tell me what's going on on this page http://source.winehq.org/transl/lang.php?lang=009%3A00 ? If you click on the bottom links (locales) I see a message "Invalid resource file". Does this mean the resource file doesn't exist, or is there a little oops in the links? Thanks, Ken.

2 2

Re: winex11.drv: Handle clipboard on an auxiliary thread for windowless apps (try 3)
by Dmitry Timoshkov 09 Jul '09

09 Jul '09

"Yuri Khan" <yurivkhan(a)gmail.com> wrote: > +void selection_acquire(void) Should be 'static'. > +DWORD WINAPI selection_thread_proc(LPVOID lphwnd) Should be 'static'. What's the purpose of such a parameter name? 'dummy', 'unused' or just 'param' would be better IMO. > +{ > + HANDLE handles[1]; > + > + selection_acquire(); > + > + while (selectionAcquired) > + { > + MsgWaitForMultipleObjectsEx(0, handles, INFINITE, QS_SENDMESSAGE, 0); > + } What's the purpose of 'handles'? 'handles' is not initialized, moreover the number of passed handles is 0. MsgWaitForMultipleObjectsEx() works just fine with '0, NULL' combination. -- Dmitry.

1 0