July 2009 - Wine-devel - list.winehq.org

Re: Minor fix for include/bits1_5.idl
by Gerald Pfeifer 02 Jul '09

02 Jul '09

Strike that, I must have misread the documentation. Only thing I am wondering is do we really need the (unsigned long) here? If anyone has a pointer to clear documentation that would be nice; what I found so far leaves some questions open... Gerald On Sun, 28 Jun 2009, Gerald Pfeifer wrote: > The generated file include/bits1_5.h is the same before and after this > patch, yet somehow the original form strikes me as a bit odd at best... > > Gerald > > > ChangeLog: > Fix prototype for GetReplyData(). > > diff --git a/include/bits1_5.idl b/include/bits1_5.idl > index 274a7de..29520e2 100644 > --- a/include/bits1_5.idl > +++ b/include/bits1_5.idl > @@ -39,7 +39,7 @@ interface IBackgroundCopyJob2 : IBackgroundCopyJob > } BG_JOB_REPLY_PROGRESS; > > HRESULT GetReplyProgress([in, out] BG_JOB_REPLY_PROGRESS *progress); > - HRESULT GetReplyData([out, size_is( , (unsigned long) *pLength)] byte **pBuffer, > + HRESULT GetReplyData([out, size_is((unsigned long) *pLength)] byte **pBuffer, > [in, out, unique] UINT64 *pLength); > HRESULT SetReplyFileName([unique] LPCWSTR filename); > HRESULT GetReplyFileName([out] LPWSTR *pFilename);

2 1

Re: AppDB test results in Spanish
by Susan Cragin 02 Jul '09

02 Jul '09

>>> Who feels like translating some test results? >>> >>> http://appdb.winehq.org/objectManager.php?sClass=version&iId=8714&iTestingI… >I mean someone actually replace that entry with a translated version. >I could do it via Google Translate, but I'd rather someone who *knows* >Spanish replace it with a REAL translation :) I read Spanish. Here's my take. I got as far as the load menu and one quick race. In "race" mode the videos don't work, and other modes also fail. Many things. All this was configured with Windows Vista settings. That can prove anything. No more to say. (Or, that goes without saying.)

3 2

Re: kernel32: Add a trailing '\n' to a MESSAGE trace
by Alexandre Julliard 02 Jul '09

02 Jul '09

Frédéric Delanoy <frederic.delanoy(a)gmail.com> writes: > Last time I submitted this (pretty trivial) patch, it got ignored. What makes you think this is necessary? Did you test it? -- Alexandre Julliard julliard(a)winehq.org

2 1

AppDB test results in Spanish
by Ben Klein 02 Jul '09

02 Jul '09

Who feels like translating some test results? http://appdb.winehq.org/objectManager.php?sClass=version&iId=8714&iTestingI…

3 3

Re: kernel32: Add a trailing '\n' to a MESSAGE trace
by Nicolas Le Cam 02 Jul '09

02 Jul '09

Le 2 juillet 2009 09:29, Frédéric Delanoy<frederic.delanoy(a)gmail.com> a écrit : > Last time I submitted this (pretty trivial) patch, it got ignored. > If it's in a bad format, please let me know! > > Frédéric Hi Frédéric, System messages already contain a new line, you don't need to add a second one. -- Nicolas Le Cam

1 0

Re: winex11.drv: Move clipboard handling to a separate thread
by Alexandre Julliard 02 Jul '09

02 Jul '09

Yuri Khan <yurivkhan(a)gmail.com> writes: > This patch achieves this by creating an auxiliary thread that will run > in the same process that puts data on the clipboard and handle X > selection messages. That looks quite inefficient, especially since you create a new thread every time. You should limit this to the cases where it's really necessary, using clipboard from command line apps is a very uncommon operation. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: RFC: Mac OSX should use existing Pictures/ Music/ Videos/ etc. directories - how exactly?
by James Mckenzie 02 Jul '09

02 Jul '09

> >You probably want a separate code path in shellpath.c for the Mac. I >don't think XDG works there. > Can check, but make sure you do not use ObjC code. AJ will reject. Also pass to me, and I will add/test it. James McKenzie

1 0

Re: [PATCH 5/6] urlmon: Added user agent tests.
by Paul Vriens 01 Jul '09

01 Jul '09

Jacek Caban wrote: > --- > dlls/urlmon/tests/misc.c | 84 > ++++++++++++++++++++++++++++++++++++++++++++- > 1 files changed, 82 insertions(+), 2 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi Jacek, The addition of these new tests led to a Coverity warning (#947) as your using str2 in your tests. str2 is checked for NULL earlier on but only skips a few tests now if it's indeed NULL. The question is, should we just add a return after the skip() or get rid of the whole checking for NULL. (The str2 checking was not added by you btw). -- Cheers, Paul.

2 1

RFC: Mac OSX should use existing Pictures/ Music/ Videos/ etc. directories - how exactly?
by Joerg-Cyril.Hoehle＠t-systems.com 01 Jul '09

01 Jul '09

Hi, http://bugs.winehq.org/show_bug.cgi?id=19028 winecfg on Mac OSX (10.5.6 and .7) does not link "My Videos" etc. to the equivalent directories on the Mac. Everything is linked to $HOME (or was it Desktop/?) instead. What a pity! Mac OSX uses directories named Documents/, Pictures/, Videos/, Music/ -- even in the German locale. The Finder GUI provides localized names. Unlike XDG/Gnome there are no crazy hacks at session begin to rename directories based on the session's locale. I don't know how earlier releases of Mac OSX behave, i.e. whether these directories have always been present. Does anyone know a reference? I located the relevant places that would need a patch: dlls/shell32/shellpath.c:_SHCreateSymbolicLinks and possibly dlls/shell32/xdg.c:XDG_UserDirLookup However, some design issues are unclear to me, hence prevent me from writing a patch: - In what order to add the Mac check? - When to check for a folder named "My Documents" (MS-Windows non-localized name in English locale, possibly translated), and when for "Documents" (MacOS constant name)? - Use XDG on the Mac or not? (if linked in, e.g. possibly when compiled via MacPorts, which pulls in a zillion libraries. Apple does not provide libfreedesktop.) Thanks for your comments, Jörg Höhle

3 2

Re: msctf: fully clear the Variant before setting it.
by Huw Davies 01 Jul '09

01 Jul '09

On Wed, Jul 01, 2009 at 10:29:22AM -0500, Aric Stewart wrote: > diff --git a/dlls/msctf/compartmentmgr.c b/dlls/msctf/compartmentmgr.c > index 3afcfda..e1c7187 100644 > --- a/dlls/msctf/compartmentmgr.c > +++ b/dlls/msctf/compartmentmgr.c > @@ -537,6 +537,7 @@ static HRESULT WINAPI Compartment_GetValue(ITfCompartment *iface, > if (!pvarValue) > return E_INVALIDARG; > > + memset(pvarValue,0,sizeof(VARIANT)); > pvarValue->n1.n2.vt = VT_EMPTY; > if (!This->variant.n1.n2.vt == VT_EMPTY) > hr = VariantCopy(pvarValue,&This->variant); > This looks wrong; there's something strange going on here. Note also there's VariantInit() which is a cleaner way to set vt to VT_EMPTY. Huw.

1 0