July 2009 - Wine-devel - list.winehq.org

RFC XRender add support for dibsections in more color depths
by Roderick Colenbrander 01 Aug '09

01 Aug '09

Hi, For some weeks I have been working on moving more 2D rendering to XRender. XRender has three advantages for Wine. First of all it allows us to perform more rendering operations using X which we previously did using a combination of software rendering and back-forth copying between the Xserver. Second XRender offers depth conversion (this gives us proper alpha support in Wine and allows us to bypass DIB color conversion in some cases!). Third XRender brings us more hardware acceleration and that way more performance. The patch attached to this thread adds support for dibsections in additional color depths. On Xservers running at 24-bit this patch offers us dibsections in 1-bit/15-bit/16-bit/24-bit/32-bit. (32-bit is for proper alpha support) Big parts of the Wine X11 Driver make assumptions about having only two color depths around (1-bit and screen_depth e.g. 24-bit). I would like to request that people apply the current patch to latest git (in combination with the Office2007 patch which I posted to wine-patches). Please report any 2D rendering issues you see and also mention possible Wine crashes due to X errors like BadMatch. Try as much programs as possible. Thanks in advance, Roderick Colenbrander

6 16

Re: ntdll: For Darwin/Mac OS X, use legacy getdirentries if 64-bit inodes enabled.
by Austin English 31 Jul '09

31 Jul '09

On Fri, Jul 31, 2009 at 4:25 PM, Ken Thomases<ken(a)codeweavers.com> wrote: > > Fixes building on Snow Leopard. > --- > dlls/ntdll/directory.c | 30 ++++++++++++++++++++++++++++++ > 1 files changed, 30 insertions(+), 0 deletions(-) FWIW, NetBSD has a similar bug (http://bugs.winehq.org/show_bug.cgi?id=18166) but AJ refused the patch, saying NetBSD should fix it on their end. -- -Austin

2 1

WGL: fix usage of non-GLX visual in glXCreateContext
by Roderick Colenbrander 31 Jul '09

31 Jul '09

Hi, We should not expect that the default Wine visual supports GLX, use glXChooseVisual instead. This should fix bug 19570. Regards, Roderick Colenbrander

1 0

Re: ws2_32: Handle the formatting of IPV6 addresses and use inet_ntop function
by Juan Lang 31 Jul '09

31 Jul '09

Hi Jeff, I have a competing version of a similar patch that I was going to send in. Ordinarily I'd defer to the first poster rule, but in this case I'd rather mine were used. The difference is, you use the ternary comparison operator: + (((const struct WS_sockaddr_in *)a)->sin_family == AF_INET) ? + (void *)&((struct WS_sockaddr_in *)a)->sin_addr : + ((struct WS_sockaddr_in6 *)a)->sin6_addr.WS_s6_addr, This makes the expression rather long, and also makes it hard to extend beyond two address families. ws2_32 also supports IPX, and with any luck it'll soon support IrDA. I'll send mine in shortly, and you can complain if you like :) --Juan

7 6

Re: gdi32: Ensure child fonts have names
by Dmitry Timoshkov 31 Jul '09

31 Jul '09

"Aric Stewart" <aric(a)codeweavers.com> wrote: > @@ -5792,6 +5792,9 @@ static BOOL load_child_font(GdiFont *font, CHILD_FONT *child) > child->font->scale_y = font->scale_y; > hfontlist = HeapAlloc(GetProcessHeap(), 0, sizeof(*hfontlist)); > hfontlist->hfont = CreateFontIndirectW(&font->font_desc.lf); > + /* ensure the child font has a name */ > + if (!child->font->name) > + child->font->name = strdupW(child->font->font_desc.lf.lfFaceName); It doesn't look like an appropriate place for this. Font name is initialized explicitly in both WineEngCreateFontInstance() and GetEnumStructs(). How it could be possible that it's NULL in the above case? -- Dmitry.

2 3

Wine to be used as botnet testbed
by Maik Schulz 30 Jul '09

30 Jul '09

More in the linked New York Times article, Sandia National Labs plans to have a Dell super computer run 1 million Linux instances using Wine to host and study a botnet: http://www.nytimes.com/2009/07/28/science/28comp.html?_r=1 Does someone on the list have more detailed information on or is even involved with it? How about we post about this on winehq.org as well? Would be a departure from posing only about new releases and WWN issues, but it could make winehq.org more interesting for users... I'd volunteer... Cheers, -Maik

2 1

Re: winecfg: Add toggle for systray visibility
by Roderick Colenbrander 30 Jul '09

30 Jul '09

Hi Andrew, Good that you have removed the unneeded changes. I'm wondering where the support in winex11.drv is for the winecfg option you added. My git version doesn't have it and I can't remember seeing patches for it (though I might have missed them). If these patches indeed have not been submitted, I would urge you to submit those first. Regards, Roderick On Wed, Jul 29, 2009 at 8:20 PM, Andrew Eikum<aeikum(a)codeweavers.com> wrote: > --- > programs/winecfg/En.rc | 2 ++ > programs/winecfg/resource.h | 1 + > programs/winecfg/theme.c | 19 +++++++++++++++++++ > 3 files changed, 22 insertions(+), 0 deletions(-) > > > > > >

1 0

Re: [6/6] hnetcfg: Register interfaces.
by Austin English 30 Jul '09

30 Jul '09

On Thu, Jul 30, 2009 at 10:36 AM, Hans Leidekker<hans(a)codeweavers.com> wrote: > On Thursday 30 July 2009 05:17:07 pm you wrote: > >> What is this series for, if you don't mind my asking? >> >> The iTunes installer/other applications looking for the XP firewall? > > Yes, this brings the iTunes installer to the next bug ;-) Great work! Which bug is that? -- -Austin

2 1

Re: winecfg: Add toggle for systray visibility
by Roderick Colenbrander 30 Jul '09

30 Jul '09

Hi Andrew, First of all it seems that the patch makes more changes than needed (e.g. lost of changes in En.rc. Second why is this patch needed? Various apps need the systray for proper functioning and hiding it doesn't look that nice to me.. Roderick On Thu, Jul 30, 2009 at 5:30 PM, Andrew Eikum<aeikum(a)codeweavers.com> wrote: > --- > programs/winecfg/En.rc | 21 +++++++++++---------- > programs/winecfg/resource.h | 1 + > programs/winecfg/x11drvdlg.c | 37 +++++++++++++++++++++++++++++++------ > 3 files changed, 43 insertions(+), 16 deletions(-) > > > > > >

1 0

Question about the gphoto2.ds resources
by Paul Vriens 30 Jul '09

30 Jul '09

Hi Marcus, I've noticed some strange output with transl: http://source.winehq.org/transl/resource.php?lang=013%3A00&resfile=dlls%2Fg… When I look at the defined resources for the first dialog I see: IDD_CAMERAUI DIALOG DISCARDABLE 0, 0, 372, 273 STYLE DS_MODALFRAME | DS_SETFOREGROUND | DS_CENTER | WS_POPUP | WS_VISIBLE | WS_CAPTION | WS_SYSMENU CAPTION "Files on Camera" MENU 20545 That MENU however is not defined anywhere. Can you remember (2006!) why that MENU entry was put in there? Mind you, I think transl should be able to cope with it, but I'm just checking if that entry can be removed. -- Cheers, Paul.

3 4