July 2009 - Wine-devel - list.winehq.org

Re: [3/3] WineD3D: Update the scissor rect on a render target change
by Henri Verbeet 21 Jul '09

21 Jul '09

2009/7/20 Stefan Dösinger <stefan(a)codeweavers.com>: > + scissor.top = 0; > + scissor.left = 0; > + scissor.right = viewport.Width; > + scissor.bottom = viewport.Height; > + IWineD3DDevice_SetScissorRect(iface, &scissor); > + IWineD3DDeviceImpl_MarkStateDirty(This, STATE_SCISSORRECT); The MarkStateDirty() call looks redundant to me. Also, does this do the right thing when we're recording a stateblock?

2 3

Status of the Status pages?
by Tomas - 21 Jul '09

21 Jul '09

The status pages in general seems to have been at a standstill since around 2007. The exception is the "API Stats" page, but now this page hasn't been updated since May 22. Is there any plans/ideas on what to do with the status pages?

3 2

Re: user32/tests: show that windows avoids creating loops in a menu tree, probably by limiting the depth of such tree.
by Paul Vriens 21 Jul '09

21 Jul '09

Rein Klazes wrote: > Show the problem with the application in bug report #12171. > +todo_wine > + ok( !ret || > + broken( 0), /* win98, NT */ > + "ModifyMenu should have failed.\n"); Hi Rein, We have a test failure on NT4 below after this patch. Shouldn't the "broken( 0)" be "broken( ret)" ? -- Cheers, Paul.

2 1

re: Status of the Status pages?
by Dan Kegel 21 Jul '09

21 Jul '09

Tomas wrote: > The status pages in general seems to have been at a standstill since around 2007. > The exception is the "API Stats" page, but now this page hasn't been updated since May 22. > Is there any plans/ideas on what to do with the status pages? I'd say we should delete them. They were always a guess. Except for API Stats, which should be kept but automated; it looks like it's still kind of manual. - Dan http://www.winehq.org/winapi_stats

1 0

Re: [PATCH 2/4] dpwsockx: Stub implementation
by Alexandre Julliard 21 Jul '09

21 Jul '09

Ismael Barros <razielmine(a)gmail.com> writes: > @@ -3,10 +3,11 @@ TOPOBJDIR = ../.. > SRCDIR = @srcdir@ > VPATH = @srcdir@ > MODULE = dpwsockx.dll > -IMPORTS = kernel32 > +IMPORTS = kernel32 ws2_32 > > C_SRCS = \ > - dpwsockx_main.c > + dpwsockx_main.c \ > + dpwsockx.c Please choose a better file name. dpwsockx.c doesn't say anything about what's in that file. > + DPWS_SetupCallbacks( lpspData->lpCB ); > + > + /* TODO: > + The original implementation calls SetSPData, > + check what it really stores */ How do you know that? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: advapi32: test a combination of CreateServiceA and GetSecurityInfo [2nd]
by Paul Vriens 21 Jul '09

21 Jul '09

Stefan Leichter wrote: > Am Monday 20 July 2009 14:13:10 schrieb Alexandre Julliard: >> You could insert that into one of the other tests that already create a >> service, so that we don't need to have too many Sleeps in there. > > This testcase demonstrates the current problem in bug 1886 > > > ------------------------------------------------------------------------ > > Hi Stefan, Please stick to the style of the file, curly braces on a separate line. (I see there is only one such style difference in the current file, but that was also introduced by you ;) ) -- Cheers, Paul.

1 0

Bug day a success!
by Scott Ritchie 21 Jul '09

21 Jul '09

I'd like to thank everyone that participated in our first Bug Day. I'm definitely going to repeat it again next release, although I may move it back a few days. Some statistics: Our bug target search (bugs unchanged since January 1st with the download tag) started at 574 bugs. Now it's down to 508. That's 66 bugs that were either resolved, confirmed, or at least checked in on. In the past two days there have been 30 bugs newly resolved. By comparison, over the previous 2 weeks before then there were only 16 bugs resolved. So, we're definitely making progress. Quite a few of us had some fun, and I personally get a real satisfaction out of transforming our bug database from a scary mess to a place we actually look forward to visiting. I'd like to give a personal thanks to Luke Benstead, who set a great example by gathering some of his real life friends to participate. Luke has shown himself to be very capable, and he deserves bugzilla permissions so he can help facilitate bug hunts in the future. Again, thank you everyone! Thanks, Scott Ritchie

1 0

Re: ws2/tests: Test AcceptEx with a deferred socket
by Paul Vriens 21 Jul '09

21 Jul '09

Mike Kaplinskiy wrote: > This tests the following AcceptEx scenario: > WSAAccept->CF_DEFER->AcceptEx > Windows seems to return the deferred socket with AcceptEx (verified on > XP & 2K3). > > Mike. > > > ------------------------------------------------------------------------ > > Hi Mike, These new tests fail on all NT4 boxes (some 6 and 1 has 4000+ failures) and what looks like to be all Windows x64_64 systems. The strange thing (or maybe not) is that the errors are the same on all of these (one box has 4000+ failures but still has those same 6). See: http://test.winehq.org/data/tests/ws2_32:sock.html Could you have a look? I can do some tests if necessary on NT4, I don't have a Windows x86_64 system however. -- Cheers, Paul.

2 6

FW: Re: please reduce the four registrations on the single winehq.org site.
by Scott Ritchie 20 Jul '09

20 Jul '09

S Page wrote: > Hey, I really want to help the Wine project out by sharing my problems > and workarounds. > > But having to register FOUR TIMES on the same winehq.com site (bugs, > AppDB, forums, wiki) is excruciatingly painful and hostile to your > would-be contributors. I realize you're just using open source > tooling, but maybe you can press those four products to > a) implement a single sign-on > b) support OpenID > > Thanks, > -- > =S Page Strangely enough, I was just talking about this today at the Community Leadership Summit. Unfortunately it seems like it's a pretty difficult problem to solve as the tools to get all these things talking to eachother haven't been written. There are packages that integrate a forum and a wiki and such together, but they don't provide an easy way to get the data out of them - switching to them also presents huge data migration issues. Mozilla are farthest on the game here, as they were working on writing some of their own custom stuff based on OpenID, however that then deals with the need of having each app support an OpenID login. I'm not sure if it's a good idea, but there may be some merit in having one of the accounts function as an OpenID Provider and then have the others be able to link to it (but still be "separate accounts"). After that it's just about being able to login by OpenID rather than have a single account moving across each place. Thanks, Scott Ritchie

3 3

D3D shader assembler
by Matteo Bruni 20 Jul '09

20 Jul '09

Hi to everybody, I'm sending here the main assembler patch for reviews and suggestions. It is bzipped as it is quite a big patch, but I couldn't find a meaningful way to split it. A quick mile-high overview: the assembler is divided in a parser and a bytecode writer. The parser is made by the flex (asmshader.l) and bison (asmshader.y) source files and the asmparser.c file. The bytecode writer is in bytecodewriter.c, btw, and asmutils.c contains some utility functions used in the assembler. With the asmshader.l SlAssembleShader function the parser processes the shader and returns an intermediate representation of it into the wine_shader struct. Then this struct is passed to the bytecode writer with the SlWriteBytecode function, which produces the assembled shader bytecode. A "point of interest": in the bottom part of asmshader.h there are some definitions borrowed from wined3d. They are used only internally, so they should not be a problem, but I'd like to hear if you think differently (ex. it is better to rename them?). Thank you, Matteo Bruni

3 8