August 2009 - Wine-devel - list.winehq.org

Towards leveraging app build and unit tests as a way to test wine
by Dan Kegel 18 Oct '09

18 Oct '09

Wine is far enough along that it ought to be able to build and run unit test suites from apps like Inkscape, Firefox, and OpenOffice, so I'm trying to write scripts that download and build various apps unattended, and eventually run their own test suites. The scripts are written to run equally well on Windows and Wine. This is hard to do without something like Cygwin or Autohotkey; I'm using Cygwin for my scripts out of personal preference. I already did a build script for Inkscape using mingw; http://kegel.com/wine/inkscape-download-and-build.sh.txt Now I'm tackling Firefox. So far the script installs Visual C++ 2005 Express and the 2003 platform SDK; see http://kegel.com/wine/vc2005x.sh.txt Next step: grabbing firefox source and building. I'm also filing bugs as I go; 19673 Microsoft Platform Installer 2003 fails to install 19668 cmd /c doesn't wait for result before exiting? 19636 Vista SDK installer fails in "Microsoft VC Redist 2008" subinstaller 19615 Can't compile Inkscape with mingw on wine: fd leak? 19581 Visual Studio 2005: "cl : Command line error D8022 : cannot open 'foo.rsp' "; foo.rsp was created with FILE_ATTRIBUTE_TEMPORARY 19502 Visual Studio 2005 SP1 install seems to fail While one doesn't really need to build the apps under Wine to run their test suites, it's a pain to have to compile them on one system and ship them over to another. And supporting building might have a nice benefit: if it's easy to develop for Windows on Wine, more Windows developers might bother to test their apps on Wine. So I think it's worth the extra effort. - Dan

5 16

search path redux - if office 2007 always uses a private riched20, why does wine interpose its own global one?
by Dan Kegel 18 Oct '09

18 Oct '09

See http://bugs.winehq.org/show_bug.cgi?id=14980 Essentially, to run Office 2007, you have to set an override for riched20. Since Office installs a new, spiffier version of riched20 in its own private directory, and expects to find it there, isn't it a bug that we don't let it have it? Sounds like it's time to write a conformance test... sure would be nice if that override wasn't needed.

9 26

Request for review: [PATCH] Resize fullscreen window when DirectDraw changes the display mode [resubmit 4]
by Johan Gill 08 Oct '09

08 Oct '09

On Wed, Jul 29, 2009 at 11:55 PM, Johan Gill <johan.gill(a)gmail.com> wrote: > This patch fixes bug 17215. Since the patch was seemingly dropped, I made > some test improvements and resubmit it. > > The tests pass on Windows XP, and of course Wine. > > Suggested changelog: > In DirectDraw fullscreen mode, make sure the fullscreen window is resized > when the display mode changes > > Johan Gill > > Since I heard nothing on this, I make a request here /Johan Gill

2 5

Re: include: Add missing definitions in af_irda.h. (try 2)
by Alexandre Julliard 13 Sep '09

13 Sep '09

Thomas Trummer <th.trummer(a)gmail.com> writes: > @@ -97,4 +100,159 @@ typedef struct _SOCKADDR_IRDA > #define LmCharSetISO_8859_9 0x09 > #define LmCharSetUNICODE 0xff > > +#define SIO_LAZY_DISCOVERY _IOR('t', 127, ULONG) > + > +#define WINDOWS_AF_IRDA 26 > +#define WINDOWS_PF_IRDA WINDOWS_AF_IRDA > + > +#define WCE_AF_IRDA 22 > +#define WCE_PF_IRDA WCE_AF_IRDA > + > +#ifndef AF_IRDA > +#define AF_IRDA WINDOWS_AF_IRDA > +#endif > + > +#ifndef PF_IRDA > +#define PF_IRDA AF_IRDA > +#endif > + > +#define IRDA_PROTO_SOCK_STREAM 1 You need a WS prefix on all definitions that can conflict with Unix. -- Alexandre Julliard julliard(a)winehq.org

4 4

font-shape/font-query related regression in wine 1.1.28
by Hin-Tak Leung 04 Sep '09

04 Sep '09

My favourite mono/.net application dies with 'Style Regular isn't supported by font Tahoma' in 1.1.28. I did a git bisect and commit 0b9ba054f6c8a2d96c898e7325087f56a6224644 Author: André Hentschel <nerv(a)dawncrow.de> Date: Wed Aug 12 19:19:32 2009 +0200 was the entry that breaks, but just reversing it in 1.1.28 does not fix the problem - i.e. more problematic commits later?; however, replacing the wine-shipped tahoma fonts with those from Vista does cure the problem; so does simply deleting them from $WINEPREFIX/drive_c/windows/fonts (and allow substitution from system fonts happen, I think). I don't know why a german translation would affect my environment (LANG=en_GB.utf8) and setting LANG=C does not fix the problem. In any case, the correct fix is probably working out what vista-shipped tahoma does which differs from wine-shipped tahoma? Anybody has any thought on this issue?

3 4

re: Wine t-shirts?
by Dan Kegel 03 Sep '09

03 Sep '09

Maarten wrote: > Why don't we have wine t-shirts any more? I dunno, where were they before? I just looked, couldn't find any on cafepress.com. I'd like to bring back the Codeweavers drunken penguin t-shirts, perhaps with a slightly more generic Wine design. Coincidentally, I found some site on the net had taken the logo from that shirt and erased the Crossover logo from the wine bottle; here's a cleaned-up copy: http://kegel.com/wine/wine-penguin-corkscrew.png

15 34

Re: programs/clock: Corrected a small lexical error in the italian translation (Corrected)
by James Mckenzie 01 Sep '09

01 Sep '09

> >Fixed a small typing error in the italian translation of clock.exe in >the property menu label (Properietà -> Proprietà). >Compiled and tested correctly on Ubuntu 9.04 64bit. > >(My first patch I send, so please be kind for any error, I'll be happy >to correct it if pointed to, thanks) > >P.S.: For some reason the previous mail attachment showed up empty in >the archives list, even if sent mail is correct, and using Thunderbird I >prefer not to paste it int he message body. Sorry for double sending. Riccardo: Please look at the processed mail message before sending to make sure that your patch is an attachment and not bound in-line. Thunderbird likes to do this to text attachments, so you might want to change the extension to .patch or .diff so Thunderbird will not do this. I did not have this problem with using git when git was configured per the GitWine page on the Wiki. James McKenzie

3 4

Re: oleaut32: use WIC to decode JPEG images
by Vincent Povirk 31 Aug '09

31 Aug '09

Of course it would probably help if I remembered to attach the patch. On Mon, Aug 31, 2009 at 5:08 PM, Vincent Povirk<vincent(a)codeweavers.com> wrote: > This needs an updated prefix to work. > > > > -- Vincent Povirk

1 0

What's wrong with my patch?
by Jan de Mooij 31 Aug '09

31 Aug '09

Hello. Subject says it all. I suppose the tests I added may fail on other locales, but there is no other way to test my patch? Should i send it without the tests? Thanks in advance. Jan ---------- Forwarded message ---------- From: Jan de Mooij <jandemooij(a)gmail.com> Date: Mon, Aug 31, 2009 at 2:24 PM Subject: comctl32/propsheet: update position of hidden buttons too To: wine-patches(a)winehq.org eMule iterates all buttons to find the left-most button, and then uses the x and y position for its own buttons. This currently fails in Wine because we don't update the position of the hidden buttons. Tests pass on Vista and Wine (2 failures without this change) Fixes bug 11345 - http://bugs.winehq.org/show_bug.cgi?id=11345

3 4

Re: [PATCH] [Msvcrt]: fixing errno handling in strtol and strtoul (#18151)
by Alexandre Julliard 31 Aug '09

31 Aug '09

Eric Pouech <eric.pouech(a)orange.fr> writes: > @@ -250,3 +250,25 @@ int CDECL __STRINGTOLD( MSVCRT__LDOUBLE *value, char **endptr, const char *str, > #endif > return 0; > } > + > +/****************************************************************** > + * strtol (MSVCRT.@) > + */ > +long int MSVCRT_strtol(const char* nptr, char** end, int base) > +{ > + /* wrapper to forward libc error code to msvcrt's error codes */ > + long ret = strtol(nptr, end, base); > + msvcrt_set_unix_errno(); > + return ret; > +} You can't simply use long here, you need to handle the difference in the size of long between Win32 and Unix. -- Alexandre Julliard julliard(a)winehq.org

3 3