September 2009 - Wine-devel

CPPCheck for Sept 8th
by chris ahrendt 09 Sep '09

09 Sep '09

[/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:982]: (error) Deallocating a deallocated pointer: stream2 [/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:966]: (error) Resource leak: stream3 [/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:973]: (error) Resource leak: stream4 [/home/cahrendt/wine-git/dlls/msvcrt/tests/heap.c:433]: (possible error) Memory leak: mem [/home/cahrendt/wine-git/dlls/ntdll/directory.c:2339]: (error) Resource leak: old_cwd [/home/cahrendt/wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [/home/cahrendt/wine-git/dlls/ntdll/server.c:882]: (error) Resource leak: fd_cwd [/home/cahrendt/wine-git/dlls/rpcrt4/tests/server.c:1189]: (possible error) Array index out of bounds [/home/cahrendt/wine-git/dlls/wineoss.drv/mmaux.c:146]: (error) Resource leak: mixer [/home/cahrendt/wine-git/dlls/wineoss.drv/mmaux.c:208]: (error) Resource leak: mixer [/home/cahrendt/wine-git/dlls/wineps.drv/init.c:270]: (error) Possible null pointer dereference: dmW - otherwise it is redundant to check if dmW is null at line 272 [/home/cahrendt/wine-git/tools/fnt2bdf.c:779]: (error) Resource leak: fd [/home/cahrendt/wine-git/tools/fnt2fon.c:387]: (error) Memory leak: file_lens [/home/cahrendt/wine-git/tools/makedep.c:953]: (error) Resource leak: file [/home/cahrendt/wine-git/tools/sfnt2fnt.c:877]: (error) Resource leak: ofp [/home/cahrendt/wine-git/tools/widl/write_msft.c:2536]: (error) Resource leak: fd [/home/cahrendt/wine-git/tools/winedump/msmangle.c:164]: (error) Memory leak: function_name [/home/cahrendt/wine-git/tools/winedump/pe.c:1549]: (possible error) Memory leak: map This is using thursdays git tree of CPPCheck.. please let me know if there are FP's so I can report them. Chris p.s. Thanks stephan for pointing out I sent it to the wrong list =D

3 2

Re: CPPCheck for Sept 8th
by chris ahrendt 09 Sep '09

09 Sep '09

Alexandre Julliard wrote: > chris ahrendt <celticht32(a)yahoo.com> writes: > >> [/home/cahrendt/wine-git/dlls/ntdll/directory.c:2339]: (error) Resource leak: old_cwd > > This is the only one that looks a real bug, all the rest are false > positives. Please filter them out from future reports. > Is there any others? So ignore the tests findings and the tools findings? Are These the ones that may be a bug then : [/home/cahrendt/wine-git/dlls/ntdll/server.c:802]: (error) Resource leak: fd [/home/cahrendt/wine-git/dlls/ntdll/server.c:882]: (error) Resource leak: fd_cwd [/home/cahrendt/wine-git/dlls/wineoss.drv/mmaux.c:146]: (error) Resource leak: mixer [/home/cahrendt/wine-git/dlls/wineoss.drv/mmaux.c:208]: (error) Resource leak: mixer [/home/cahrendt/wine-git/dlls/wineps.drv/init.c:270]: (error) Possible null pointer dereference: dmW - otherwise it is redundant to check if dmW is null at line 272 These Ignore correct? [/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:982]: (error) Deallocating a deallocated pointer: stream2 [/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:966]: (error) Resource leak: stream3 [/home/cahrendt/wine-git/dlls/msvcrt/tests/file.c:973]: (error) Resource leak: stream4 [/home/cahrendt/wine-git/dlls/msvcrt/tests/heap.c:433]: (possible error) Memory leak: mem [/home/cahrendt/wine-git/dlls/rpcrt4/tests/server.c:1189]: (possible error) Array index out of bounds [/home/cahrendt/wine-git/tools/fnt2bdf.c:779]: (error) Resource leak: fd [/home/cahrendt/wine-git/tools/fnt2fon.c:387]: (error) Memory leak: file_lens [/home/cahrendt/wine-git/tools/makedep.c:953]: (error) Resource leak: file [/home/cahrendt/wine-git/tools/sfnt2fnt.c:877]: (error) Resource leak: ofp [/home/cahrendt/wine-git/tools/widl/write_msft.c:2536]: (error) Resource leak: fd [/home/cahrendt/wine-git/tools/winedump/msmangle.c:164]: (error) Memory leak: function_name [/home/cahrendt/wine-git/tools/winedump/pe.c:1549]: (possible error) Memory leak: map Chris

1 0

Re: CPPCheck for Sept 8th
by chris ahrendt 09 Sep '09

09 Sep '09

Alexandre Julliard wrote: > chris ahrendt <celticht32(a)yahoo.com> writes: > >> [/home/cahrendt/wine-git/dlls/ntdll/directory.c:2339]: (error) Resource leak: old_cwd > > This is the only one that looks a real bug, all the rest are false > positives. Please filter them out from future reports. > Alexandre, I will filter them as best I can going forward... Chris

1 0

Re: CPP Run for Sept 8
by Stefan Dösinger 09 Sep '09

09 Sep '09

hi, I think its better to send these reports to wine-devel instead of wine-patches

1 0

Re: gdi32/tests: Some GdiAlphaBlend tests
by Roderick Colenbrander 09 Sep '09

09 Sep '09

Regarding the zero source DC, what happens visually? On Wed, Sep 9, 2009 at 1:30 PM, Nikolay Sivov<bunglehead(a)gmail.com> wrote: > Bug http://bugs.winehq.org/show_bug.cgi?id=18041 shows this commented crash. > I'm not sure how to fix it, but I think this call can't do anything > without source context. > > Another question is where to place such check - in gdi32 or winex11...any > advices are welcome. > > Changelog: > - Some GdiAlphaBlend tests > > >From a59cadcf03edeefff95c340230a47c9c3c60727f Mon Sep 17 00:00:00 2001 > From: Nikolay Sivov <bunglehead(a)gmail.com> > Date: Wed, 9 Sep 2009 15:20:34 +0400 > Subject: Some GdiAlphaBlend tests > > --- > dlls/gdi32/tests/bitmap.c | 19 +++++++++++++++++++ > 1 files changed, 19 insertions(+), 0 deletions(-) > > diff --git a/dlls/gdi32/tests/bitmap.c b/dlls/gdi32/tests/bitmap.c > index 8666da2..38acd09 100644 > --- a/dlls/gdi32/tests/bitmap.c > +++ b/dlls/gdi32/tests/bitmap.c > @@ -2376,6 +2376,25 @@ static void test_GdiAlphaBlend(void) > blend.SourceConstantAlpha = 128; > blend.AlphaFormat = 0; > > + /* zero dimensions */ > + SetLastError(0xdeadbeef); > + expect_eq(pGdiAlphaBlend(hdcDst, 0, 0, 0, 0, hdcSrc, 0, 0, 20, 20, blend), TRUE, BOOL, "%d"); > + expect_eq(GetLastError(), 0xdeadbeef, int, "%d"); > + SetLastError(0xdeadbeef); > + expect_eq(pGdiAlphaBlend(hdcDst, 0, 0, 20, 20, hdcSrc, 0, 0, 0, 0, blend), TRUE, BOOL, "%d"); > + expect_eq(GetLastError(), 0xdeadbeef, int, "%d"); > + > + SetLastError(0xdeadbeef); > + expect_eq(pGdiAlphaBlend(hdcDst, 0, 0, 0, 0, hdcSrc, 0, 0, 0, 0, blend), TRUE, BOOL, "%d"); > + expect_eq(GetLastError(), 0xdeadbeef, int, "%d"); > + > +#if 0 > + /* zero source HDC - crashes on wine, works on native */ > + SetLastError(0xdeadbeef); > + expect_eq(pGdiAlphaBlend(hdcDst, 0, 0, 20, 20, NULL, 0, 0, 20, 20, blend), FALSE, BOOL, "%d"); > + expect_eq(GetLastError(), 0xdeadbeef, int, "%d"); > +#endif > + > expect_eq(pGdiAlphaBlend(hdcDst, 0, 0, 20, 20, hdcSrc, 0, 0, 20, 20, blend), TRUE, BOOL, "%d"); > SetLastError(0xdeadbeef); > expect_eq(pGdiAlphaBlend(hdcDst, 0, 0, 20, 20, hdcSrc, -1, 0, 10, 10, blend), FALSE, BOOL, "%d"); > -- > 1.5.6.5 > > > > >

2 1

Re: mfc42: Stub implementation with the message where to get it from
by Alexandre Julliard 09 Sep '09

09 Sep '09

Vitaliy Margolen <wine-patches(a)kievinfo.com> writes: > This is more of the testing waters type of patch. If this approach is > fine then we can do the same for all other dlls that are shipped with > Windows but not really a part of an O/S. I don't think you can put up a message box on attach, that could potentially become very annoying since it will trigger also for version checks etc. That sort of thing should be done at the loader level. -- Alexandre Julliard julliard(a)winehq.org

2 1

Re: gdi32: Handle OEM_CHARSET
by Dmitry Timoshkov 09 Sep '09

09 Sep '09

"Vladimir Pankratov" <scriptkid(a)mail.ru> wrote: > --- a/dlls/gdi32/freetype.c 2009-08-08 13:27:23.000000000 +0500 > +++ b/dlls/gdi32/freetype.c 2009-09-07 19:58:58.000000000 +0500 > @@ -3576,6 +3576,7 @@ > if(!TranslateCharsetInfo((DWORD*)(INT_PTR)lf.lfCharSet, &csi, TCI_SRCCHARSET)) { > switch(lf.lfCharSet) { > case DEFAULT_CHARSET: > + case OEM_CHARSET: > csi.fs.fsCsb[0] = 0; > break; > default: How is this different from the default case? -- Dmitry.

2 1

Re: [PATCH 02/10] d3d10: Implement annotation parsing.
by Henri Verbeet 09 Sep '09

09 Sep '09

2009/9/9 Rico Schüller <kgbricola(a)web.de>: > -static void parse_fx10_annotation(const char **ptr) > +static HRESULT parse_fx10_annotation(struct d3d10_effect_variable *a, const char **ptr, const char *data) > { > - skip_dword_unknown(ptr, 3); > + DWORD offset; > + > + read_dword(ptr, &offset); > + TRACE("Annotation name at offset %#x.\n", offset); > + > + a->name = copy_name(data + offset); > + if (!a->name) > + { > + ERR("Failed to copy name.\n"); > + return E_OUTOFMEMORY; > + } > + TRACE("Annotation name: %s.\n", a->name); > + > + read_dword(ptr, &offset); > + TRACE("Annotation type info at offset %#x.\n", offset); > + > + a->type = get_fx10_type(a->effect, data, offset); > + if (!a->type) > + { > + ERR("Failed to get variable type.\n"); > + return E_FAIL; > + } > + > + skip_dword_unknown(ptr, 1); > + > + return S_OK; > } It seems to me that this is just the same code for parsing variables (that has implications for 1/10 as well).

2 1

Re: msxml3: Add IDispatchEx support to IXMLDOMElement (resend 2)
by Alexandre Julliard 09 Sep '09

09 Sep '09

Alistair Leslie-Hughes <leslie_alistair(a)hotmail.com> writes: > Hi, > Feedback if something is wrong would be great. domdoc.c:601: warning: ISO C90 forbids mixed declarations and code -- Alexandre Julliard julliard(a)winehq.org

1 0

Google Summer of Code mentor summit Oct 24th-25th
by Kai Blin 09 Sep '09

09 Sep '09

Hi folks, Wine gets to send two delegates to the Google Summer of Code mentor summit in Mountain View, CA, this October. Is anybody who mentored interested in going? Cheers, Kai -- Kai Blin WorldForge developer http://www.worldforge.org/ Wine developer http://wiki.winehq.org/KaiBlin Samba team member http://www.samba.org/samba/team/ -- Will code for cotton.

1 0