September 2009 - Wine-devel

Re: [1/4] ntdll: add initial test for NtQueryDirectoryFile(), improve test for NtQueryInformationFile() (take 3)
by Alexandre Julliard 24 Sep '09

24 Sep '09

Dan Kegel <dank(a)kegel.com> writes: > Change since last try: > - let NtQueryInformationFile() return STATUS_NOT_IMPLEMENTED > (seems to on Vista Home Basic), don't fail if other attributes set Please send unrelated changes as separate patches. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: advapi32: implement LsaLookupSids
by Alexandre Julliard 24 Sep '09

24 Sep '09

Aric Stewart <aric(a)codeweavers.com> writes: > + { > + name_size = domain_size = 0; > + (*Names)[i].Use = SidTypeUnknown; > + (*Names)[i].DomainIndex = -1; > + (*Names)[i].Name.Length = 0; > + (*Names)[i].Name.MaximumLength = 0; > + (*Names)[i].Name.Buffer = NULL; > + LookupAccountSidW(NULL, Sids[i], NULL, &name_size, NULL, &domain_size, &use); > + if (GetLastError() != ERROR_NONE_MAPPED) > + { You need to check the function return for failure first, though what you probably want is to check that it succeeded. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: (try 3) shlwapi: implement StrChrNW
by Paul Vriens 24 Sep '09

24 Sep '09

On 09/24/2009 02:19 PM, Aric Stewart wrote: > > includes test to show that MSDN is wrong and the search IS case-sensitive. > > thanks for all the comments. > --- > dlls/shlwapi/shlwapi.spec | 1 + > dlls/shlwapi/string.c | 22 ++++++++++++++++++++++ > dlls/shlwapi/tests/string.c | 22 ++++++++++++++++++++++ > 3 files changed, 45 insertions(+), 0 deletions(-) > > > > ------------------------------------------------------------------------ > > Hi Aric, You should return from the function after the win_skip(). -- Cheers, Paul.

2 1

Re: (resend) shlwapi: implement StrChrNW
by Jacek Caban 24 Sep '09

24 Sep '09

Hi Aric, Aric Stewart wrote: > --- > dlls/shlwapi/shlwapi.spec | 1 + > dlls/shlwapi/string.c | 23 +++++++++++++++++++++++ > 2 files changed, 24 insertions(+), 0 deletions(-) > I didn't test it myself, but StrChrNW name suggests, that the search shouldn't be case insensitive. Jacek

4 4

Re: shlwapi: implement StrChrNW
by Dmitry Timoshkov 24 Sep '09

24 Sep '09

"Aric Stewart" <aric(a)codeweavers.com> wrote: > +LPWSTR WINAPI StrChrNW(LPCWSTR lpszStr, WCHAR ch, UINT cchMax) > +{ > + TRACE("(%s(%i),%i)\n", debugstr_wn(lpszStr,cchMax), cchMax, ch); > + > + if (lpszStr) > + { > + ch = toupperW(ch); > + while (*lpszStr && cchMax > 0) > + { > + if (toupperW(*lpszStr) == ch) > + return (LPWSTR)lpszStr; > + lpszStr++; > + cchMax --; > + } > + lpszStr = NULL; > + } > + return (LPWSTR)lpszStr; > +} Are you sure that the search should be case insensitive? -- Dmitry.

2 1

Re: ole32/tests: Test for nested storage reference counting
by James McKenzie 24 Sep '09

24 Sep '09

Markus Stockhausen wrote: > Hi, > > as Nikolay had some tipps for the patch (layout of header and coding) I > attach a new version of the testcase for IStorage reference counters. > Please resend in git format. AJ will reject this patch outright. James McKenzie

2 1

Submitted Bug Link accepted but not showing up
by Erich Hoover 23 Sep '09

23 Sep '09

I received an email that a "Bug Link" I requested was accepted, but it's not showing up: http://appdb.winehq.org/objectManager.php?sClass=version&iId=11395 Relevant text: The bug link you submitted between Bug 7929 and Command & Conquer 3: Tiberium Wars Kane's Wrath: 1.0 has been accepted. ... Any thoughts? Erich Hoover ehoover(a)mines.edu

2 1

Coverity access
by John Klehm 23 Sep '09

23 Sep '09

Is there a local list of coverity defects for people like me with a spare moment here and there? Or if not is it possible to get me signed up? Thanks, --John Klehm

1 0

jscript: Update French translation
by Frédéric Delanoy 23 Sep '09

23 Sep '09

1 0

Re: shlwapi: implement StrChrNW
by Nikolay Sivov 23 Sep '09

23 Sep '09

Aric Stewart wrote: > --- > dlls/shlwapi/shlwapi.spec | 1 + > dlls/shlwapi/string.c | 23 +++++++++++++++++++++++ > 2 files changed, 24 insertions(+), 0 deletions(-) Maybe it's better to move this --- +@ stdcall StrChrNW(wstr long long) --- closer to context: --- @ stdcall StrChrA (str long) @ stdcall StrChrIA (str long) @ stdcall StrChrIW (wstr long) @ stdcall StrChrW (wstr long) --- to keep it consistent.

1 0