January 2010 - Wine-devel - list.winehq.org

re:CPP Check Runs Clean but found these Style Issues on Latest Git...
by Dan Kegel 17 Jan '10

17 Jan '10

You have some false positives, e.g. dlls/gdi32/enhmfdrv/mapping.c 1 The function EMFDRV_ModifyWorldTransform' is never used That function is indeed used in dlls/gdi32/enhmfdrv/init.c; the struct EMFDRV_Funcs is initialized with it. I guess cppcheck doesn't grok function pointers yet? - Dan

1 0

CPP Check Runs Clean but found these Style Issues on Latest Git...
by chris ahrendt 17 Jan '10

17 Jan '10

Don't know if anyone is interested in this or not but I thought I would send this out to the list. CPPCheck is now running clean on the GIT tree... but its showing some style issues. If they are there for API compatibility let me know and I will ignore them from now on. Here they are: File Line Style Problem dlls/dnsapi/ns_name.c 1 The function dns_ns_name_skip' is never used The function dns_ns_name_uncompress' is never used dlls/gdi32/enhmfdrv/mapping.c 1 The function EMFDRV_ModifyWorldTransform' is never used The function EMFDRV_OffsetViewportOrg' is never used The function EMFDRV_OffsetWindowOrg' is never used The function EMFDRV_ScaleViewportExt' is never used The function EMFDRV_ScaleWindowExt' is never used The function EMFDRV_SetMapMode' is never used The function EMFDRV_SetViewportExt' is never used The function EMFDRV_SetViewportOrg' is never used The function EMFDRV_SetWindowExt' is never used The function EMFDRV_SetWindowOrg' is never used The function EMFDRV_SetWorldTransform' is never used dlls/gdi32/mfdrv/dc.c 1 The function MFDRV_AbortPath' is never used The function MFDRV_BeginPath' is never used The function MFDRV_CloseFigure' is never used The function MFDRV_EndPath' is never used The function MFDRV_ExcludeClipRect' is never used The function MFDRV_FillPath' is never used The function MFDRV_FlattenPath' is never used The function MFDRV_IntersectClipRect' is never used The function MFDRV_OffsetClipRgn' is never used The function MFDRV_RestoreDC' is never used The function MFDRV_SaveDC' is never used The function MFDRV_SelectClipPath' is never used The function MFDRV_SetBkMode' is never used The function MFDRV_SetMapperFlags' is never used The function MFDRV_SetPolyFillMode' is never used The function MFDRV_SetRelAbs' is never used The function MFDRV_SetROP2' is never used The function MFDRV_SetStretchBltMode' is never used The function MFDRV_SetTextAlign' is never used The function MFDRV_SetTextCharacterExtra' is never used The function MFDRV_SetTextJustification' is never used The function MFDRV_StrokeAndFillPath' is never used The function MFDRV_StrokePath' is never used The function MFDRV_WidenPath' is never used dlls/rpcrt4/rpc_transport.c 1 The function RpcNetworkIsProtseqValidA' is never used dlls/rpcrt4/rpc_transport.c 700 The scope of the variable b_handle can be reduced dlls/wininet/cookie.c 1 The function IsDomainLegalCookieDomainW' is never used dlls/wininet/cookie.c 225 The scope of the variable len can be reduced dlls/wininet/dialogs.c 132 The scope of the variable q can be reduced dlls/wininet/dialogs.c 181 The scope of the variable u_len can be reduced dlls/wininet/ftp.c 359 The scope of the variable nResCode can be reduced dlls/wininet/ftp.c 1261 The scope of the variable retval can be reduced dlls/wininet/http.c 1 The function IsHostInProxyBypassList' is never used dlls/wininet/http.c 750 The scope of the variable userlen can be reduced dlls/wininet/http.c 751 The scope of the variable passlen can be reduced dlls/wininet/http.c 3355 The scope of the variable lpszCookies can be reduced dlls/wininet/http.c 3365 The scope of the variable cnt can be reduced dlls/wininet/http.c 3868 The scope of the variable headerlen can be reduced dlls/wininet/internet.c 1 The function DllMain' is never used dlls/wininet/internet.c 1464 The scope of the variable lpszNetLoc can be reduced dlls/wininet/internet.c 2712 The scope of the variable len can be reduced dlls/wininet/internet.c 2714 The scope of the variable status can be reduced dlls/wininet/urlcache.c 1 The function CreateUrlCacheContainerA' is never used The function CreateUrlCacheContainerW' is never used The function DeleteUrlCacheContainerA' is never used The function DeleteUrlCacheContainerW' is never used The function FindFirstUrlCacheContainerA' is never used The function FindFirstUrlCacheContainerW' is never used The function FindNextUrlCacheContainerA' is never used The function FindNextUrlCacheContainerW' is never used The function FreeUrlCacheSpaceA' is never used The function FreeUrlCacheSpaceW' is never used The function RegisterUrlCacheNotification' is never used dlls/wininet/urlcache.c 155 struct or union member _URLCACHE_HEADER::dwBlocksInUse' is never used dlls/wininet/urlcache.c 159 struct or union member _URLCACHE_HEADER::dwUnknown4' is never used dlls/wininet/urlcache.c 160 struct or union member _URLCACHE_HEADER::dwUnknown5' is never used dlls/wininet/urlcache.c 161 struct or union member _URLCACHE_HEADER::dwUnknown6' is never used dlls/wininet/urlcache.c 164 struct or union member _URLCACHE_HEADER::Unknown8' is never used dlls/wininet/urlcache.c 673 The scope of the variable error can be reduced dlls/wininet/urlcache.c 2190 The scope of the variable dwError can be reduced dlls/wininet/urlcache.c 2438 The scope of the variable len can be reduced dlls/wininet/urlcache.c 2731 The scope of the variable dwError can be reduced dlls/wininet/urlcache.c 2733 The scope of the variable len can be reduced libs/port/spawn.c 39 The scope of the variable wret can be reduced libs/wpp/ppl.yy.c 393 struct or union member yy_trans_info::yy_verify' is never used libs/wpp/ppl.yy.c 394 struct or union member yy_trans_info::yy_nxt' is never used libs/wpp/ppl.yy.c 3942 The scope of the variable new_alloc can be reduced libs/wpp/ppl.yy.c 4152 The scope of the variable new_alloc can be reduced libs/wpp/ppy.tab.c 265 struct or union member YYSTYPE::iptr' is never used libs/wpp/preproc.c 321 The scope of the variable len can be reduced loader/preloader.c 1 The function __bb_init_func' is never used The function __stack_chk_fail_local' is never used The function __stack_chk_fail' is never used The function wld_start' is never used tools/widl/client.c 80 The scope of the variable method_count can be reduced tools/widl/header.c 717 The scope of the variable first_iface can be reduced tools/widl/header.c 803 The scope of the variable first_iface can be reduced tools/widl/parser.tab.c 432 struct or union member YYSTYPE::array_dims' is never used tools/widl/parser.tab.c 439 struct or union member YYSTYPE::func_list' is never used tools/widl/parser.yy.c 388 struct or union member yy_trans_info::yy_verify' is never used tools/widl/parser.yy.c 389 struct or union member yy_trans_info::yy_nxt' is never used tools/widl/proxy.c 591 The scope of the variable first_func can be reduced tools/winebuild/import.c 227 The scope of the variable i can be reduced tools/winebuild/parser.c 913 The scope of the variable i can be reduced tools/winebuild/res32.c 281 The scope of the variable i can be reduced tools/winebuild/res32.c 600 The scope of the variable err can be reduced Chris

2 1

Re: [PATCH] mmdevapi: Add some basic tests for property store
by Paul Vriens 17 Jan '10

17 Jan '10

On 01/17/2010 02:11 PM, Maarten Lankhorst wrote: > +static void test_propertystore(IPropertyStore *store) > +{ > +} Is that one supposed to be empty ? -- Cheers, Paul.

2 1

Re: [Kernel32]Test for Bug 21292: Createfile creating with illegal char in name
by Paul Vriens 17 Jan '10

17 Jan '10

On 01/17/2010 01:27 PM, Uwe Bonnes wrote: > > CreateFile with an illegal character in the name fail on all systems beside > NT4 and wine when ordered to create the file. No test errors on my mchines > and the winetestbot (Job 319) If creating the file succeeds you should close the handle and delete the file. -- Cheers, Paul.

1 0

Re: sti: add launch application registry
by Paul Vriens 17 Jan '10

17 Jan '10

On 01/17/2010 10:09 AM, Damjan Jovanovic wrote: > + else > + skip("No StiCreateInstanceW function\n"); Shouldn't that be a win_skip() ? Why don't you do something like: if (!pStiCreateInstanceW) { win_skip("No StiCreateInstanceW function\n"); return; } That way you also get rid of one level of indentation for the big block. -- Cheers, Paul.

1 0

Winetest: What to do if NT4 behaves other then W2k and up
by Uwe Bonnes 17 Jan '10

17 Jan '10

Wine Bug 21292 shows a problem with CreateFileA("bla/n", GENERIC_READ, FILE_SHARE_READ | FILE_SHARE_WRITE, NULL, OPEN_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL) All winebot systems beside WNT4WSSP6 return ERROR_INVALID_NAME 123L, while wine and NT4 happily open the file. How to proceed? === WNT4WSSP6 (NT4 Workstation SP6 (English, IE2)) === file.c:875: Test failed: CreateFileA failed on nonexist.ent/, hFile 000000B4, err=0, should be 123 === W2KPROSP4 (Windows 2000 Professional SP4) === No test failures found === WXPPROSP3 (XP Professional SP3 (English, IE6)) === No test failures found === W2K3R2SESP2 (Server 2003 R2 Standard Edition SP2) === No test failures found === WVISTAADM (Windows Vista (English, IE7)) === No test failures found === W2K8SE (Server 2008 Standard Edition) === No test failures found -- Uwe Bonnes bon(a)elektron.ikp.physik.tu-darmstadt.de Institut fuer Kernphysik Schlossgartenstrasse 9 64289 Darmstadt --------- Tel. 06151 162516 -------- Fax. 06151 164321 ----------

3 2

Re: include: rename LIST_ENTRY to WINE_LIST_ENTRY to prevent a conflict on *BSD/OSX (resend) (1/7)
by Alexandre Julliard 17 Jan '10

17 Jan '10

Austin English <austinenglish(a)gmail.com> writes: > Subject: [PATCH 1/7] include: rename LIST_ENTRY to WINE_LIST_ENTRY to prevent a conflict on *BSD/OSX Don't do that. Fix the includes order in the files that fail to compile. -- Alexandre Julliard julliard(a)winehq.org

1 0

Unable to connect to #winehackers
by James Mckenzie 17 Jan '10

17 Jan '10

All: I have been trying to connect to #winehackers from my Mac using Conversation. However, this is not working as I am not receiving the welcome screen from irc.freenode.net. Anyone else experiencing this problem and have a workaround. I would really like to get onto winehackers to discuss the patch I've been working on. James McKenzie

3 2

Re: Unable to connect to #winehackers
by James Mckenzie 17 Jan '10

17 Jan '10

>Hi James, > >> I have been trying to connect to #winehackers from my Mac using Conversation. However, this is not working as I am not receiving the welcome screen from irc.freenode.net. > >There's possibly some issue with Freenode, as is not uncommon. Have you >tried connecting to any particular Freenode server manually? I seem to >be on "lindbohm.freenode.net", and it's working fine. > Owen: Thank you. However sending /msg nickserv help caused the program to crash. Also when I attempt to connect to winehackers I don't get the chat window. I will ask another MacOSX developer what he is using these days. James McKenzie

3 2

Code review request, fix for PATH setting bug 21322
by Dan Kegel 16 Jan '10

16 Jan '10

I was surprised to find that Wine didn't handle system-wide and user-local PATH together properly. The bug and a proposed fix are at http://bugs.winehq.org/show_bug.cgi?id=21322 Could someone review the patch before I risk sending it to wine-patches? I think it's clean, but my luck hasn't been good lately. Thanks, Dan

2 1