October 2010 - Wine-devel - list.winehq.org

Re: [1/2] msvcrt: Implement _mbsnbcat_s.
by Piotr Caban 20 Oct '10

20 Oct '10

Hi, On 10/20/10 08:49, Andrew Nguyen wrote: + * a lead byte and move the pointer back by one for later overwrite. */ + if (get_locale()->locinfo->mb_cur_max > 1 && MSVCRT_isleadbyte(*(ptr - 1))) + size++, ptr--; You may access dst-1. + ok(errno == EINVAL, "Expected errno to be EINVAL, got %d\n", ret); Printing ret here may be misleading. Cheers, Piotr

1 0

Re: [3/4]strmbase: implement OLE registration in AMovieDllRegisterServer2
by Alexandre Julliard 20 Oct '10

20 Oct '10

Aric Stewart <aric(a)codeweavers.com> writes: > HRESULT WINAPI AMovieDllRegisterServer2(BOOL bRegister) > { > HRESULT hr; > int i; > IFilterMapper2 *pIFM2 = NULL; > + HMODULE psapi; > + fnGetModuleFileNameExW pFunc; > + WCHAR szFileName[MAX_PATH]; > + > + psapi = LoadLibraryA("psapi.dll"); > + if (psapi) > + { > + pFunc = (fnGetModuleFileNameExW)GetProcAddress(psapi, "GetModuleFileNameExW"); > + if (pFunc) > + { > + if (!pFunc(GetCurrentProcess(), g_hInst, szFileName, MAX_PATH)) > + { > + ERR("Failed to get module file name for registration\n"); > + return E_FAIL; > + } > + } > + else > + { > + ERR("Failed to get get function GetModuleFileNameExW\n"); > + return E_FAIL; > + } > + } > + else > + { > + ERR("Failed to load psapi.dll\n"); > + return E_FAIL; > + } > + FreeLibrary(psapi); There's no reason to use psapi for this. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: oleaut32/tests: Better reflect the naming scheme
by Alexandre Julliard 20 Oct '10

20 Oct '10

André Hentschel <webmaster(a)dawncrow.de> writes: > @@ -10,7 +10,7 @@ C_SRCS = \ > typelib.c \ > usrmarshal.c \ > varformat.c \ > - vartest.c \ > + variant.c \ > vartype.c Renaming tests should be avoided, it makes it hard to follow the history on test.winehq.org. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [1/7] msxml3/tests: internal schema doc storage tests (resend)
by Alexandre Julliard 20 Oct '10

20 Oct '10

Adam Martinson <amartinson(a)codeweavers.com> writes: > +#define _create(cls) cls, #cls > + > +#define _obj(cls, ...) &_create(cls ## __VA_ARGS__) You can't do that, varargs macros are not portable. -- Alexandre Julliard julliard(a)winehq.org

1 0

Translation of the AppDB
by Yaron Shahrabani 20 Oct '10

20 Oct '10

Is there any way to localize the AppDB? The Israeli community assumes that having a Hebrew system will make more users report issues. Kind regards, Yaron Shahrabani <Hebrew translator>

4 6

Re: msxml3/domdoc: Partially implement ::setAttributeNode()
by testbot＠testbot.winehq.org 20 Oct '10

20 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6343 Your paranoid android. === WXPPROSP3 (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W2K3R2SESP2 (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === WVISTAADM (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W2K8SE (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W7PRO (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W7PROX64 (32 bit domdoc) === domdoc.c:6872: Test failed: got 1 === W7PROX64 (64 bit domdoc) === domdoc.c:6872: Test failed: got 1

1 0

Re: windowscodecs: Fix *_CopyPixels functions to properly handle a NULL rectangle
by Vincent Povirk 20 Oct '10

20 Oct '10

+1 + if (!prc) + { + UINT width, height; + hr = IWICBitmapSource_GetSize(This->source, &width, &height); + if (FAILED(hr)) return hr; + rc.X = 0; + rc.Y = 0; + rc.Width = width; + rc.Height = height; + prc = &rc; + } Any reason you didn't use this approach in the other functions?

5 6

Re: [3/6] msxml3/tests: internal schema doc storage tests (try 2)
by Alexandre Julliard 19 Oct '10

19 Oct '10

Adam Martinson <amartinson(a)codeweavers.com> writes: > --- > dlls/msxml3/tests/schema.c | 438 > +++++++++++++++++++++++++++++++++----------- > 1 files changed, 334 insertions(+), 104 deletions(-) Please don't resend just a patch marked 3/6, resend a proper series numbered from 1 so that winetestbot can figure it out. -- Alexandre Julliard julliard(a)winehq.org

2 3

Re: [PATCH] mscms: Handle bitmap formats BM_xRGBQUADS and BM_xBGRQUADS in from_bmformat( BMFORMAT format )
by Hans Leidekker 19 Oct '10

19 Oct '10

On Mon, 2010-10-18 at 18:10 +0200, Tomasz Michno wrote: > +/* unfortunately GetProcAddress cannot return proper pointer to > from_bmformat() function, but for this function it's not a problem, > using copy from ../transform.c */ That's not how it's done in Wine, you will need to go through the API. In this case that means you need to define a bitmap in the appropriate format, create a color transform and then call TranslateBitmapBits. Note that Wine doesn't bundle a color profile, so you need to install one, or configure your X server to use one and retrieve it via GetICMProfile.

2 2

Re: [1/2] windowscodecs: Fix *_CopyPixels functions to properly handle a NULL rectangle (try 2).
by Alexandre Julliard 19 Oct '10

19 Oct '10

Krzysztof Nowicki <krissn(a)op.pl> writes: > I've decided to keep the optimisation in copy_pixels() that checks if the source > and dest rectangles + strides matches and if yes, does a straight memcpy of the > whole bitmap. Please do this as a separate patch. -- Alexandre Julliard julliard(a)winehq.org

1 0