October 2010 - Wine-devel - list.winehq.org

Website: Change language string
by Yaron Shahrabani 17 Oct '10

17 Oct '10

Where does the translation of "Change Language" string at the bottom of the page and in the lang.template come from? (The current term used is male specific, I want to make it genderless). Kind regards, Yaron Shahrabani <Hebrew translator>

2 2

Packagers: cups-bsd/cupsys-bsd (lpr and friends) no longer needed
by Detlef Riekenberg 16 Oct '10

16 Oct '10

Hi Wine packing Team. Cups has a compatibility package for the BSD style printing system (lpr, lpq, lprm, lpc and related files). The package is named cups-bsd on ubuntu and cupsys-bsd on debian. This compatibility package is no longer needed since Wine-1.3.5, when cups is installed: http://source.winehq.org/git/wine.git/?a=commit;h=f69a4ef07f7b1b0017e1bf335… Thanks for updating the Wine dependency. -- By by ... Detlef

2 1

Re: user32: Update last active popup for all parents
by testbot＠testbot.winehq.org 16 Oct '10

16 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6225 Your paranoid android. === W7PROX64 (64 bit win) === win.c:2684: Test failed: GetActiveWindow() = 0000000000000000 win.c:2684: Test failed: GetFocus() = 0000000000000000 win.c:2710: Test failed: GetActiveWindow() = 0000000000000000 win.c:2710: Test failed: GetFocus() = 0000000000000000 win.c:2769: Test failed: GetActiveWindow() = 0000000000000000 win.c:2769: Test failed: GetFocus() = 0000000000000000

1 0

Re: [PATCH] problem with color management with mscms and gdi
by Detlef Riekenberg 16 Oct '10

16 Oct '10

Hi Tomasz. Welcome to Wine. You already fixed your missing real name in your first patch. That is good, but there are more suggestions. > For applications which uses EnumICMProfiles to detect monitor icc profile, > there should be a copy of monitor profile in > windows\system32\spool\drivers\color\monitor.icc. If there is no monitor.icc > in this directory, application works the same as if there were no color > management enabled (but image is displayed ok). A description for the issue is a good idea. > INT WINAPI EnumICMProfilesA(HDC hdc, ICMENUMPROCA func, LPARAM > lparam) > { > FIXME("%p, %p, 0x%08lx stub\n", hdc, func, lparam); > - return -1; > + (*func)("C: > \\windows\\system32\\spool\\drivers\\color\\monitor.icc",lparam); > + FIXME("partially fixed: force C: > \\windows\\system32\\spool\\drivers\\color\\monitor.icc\n"); > + return 1; > } What you wrote in your patch is a hack and hacks are missing the code quality to be accepted in Wine. Wine development is test driven. You should add some tests for this function and try to invent a real implementation, which match the tests. - Does this function handle a NULL parameter for hdc and/or for func? (If a NULL produce a crash on Windows, there is no need to check for a NULL in the implementation in Wine) - What does the function return, when the directory does not exist or when there are no icc profiles in the directory? - A HDC for a window on the monitor is not the only type for an HDC. (memory, printers, metafiles) Implementing all possible types is not a requirement (as long, as an app does not need it), but the usual way in Wine is at least printing a FIXME for the unimplemented part of the API. - There are usable API functions, to get the icc profile path. - Reading the directory and calling the user func for every file is not very difficult, as wine has examples in the source. You can ask for help for the implementation or for the tests on wine-devel or use #winehackers on freenode. There is has also http://testbot.winehq.org and later http://tests.winehq.org > INT WINAPI EnumICMProfilesW(HDC hdc, ICMENUMPROCW func, LPARAM ... > + (*func)("C: > \\windows\\system32\\spool\\drivers\\color\\monitor.icc",lparam); Providing an ANSI Path to a UNICODE callback will never work. > /********************************************************************** > diff --git a/dlls/mscms/transform.c b/dlls/mscms/transform.c This is a separate Patch I know, that the starting step is not easy, but once you contributed successfully to Wine, your Development results (patches) are much better. Did you read http://wiki.winehq.org/DeveloperFaq and http://wiki.winehq.org/SubmittingPatches ? Overview: http://wiki.winehq.org/Developers -- By by ... Detlef

1 0

Re: [PATCH] problem with color management with mscms and gdi
by André Hentschel 16 Oct '10

16 Oct '10

Hi and welcome to wine development, your patch is wrapped. see the gdi part of it at http://source.winehq.org/patches/. so you should check your mailclient. Further you might want to split it per module (gdi and mscms, one patch each) -- Best Regards, André Hentschel

2 1

Re: [PATCH] problem with color management with mscms and gdi
by Hans Leidekker 16 Oct '10

16 Oct '10

Hi Tomasz, This patch is wrapped, unlike your first attempt were you attached the patch. > dlls/gdi32/icm.c | 8 ++++++-- > dlls/mscms/transform.c | 2 ++ > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/dlls/gdi32/icm.c b/dlls/gdi32/icm.c > index 0e346ee..d75c528 100644 > --- a/dlls/gdi32/icm.c > +++ b/dlls/gdi32/icm.c > @@ -44,7 +44,9 @@ WINE_DEFAULT_DEBUG_CHANNEL(icm); > INT WINAPI EnumICMProfilesA(HDC hdc, ICMENUMPROCA func, LPARAM > lparam) > { > FIXME("%p, %p, 0x%08lx stub\n", hdc, func, lparam); > - return -1; > + (*func)("C: > \\windows\\system32\\spool\\drivers\\color\\monitor.icc",lparam); > + FIXME("partially fixed: force C: > \\windows\\system32\\spool\\drivers\\color\\monitor.icc\n"); > + return 1; > } You can't hardcode the filename like that. EnumICMProfiles should call down into the driver and probably enumerate a registry key. > /********************************************************************** > diff --git a/dlls/mscms/transform.c b/dlls/mscms/transform.c > index a795386..e7a3faa 100644 > --- a/dlls/mscms/transform.c > +++ b/dlls/mscms/transform.c > @@ -65,6 +65,8 @@ static DWORD from_bmformat( BMFORMAT format ) > { > case BM_RGBTRIPLETS: return TYPE_RGB_8; > case BM_BGRTRIPLETS: return TYPE_BGR_8; > + case BM_xRGBQUADS: return TYPE_RGBA_8; > + case BM_xBGRQUADS: return TYPE_ABGR_8; > case BM_GRAY: return TYPE_GRAY_8; > default: > if (quietfixme == 0) You should send this as a separate patch.

1 0

Re: [Website] Foundation of the Hebrew website
by James McKenzie 16 Oct '10

16 Oct '10

On 10/11/10 9:28 AM, Yaron Shahrabani wrote: > Started some translation work, there is still much more RTLing work to > do so we will settle for an LTR for now and I will handle it soon. > Yaron Shahrabani > > <Hebrew translator> > > > > Yaron: Since the web site works runs on a Web Server, should you not be building the work RTL rather than LTR? Just a thought, mind you and it might save work later. James McKenzie

2 4

Re: [2/6] msxml3: IXMLDOMSchemaCollection/XMLSchemaCache backend
by Nikolay Sivov 16 Oct '10

16 Oct '10

On 10/15/2010 18:25, Adam Martinson wrote: > > Implemented on top of libxml's hash table. > --- > dlls/msxml3/schema.c | 376 > +++++++++++++++++++++++++++++++++++++++++++------- > 1 files changed, 326 insertions(+), 50 deletions(-) > +static LONG cache_entry_release(cache_entry* entry) > { > - schema_t *This = impl_from_IXMLDOMSchemaCollection( iface ); > + LONG ref = InterlockedDecrement(&entry->ref); > + TRACE("%p new ref %d\n", entry, ref); > > - TRACE("(%p)->(%s %p)\n", This, debugstr_guid( riid ), ppvObject ); > + if (ref == 0) > + { > + if (entry->type == SCHEMA_TYPE_XSD) > + { > + xmldoc_release(entry->doc); > + entry->schema->doc = NULL; > + xmlSchemaFree(entry->schema); > + heap_free(entry); > + } > + else /* SCHEMA_TYPE_XDR */ > + { > + xmldoc_release(entry->doc); > + heap_free(entry); > + } > + } > + return ref; > +} Looks a but redundant. xmldoc_release() and heap_free(entry) are always used, so only xmlSchemaFree() and doc reset before it should be under condition. > + xmlNodePtr root; > + if (schema) > + root = xmlDocGetRootElement(schema); > + if (root&& root->ns) > + { root uninitialized? If this never happens practically then remove if (schema) condition. > - IXMLDOMSchemaCollection_AddRef( iface ); > + IXMLDOMSchemaCollection_AddRef(iface); > > return S_OK; > } > > -static ULONG WINAPI schema_cache_AddRef( IXMLDOMSchemaCollection *iface ) > +static ULONG WINAPI schema_cache_AddRef(IXMLDOMSchemaCollection *iface) No need for such changes here and later in this patch, even some new added lines use white-spaces in such cases. > + IXMLDOMNode* domnode = NULL; > + IDispatch_QueryInterface(V_DISPATCH(&var),&IID_IXMLDOMNode, (void**)&domnode); > + > + if (domnode) > + doc = xmlNodePtr_from_domnode(domnode, XML_DOCUMENT_NODE)->doc; Not sure about that, I'd say it's better to test for hr == S_OK and return value from QueryInterface, is this branch tested?

1 0

Re: [1/6] msxml3: add a function to initialize xmlDoc->_private data
by Nikolay Sivov 16 Oct '10

16 Oct '10

On 10/15/2010 18:25, Adam Martinson wrote: > > Needed to associate an internal ref count, etc with a xmlDoc > outside of domdoc.c, without creating the whole domdoc struct. > --- > dlls/msxml3/domdoc.c | 6 ++++++ > dlls/msxml3/msxml_private.h | 1 + > 2 files changed, 7 insertions(+), 0 deletions(-) Why not use this helper in DOMDocument_create() ?

1 0

Re: [6/6] msxml3: implement schema_cache_addCollection()
by testbot＠testbot.winehq.org 16 Oct '10

16 Oct '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6213 Your paranoid android. === W98SE (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:342: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:346: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:460: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:461: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:462: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:464: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 === WNT4WSSP6 (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:342: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:346: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:460: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:461: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:462: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:464: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 === W2KPROSP4 (32 bit schema) === schema.c:233: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:340: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:341: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:342: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:344: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:345: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:346: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154 schema.c:460: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:461: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:462: Test failed: failed to create CLSID_DOMDocument instance: 0x80040154 schema.c:464: Test failed: failed to create CLSID_XMLSchemaCache instance: 0x80040154

1 0