December 2010 - Wine-devel - list.winehq.org

Re: [try 2] msvcrt: Implement wcsnicoll
by Andrew Nguyen 04 Dec '10

04 Dec '10

On Fri, Dec 3, 2010 at 11:21 AM, Mike Gibson <mike.gibson(a)storagecraft.com> wrote: > Had a typo in the first try. > --- > dlls/msvcr100/msvcr100.spec | 2 +- > dlls/msvcr70/msvcr70.spec | 2 +- > dlls/msvcr80/msvcr80.spec | 2 +- > dlls/msvcr90/msvcr90.spec | 2 +- > dlls/msvcrt/msvcrt.spec | 2 +- > dlls/msvcrt/wcs.c | 9 +++++++++ > include/msvcrt/string.h | 1 + > include/msvcrt/wchar.h | 1 + > 8 files changed, 16 insertions(+), 5 deletions(-) > > > You forgot to attach the patch.

1 0

Re: [PATCH 2/6] quartz: Add support for filtermapper3 to filtergraph
by Alexandre Julliard 03 Dec '10

03 Dec '10

Maarten Lankhorst <m.b.lankhorst(a)gmail.com> writes: > @@ -269,6 +269,9 @@ static HRESULT WINAPI FilterGraphInner_QueryInterface(IUnknown * iface, > } else if (IsEqualGUID(&IID_IFilterMapper2, riid)) { > *ppvObj = This->pFilterMapper2; > TRACE(" returning IFilterMapper2 interface from aggregated filtermapper (%p)\n", *ppvObj); > + } else if (IsEqualGUID(&IID_IFilterMapper3, riid)) { > + *ppvObj = This->pFilterMapper2; > + TRACE(" returning IFilterMapper3 interface from aggregated filtermapper (%p)\n", *ppvObj); You have to query that interface first. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] user32/tests: Disable IME for msg tests.
by Marvin 03 Dec '10

03 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7434 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: [PATCH] user32/tests: Close second window in DBCS WM_CHAR tests.
by Marvin 03 Dec '10

03 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7432 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: [1/7] urlmon: Standardize COM implementation of IUri
by Alexandre Julliard 03 Dec '10

03 Dec '10

Thomas Mullaly <thomas.mullaly(a)gmail.com> writes: > @@ -3567,7 +3567,7 @@ static HRESULT set_builder_component(LPWSTR *component, DWORD *component_len, LP > return S_OK; > } > > -#define URI(x) ((IUri*) &(x)->lpIUriVtbl) > +#define URI(x) ((IUri*) &(x)->IUri_iface.lpVtbl) > #define URIBUILDER(x) ((IUriBuilder*) &(x)->lpIUriBuilderVtbl) You should also get rid of these macros. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: Death to win9x?
by James Mckenzie 03 Dec '10

03 Dec '10

Alexandre Julliard <julliard(a)winehq.org> wrote: >Sent: Dec 2, 2010 6:30 AM >To: Joerg-Cyril.Hoehle(a)t-systems.com >Cc: wine-devel(a)winehq.org >Subject: Re: Death to win9x? > ><Joerg-Cyril.Hoehle(a)t-systems.com> writes: > >> However, this only allows to run one test at a time, i.e. the big picture is missing. >> Therefore I'd suggest running winetest.exe on all testbot machines once a week >> or some such, e.g. only for releases. > >That's not useful. The whole point is that we don't want to spend the >effort required to keep the tests error-free on platforms that we don't >care about. That makes it easier to write tests for platforms that >actually matter, which is a more productive use of everybody's time. > YOU might not care about them AJ, but we have Wine users that are still using Windows95 programs with Wine on Linux and there are NO suitable replacements for them. Several recent user reports have asked how do I get program X (released for Windows95) to work on Wine. One of my test programs is dOOmII, released in 1996 and I use Wine to run it. Should I just go out and find a copy of Windows98SE and VirtualBox to run this on? Your reply makes it sound like the Wine program just does not care if Windows9x functionality does not matter, it does. I do agree that not much effort should be expended to incorporate more 'A' functionality, but breaking what does work is not reflect well on this project. Remember the original purpose and I think it is still the purpose is to build out the ENTIRE Windows64/32 API, not just a portion of it. If I'm wrong, feel free to chastise me. James McKenzie

4 3

Re: ddeml: More calling convention fixes
by Dmitry Timoshkov 03 Dec '10

03 Dec '10

Tristan Schmelcher <tristan_schmelcher(a)alumni.uwaterloo.ca> wrote: > + if (cbData != (DWORD)-1) > + { > + /* pData is not a pointer if cbData is -1, so we linearize the address > + * here rather than in the calling code. */ > + pData = MapSL((SEGPTR)pData); > + } -1 here should be replaced by CBR_BLOCK, and this piece of the patch should be sent separately from .spec file fixes. -- Dmitry.

2 2

Re: msvcrt: Implement wcsnicoll
by Juan Lang 03 Dec '10

03 Dec '10

Hi Mike, --- a/dlls/msvcr70/msvcr70.spec +++ b/dlls/msvcr70/msvcr70.spec @@ -601,7 +601,7 @@ @ cdecl _wcslwr(wstr) msvcrt._wcslwr @ stub _wcsncoll @ cdecl _wcsnicmp(wstr wstr long) msvcrt._wcsnicmp -@ stub _wcsnicoll +@ cdecl _wcsnicoll(wstr wstr long) msvcrt._wcsnicmp Typo?

1 0

Re: [3/7] urlmon: Implemented PARSE_PATH_FROM_URL for CoInternetParseIUri
by Marvin 03 Dec '10

03 Dec '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=7419 Your paranoid android. === WVISTAADM (32 bit uri) === Failure running script in VM: The specified guest user must be logged in interactively to perform this operation

1 0

Re: wineqtdecoder: initial commit of the video decoder using Mac OS/X QuickTime Framework
by C.W. Betts 03 Dec '10

03 Dec '10

The main problem when using the QuickTime C APIs is that the majority, if not all of it, is deprecated and not available on 64-bit code. I would suggest using the Objective-C QTKit, but apparently Objective-C code is a no-no in Wine. On Nov 29, 2010, at 10:31 AM, Aric Stewart wrote: > --- > configure | 8 +- > configure.ac | 5 + > dlls/wineqtdecoder/Makefile.in | 11 + > dlls/wineqtdecoder/main.c | 135 +++++++++ > dlls/wineqtdecoder/qtvdecoder.c | 536 +++++++++++++++++++++++++++++++++ > dlls/wineqtdecoder/version.rc | 26 ++ > dlls/wineqtdecoder/wineqtdecoder.spec | 4 + > 7 files changed, 724 insertions(+), 1 deletions(-) > create mode 100644 dlls/wineqtdecoder/Makefile.in > create mode 100644 dlls/wineqtdecoder/main.c > create mode 100644 dlls/wineqtdecoder/qtvdecoder.c > create mode 100644 dlls/wineqtdecoder/version.rc > create mode 100644 dlls/wineqtdecoder/wineqtdecoder.spec > > > <89fa3b1cdaca45ec01cde9e2350010b82c985666.diff>

3 3