April 2010 - Wine-devel - list.winehq.org

Re: Minor dlls/localspl/tests/localmon.c simplificiation
by Nikolay Sivov 02 May '10

02 May '10

On 4/23/2010 16:50, Gerald Pfeifer wrote: > In addition to just building this patch as is, I also gave it a spin > changing the if (0) to if (1) to ensure this still builds (it should, > of course, and it does, but...) > > Gerald > > ChangeLog: > Remove variable res which is not really used from test_XcvClosePort. > We should better test for return value than remove it.

2 3

Re: Minor dlls/comctl32/tests/listview.c simplification
by Nikolay Sivov 02 May '10

02 May '10

On 4/21/2010 21:32, Gerald Pfeifer wrote: > ChangeLog: > Remove variable hwndheader which is not really used from test_items. > > diff --git a/dlls/comctl32/tests/listview.c b/dlls/comctl32/tests/listview.c > index 2c5ef70..06f2ddd 100644 > --- a/dlls/comctl32/tests/listview.c > +++ b/dlls/comctl32/tests/listview.c > @@ -1182,7 +1182,7 @@ static void test_items(void) > > static void test_columns(void) > { > - HWND hwnd, hwndheader; > + HWND hwnd; > LVCOLUMN column; > DWORD rc; > INT order[2]; > @@ -1207,7 +1207,6 @@ static void test_columns(void) > > /* LVM_GETCOLUMNORDERARRAY */ > hwnd = create_listview_control(LVS_REPORT); > - hwndheader = subclass_header(hwnd); > > memset(&column, 0, sizeof(column)); > column.mask = LVCF_WIDTH; > Hi, Gerald. You can't do this, subclassing is important thing here. And you will see it if you run a test (that you should do before sending patch actually).

2 1

Re: Francois Gouget : winedbg: Fix compilation with gcc 2. 95 and non-GNU compilers.
by Eric Pouech 02 May '10

02 May '10

Alexandre Julliard a écrit : > Module: wine > Branch: master > Commit: 51dfd9adb11885daec878737f18f89fb05c1516c > URL: http://source.winehq.org/git/wine.git/?a=commit;h=51dfd9adb11885daec878737f… > > Author: Francois Gouget <fgouget(a)free.fr> > Date: Sat Mar 27 16:55:27 2010 +0100 > > winedbg: Fix compilation with gcc 2.95 and non-GNU compilers. > François, what was the exact issue here ? I guess that the ; at the end of the attribute definition for GNUCC compiler was missing for the non gnu C compilers ? your fix is wrong as dbg_printf doesn't take a va_list as argument (you'd want dbg_vprintf which doesn't exist) does the attached patch work in your configuration ? A+ -- Eric Pouech "The problem with designing something completely foolproof is to underestimate the ingenuity of a complete idiot." (Douglas Adams) diff --git a/programs/winedbg/db_disasm64.c b/programs/winedbg/db_disasm64.c index 98f7ef2..88fa0dd 100644 --- a/programs/winedbg/db_disasm64.c +++ b/programs/winedbg/db_disasm64.c @@ -32,24 +32,13 @@ #include <stdio.h> #include "debugger.h" -#ifndef __GNUC__ -#define __attribute__(X) +#ifdef __GNUC__ +static int (*db_printf)(const char* format, ...) __attribute__((format (printf,1,2))); +#else +static int (*db_printf)(const char* format, ...); #endif -static int db_debug = 0; -static int db_printf(const char* format, ...) __attribute__((format (printf,1,2))); -int db_printf(const char* format, ...) -{ - va_list valist; - int len = 0; - if (db_debug) - { - va_start(valist, format); - len = dbg_printf(format, valist); - va_end(valist); - } - return len; -} +static int no_printf(const char* format, ...) {return 0;} typedef DWORD_PTR db_addr_t; typedef BOOL boolean_t; @@ -93,7 +82,7 @@ static ULONG64 db_get_value(db_addr_t addr, int size, int is_signed) static void db_printsym(db_addr_t addr, unsigned unused) { - if (db_debug) + if (db_printf != no_printf) { ADDRESS64 a; @@ -1656,6 +1645,6 @@ db_disasm(db_addr_t loc, boolean_t altfmt) void be_x86_64_disasm_one_insn(ADDRESS64 *addr, int display) { - db_debug = display; + db_printf = display ? dbg_printf : no_printf; addr->Offset = db_disasm(addr->Offset, TRUE); }

2 3

new wisotool 20100424: new verbs 3dmark2000, 3dmark2001, 3dmark03, 3dmark05, 3dmark06, baldursgate2, gta_vc, pcmark04, pcmark05, unigine_heaven
by Dan Kegel 02 May '10

02 May '10

wisotool is a handy winetricks-like script for automatically installing games from .iso files copied from your own dvds (or, if the game is freely downloadable, it will download it). Just like winetricks, it is intended to make testing Wine easier, but might be useful for people who simply want to install games. Unlike winetricks, wisotool is quiet by default; it doesn't ask any questions (except, for now, it prompts for the root password so it can mount the .iso file; later it will use fuse instead). This version is the first to be called a release. Currently supported apps are: 3dmark03 3D Mark 03 (Futuremark, 2003) [download] 3dmark05 3D Mark 05 (Futuremark, 2005) [download] 3dmark06 3D Mark 06 (Futuremark, 2006) [download] 3dmark2000 3DMark2000 (MadOnion.com, 2000) [download] 3dmark2001 3DMark2001 (MadOnion.com, 2001) [download] assassinscreed Assassins Creed (Ubisoft, 2008) baldursgate2 Baldurs Gate 2 - Shadows of Amn (Bioware, 2000) diablo2 Diablo II (Blizzard, 2000) dragonage Dragon Age: Origins (Bioware, 2009) gta_vc Grand Theft Auto: Vice City (Rockstar, 2003) morrowind The Elder Scrolls III: Morrowind (Bethesda, 2002) pcmark04 PC Mark 04 (Futuremark, 2004) [download] pcmark05 PC Mark 05 (Futuremark, 2005) [download] plantsvszombies Plants vs. Zombies (PopCap Games, 2009) [download] quake3 Quake 3 (ID Software, 1999) re5bench Resident Evil 5 Benchmark (Capcom, 2009) [download] sims3 The Sims 3 (EA, 2009) starcraft2 Starcraft II beta (Blizzard, 2010) starcraft Starcraft Battle Chest (Blizzard, 1998) stfu Starwars: The Force Unleashed (Aspyr, 2009) unigine_heaven Unigen Heaven 2 Benchmark (Unigen, 2010) [download] wog World of Goo demo (2D Boy, 2008) [download] It's available at http://kegel.com/wine/wisotool You can read more about it at http://wiki.winehq.org/wisotool Please report bugs via http://code.google.com/p/winezeug/issues/

3 5

Re: [2/4] rsaenh: Fixing a testfailure because Win7 seems to support salt with AES
by Juan Lang 30 Apr '10

30 Apr '10

Hi Andre, I don't object to this patch per se, but: - ok(!result && (GetLastError() == NTE_BAD_KEY || GetLastError() == ERROR_NO_TOKEN /* Win7 */), - "expected NTE_BAD_KEY or ERROR_NO_TOKEN, got %08x\n", GetLastError()); + todo_wine ok(broken(!result && GetLastError() == NTE_BAD_KEY) || result /* Win7 */, + "CryptGetKeyParam failed, got %08x\n", GetLastError()); Why don't you fix rsaenh while you're at it? It'd be an exceedingly easy patch. Look for KP_SALT in rsaenh.c, and you'll see what I mean. --Juan

2 1

South East Linux Fest
by Steven Edwards 30 Apr '10

30 Apr '10

Hi, I'm going to be running a both at the South East Linux Fest in Spartanburg SC June 11th-13th. If any wine hackers or lurkers from the South Eastern United States want to come out and help, drop me a note privately. I can't offer much in accommodation but I'll provide beer. Thanks -- Steven Edwards "There is one thing stronger than all the armies in the world, and that is an idea whose time has come." - Victor Hugo

1 0

Re: (resend) shell32: handle NULL pName in ShellLink fnSetDescription.
by testbot＠testbot.winehq.org 30 Apr '10

30 Apr '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=1835 Your paranoid android. === WNT4WSSP6 (32 bit shelllink) === shelllink.c:144: Test failed: GetDescription returned 'Some description'

1 0

Bugzilla not updated on server
by Vitaliy Margolen 30 Apr '10

30 Apr '10

Alexandre committed a patch to remove few no longer working links. But the bugzilla on Wine's server still showing those links. Is the bugzilla automatically being pulled from git? Vitaliy.

1 0

Re: Benchmarking D3D?
by Roderick Colenbrander 30 Apr '10

30 Apr '10

On Sun, Apr 18, 2010 at 8:32 PM, Stefan Dösinger <stefandoesinger(a)gmx.at> wrote: > > Am 18.04.2010 um 18:33 schrieb Roderick Colenbrander: >> There's not much better than can be done. Some games use the same >> calculation as in Wine while others take into account previous >> results. Here I have adjusted the code to basically: current_fps = >> 0.1*last_fps + 0.9*frames/(current_time - prev_time) and adjusted the >> sample period to 1s. This made the fps a bit more accurate. > My main concern here is separating different parts of the runs. A while ago the ATI developers asked for a fps average for the entire runtime of the app. That is good for their small samples, but if you use this with e.g. HL2 the time it takes to load the game from disk comes into play. > > I'm not saying that benchmarking load times is bad, but you want to separate that from the play benchmark. With the apps I use the game knows when it stops loading and when it starts rendering, which is why I consider the game's results more trustworthy than the +fps channel. > > --snip 1-- > > While we're talking about it, I've brought my "amd64" test box live again, so we should get fresh test results from a GF7600 card. I have a new Linux box with an ATI card, and I've set up the tests there as well, but before I can run them reasonably I have to wait for the next fglrx release to get the FBO crash fixed. > > --snip 2-- > > I am thinking about extending this a bit, and write a wrapper d3d9.dll that can monitor d3d calls, and catch e.g. a shader that signals that the main game rendering has started / stopped, etc. With such a setup we can start thinking about taking screenshots(in a separate run of course) to see if the rendering result is roughly what we expect. If I extend the idea a little, make it slightly less Wine and D3D specific and find a fancy title(e.g. "Quality Assurance in interactive 3D applications") I might get a master's thesis out of it. > > Implementation details aside it would be very useful if a mechanism can take advantage of GPU monitor APIs like the ones from nvidia perfkit and GL_AMD_performance_monitor. This would also allow us to monitor what is holding up the GPU. I have been looking into nvperfkit the past few days. The current Linux version is based on the 173.x drivers (ancient but they would work fine for your geforce 7600). As a workaround I have been experimenting a bit on Windows mostly in the hope to get NVPerfkit running on WineD3D there. In the end WineD3D worked and perfkit also installed (there were some issues for 32-bit apps on Win7) but then it appeared that my GPU is too new yet (it is a GTS 360M), so it doesn't work yet. In case of AMD no special drivers are needed, so perhaps I'll give GL_AMD_performance_monitor a shot but they say that on Linux due to lack of good tools it is a bit hard to use. Roderick

3 3

new wisotool 20100424: new verbs 3dmark2000, 3dmark2001, 3dmark03, 3dmark05, 3dmark06, baldursgate2, gta_vc, pcmark04, pcmark05, unigine_heaven
by wylda＠volny.cz 30 Apr '10

30 Apr '10

> I'm ripping it now, but it's pretty slow, comparatively. Tons of: > Found L-EC error at sector 1589216 - ignored. Good luck and hopefully your DVD drive will survive it ;) After long tests, i choosed (year ago) Alcohol 120% as the ripping tool, because it produced most number of working backup copies and makes them fast. However, if the safedisc image will work most depends on DVD drive. Again from personal test of 5 bought drives Samsung SH-S223F is winner for me. And for loading such image under linux i use http://www.cdemu.org so mounting an image is done by: cdemu load 0 my_image.mds cdemu unload 0 my_image.mds This SW need a kernel module, so it's not easy as other tools, but the reward is, you can SafeDisc/SecuROM working without needing a crack (of course the image have to firstly work under WinXP and wine have to support such protection like SecuROM v7.30.0014). Unfortunately SecuROM v7.27.0014 doen't work in wine, because of "Unsupported ioctl 2d0c04", but bug 20935 Anastasius how to overcome, but i don't know where to put the heck 0. So if wisotool would support "cdemu load", that would be tool even for me ;)

2 1