May 2010 - Wine-devel - list.winehq.org

Re: Release plans
by James Mckenzie 27 May '10

27 May '10

Austin English <austinenglish(a)gmail.com> wrote: > >On Fri, May 21, 2010 at 3:47 AM, <Joerg-Cyril.Hoehle(a)t-systems.com> wrote: >>>> And I didn't write trivial Mac patches either, e.g. to have >>>> wineprefixcreate symlink c:\users\xyz\ Desktop + Videos + Documents + >>>> Music to /Users/xyz/Desktop/ etc. This happens on Linux, not on MacOS. >>>> That's another (example of a) missing element. >>>> (Why didn't I write it? Because I was unsure where to put the #ifdef) >>>Isn't that linking done relative to $HOME, which should resolve to >>>/Users/xyz on Mac? >> That's not the problem. What I also don't know is whether I could hardcode >> the directories ~/Documents etc. (these already exist in my /Users/xyz, >> (but what about Tiger?)), or whether I ought to call some OSX API that >> yields the name of the dir (and possibly creates it if it does not yet exist). >> I'm not familiar at all with Mac APIs, but it sounds like an easy patch >> for somebody with a little MacOS programming knowledge. > >I haven't used Tiger in ages, but at least for me on Snow Leopard, I >can't delete those directories, since OSX considers them 'essential to >OS function'. The likelihood of them missing is small, IMHO. > Correct. However, you are free to create new directories for these functions and use them, except the Desktop. The location of these files could be changed but that is mostly beyond most Mac Users. Defaulting to $HOME/Desktop and $HOME/Documents is a good first step. James McKenzie

4 3

Re: user32/tests: check return value of GetUpdateRect in test_validatergn (try 3)
by testbot＠testbot.winehq.org 27 May '10

27 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2337 Your paranoid android. === W7PRO (32 bit win) === win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 006C0178 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 006E0178 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00060138 fg 00010040 in hook HCBT_SETFOCUS win.c:2664: Test failed: GetActiveWindow() = 00000000 win.c:2664: Test failed: GetFocus() = 00000000 win.c:2690: Test failed: GetActiveWindow() = 00000000 win.c:2690: Test failed: GetFocus() = 00000000 win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00070138 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00070136 fg 00010040 in hook HCBT_SETFOCUS win.c:2749: Test failed: GetActiveWindow() = 00000000 win.c:2749: Test failed: GetFocus() = 00000000 win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00070132 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00300136 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00310136 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 006F0178 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00730178 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00740178 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00190138 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00020142 fg 00010040 in hook HCBT_SETFOCUS win.c:823: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00070132 fg 00010040 in hook HCBT_SETFOCUS

1 0

Re: [PATCH 7/7] jsciprt: Added leftContext and rightCont4ext tests.
by testbot＠testbot.winehq.org 26 May '10

26 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2331 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 3/7] jscript: Treat no argument as "undefined" in RegExp.test.
by testbot＠testbot.winehq.org 26 May '10

26 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2330 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

Re: [PATCH 1/7] jscript: Store builtin constructor's length in instance object.
by testbot＠testbot.winehq.org 26 May '10

26 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2329 Your paranoid android. === W98SE (32 bit) === No test summary line found === WNT4WSSP6 (32 bit) === No test summary line found === W2KPROSP4 (32 bit) === No test summary line found === WXPPROSP3 (32 bit) === No test summary line found === W2K3R2SESP2 (32 bit) === No test summary line found === WVISTAADM (32 bit) === No test summary line found === W2K8SE (32 bit) === No test summary line found === W7PRO (32 bit) === No test summary line found === W7PROX64 (32 bit) === No test summary line found === W7PROX64 (64 bit) === No test summary line found

1 0

re: Alexandre Julliard : user32: Copy icon bits by hand in CreateIconIndirect if the bitmaps can' t be selected into a DC.
by Dan Kegel 26 May '10

26 May '10

Should that || 1 be there? + if (!SelectObject( hdc, src ) || 1) /* do it the hard way */

2 1

Re: [1/2] shell32/tests: Explicitly link all tests to IL* calls by ordinals
by Alexandre Julliard 26 May '10

26 May '10

Nikolay Sivov <bunglehead(a)gmail.com> writes: > Explicitly link all tests to IL* calls by ordinals There's no reason to do this. -- Alexandre Julliard julliard(a)winehq.org

2 2

Re: [PATCH 0/7] wined3d: blit set_shader texture_target activation cleanup
by Stefan Dösinger 26 May '10

26 May '10

Am 19.05.2010 um 00:38 schrieb Roderick Colenbrander: > This patch series removes the responsibility for enabling/disabling the > texture_target from the 'set_shader' stage of the blit_shader. I disagree with this patch. glEnable(GL_TEXTURE_2D) is the fixed function pipline's way of putting the right texture target into the "TEX dst, src, sampler, dimension" instruction. They are in the ARB blitter only because of my laziness - it is using the fixed function pipeline instead of an equivalent shader. So if you want to get rid of the glEnable / glDisable calls you should instead use ARB shaders which match the fixed function pipeline's functionality, e.g. TEX result.color, fragment.texcoord[0], texture[0], 2D; (for the 2D case) ffp_blit will keep calling glEnable / glDisable GL_TEXTURE_... > At a later stage I might disallow calling set_shader when we don't need the shader. How does the caller know when a shader is needed?

3 7

Re: [PATCH] wininternet: check for NULL lpwhh (Coverity)
by Nikolay Sivov 26 May '10

26 May '10

On 5/26/2010 11:53, Marcus Meissner wrote: > Hi, > > the other cases also check for NULL lpwhh, so do it too. > > Ciao, Marcus > --- > dlls/wininet/internet.c | 5 +++++ > 1 files changed, 5 insertions(+), 0 deletions(-) > > diff --git a/dlls/wininet/internet.c b/dlls/wininet/internet.c > index 5b1913a..fd93276 100644 > --- a/dlls/wininet/internet.c > +++ b/dlls/wininet/internet.c > @@ -2581,6 +2581,11 @@ BOOL WINAPI InternetSetOptionW(HINTERNET hInternet, DWORD dwOption, > } > case INTERNET_OPTION_CONTEXT_VALUE: > { > + if (!lpwhh) > + { > + SetLastError(ERROR_INTERNET_INCORRECT_HANDLE_TYPE); > + return FALSE; > + } > if (!lpBuffer || dwBufferLength != sizeof(DWORD_PTR)) > { > SetLastError(ERROR_INVALID_PARAMETER); > Could you add a test for that?

1 0

Re: [PATCH 1/2] d3d8: Set the FPU control word on device creation.
by testbot＠testbot.winehq.org 26 May '10

26 May '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2319 Your paranoid android. === WVISTAADM (32 bit device) === device.c:1598: Test failed: Expected foreground window 00020210, got 00020260.

1 0