June 2010 - Wine-devel - list.winehq.org

Re: [PATCH] winedevice: Use 64-bit wide delta when relocating
by Dmitry Timoshkov 23 Jun '10

23 Jun '10

Alessandro Pignotti <a.pignotti(a)sssup.it> wrote: > @@ -67,7 +67,8 @@ static HMODULE load_driver_module( const WCHAR *name ) > IMAGE_NT_HEADERS *nt; > const IMAGE_IMPORT_DESCRIPTOR *imports; > size_t page_size = getpagesize(); > - int i, delta; > + int i; > + intptr_t delta; You need to use SDK types, INT_PTR in this case. -- Dmitry.

1 0

Re: avifil32: Update Portuguese (Brazilian) translation
by Paul Vriens 23 Jun '10

23 Jun '10

On 06/23/2010 04:28 PM, Gustavo wrote: > Updated Brazilian Portuguese translation and changed codification of > resource file to UTF-8 > Hi Gustavo, If you change the encoding to UTF-8 you also need to add a "#pragma code_page(65001)", otherwise we'll end up with compile warnings like: Warning: string "Opções de compressão" seems to be UTF-8 but codepage 1252 is in use. Same is true for your other patches where you change the encoding. -- Cheers, Paul.

1 0

Re: [PATCH 4/4] wined3d: use stretch_rect_fbo for swapchainless blits
by Henri Verbeet 23 Jun '10

23 Jun '10

On 28 April 2010 14:29, Roderick Colenbrander <thunderbird2k(a)gmail.com> wrote: > + /* Early sort out of cases where no render target is used */ > + if (!dstSwapchain && !srcSwapchain > + && src_surface != device->render_targets[0] > + && dst_surface != device->render_targets[0]) > + { > + if (fbo_blit_supported(&device->adapter->gl_info, BLIT_OP_BLIT, > + &src_rect, src_surface->resource.usage, src_surface->resource.pool, src_surface->resource.format_desc, > + &dst_rect, dst_surface->resource.usage, dst_surface->resource.pool, dst_surface->resource.format_desc)) > + { > + stretch_rect_fbo(device, src_surface, &src_rect, dst_surface, &dst_rect, Filter); > + return WINED3D_OK; > + } > + > + TRACE("No surface is render target, not using hardware blit.\n"); > + return WINED3DERR_INVALIDCALL; > + } > + You might as well try FBO blits first, before doing most of the other checks. That's how it's eventually supposed to work anyway, and you could remove the other strecth_rect_fbo() calls in that case. That does depend on fbo_blit_supported() working properly, of course.

2 4

Re: msvcrt/tests: Make test_dup2() static.
by testbot＠testbot.winehq.org 23 Jun '10

23 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2829 Your paranoid android. === W98SE (32 bit file) === file.c:988: Test failed: smaller size block: Wrong error data () file.c:996: Test failed: smaller size block: Stdout file shouldn't contain data

2 1

Re: msvcr90/tests: Make test_invalid_parameter_handler() static.
by testbot＠testbot.winehq.org 23 Jun '10

23 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2832 Your paranoid android. === WXPPROSP3 (32 bit msvcr90) === No test summary line found === W2K3R2SESP2 (32 bit msvcr90) === No test summary line found === WVISTAADM (32 bit msvcr90) === No test summary line found === W2K8SE (32 bit msvcr90) === No test summary line found

2 1

Re: shlwapi/tests: Make the XXX_Construct() functions static.
by testbot＠testbot.winehq.org 23 Jun '10

23 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2830 Your paranoid android. === W2KPROSP4 (32 bit ordinal) === ordinal.c:593: Test failed: GetShellSecurityDescriptor should fail ordinal.c:616: Test failed: returned value is not valid SD No test summary line found === W7PRO (32 bit ordinal) === ordinal.c:1759: Test failed: got 13 ordinal.c:1765: Test failed: got 28 ordinal.c:1780: Test failed: got 10 ordinal.c:1793: Test failed: got 13 ordinal.c:1801: Test failed: got 13 ordinal.c:1815: Test failed: got 28 ordinal.c:1823: Test failed: got 28 ordinal.c:1831: Test failed: got 40, length 41 ordinal.c:1842: Test failed: got 43 ordinal.c:1853: Test failed: got 23 === W7PROX64 (32 bit ordinal) === ordinal.c:1759: Test failed: got 9 ordinal.c:1765: Test failed: got 25 ordinal.c:1780: Test failed: got 6 ordinal.c:1793: Test failed: got 9 ordinal.c:1801: Test failed: got 9 ordinal.c:1815: Test failed: got 25 ordinal.c:1823: Test failed: got 25 ordinal.c:1853: Test failed: got 19 ordinal.c:1864: Test failed: got 22 === W7PROX64 (64 bit ordinal) === ordinal.c:1759: Test failed: got 9 ordinal.c:1765: Test failed: got 25 ordinal.c:1780: Test failed: got 6 ordinal.c:1793: Test failed: got 9 ordinal.c:1801: Test failed: got 9 ordinal.c:1815: Test failed: got 25 ordinal.c:1823: Test failed: got 25 ordinal.c:1853: Test failed: got 19 ordinal.c:1864: Test failed: got 22

2 1

Re: [PATCH 2/2] d3dx9: Add stub and basic test for D3DXCreateSphere.
by testbot＠testbot.winehq.org 23 Jun '10

23 Jun '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=2859 Your paranoid android. === WINEBUILD (build) === Make failed

1 0

Re: msvfw32: Add the Romanian translation.
by Alexandru Băluț 23 Jun '10

23 Jun '10

On Wed, Jun 23, 2010 at 01:14, Michael Stefaniuc <mstefani(a)redhat.com> wrote: > + CONTROL "&Toate cadre cheie",887,"Button",BS_AUTOCHECKBOX|WS_TABSTOP,9,60,70,12 > + EDITTEXT 888,82,60,22,12 > + LTEXT "Cadre",889,106,62,22,10 This will look like "Toate cadre cheie X Cadre" and it does not make sense. The original message is "Key Frame Every X frames" - it could be translated as "Cadru cheie la fiecare X cadre". Thanks, Alex

2 1

Re: wined3d: Better validation of BltFast destination
by Stefan Dösinger 23 Jun '10

23 Jun '10

Am Dienstag 22 Juni 2010 23:37:20 schrieb Iain Arnell: > --- a/dlls/wined3d/surface_base.c > +++ b/dlls/wined3d/surface_base.c > @@ -1657,6 +1657,11 @@ HRESULT WINAPI > IWineD3DBaseSurfaceImpl_BltFast(IWineD3DSurface *iface, DWORD dst > lock_dst.right = dstx + w; > lock_dst.bottom = dsty + h; > > + if ( lock_dst.left < 0 || lock_dst.top < 0 ) { > + WARN("Application gave us bad desitination offset for > BltFast.\n"); + return WINEDDERR_INVALIDRECT; > + } You're catching only the GDI surface case here since opengl surfaces don't use IWineD3DBaseSurfaceImpl_BltFast. I recommend to put this check into ddraw, like in your previous attempts(but keep checking for < 0, don't do any bit testing magic like in your old patches)

4 5

[PATCH] winedevice: Use 64-bit wide delta when relocating
by alex.pigna＠inventati.org 23 Jun '10

23 Jun '10

Hi Everyone, when using Wine64 relocations should use 64-bit wide deltas, winedevice was not compliant with this. Patch follows Regards, Alessandro Pignotti --- programs/winedevice/device.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/programs/winedevice/device.c b/programs/winedevice/device.c index e0cd07b..1b5b87a 100644 --- a/programs/winedevice/device.c +++ b/programs/winedevice/device.c @@ -67,7 +67,8 @@ static HMODULE load_driver_module( const WCHAR *name ) IMAGE_NT_HEADERS *nt; const IMAGE_IMPORT_DESCRIPTOR *imports; size_t page_size = getpagesize(); - int i, delta; + int i; + intptr_t delta; ULONG size; HMODULE module = LoadLibraryW( name ); -- 1.7.1

2 1