July 2010 - Wine-devel - list.winehq.org

Re: [1/2] gdiplus: Fixed GdipFillClosedCurve2 and GdipFillClosedCurve2I in the case that count == 1 (should do nothing).
by James Mckenzie 08 Jul '10

08 Jul '10

Wade: Does this fix a known bug? We are indeed in code freeze and this is a big patch... James McKenzie -----Original Message----- >From: Wade Gobel <wgobel(a)codeweavers.com> >Sent: Jul 8, 2010 7:27 AM >To: wine-patches <wine-patches(a)winehq.org> >Subject: [1/2] gdiplus: Fixed GdipFillClosedCurve2 and GdipFillClosedCurve2I in the case that count == 1 (should do nothing). >

2 1

Re: write: Add Gaelic resource
by Jimmy O'Regan 08 Jul '10

08 Jul '10

On 8 July 2010 14:52, Ken Sharp <kennybobs(a)o2.co.uk> wrote: > My Irish (Irish, not "Gaelic") has been steadily deteriorating since I left school, but it's painfully clear that you don't speak a word of the language. + IDS_FAILED, "Ag tosú Wordpad Theip" Should be something like 'Theip ar Wordpad a thosú'; what you've written comes across like "Is starting Wordpad. Fail!" And it's not just this patch. This line from MAPI is just word soup: "R-phost a sheoladh mar a theip ní gá duit a cliant ríomhphoist MAPI shuiteáil" 'Email to send because to fail you don't need her MAPI email client install" -- <Leftmost> jimregan, that's because deep inside you, you are evil. <Leftmost> Also not-so-deep inside you.

2 2

Re: ntdll: Stub system service requests in i386 mode (Int 2E, SYSENTER, SYSCALL) (try 3)
by Vitaliy Margolen 08 Jul '10

08 Jul '10

On 07/06/2010 03:15 PM, Paul Chitescu wrote: > Changelog: > ntdll: Stub system service requests in i386 mode (Int 2E, SYSENTER, SYSCALL) > > + WINE_FIXME( "(0x%02X, %p): stub\n", index, param_block ); > + WINE_TRACE( "INT 2E at 08%x\n", context->Eip ); Any particular reason you using these and not FIXME/TRACE ? Vitaliy.

2 1

Re: [1/2] gdiplus: Fixed GdipFillClosedCurve2 and GdipFillClosedCurve2I in the case that count == 1 (should do nothing).
by Nikolay Sivov 08 Jul '10

08 Jul '10

On 7/8/2010 18:27, Wade Gobel wrote: > --- > dlls/gdiplus/graphics.c | 8 ++- > dlls/gdiplus/tests/graphics.c | 135 > +++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 142 insertions(+), 1 deletions(-) Hi, Wade. Patches are broken by your mail client. You could attach or setup your client to preserve message text as you pasted it.

1 0

Re: [PATCH 1/2] d3dx9: Fix indentation in D3DXDeclaratorFromFVFTest. (try 4)
by Misha Koshelev 08 Jul '10

08 Jul '10

> Misha Koshelev <misha680 at gmail.com> wrote: > > > >Ok per Dan's comments back to <last as this looks nicer. > > > Misha: > > Alexandre rejects 'white space' changes, that is changes that fix indentation, remove extraneous or trailing spaces and tabs unless there is another change needed. If there is a needed change in this file, go ahead and fixup white space around the change. Otherwise, hold onto this change in case you need to use it in the future. > > Your other change was accepted by Alexandre and was committed. > > James McKenzie Thanks James and I appreciate the style advice. Hope I didn't start anything too bitter about coding styles ;) Remember we're all on the same page - making a great product even greater! (Ok enough silly cheery attitude now). Misha

2 2

Re: [2/2] gdiplus: Implemented GdipFillClosedCurve and GdipFillClosedCurveI.
by testbot＠testbot.winehq.org 08 Jul '10

08 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3232 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: [1/2] gdiplus: Fixed GdipFillClosedCurve2 and GdipFillClosedCurve2I in the case that count == 1 (should do nothing).
by testbot＠testbot.winehq.org 08 Jul '10

08 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3231 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

How far to push behavioural compatibility with native?
by Joerg-Cyril.Hoehle＠t-systems.com 08 Jul '10

08 Jul '10

Hi, Unlike mciwave, the native mciseq MIDI player does not know the MCI_RESUME command. It instead returns MCIERR_UNSUPPORTED_FUNCTION. Tests with notification suggest that MCI_PAUSE actually aborts the player, much like MCI_STOP. It's a different behaviour than mciwave. (You can always "resume" a paused player using MCI_PLAY without arguments. MCI_RESUME is superfluous, except that "resume all" is different from "play all".) OTOH, Wine implements MCI_RESUME and MCI_PAUSE functionality for the MIDI sequencer as one would expect it to work (and mciwave does), according to the MCI specification. As I'm currently thinking about how to rewrite the players to avoid various race conditions (e.g. bug #22978), I'm left wondering whether I should drop the extra functionality that was written for Wine and replace it with something which behaves as closely as possible like the native player, or whether it's nice to have something more evolved in Wine, e.g. working PAUSE and RESUME commands (and some apps issue PAUSE ALL or RESUME ALL commands). What do you think? A) Bug compatibility => Behavioural compatibility => drop existing code and try to mimic native's behaviour as closely as possible. B) PAUSE and RESUME is a useful extension not present in native, keep it as long as no app is affected by this difference in behaviour. Regards, Jörg Höhle

3 2

Re: kernel32/tests: Skip fewer tests on Win9x.
by testbot＠testbot.winehq.org 08 Jul '10

08 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3224 Your paranoid android. === WINEBUILD (build) === Patch failed

1 0

Re: d3d9: add few tests for GetAdtapterDisplayModeEx (try 2)
by testbot＠testbot.winehq.org 08 Jul '10

08 Jul '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=3223 Your paranoid android. === WINEBUILD (build) === Make failed

1 0