September 2010 - Wine-devel

Re: [1/3] mscoree: Store the AppDomain from CorExeMain, for use in other functions.
by Vincent Povirk 21 Sep '10

21 Sep '10

On second thought, please don't commit this. It'll be better to design this around the COM interface in .NET 4, and easier to do that while the current code is simple. On Mon, Sep 20, 2010 at 4:15 PM, Vincent Povirk <vincent(a)codeweavers.com> wrote: > > > > > >

1 0

Re: user32: Make sure that SendInput always initializes the time field.
by Alexandre Julliard 21 Sep '10

21 Sep '10

Dmitry Timoshkov <dmitry(a)codeweavers.com> writes: > This patch should fix the problem reported in the bug 24435. I don't think you want to modify the structure passed by the app. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] shell32: use flexible arrays to avoid fortify failures
by Alexandre Julliard 21 Sep '10

21 Sep '10

Mike Frysinger <vapier(a)gentoo.org> writes: > Newer versions of gcc/glibc with fortify checks enabled will complain > about the handling of the network's szNames field. Currently it is > always defined with a length of one which means writing more then a > single byte will trigger: > In function 'strcpy', inlined from '_ILCreateEntireNetwork' at > dlls/shell32/pidl.c:1762:15: > warning: call to __builtin___strcpy_chk will always overflow destination buffer > and then at runtime, we hit an abort(). > > Since this field is really serving as the header to an arbitrary buffer, > using a flexible array instead should solve the issue. What you want is ANYSIZE_ARRAY, which already exists. -- Alexandre Julliard julliard(a)winehq.org

6 12

Re: kernel32: fix use-after-close in create_process
by Dmitry Timoshkov 21 Sep '10

21 Sep '10

Dan Kegel <dank(a)kegel.com> wrote: > Spotted by Guillaume ORTEGA. He reports this fixes > http://bugs.winehq.org/show_bug.cgi?id=24101 > > Passes kernel32 tests. That's not a use after close, client's fd passed in the server call is used just as an association of the server side. -- Dmitry.

2 1

Re: ole32: Call the draw_continue function.
by testbot＠testbot.winehq.org 21 Sep '10

21 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5372 Your paranoid android. === W98SE (32 bit ole2) === ole2.c:1284: Test failed: IViewObject_Draw with draw_continue_false returns 0x00000000 ole2.c:1063: Test failed: Expected draw_continue to be called instead of DataObject_DAdvise ole2.c:1063: Test failed: Expected draw_continue_false to be called instead of DataObject_DAdvise ole2.c:1072: Test failed: Expected DataObject_DAdvise to be called instead of DataObject_DUnadvise ole2.c:1072: Test failed: Expected DataObject_DAdvise to be called instead of DataObject_DUnadvise ole2.c:1308: Test failed: Method sequence starting from DataObject_DUnadvise not called ole2.c:1007: Test failed: Expected draw_continue to be called instead of DataObject_GetData ole2.c:1007: Test failed: Expected draw_continue to be called instead of DataObject_GetData ole2.c:1007: Test failed: Expected draw_continue to be called instead of DataObject_GetData ole2.c:1380: Test failed: Method sequence starting from DataObject_GetData not called

1 0

Re: user32: Uncomment the GetWindowPlacement() test, fill the test data with real values.
by testbot＠testbot.winehq.org 21 Sep '10

21 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5370 Your paranoid android. === W7PROX64 (64 bit msg) === Timeout

1 0

Re: ipconfig: Add the Polish translation.
by Paul Vriens 21 Sep '10

21 Sep '10

On 09/19/2010 11:11 AM, Łukasz Wojniłowicz wrote: > +#include "ipconfig.h" > + > +LANGUAGE LANG_POLISH, SUBLANG_DEFAULT > + > +STRINGTABLE Hi Łukasz, This newly created file is UTF-8 so you should add the needed pragma (or convert to something else). Compiling this one results in: Warning: string "Spos�b u�ycia: ipconfig [ /? | /all ] " seems to be UTF-8 but codepage 1250 is in use. Warning: string "B��d: Nierozpoznany lub niepe�ny wiersz polecenia " seems to be UTF-8 but codepage 1250 is in use. Warning: string "Sufiks DNS konkretnego po��czenia" seems to be UTF-8 but codepage 1250 is in use. Warning: string "Typ w�z�a" seems to be UTF-8 but codepage 1250 is in use. Warning: string "Przekierowywanie IP w��czone" seems to be UTF-8 but codepage 1250 is in use. Warning: string "DHCP w��czone" seems to be UTF-8 but codepage 1250 is in use. The same is true for your "inetcpl: Add the Polish translation" patch. -- Cheers, Paul.

1 1

Re: user32: Do not test window state on the HCBT_SETFOCUS event, it's undefined.
by testbot＠testbot.winehq.org 21 Sep '10

21 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5367 Your paranoid android. === W98SE (32 bit win) === win.c:2968: Test failed: message 000f available win.c:2980: Test failed: message 000f available win.c:2989: Test failed: message 000f available win.c:2998: Test failed: message 000f available === W7PROX64 (64 bit win) === win.c:2682: Test failed: GetActiveWindow() = 0000000000000000 win.c:2682: Test failed: GetFocus() = 0000000000000000 win.c:2708: Test failed: GetActiveWindow() = 0000000000000000 win.c:2708: Test failed: GetFocus() = 0000000000000000 win.c:2767: Test failed: GetActiveWindow() = 0000000000000000 win.c:2767: Test failed: GetFocus() = 0000000000000000

1 0

Re: user32: UpdateLayeredWindow() should fail on non-layered or already initialized window.
by testbot＠testbot.winehq.org 21 Sep '10

21 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5366 Your paranoid android. === W98SE (32 bit win) === win.c:2946: Test failed: hwnd 000004C4 message 0112 win.c:2948: Test failed: message 0100 available win.c:2969: Test failed: message 000f available win.c:2981: Test failed: message 000f available win.c:2990: Test failed: message 000f available win.c:2999: Test failed: message 000f available === W7PROX64 (64 bit win) === win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00000000006C01A8 fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00000000006E01A8 fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00000000000301A0 fg 0000000000010092 in hook HCBT_SETFOCUS win.c:2683: Test failed: GetActiveWindow() = 0000000000000000 win.c:2683: Test failed: GetFocus() = 0000000000000000 win.c:2709: Test failed: GetActiveWindow() = 0000000000000000 win.c:2709: Test failed: GetFocus() = 0000000000000000 win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00000000006F01A8 fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00000000000501A0 fg 0000000000010092 in hook HCBT_SETFOCUS win.c:2768: Test failed: GetActiveWindow() = 0000000000000000 win.c:2768: Test failed: GetFocus() = 0000000000000000 win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00000000000C016A fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00000000003301A0 fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00000000003401A0 fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000000000002019E fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000000000006019E fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 000000000007019E fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00000000008201A8 fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 0000000000020198 fg 0000000000010092 in hook HCBT_SETFOCUS win.c:845: Test failed: wrong dwWindowStatus: 0000 != 0001 active 00000000000C016A fg 0000000000010092 in hook HCBT_SETFOCUS

1 0

Re: [1/3] dinput: Add top level HID Collection detection to OSX joystick driver
by Vitaliy Margolen 21 Sep '10

21 Sep '10

On 09/19/2010 03:21 PM, Zachary Smith wrote: > This Patch: > Here I add find_osx_top_level() to the file, which is designed to identify > top level HID collections. It is independent from patch [2/3] but required > for patch [3/3] Your formatting does not match the rest of the file (curly braces on separate line), no space between opening / closing parentheses and content. And you should merge your 3 patches into one. First two just add dead code. Vitaliy.

2 2