September 2010 - Wine-devel

Re: [PATCH 3/7] CMD: cmd /c cannot use argv/argc to walk the arguments
by testbot＠testbot.winehq.org 04 Sep '10

04 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5014 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:188: Test failed: unexpected end of output in line 49, expected 0x30

1 0

Re: [PATCH 2/7] CMD: echo.word should echo back the word without the . [bug21130]
by testbot＠testbot.winehq.org 04 Sep '10

04 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5013 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:188: Test failed: unexpected end of output in line 49, expected 0x30

1 0

Re: [PATCH 1/7] CMD : Correct support for cmd.exe /C string [bug 21927]
by testbot＠testbot.winehq.org 04 Sep '10

04 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=5012 Your paranoid android. === WNT4WSSP6 (32 bit) === batch.c:188: Test failed: unexpected end of output in line 47, expected 0x30

1 0

Please report mcicda (CDROM audio) test results
by Joerg-Cyril.Hoehle＠t-systems.com 03 Sep '10

03 Sep '10

Saulius, Saulius Krasuckas wrote: >It would be nice to indicate disks containing tracks of different types >(sessions) in the log and to extract some info from the data track. >Drive info would be also interesting to see in the log. It is on purpose that I did not write too specific info to the log. I don't want logs posted to the Internet to contain (too much) sensitive information, violating your privacy. No CDDB ID. >Then we would know for sure :) As far as MCICDA is concerned, it doesn't look like it knows about multi-sessions. All it offers is to play music. Therefore the mcicda tests is not the right place to look for a disc utility that'll show you information about your drive and disc. >me_s2-clean-updated/winmm:mcicda.html Ah, that's you, good to know. You can help me debug the ME-only errors in winmm:midi midioutXyz returns rc=MMSYSERR_INVALPARAM Paul Vriens found out that the binary he compiled does not produce such errors on WinMe, while testbot's binary does. What about your machine? In testbot job #4990, you'll find a MSVC compiled 150KB binary. Please run the MIDI tests with it on your WinME machine. wintest.exe midi Non-ME output is: midi.c:298: Test failed: no PARAM error, now setting BytesRecorded too large testbot would instead trigger ok(0,"PARAM error, setting BytesRecorded\n"); Thank you, Jörg Höhle

2 1

kernel32: Add tests for SetHandleCount + make tests pass for winversions >WINNT
by Louis Lenders 03 Sep '10

03 Sep '10

Hi Juan, >Since we don't have the same limitation in Wine, >applications can call it or not, but it won't have any effect. Hence >maintaining a version-dependent external behavior, while not behaving >differently internally, doesn't make sense to me. Ok, thanks for the info, then i'll just let it return 'count', that should be ok then for apps that use this function (and fixes the bug for Street Fighter). I'll send a new patch tomorrow.

1 0

Script for finding references to stub functions
by Dan Kegel 03 Sep '10

03 Sep '10

I threw together a perl script this morning to scan a wineprefix for references to MS dlls. It's at http://code.google.com/p/winezeug/source/browse/trunk/mscodescan.pl It's pretty crufty, but might still be handy. For a working install of Sam and Max episode 304 (with native vcrun80 installed), it outputs Found 24 bundled MS modules: ./windows/winsxs/x86_Microsoft.VC80.OpenMP_1fc8b3b9a1e18e3b_8.0.50727.4053_x-ww_e79c4723/vcomp.dll ./windows/winsxs/x86_Microsoft.VC80.CRT_1fc8b3b9a1e18e3b_8.0.50727.4053_x-ww_e6967989/msvcr80.dll ... ./windows/winsxs/x86_Microsoft.VC80.MFC_1fc8b3b9a1e18e3b_8.0.50727.4053_x-ww_b77cec8e/mfc80u.dll ./windows/system32/xinput9_1_0.dll ./windows/system32/xinput1_1.dll ./windows/system32/d3dx9_27.dll ./windows/system32/xinput1_2.dll ./windows/system32/d3dx9_41.dll ./windows/system32/xinput1_3.dll ./Program Files/Telltale Games/Sam and Max - The Devil's Playhouse/Beyond the Alley of the Dolls/QtCore4.dll imports following stub symbols: msvcp80:??0?$basic_string(a)DU?$char_traits(a)D@std@@V?$allocator(a)D@2@@std@@QAE(a)PBDI@Z ... msvcp80:?uncaught_exception(a)std@@YA_NXZ ./Program Files/Telltale Games/Sam and Max - The Devil's Playhouse/Beyond the Alley of the Dolls/QtWebKit4.dll imports following stub symbols: msvcp80:?max@?$numeric_limits(a)I@std@@SAIXZ msvcp80:?quiet_NaN@?$numeric_limits(a)N@std@@SANXZ msvcp80:_FInf msvcp80:_Inf msvcp80:_Nan ./Program Files/Telltale Games/Sam and Max - The Devil's Playhouse/Beyond the Alley of the Dolls/QtGui4.dll imports following stub symbols: msvcr80:?_type_info_dtor_internal_method(a)type_info@@QAEXXZ msvcr80:_crt_debugger_hook ./Program Files/Telltale Games/Sam and Max - The Devil's Playhouse/Beyond the Alley of the Dolls/QtCore4.dll imports following stub symbols: msvcr80:?_type_info_dtor_internal_method(a)type_info@@QAEXXZ msvcr80:_crt_debugger_hook msvcr80:_fseeki64 msvcr80:_ftelli64 msvcr80:_get_tzname msvcr80:_localtime64_s msvcr80:_putenv_s msvcr80:_wassert msvcr80:getenv_s ./Program Files/Telltale Games/Sam and Max - The Devil's Playhouse/Beyond the Alley of the Dolls/QtNetwork4.dll imports following stub symbols: msvcr80:?_type_info_dtor_internal_method(a)type_info@@QAEXXZ msvcr80:_crt_debugger_hook ./Program Files/Telltale Games/Sam and Max - The Devil's Playhouse/Beyond the Alley of the Dolls/QtWebKit4.dll imports following stub symbols: msvcr80:?_type_info_dtor_internal_method(a)type_info@@QAEXXZ msvcr80:_crt_debugger_hook msvcr80:_localtime64_s

1 0

Re:kernel32: Add tests for SetHandleCount + make tests pass for winversions >WINNT
by Louis Lenders 03 Sep '10

03 Sep '10

>It's pretty unlikely that count would be larger than 0xffffffff. I agree, but i thought we should mimic Windows-behaviour, and the tests showed that such large values are at least allowed. If this value is too large could you suggest another one? > Also I don't think we need a version check. The check is there as the tests show that there is a difference between ver < win98 and ver > WINNT. I don't know if there a are applications that depend on this difference really. Anyway, i could return something like min(65536,count) for all versions, is that ok? (i'll strip out the tests then, as they won't be passing then anymore)

3 2

Re: [PATCH 3/3] winmm: Implement MCIERR_DUPLICATE_ALIAS and MCIERR_DEVICE_OPEN.
by testbot＠testbot.winehq.org 03 Sep '10

03 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4989 Your paranoid android. === W98SE (32 bit mci) === mci.c:903: Test failed: not enough time elapsed 58ms

1 0

Re: [PATCH 2/3] winmm: GetDeviceID only considers a single name per entry.
by testbot＠testbot.winehq.org 03 Sep '10

03 Sep '10

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4988 Your paranoid android. === W98SE (32 bit mci) === mci.c:1001: Test failed: mci pause wait returned MMSYSERR 5 mci.c:1015: Test failed: mci pause (space) wait returned MMSYSERR 5 mci.c:1018: Test failed: mci pause wait returned MMSYSERR 5 mci.c:1032: Test failed: Expect message 0004 from play (aborted by close)

1 0

Re: [1/4] urlmon: Implemented IUriBuilder_{Get/Set}Fragment
by Jacek Caban 03 Sep '10

03 Sep '10

Hi Thomas, On 9/3/10 1:19 AM, Thomas Mullaly wrote: > --- > dlls/urlmon/tests/uri.c | 22 ++++++++++++- > dlls/urlmon/uri.c | 80 > ++++++++++++++++++++++++++++++++++++++++++---- > 2 files changed, 93 insertions(+), 9 deletions(-) > +static HRESULT setup_builder_properties(UriBuilder*builder, const Uri* uri) { + if(uri->fragment_start> -1) { + builder->fragment = heap_alloc((uri->fragment_len+1)*sizeof(WCHAR)); + if(!builder->fragment) + return E_OUTOFMEMORY; + + memcpy(builder->fragment, uri->canon_uri+uri->fragment_start, uri->fragment_len*sizeof(WCHAR)); + builder->fragment[uri->fragment_len] = '\0'; + builder->fragment_len = uri->fragment_len; + } + + return S_OK; +} I don't think it's a good idea. It should be possible to avoid fetching all URI properties here. You can do it, eg. on demand, when you get a call to GetFragment and the fragment is not everwriten by SetFragment call. Thinking about it, the way these APIs work suggests that Uri object should store null-terminated properties that we could return here, but it may be too far conclusion. Jacek

1 0