September 2010 - Wine-devel

Re: user32: Unlike RedrawWindow, UpdateWindow doesn't accept a NULL hwnd + test
by Austin English 27 Sep '10

27 Sep '10

On Mon, Sep 27, 2010 at 7:27 PM, Louis Lenders <xerox_xerox2000(a)yahoo.co.uk> wrote: > Hi, this fixes http://bugs.winehq.org/show_bug.cgi?id=24527 Howdy Louis, + ok( GetLastError() == ERROR_INVALID_WINDOW_HANDLE || /* win98 */ GetLastError() == 0xdadadada, "Expected ERROR_INVALID_WINDOW_HANDLE, got %d\n", GetLastError()); shouldn't that win98 path be enclosed in broken()? -- -Austin

1 0

Re: [1/5] urlmon: Implemented validation of the host name component of a IUriBuilder
by Alexandre Julliard 27 Sep '10

27 Sep '10

Thomas Mullaly <thomas.mullaly(a)gmail.com> writes: > -#define ALLOW_NULL_TERM_SCHEME 0x1 > -#define ALLOW_NULL_TERM_USER_NAME 0x2 > -#define ALLOW_NULL_TERM_PASSWORD 0x4 > +#define ALLOW_NULL_TERM_SCHEME 0x1 > +#define ALLOW_NULL_TERM_USER_NAME 0x2 > +#define ALLOW_NULL_TERM_PASSWORD 0x4 > +#define ALLOW_BRACKETLESS_IP_LITERAL 0x8 > +#define SKIP_IP_FUTURE_CHECK 0x16 > +#define IGNORE_PORT_DELIMITER 0x32 These won't work as flags... -- Alexandre Julliard julliard(a)winehq.org

1 0

Sound on TestBot
by Joerg-Cyril.Hoehle＠t-systems.com 27 Sep '10

27 Sep '10

Greg Geldorp wrote: >I've found a way to add a soundcard to most of the TestBot VMs (using >the virtual soundcard driver from VMware View). This is excellent news. It even has MIDI-out! Alas, capture.c:661: found 0 WaveIn devices means that most mci.c tests (which are mostly mciwave tests) are skipped because the tests depend on the ability to record, then play back. mci.c:651: Tests skipped: Please install audio driver. Everything is skipped. Hopefully Francois Gouget will update his vmware machines with these drivers (or the ones Paul Vriens' uses) so that the timeouts will disappear. http://test.winehq.org/data/190c3518d66df44cfa464d8dc1ca3fd50ff6c361/xp_fg-… Earlier this year, Julius Schwartzenberg found out that the timeouts in winmm tests on vmware could be avoided by installing another driver. http://www.winehq.org/pipermail/wine-devel/2010-March/082118.html capture.c:674: Test failed: waveInGetDevCapsA(WAVE_MAPPER): got MMSYSERR_NOERROR capture.c:691: Test failed: waveInGetDevCapsW(1): got MMSYSERR_NOERROR Weird. waveOutGetDevCaps (in wave.c) behaves as expected. Looks like a driver bug. Perhaps one explanation for the WAVE_MAPPER case is found in my mci.c tests: * However some w2k8/w7 machines return no error when there's no wave * input device (perhaps querying waveOutGetNumDevs instead of waveIn?), * still the record command below fails with MCIERR_WAVE_INPUTSUNSUITABLE. * Don't skip here, record will fail below. */ err = mciSendString("set x format tag pcm", NULL, 0, NULL); I should feed testbot a patch to call wave_in_test_device(1) despite numdevs=0 to see what happens. Regards, Jörg Höhle

3 2

Re: [1/3] comctl32/tab: Add a test for TCM_SETITEMEXTRA
by Vitaliy Margolen 27 Sep '10

27 Sep '10

On 09/26/2010 05:08 PM, Nikolay Sivov wrote: > Add a test for TCM_SETITEMEXTRA > > > > > +static HWND parent_wnd; > -static void test_curfocus(HWND parent_wnd, INT nTabs) > +static void test_curfocus(void) > { > - hTab = createFilledTabControl(parent_wnd, TCS_FIXEDWIDTH, TCIF_TEXT|TCIF_IMAGE, nTabs); > + hTab = createFilledTabControl(parent_wnd, TCS_FIXEDWIDTH, TCIF_TEXT|TCIF_IMAGE, 5); So how is the global better then function parameter? Or a magic number? Vitaliy.

2 3

Re: [4/5] msxml3/httprequest: Store user defined request headers on transaction beginning
by Jacek Caban 27 Sep '10

27 Sep '10

Hi Nikolay, On 9/25/10 10:16 PM, Nikolay Sivov wrote: > Store user defined request headers on transaction beginning + buff = CoTaskMemAlloc((size+1)*sizeof(WCHAR)); + if (!buff) return E_OUTOFMEMORY; + + LIST_FOR_EACH_ENTRY(entry,&This->request->reqheaders, struct reqheader, entry) + { + LONG header_size = SysStringLen(entry->header) + SysStringLen(entry->value) + 4 /* colon, space, CRLF */; + + /* get large enough buffer */ + while (freech< header_size) + { + WCHAR *buff2; + + freech += size; + size *= 2; + buff2 = CoTaskMemRealloc(buff, (size+1)*sizeof(WCHAR)); This is very inefficient. You can compute header size before doing allocation, so that no reallocation is needed. And even when doing reallocation, the inner loop may be easily avoided. Jacek

1 0

Re: [1/5] msxml3/httprequest: Store passed data for IXMLHttpRequest::open()
by Jacek Caban 27 Sep '10

27 Sep '10

Hi Nikolay, On 9/25/10 10:15 PM, Nikolay Sivov wrote: > Store passed data for IXMLHttpRequest::open() + hr = VariantChangeType(&async,&async, 0, VT_BOOL); + This->async = (hr == S_OK) ? V_BOOL(&async) : FALSE; You mix BOOL and VARIANT_BOOL here. |This->async = (hr == S_OK) && V_BOOL(&async)| will do what you want. + hr = VariantChangeType(&user,&user, 0, VT_BSTR); + if (hr == S_OK) + This->user = SysAllocString(V_BSTR(&user)); You potentially leak here. + hr = VariantChangeType(&password,&password, 0, VT_BSTR); + if (hr == S_OK) + This->password = SysAllocString(V_BSTR(&password)); And here. + { + return SysReAllocString(&entry->value, value) == TRUE ? S_OK : E_OUTOFMEMORY; + You shouldn't compare to TRUE value. This should be |return SysReAllocString(...) ? S_OK : E_OUTOFMEMORY|. + *bind_flags = BINDF_FROMURLMON; Are you sure you need BINDF_FROMURLMON here? This flag is set by urlmon before calling protocol handler. + hr = BindStatusCallback_create(This,&bsc); + if (FAILED(hr)) return hr; + + ERR("%x\n", hr); Debugging code left? Jacek

1 0

Re: d3d9: Add a sRGB format test
by Henri Verbeet 27 Sep '10

27 Sep '10

On 25 September 2010 23:45, Stefan Dösinger <stefan(a)codeweavers.com> wrote: > + struct > + { > + D3DFORMAT fmt; > + const char *name; > + } > + formats[] = > + { > + { D3DFMT_R5G6B5, "D3DFMT_R5G6B5" }, > + { D3DFMT_X8R8G8B8, "D3DFMT_X8R8G8B8" }, > + { D3DFMT_A8R8G8B8, "D3DFMT_A8R8G8B8" }, > + { D3DFMT_A16B16G16R16F, "D3DFMT_A16B16G16R16F" }, > + { D3DFMT_A32B32G32R32F, "D3DFMT_A32B32G32R32F" }, > + }; This should be static const. I recently fixed a number of these. > + const float quad[] = { > + -1.0, -1.0, 0.1, 0.0, 0.0, > + -1.0, 1.0, 0.1, 1.0, 0.0, > + 1.0, -1.0, 0.1, 0.0, 1.0, > + 1.0, 1.0, 0.1, 1.0, 1.0 > + }; Please use a proper structure?

1 0

hey, saw a job ad that mentions wine!
by Dan Kegel 26 Sep '10

26 Sep '10

I do periodic searches in google blogsearch and twitter for references to wine, sometimes I find interesting tidbits that way. Tonight I also tried searching on indeed.com, and one job popped up: http://storagecraft.iapplicants.com/ViewJob-106203.html They're only looking for wine users, but still, it's nice to see.

2 1

Wine test bot failure?
by Travis Athougies 26 Sep '10

26 Sep '10

Hi, I was trying to run my HLSL test suite patch through wine test bot and the build failed. However, it's not a compilation failure. Instead it complains about not being able to copy some executable file. Also, the build fails almost instantaneously. It also complains about a missing command. The results are at https://testbot.winehq.org/JobDetails.pl?Key=5449&log_101=1#k101 How can I get this to builid and run? Travis Athougies. -- Travis Athougies

6 9

what's the proper way to define a COM interface that takes function pointers as arguments?
by Vincent Povirk 26 Sep '10

26 Sep '10

I am trying to define the ICLRRuntimeHost interface. It has this method: http://msdn.microsoft.com/en-us/library/ms164410.aspx One of the arguments is a function pointer type: http://msdn.microsoft.com/en-us/library/aa964757.aspx Widl fails when I try to define a function pointer type using C syntax. So, what's the proper way to do this? Does widl need to be fixed?

1 1