January 2011 - Wine-devel - list.winehq.org

Re: [PATCH 3/3] dinput: Combine ASCII and Unicode device create callbacks. Add tests.
by Marvin 19 Jan '11

19 Jan '11

Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=8419 Your paranoid android. === WNT4WSSP6 (32 bit device) === device.c:164: Test failed: DirectInputCreate() failed: 80040154

2 1

Re: [PATCH 4/4] [Kernel32]: add ability to load additional terminfo data from Wine registry
by Alexandre Julliard 19 Jan '11

19 Jan '11

Eric Pouech <eric.pouech(a)orange.fr> writes: > @@ -690,6 +690,9 @@ HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{de5aed00-a4bf-11d1-99 > HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{de5aed00-a4bf-11d1-9948-00c04f98bbc9},"IsInstalled",2,1 > HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{de5aed00-a4bf-11d1-9948-00c04f98bbc9},"Locale",2,"*" > HKLM,SOFTWARE\Microsoft\Active Setup\Installed Components\{de5aed00-a4bf-11d1-9948-00c04f98bbc9},"Version",2,"4,74,9273,0" > +; Some missing key mapping in libterm > +HKCU,Software\Wine\Term,"^[[1;5C",3,01,01,4d,27,08,00 > +HKCU,Software\Wine\Term,"^[[1;5D",3,01,01,4b,25,08,00 There shouldn't be any need to create Wine-specific keys from wine.inf, especially not under HKCU. The code should be using appropriate defaults if the key is missing. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [PATCH] [WineGCC]: correctly manage the -V option (gcc expects to be among the first ones, with -b)
by Alexandre Julliard 19 Jan '11

19 Jan '11

Eric Pouech <eric.pouech(a)orange.fr> writes: > @@ -969,7 +972,7 @@ static void build(struct options* opts) > if (fake_module) return; /* nothing else to do */ > > /* link everything together now */ > - strarray_addall(link_args, get_translator(opts)); > + strarray_addall(link_args, get_translator(opts, NULL)); Why do you want to use a different version when linking? -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: oleaut32/tmarshal: Remove S_OK value assumptions, fix potential stream leak
by Alexandre Julliard 19 Jan '11

19 Jan '11

Nikolay Sivov <nsivov(a)codeweavers.com> writes: > Remove S_OK value assumptions, fix potential stream leak Returning an error value and 0 on success is a common pattern, using a magic constant for 0 is not an improvement. -- Alexandre Julliard julliard(a)winehq.org

1 0

Re: [10/10] shell32: Fix initial reference count for a new IAutoComplete instance.
by Nikolay Sivov 19 Jan '11

19 Jan '11

On 1/15/2011 11:28, Andrew Nguyen wrote: > Spotted with Valgrind. > --- > dlls/shell32/autocomplete.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(- This doesn't look right. If initial count is zero this failure code will decrement to -1: --- if (FAILED (IUnknown_QueryInterface (_IUnknown_ (lpac), riid, ppv))) { IUnknown_Release (_IUnknown_ (lpac)); return E_NOINTERFACE; } --- I think it's better to add another _Release().

1 0

New winetricks 20110117-alpha: new verbs dxdiag, firefox4, ut3, hegemonygold_demo, dxdiagn, pngfilt; new svn repo, download url
by Dan Kegel 18 Jan '11

18 Jan '11

Another fortnight, another winetricks. New version 20110117-alpha adds the following new verbs: firefox4 - beta9 of Firefox's new web browser ut3 - the first-person shooter Unreal Tournament 3 (requires dvd) hegemonygold_demo - the strategy game Hegemony Gold, dxdiag - Microsoft's native dxdiag app plus many less noticable improvements. It should be ready to replace classic winetricks now... let me know if you find it lacking. Also, to celebrate the new version (and foil domain squatters), I've given it an easier to remember download url: http://winetricks.org/winetricks-alpha and svn repository / bug tracker: http://winetricks.googlecode.com (The old download url at kegel.com/wine/winetricks-alpha will still work, they're symlinked.) Changelog: Dan Kegel: Added new verbs dxdiag, dxdiagn, firefox4, pngfilt vc2005express: switched to offline installer to make regression testing easier ie6: make png images work (thanks to Qian Hong for the bug report) Allow changing -q from main menu Experimentally mention WINEPREFIX in window title to help avoid user confusion Don't make zenity bigger than the screen, if we can help it. Leave less cruft in wineprefix (in particular, autohotkey) Sped up script a bit more in cygwin Phil Blankenship: Ported most of the remaining verbs from classic winetricks Shannon Vanwagner: Added new verb hegemenygold_demo Scott Jackson: Added new verb ut3

4 3

Re: [PATCH] sdfmlsdkf
by Austin English 18 Jan '11

18 Jan '11

On Tue, Jan 18, 2011 at 12:39 PM, Eric Pouech <eric.pouech(a)orange.fr> wrote: I think you messed up the patch subject ;-). -- -Austin

1 0

Re: today's git does not compile
by Susan Cragin 18 Jan '11

18 Jan '11

> It's not wine's fault, and you're not missing any dependencies; the >> new version of gcc is probably buggy, and the bug is triggered by >> something inside wine. > >If you've compiled Wine before and are re-using object files from an >old gcc it's possible that there is a conflict between the object >files from before and the object files with your new version of gcc. >So, you could try a "make clean" and then compile again. > >Erich Hoover >ehoover(a)mines.edu I tried "make distclean" and also tried a new wine-git download... so far nothing. On with the flags test.

1 0

re: today's git does not compile
by Dan Kegel 18 Jan '11

18 Jan '11

Susan wrote: > I have the latest version of Natty Narwhal > gcc (Ubuntu/Linaro 4.5.2-1ubuntu6) 4.5.2 >... >gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogical-op -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o pen.o pen.c >pen.c: In function ‘X11DRV_SelectPen’: >pen.c:31:12: internal compiler error: Segmentation fault >Please submit a full bug report, >with preprocessed source if appropriate. >See <file:///usr/share/doc/gcc-4.5/README.Bugs> for instructions. It's not wine's fault, and you're not missing any dependencies; the new version of gcc is probably buggy, and the bug is triggered by something inside wine. Try switching from -O2 to -O1 with configure CFLAGS="-g -O1" and rebuild. Does that help? Regardless of whether that gets you past the problem, please file a bug in launchpad against gcc-4.5. https://bugs.launchpad.net/ubuntu/+source/gcc-4.5/+bug/693686 and https://bugs.launchpad.net/ubuntu/+source/gcc-4.5/+bug/690194 are similar bugs you could use as examples. Ideally they'd want you to run with -save-temps and give them a copy of pen.i.

2 2

today's git does not compile
by Susan Cragin 18 Jan '11

18 Jan '11

Could there be a new dependency that isn't summoned by build-dep? Or is it me? I have the latest version of Natty Narwhal gcc (Ubuntu/Linaro 4.5.2-1ubuntu6) 4.5.2 gcc -m32 -c -I. -I. -I../../include -I../../include -D__WINESRC__ -D_REENTRANT -fPIC -Wall -pipe -fno-strict-aliasing -Wdeclaration-after-statement -Wstrict-prototypes -Wtype-limits -Wwrite-strings -Wpointer-arith -Wlogical-op -g -O2 -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=0 -o pen.o pen.c pen.c: In function ‘X11DRV_SelectPen’: pen.c:31:12: internal compiler error: Segmentation fault Please submit a full bug report, with preprocessed source if appropriate. See <file:///usr/share/doc/gcc-4.5/README.Bugs> for instructions. make[1]: *** [pen.o] Error 1 make[1]: Leaving directory `/home/susan/wine/dlls/winex11.drv' make: *** [dlls/winex11.drv] Error 2 susan(a)ubuntu:~/wine$ cd

2 1