November 2011 - Wine-devel - list.winehq.org

Re: [1/2] kernel32/tests: add tests for GetDllDirectoryA
by Vincent Povirk 06 Nov '11

06 Nov '11

I don't think you can rely on C:\Windows existing. On Sun, Nov 6, 2011 at 10:14 AM, Thomas Faber <thfabba(a)gmx.de> wrote: > > > >

3 2

Re: [2/2] mscoree: Implement ICorDebug CreateProcess
by Vincent Povirk 05 Nov '11

05 Nov '11

I'm curious why you've chosen to work on this. Is there a program relying on this, or do you have some .NET debugging tools you'd like to use? Or are you thinking we'd implement our own debugging tool as well (perhaps extending winedbg)? Better debugging tools for wine/mono would definitely be nice, but there are a lot of things we need, and this is not the first one I'd pick. The current state of the art in Mono debugging is the soft debugger. >From what I've heard, all other debugger technologies in Mono have been deprecated. http://www.mono-project.com/Mono:Runtime:Documentation:SoftDebugger They have documentation on the wire protocol, which is probably what we'd end up using because .NET libraries are inconvenient to use. >From what I can tell, the soft debugger needs to be configured to listen for TCP connections on a particular port. Ideally, we would want to modify it by adding a new "transport" using something like a named pipe server named based on the process id (it looks straightforward to do so, but we'd have to modify the mono runtime). Otherwise, I'm not sure how we'd identify the socket server for the process we want, and having mono run a TCP server all the time seems like a bad idea. It may also be possible to configure mono to use the soft debugger in the "normal" way and attach to it with a Linux MonoDevelop, if you want a quicker solution. It seems like it's designed to remotely debug any mono process on any platform. If you figure out how to do this, wiki documentation would be appreciated.

2 1

Warning report for wine-1.3.32
by Jerome Leclanche 04 Nov '11

04 Nov '11

warning: variable ‘_qzz_res’ set but not used [-Wunused-but-set-variable] That's valgrind stuff. Apparently I might need a valgrind update or something, I'm not 100% sure what's going on. A few more can be fixed with FIXME()s instead of comments. J. Leclanche

1 0

Re: [3/4] msxml3: Add IDispatchEx support for IXMLDOMNamedNodeMap
by Jacek Caban 04 Nov '11

04 Nov '11

Hi Nikolay, On 11/04/11 16:46, Nikolay Sivov wrote: > + if(This->data->vtbl&& This->data->vtbl->invoke) { > + hres = This->data->vtbl->invoke(This->outer, id, lcid, wFlags, pdp, pvarRes, pei); > + if (hres != E_NOTIMPL) return hres; > + } Using E_NOTIMPL for special meaning here seems wrong to me. DISP_E_UNKNOWNNAME could be a better choice. However, if you'd move custom invoke implementation to be the last choice, after dynamic and typelib-based values, then you could simply return whatever invoke returns. Jacek

3 3

Re: [PATCH] userenv: GetUserProfileDirectoryW should fail with ERROR_INVALID_HANDLE if handle is NULL.
by Alexandre Julliard 04 Nov '11

04 Nov '11

Christian Inci <chris.pcguy.inci(a)gmail.com> writes: > @@ -149,6 +149,12 @@ BOOL WINAPI GetUserProfileDirectoryW( HANDLE hToken, LPWSTR lpProfileDir, > > TRACE( "%p %p %p\n", hToken, lpProfileDir, lpcchSize ); > > + if (!hToken) > + { > + SetLastError( ERROR_INVALID_HANDLE ); > + return FALSE; > + } There's no reason to treat a 0 handle differently. Please stop adding such special cases just to satisfy the tests. Parameter checking needs to fall out of the implementation. -- Alexandre Julliard julliard(a)winehq.org

1 0

winedevice taking up 100% after wine cmd
by Hin-Tak Leung 04 Nov '11

04 Nov '11

I just had a rather odd incident earlier today when I just launched "wine cmd", and saw that my process monitor max-out to 100% - and it continued, until I finished what I intended to do and exited cmd, minutes later. I wasn't doing anything else and no typing anything in the cmd console either, so that was curious. It was winedevice taking up 100%. I tried wine cmd later but couldn't get that odd behavior any more. But is there any reason why winedevice should go into a spin? This is fedora 15 x86_64 running 32-bit wine I built myself.

2 1

Re: [PATCH] shell32: IShellDispatch_NameSpace: Special-folder argument shouldn't be negative.
by Alexander Morozov 03 Nov '11

03 Nov '11

-1 in this test is only a sample of a bad constant. Do you sure that S_OK should be returned for any positive argument?

3 2

Re: winealsa: Don't set ALSA's period time.
by Andrew Eikum 03 Nov '11

03 Nov '11

On Thu, Nov 03, 2011 at 09:41:46AM +0100, Joerg-Cyril.Hoehle(a)t-systems.com wrote: > perhaps I shouldn't send this one day before release... > > I argue that Wine has no business setting ALSA's period size, > esp. not to a completely random value like duration/10. > Better leave it complete freedom, as confirmed in > http://mailman.alsa-project.org/pipermail/alsa-devel/2011-August/042837.html > > What I think may be interesting is set min and/or max of the *buffer* time I completely agree, and have similar patches sitting in Bugs 28723 (don't set period time) and 28282 (request ALSA buffer time near requested MMDevice buffer time; needs more thought), although I was waiting for feedback from users before submitting. I have no problem with this patch getting in today, though it is late in the cycle, yeah ;) Andrew

1 0

Re: [2/3] ntdll: Use PAGE_READWRITE access when resolving DLL imports.
by Alexandre Julliard 03 Nov '11

03 Nov '11

Dmitry Timoshkov <dmitry(a)baikal.ru> writes: > diff --git a/dlls/ntdll/loader.c b/dlls/ntdll/loader.c > index 5ee7d0a..314813f 100644 > --- a/dlls/ntdll/loader.c > +++ b/dlls/ntdll/loader.c > @@ -563,7 +563,7 @@ static WINE_MODREF *import_dll( HMODULE module, const IMAGE_IMPORT_DESCRIPTOR *d > protect_base = thunk_list; > protect_size *= sizeof(*thunk_list); > NtProtectVirtualMemory( NtCurrentProcess(), &protect_base, > - &protect_size, PAGE_WRITECOPY, &protect_old ); > + &protect_size, PAGE_READWRITE, &protect_old ); Restoring the permissions is not going to work if it was already writable. -- Alexandre Julliard julliard(a)winehq.org

2 4

RFC: wined3d: Implementing depth/stencil buffer locking
by Octavian Voicu 03 Nov '11

03 Nov '11

Hi, Here is a first shot at implementing depth/stencil buffer locking in wined3d. Currently depth/stencil buffer locations are onscreen and offscreen, with transitions between the two states done in load_ds_location. I added another location, sysmem, and implemented transitions from offscreen to sysmem and from sysmem to offscreen. If buffer is onscreen, it will be moved offscreen first, then to sysmem. Some issues with this implementation: 1) make dsurface.ok in ddraw/tests crashes in context_acquire (wined3d/context.c:2456) called from surface_load_location (wined3d/surface.c:6323), I'm guessing in because there is no swapchain. How can I prevent this crash and still get a context? Loading from offscreen to sysmem shouldn't require a swapchain. 2) When running my test app [1] I also get this error: err:d3d_surface:surface_load_ds_location >>>>>>>>>>>>>>>>> GL_INVALID_VALUE (0x501) from glTexSubImage2D @ ../../../../wine/dlls/wined3d/surface.c / 5877 3) There are other issues with my test app (looks like it's related to textures), so can't be sure if locking works correctly. There is an improvement over the unpatched version, but can't be sure until the other issue is resolved. Game uses pre-rendered backgrounds and probably loads the Z-buffer by locking the surface, so it can render 3D characters correctly over the pre-rendered backgrounds. It happens in the "if (surface->flags & SFLAG_DS_SYSMEM)" branch of the surface_load_ds_location function. Uploading happens on each frame, this error only happens for the first upload. I'm quite new to wined3d code so I might have missed some obvious things. Any comments and suggestions are welcome. Thanks. Octavian [1] The demo of The Longest Journey, available for download here (to reproduce, click on the Begin Journey, press ESC to skip intro movies; notice how rendered characters look): http://games.softpedia.com/get/Games-Demo/The-Longest-Journey-161-Demo.shtml

3 3